commit a94e0261ef436b46ec63f2f72a654ce97b278901
author John Stiles <johnstiles@google.com> Tue Apr 27 17:29:59 2021 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed Apr 28 15:16:27 2021 +0000
tree 76f5daeeb421d7918cc50d741aa9cf1ba1f0d668
parent 4f0098227eb7ec0925b52f57e09ec44ff6ea8eaf

Add Make factory method to VariableReference.

There aren't any optimization opportunities here, but it was the only
expression/statement type left without a Make or Convert factory.

Change-Id: I4c413a3b2619261f9e974528fa45211383e56fa7
Bug: skia:11342
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/402017
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>
Reviewed-by: Ethan Nicholas <ethannicholas@google.com>

src/sksl/SkSLRehydrator.cpp

diff --git a/src/sksl/SkSLRehydrator.cpp b/src/sksl/SkSLRehydrator.cpp
index c4dd94f..46adfc7 100644
--- a/src/sksl/SkSLRehydrator.cpp
+++ b/src/sksl/SkSLRehydrator.cpp
@@ -564,7 +564,7 @@
         case Rehydrator::kVariableReference_Command: {
             const Variable* var = this->symbolRef<Variable>(Symbol::Kind::kVariable);
             VariableReference::RefKind refKind = (VariableReference::RefKind) this->readU8();
-            return std::make_unique<VariableReference>(-1, var, refKind);
+            return VariableReference::Make(/*offset=*/-1, var, refKind);
         }
         case Rehydrator::kVoid_Command:
             return nullptr;