commit aa0ce825b877871f73532beb6fde6bf2f80e99dd
author Florin Malita <fmalita@chromium.org> Mon Aug 28 12:50:26 2017 -0400
committer Florin Malita <fmalita@chromium.org> Tue Aug 29 17:10:36 2017 +0000
tree 6cc4c265c8ccb84e1408b5b9cfe6068e9abc6fec
parent 9d7e57d509149dd2fcb3ba73ea8f4cdce11f84bd

Use the 4f impl for legacy/8888 linear gradients

This is a partial revert of https://skia-review.googlesource.com/c/20280,
adding back L32 support for 4f gradients and switching off the legacy
impl.

If it sticks, we should be able to completely delete the legacy gradient
code.

Change-Id: Iaa6d722ea4dfd8e4d959bb76eca815a30ca7098f
Reviewed-on: https://skia-review.googlesource.com/31425
Reviewed-by: Herb Derby <herb@google.com>
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Florin Malita <fmalita@chromium.org>

src/shaders/gradients/Sk4fGradientBase.cpp

diff --git a/src/shaders/gradients/Sk4fGradientBase.cpp b/src/shaders/gradients/Sk4fGradientBase.cpp
index 0d9e6d0..60f8ced 100644
--- a/src/shaders/gradients/Sk4fGradientBase.cpp
+++ b/src/shaders/gradients/Sk4fGradientBase.cpp
@@ -288,9 +288,8 @@
                                                          const ContextRec& rec)
     : INHERITED(shader, rec)
     , fFlags(this->INHERITED::getFlags())
+    , fDither(rec.fPaint->isDither())
 {
-    SkASSERT(rec.fPreferredDstType == ContextRec::kPM4f_DstType);
-
     const SkMatrix& inverse = this->getTotalInverse();
     fDstToPos.setConcat(shader.fPtsToUnit, inverse);
     SkASSERT(!fDstToPos.hasPerspective());
@@ -309,9 +308,3 @@
 GradientShaderBase4fContext::isValid() const {
     return fDstToPos.isFinite();
 }
-
-void SkGradientShaderBase::
-GradientShaderBase4fContext::shadeSpan(int x, int y, SkPMColor dst[], int count) {
-    // This impl only shades to 4f.
-    SkASSERT(false);
-}