| commit | ab8ed92a0c346faac2d7f409a69543a5fcf152b9 | [log] [tgz] |
|---|---|---|
| author | John Stiles <johnstiles@google.com> | Tue Jan 05 09:59:32 2021 -0500 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Tue Jan 05 16:30:11 2021 +0000 |
| tree | 71c5752a36affdfa738795be28ce4e1d5e25b514 | |
| parent | 0755d4bcde9e258212f7356794fa012dc96dd569 [diff] |
Add unit test for casting between float, int and bool. This actually exposed a latent bug: we don't support bool(1.23) or bool(1) casts, but these are valid in GLSL: https://www.khronos.org/opengl/wiki/Data_Type_(GLSL)#Conversion_constructors "to bool: A value equal to 0 or 0.0 becomes false; anything else is true." Change-Id: Ia929a09914ffc96f081d0402d7bb05b5428f8db6 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/349977 Auto-Submit: John Stiles <johnstiles@google.com> Commit-Queue: Brian Osman <brianosman@google.com> Reviewed-by: Brian Osman <brianosman@google.com>