commit abda35d2b77f2765985ab16d3417c5cce296b8af
author mtklein <mtklein@chromium.org> Thu Jul 14 06:57:31 2016 -0700
committer Commit bot <commit-bot@chromium.org> Thu Jul 14 06:57:31 2016 -0700
tree d97b03be42e2794b62b118feb8c25881c707fca1
parent 614d8f9a3c44e22d77fa909e82119e8a6746e1b1

GrBufferAllocPool: use _throw calloc() if unchecked.

Looks like this code is using sk_calloc(), NULL on failure, accidentally
instead of sk_calloc_throw().  We're using sk_malloc_throw() in the parallel
code path, so it really seems like we're not checking the result pointer.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2152753002

Review-Url: https://codereview.chromium.org/2152753002

src/gpu/GrBufferAllocPool.cpp

diff --git a/src/gpu/GrBufferAllocPool.cpp b/src/gpu/GrBufferAllocPool.cpp
index d19604c..bb73a10 100644
--- a/src/gpu/GrBufferAllocPool.cpp
+++ b/src/gpu/GrBufferAllocPool.cpp
@@ -281,7 +281,7 @@
     sk_free(fCpuData);
     if (newSize) {
         if (fGpu->caps()->mustClearUploadedBufferData()) {
-            fCpuData = sk_calloc(newSize);
+            fCpuData = sk_calloc_throw(newSize);
         } else {
             fCpuData = sk_malloc_throw(newSize);
         }