commit ace470be9ab6751227796651fcdbd1a1fd522d5e
author Ethan Nicholas <ethannicholas@google.com> Mon Aug 30 16:15:20 2021 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Tue Aug 31 14:37:10 2021 +0000
tree c965f669d12939122deb45a536e1ffcb7c00b0fc
parent 17c7c2f4b15bad37494078de2d260da92cf098a1

Make IRGenerator::call propagate poison

This fixes redundant "not a function" errors when we have already
produced an error resolving the target of a call.

Change-Id: I94876ec09feac399108033d1b850e78c7750dd1d
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/443411
Reviewed-by: John Stiles <johnstiles@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

src/sksl/SkSLIRGenerator.cpp

diff --git a/src/sksl/SkSLIRGenerator.cpp b/src/sksl/SkSLIRGenerator.cpp
index 663ac2a..7a4486a 100644
--- a/src/sksl/SkSLIRGenerator.cpp
+++ b/src/sksl/SkSLIRGenerator.cpp
@@ -1196,6 +1196,8 @@
             }
             return this->call(offset, *functions[0], std::move(arguments));
         }
+        case Expression::Kind::kPoison:
+            return functionValue;
         default:
             this->errorReporter().error(offset, "not a function");
             return nullptr;