commit addccaf9cfb6fa66f5a8b007e52def5d0cf7d7be
author John Stiles <johnstiles@google.com> Mon Aug 02 19:03:30 2021 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Tue Aug 03 13:30:40 2021 +0000
tree 45b230a59a6d330e0c7e7e402fdda0d52be16183
parent 1c38121964e5599f70610271ae1bcf2c37dc7c4c

Enable narrowing conversions automatically for Runtime Effects.

Previously, it was possible to compile runtime effects with narrowing
conversions disabled; e.g. skslc would do this. A Runtime Effect-based
ProgramKind now enables narrowing conversions automatically. (The
setting flag could still be turned on manually as well.)

Change-Id: I912c9adda77c29ccfda3b1d85d106315f648d624
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/435916
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

src/sksl/ir/SkSLFunctionDeclaration.cpp

diff --git a/src/sksl/ir/SkSLFunctionDeclaration.cpp b/src/sksl/ir/SkSLFunctionDeclaration.cpp
index 3554555..845c834 100644
--- a/src/sksl/ir/SkSLFunctionDeclaration.cpp
+++ b/src/sksl/ir/SkSLFunctionDeclaration.cpp
@@ -90,7 +90,7 @@
 
         Modifiers m = param->modifiers();
         if (isMain) {
-            if (context.fConfig->isRuntimeEffect()) {
+            if (ProgramConfig::IsRuntimeEffect(context.fConfig->fKind)) {
                 // We verify that the signature is fully correct later. For now, if this is a
                 // runtime effect of any flavor, a float2 param is supposed to be the coords, and a
                 // half4/float parameter is supposed to be the input or destination color: