remove NEON matrix procs

These appear to autovectorize fine.

There are a ton of tiny diffs here, which sounds to me like the NEON
code is doing something slightly different than the portable path.
That's kind of reason enough for me to want to drop this code... it's
write-once code that never gets updated or bug fixes.

I'm going to try replacing these next with some skvx-based code to see
if there's any speed up to be gotten from readable code.

nanobench -m bitmap_ [-before-]{+after+} is uninteresting:

! -> high variance, ? -> moderate variance
    micros      bench
   [-6086.72-]{+5996.35+}       shadermaskfilter_bitmap_80      8888
   [-5629.37-]{+5603.07+}       shadermaskfilter_bitmap_ff      8888
    [-348.31-]{+348.62+}        draw_bitmap_aa_rotate   8888
    [-215.12-]{+221.48+}        draw_bitmap_aa_translate        8888
    [-294.87-]{+315.18+}        draw_bitmap_aa_scale    8888
     [-11.89 !-]{+11.95+}       draw_bitmap_aa_ident    8888
    [-307.47-]{+304.01+}        draw_bitmap_noaa_rotate 8888
     [-14.56 !-]{+16.18+}       draw_bitmap_noaa_translate      8888
    [-294.56-]{+312.53+}        draw_bitmap_noaa_scale  8888
     [-12.05-]{+12.44+}         draw_bitmap_noaa_ident  8888
     [-38.14-]{+37.84+} ?       bitmap_RGBA_8888_A_source_stripes_three 8888
     [-35.98-]{+37.81 ?+}       bitmap_RGBA_8888_A_source_stripes_two   8888
     [-23.58-]{+23.89+}         bitmap_RGBA_8888_A_source_transparent   8888
     [-25.02-]{+24.96+}         bitmap_RGBA_8888_A_source_opaque        8888
    [-882.88-]{+777.45+}        bitmap_RGBA_8888_A_scale_rotate_bicubic 8888
    [-865.57-]{+451.20+}        bitmap_RGBA_8888_A_scale_bicubic        8888
    [-132.63-]{+145.47+}        bitmap_RGBA_8888_update_scale_rotate_bilerp     8888
    [-139.90-]{+147.01+}        bitmap_RGBA_8888_update_volatile_scale_rotate_bilerp    8888
    [-144.19-]{+132.19+}        bitmap_RGBA_8888_scale_rotate_bilerp    8888
    [-150.94-]{+158.66+}        bitmap_RGBA_8888_A_scale_rotate_bilerp  8888
     [-86.07-]{+85.63+}         bitmap_RGB_565_scale    8888
    [-455.76-]{+455.36+}        bitmap_RGB_565_scale_bilerp     8888
     [-91.71-]{+94.45+}         bitmap_RGBA_8888_update_scale_bilerp    8888
     [-93.79-]{+99.09+}         bitmap_RGBA_8888_update_volatile_scale_bilerp   8888
     [-95.02-]{+94.31+}         bitmap_RGBA_8888_scale_bilerp   8888
    [-100.45-]{+105.19+}        bitmap_RGBA_8888_A_scale_bilerp 8888
     [-20.89-]{+21.15+}         bitmap_RGBA_8888_update 8888
     [-21.16-]{+20.98+}         bitmap_RGBA_8888_update_volatile        8888
     [-81.12-]{+80.12+}         bitmap_RGB_565  8888
     [-21.05-]{+21.35+}         bitmap_RGBA_8888_scale  8888
     [-21.04-]{+20.99+}         bitmap_RGBA_8888        8888
     [-27.91-]{+27.78+}         bitmap_RGBA_8888_A      8888

Change-Id: Ia2746ac342e2a29653846da5252c09467a85a077
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/250688
Reviewed-by: Mike Reed <reed@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
1 file changed