Revert "Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding""
This reverts commit d84b691950a8586d5691726de9ac804a21286e92.
Reason for revert: seems like chrome's glInterface is maybe not setup correctly. Crashing on intel gpu chrome bots: https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8884195221041295328/+/steps/trace_test_on__intel-hd-630-ubuntu-stable__GPU_on_Linux__retry_shards_with_patch__on_linux-intel-stable/0/stdout
snippet:
Crash reason: SIGABRT
Crash address: 0x3e8000050b0
Process uptime: not available
Thread 0 (crashed)
0 libc.so.6 + 0x43ed7
rax = 0x0000000000000000 rdx = 0x0000000000000000
rcx = 0x00007ff964c3ced7 rbx = 0x00002cc73685ddc0
rsi = 0x00007fffb9128960 rdi = 0x0000000000000002
rbp = 0x00007fffb9128bb0 rsp = 0x00007fffb9128960
r8 = 0x0000000000000000 r9 = 0x00007fffb9128960
r10 = 0x0000000000000008 r11 = 0x0000000000000246
r12 = 0x0000000000000048 r13 = 0x0000000000000000
r14 = 0x000000000000006c r15 = 0x0000000000000000
rip = 0x00007ff964c3ced7
Found by: given as instruction pointer in context
1 chrome!GrGLGpu::drawElementsInstancedBaseVertexBaseInstance(GrPrimitiveType, int, unsigned int, void const*, int, int, unsigned int)::$_81::operator()() const + 0x33
rbp = 0x00007fffb9128bc0 rsp = 0x00007fffb9128bc0
rip = 0x000055c5c1db6923
Found by: previous frame's frame pointer
2 chrome!drawElementsInstancedBaseVertexBaseInstance [GrGLGpu.cpp : 2306 + 0x5]
rbp = 0x00007fffb9128c10 rsp = 0x00007fffb9128bd0
rip = 0x000055c5c1db68b6
Found by: call frame info
3 chrome!onDrawIndexed [GrGLOpsRenderPass.cpp : 144 + 0x16]
Original change's description:
> Reland "Use glDraw.*BaseInstance calls to avoid deferred buffer binding"
>
> This is a reland of e8c963d474b7a672bb1292c02b7a774ab29b2cef
>
> Original change's description:
> > Use glDraw.*BaseInstance calls to avoid deferred buffer binding
> >
> > Change-Id: I968dab317673051acc65f87ea76a0d657d89b3d2
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/279538
> > Commit-Queue: Chris Dalton <csmartdalton@google.com>
> > Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> > Reviewed-by: Brian Salomon <bsalomon@google.com>
>
> Change-Id: I79b2d23e5e66d47214898a9068079b6fe2269599
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/280806
> Commit-Queue: Chris Dalton <csmartdalton@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
TBR=bsalomon@google.com,csmartdalton@google.com,michaelludwig@google.com
Change-Id: I1d2617f077676b6f36bb723615d527e4aa4b3efe
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/281057
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
8 files changed