commit b23630c509010bef0a325db251ffbb033acba4b9
author Michael Ludwig <michaelludwig@google.com> Tue Aug 10 12:27:25 2021 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Tue Aug 10 17:57:41 2021 +0000
tree 8ebd2f67910248b288d4aa4f7f3a559d8d045777
parent 68556bc79851fc3552d80a9d7109749e44dff5d9

Reland "Remove SkTLList"

This reverts commit 14b1d56a2b2b8f0ffcb62180382b7347673aaa11.

Reason for revert: fix emplace_back() usage

Original change's description:
> Revert "Remove SkTLList"
>
> This reverts commit e1d523d70fec3b3d24fef6da4a823c52092b6c77.
>
> Reason for revert: breaking old stdlib versions (< c17)
>
> Original change's description:
> > Remove SkTLList
> >
> > Change-Id: I198678b5cb298cf51872fbb8d4fd5d705a6b684e
> > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/437339
> > Reviewed-by: Brian Osman <brianosman@google.com>
> > Commit-Queue: Michael Ludwig <michaelludwig@google.com>
>
> TBR=brianosman@google.com,michaelludwig@google.com,skcq-be@skia-corp.google.com.iam.gserviceaccount.com
>
> Change-Id: I8e02e4cd2f293e7530f842be783de10f69be2ef4
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Reviewed-on: https://skia-review.googlesource.com/c/skia/+/438078
> Reviewed-by: Michael Ludwig <michaelludwig@google.com>
> Commit-Queue: Michael Ludwig <michaelludwig@google.com>

# Not skipping CQ checks because this is a reland.

Change-Id: Ied33ce81a8312963ff0713c4660cdb8541a02180
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/438080
Commit-Queue: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>

gm/convexpolyeffect.cpp

diff --git a/gm/convexpolyeffect.cpp b/gm/convexpolyeffect.cpp
index 7485293..05747dc 100644
--- a/gm/convexpolyeffect.cpp
+++ b/gm/convexpolyeffect.cpp
@@ -20,7 +20,6 @@
 #include "include/core/SkString.h"
 #include "include/private/GrTypesPriv.h"
 #include "src/core/SkCanvasPriv.h"
-#include "src/core/SkTLList.h"
 #include "src/gpu/GrFragmentProcessor.h"
 #include "src/gpu/GrPaint.h"
 #include "src/gpu/effects/GrConvexPolyEffect.h"
@@ -56,11 +55,12 @@
         tri.lineTo(100.f, 20.f);
         tri.lineTo(15.f, 100.f);
 
-        fPaths.addToTail(tri);
-        fPaths.addToTail(SkPath())->reverseAddPath(tri);
+        fPaths.push_back(tri);
+        fPaths.emplace_back();
+        fPaths.back().reverseAddPath(tri);
 
         tri.close();
-        fPaths.addToTail(tri);
+        fPaths.push_back(tri);
 
         SkPath ngon;
         constexpr SkScalar kRadius = 50.f;
@@ -77,16 +77,16 @@
             }
         }
 
-        fPaths.addToTail(ngon);
+        fPaths.push_back(ngon);
         SkMatrix scaleM;
         scaleM.setScale(1.1f, 0.4f);
         ngon.transform(scaleM);
-        fPaths.addToTail(ngon);
+        fPaths.push_back(ngon);
 
         SkPath linePath;
         linePath.moveTo(5.f, 5.f);
         linePath.lineTo(6.f, 6.f);
-        fPaths.addToTail(linePath);
+        fPaths.push_back(linePath);
     }
 
     DrawResult onDraw(GrRecordingContext* rContext, SkCanvas* canvas, SkString* errorMsg) override {
@@ -100,16 +100,13 @@
         static constexpr SkScalar kDX = 12.f;
         static constexpr SkScalar kOutset = 5.f;
 
-        for (PathList::Iter iter(fPaths, PathList::Iter::kHead_IterStart);
-             iter.get();
-             iter.next()) {
-            const SkPath* path = iter.get();
+        for (const SkPath& path : fPaths) {
             SkScalar x = 0;
 
             for (int et = 0; et < kGrClipEdgeTypeCnt; ++et) {
                 const SkMatrix m = SkMatrix::Translate(x, y);
                 SkPath p;
-                path->transform(m, &p);
+                path.transform(m, &p);
 
                 GrClipEdgeType edgeType = (GrClipEdgeType) et;
                 auto [success, fp] = GrConvexPolyEffect::Make(/*inputFP=*/nullptr, edgeType, p);
@@ -125,28 +122,27 @@
                 auto op = sk_gpu_test::test_ops::MakeRect(rContext, std::move(grPaint), rect);
                 sdc->addDrawOp(std::move(op));
 
-                x += SkScalarCeilToScalar(path->getBounds().width() + kDX);
+                x += SkScalarCeilToScalar(path.getBounds().width() + kDX);
             }
 
             // Draw AA and non AA paths using normal API for reference.
             canvas->save();
             canvas->translate(x, y);
             SkPaint paint;
-            canvas->drawPath(*path, paint);
-            canvas->translate(path->getBounds().width() + 10.f, 0);
+            canvas->drawPath(path, paint);
+            canvas->translate(path.getBounds().width() + 10.f, 0);
             paint.setAntiAlias(true);
-            canvas->drawPath(*path, paint);
+            canvas->drawPath(path, paint);
             canvas->restore();
 
-            y += SkScalarCeilToScalar(path->getBounds().height() + 20.f);
+            y += SkScalarCeilToScalar(path.getBounds().height() + 20.f);
         }
 
         return DrawResult::kOk;
     }
 
 private:
-    typedef SkTLList<SkPath, 1> PathList;
-    PathList fPaths;
+    std::vector<SkPath> fPaths;
 
     using INHERITED = GM;
 };