commit | b7dbf633a69408fef33105e39b60c442771dba07 | [log] [tgz] |
---|---|---|
author | scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | Tue Apr 23 15:38:09 2013 +0000 |
committer | scroggo@google.com <scroggo@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> | Tue Apr 23 15:38:09 2013 +0000 |
tree | 61d34f61e99f6c353a05c0cd5db1631afb1f868f | |
parent | d42aca31b9ddc1cb9a81522b4c73a9fe550450bc [diff] [blame] |
Fix an SkCommandLineFlags bug. Previously I was storing an SkTDArray of const char*, which fails if the strings go out of scope. Instead, store an SkTArray of SkString, and copy the strings, so we do not depend on the strings sticking around. Using an SkTArray because it is smart enough to call the destructors, so the copies can be destroyed on program exit. BUG=https://code.google.com/p/skia/issues/detail?id=1237 Review URL: https://codereview.chromium.org/14414008 git-svn-id: http://skia.googlecode.com/svn/trunk@8829 2bbb7eff-a529-9590-31e7-b0007b416f81
diff --git a/tools/flags/SkCommandLineFlags.cpp b/tools/flags/SkCommandLineFlags.cpp index 451daf7..d634edb 100644 --- a/tools/flags/SkCommandLineFlags.cpp +++ b/tools/flags/SkCommandLineFlags.cpp
@@ -6,6 +6,7 @@ */ #include "SkCommandLineFlags.h" +#include "SkTDArray.h" static bool string_is_in(const char* target, const char* set[], size_t len) { for (size_t i = 0; i < len; i++) {