commit b8310aefc4ec46135b51f22aa3d7c1607233713d
author John Stiles <johnstiles@google.com> Thu Sep 23 17:14:23 2021 -0400
committer SkCQ <skcq-be@skia-corp.google.com.iam.gserviceaccount.com> Fri Sep 24 13:04:42 2021 +0000
tree ef382f9565e02854d9a287bf903187b7da1e60f7
parent 05f78f555fc7cb55b0b3c2050ab88a252239ab58

Run conditional-assignment loop forwards.

This makes for a slightly more easier-to-read disassembly; register
numbering no longer goes in reverse for vector assignment. Of course, it
makes no difference in the actual execution.

Change-Id: I86c5024bae1f73b1cd98252e4831207e47dc11eb
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/452323
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>

src/sksl/codegen/SkSLVMCodeGenerator.cpp

diff --git a/src/sksl/codegen/SkSLVMCodeGenerator.cpp b/src/sksl/codegen/SkSLVMCodeGenerator.cpp
index 2548188..41d923a 100644
--- a/src/sksl/codegen/SkSLVMCodeGenerator.cpp
+++ b/src/sksl/codegen/SkSLVMCodeGenerator.cpp
@@ -1465,7 +1465,7 @@
 
     // `slots` are now absolute indices into `fSlots`.
     skvm::I32 mask = this->mask();
-    for (size_t i = rhs.slots(); i --> 0;) {
+    for (size_t i = 0; i < rhs.slots(); ++i) {
         skvm::Val& slotVal = fSlots[slots[i]];
         slotVal = this->writeConditionalStore(slotVal, rhs[i], mask);
     }