commit b935cf8e12d7371246d318f20f4ebf88e321573a
author Herb Derby <herb@google.com> Thu Jul 26 16:54:18 2018 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Jul 27 03:13:56 2018 +0000
tree 4af6fce01d981c24e16c5adfd92680d49199988e
parent 5f1dc76d0ceceb97796ec1626e59fe8d4ede581c

const all the things

Having the glyph run list be const as it passes through the stack means
that future change can't be introduced in the device code that changes
behavior. Try to force all text changes into the SkGylphRun system.

Change-Id: I9412bc094c7adb8554887c725a6264af306e1d42
Reviewed-on: https://skia-review.googlesource.com/143702
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Ben Wagner <bungeman@google.com>

src/gpu/text/GrTextBlobCache.h

diff --git a/src/gpu/text/GrTextBlobCache.h b/src/gpu/text/GrTextBlobCache.h
index 72743f8..110e0ad 100644
--- a/src/gpu/text/GrTextBlobCache.h
+++ b/src/gpu/text/GrTextBlobCache.h
@@ -56,18 +56,18 @@
         return cacheBlob;
     }
 
-    sk_sp<GrTextBlob> makeBlob(SkGlyphRunList* glyphRunList) {
-        return GrTextBlob::Make(glyphRunList->totalGlyphCount(), glyphRunList->size());
+    sk_sp<GrTextBlob> makeBlob(const SkGlyphRunList& glyphRunList) {
+        return GrTextBlob::Make(glyphRunList.totalGlyphCount(), glyphRunList.size());
     }
 
-    sk_sp<GrTextBlob> makeCachedBlob(SkGlyphRunList* glyphRunList,
+    sk_sp<GrTextBlob> makeCachedBlob(const SkGlyphRunList& glyphRunList,
                                      const GrTextBlob::Key& key,
                                      const SkMaskFilterBase::BlurRec& blurRec,
                                      const SkPaint& paint) {
         sk_sp<GrTextBlob> cacheBlob(makeBlob(glyphRunList));
         cacheBlob->setupKey(key, blurRec, paint);
         this->add(cacheBlob);
-        glyphRunList->temporaryShuntBlobNotifyAddedToCache(fUniqueID);
+        glyphRunList.temporaryShuntBlobNotifyAddedToCache(fUniqueID);
         return cacheBlob;
     }