Add private blender type to SkSL built-in types.
This type will hold blender objects, similar to color filters and
shaders. Since the implementation is not yet complete, the type is
currently named `$blender` to indicate that it's private/inaccessible.
The $ will be removed once sampling is functional.
Many places which were conditioned on "is a color filter or shader" are
now conditioned on a helper method instead; if we ever add another
runtime effect type in the future, there should be less hunting for
places that need to be fixed.
Change-Id: I207219abf8764906c3612ce8896492c7a2af6ea1
Bug: skia:12257
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/432259
Commit-Queue: John Stiles <johnstiles@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
diff --git a/src/sksl/codegen/SkSLVMCodeGenerator.cpp b/src/sksl/codegen/SkSLVMCodeGenerator.cpp
index ae5d2ae..f36dfea 100644
--- a/src/sksl/codegen/SkSLVMCodeGenerator.cpp
+++ b/src/sksl/codegen/SkSLVMCodeGenerator.cpp
@@ -871,8 +871,8 @@
const size_t nargs = c.arguments().size();
if (intrinsicKind == k_sample_IntrinsicKind) {
- // Sample is very special, the first argument is a child (shader/colorFilter), which can't
- // be evaluated
+ // Sample is very special. The first argument is a child (shader/colorFilter/blender),
+ // which is opaque and can't be evaluated.
SkASSERT(nargs == 2);
const Expression* child = c.arguments()[0].get();
SkASSERT(child->type().isEffectChild());