commit bd3ffa43d23fbbef822f9e88dfc886e1f945b80a
author John Stiles <johnstiles@google.com> Thu Jul 30 20:24:57 2020 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Jul 31 01:02:21 2020 +0000
tree a5640c1412f9460fe9814ecb0f7945379dd1e8fe
parent bcde9eec203486eda856848c77b733588f2d8f38

Fix range-based for loops which copy the loop variable unnecessarily.

This will allow us to enable the ClangTidy check
performance-for-range-copy.

Change-Id: I11f152ffe458f5f353da8715ffd2fd47cf4e71a7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/306946
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>

src/pathops/SkPathOpsAsWinding.cpp

diff --git a/src/pathops/SkPathOpsAsWinding.cpp b/src/pathops/SkPathOpsAsWinding.cpp
index 763427f..500dc35 100644
--- a/src/pathops/SkPathOpsAsWinding.cpp
+++ b/src/pathops/SkPathOpsAsWinding.cpp
@@ -325,7 +325,7 @@
         SkPathPriv::Iterate iterate(fPath);
         auto iter = iterate.begin();
         int verbCount = 0;
-        for (auto contour : contours) {
+        for (const Contour& contour : contours) {
             SkPath reverse;
             SkPath* temp = contour.fReverse ? &reverse : result;
             for (; iter != iterate.end() && verbCount < contour.fVerbEnd; ++iter, ++verbCount) {