commit c9b06ca70890ba23ab3f54fb69e4db7fbac79393
author Dominik Röttsches <drott@chromium.org> Fri Jan 31 18:13:37 2020 +0200
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Jan 31 18:35:10 2020 +0000
tree 1599e2393f92ce0c4897d1ad8a52ee3c91413af1
parent e530acdf371f6e6b06c11f674a7dc909876e2755

Remove CGFontRef parameter from SkMakeTypefaceFromCTFont

Since the Blink side CTFontRefs are no longer created from CGFontRefs
after [1], we do not need to pass CGFontRefs to Skia any longer for
keeping them alive. Clean up related plumbing which previously passed
through the CGFontRef to the SkTypefaceMac constructor.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1964073

Bug: chromium:1033478
Change-Id: Ic85cae6289fa9b4886201c92defb54fcc5622720
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/266816
Reviewed-by: Dominik Röttsches <drott@chromium.org>
Reviewed-by: Ben Wagner <bungeman@google.com>
Commit-Queue: Ben Wagner <bungeman@google.com>

RELEASE_NOTES.txt

diff --git a/RELEASE_NOTES.txt b/RELEASE_NOTES.txt
index e5a318f..66f6580 100644
--- a/RELEASE_NOTES.txt
+++ b/RELEASE_NOTES.txt
@@ -7,6 +7,11 @@
 Milestone 82
 
 <Insert new notes here- top is most recent.>
+
+  * Remove CGFontRef parameter from SkCreateTypefaceFromCTFont.
+    Use CTFontManagerCreateFontDescriptorFromData instead of
+    CGFontCreateWithDataProvider to create CTFonts to avoid memory use issues.
+
   * Added SkAndroidCodec::getICCProfile for reporting the native ICC profile of
     an encoded image, even if it doesn't map to an SkColorSpace.