commit cab588677bbc87624823b119295adafbd65c5874
author John Stiles <johnstiles@google.com> Wed Aug 12 15:47:06 2020 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed Aug 12 20:20:51 2020 +0000
tree cde020222450deabec6dd6583ba4220808fffad6
parent 8d9bf6467bd2d13322218f50aaf0b18f9746f908

Add `GrProcessor::onDumpInfo` for subclass info dumps.

This CL also marks `GrProcessor::dumpInfo` as final. This prevents a
subclass from mistakenly overriding `dumpInfo` instead of `onDumpInfo`.

`onDumpInfo` is responsible for providing the same data as `dumpInfo`,
except that the FP name is automatically prepended.

Change-Id: I2b44c30a01bc65e9d88321cc21651a94e20074c6
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/309793
Commit-Queue: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

src/gpu/effects/generated/GrMagnifierEffect.cpp

diff --git a/src/gpu/effects/generated/GrMagnifierEffect.cpp b/src/gpu/effects/generated/GrMagnifierEffect.cpp
index 1cdb314..faf7f31 100644
--- a/src/gpu/effects/generated/GrMagnifierEffect.cpp
+++ b/src/gpu/effects/generated/GrMagnifierEffect.cpp
@@ -148,10 +148,10 @@
     return std::make_unique<GrMagnifierEffect>(*this);
 }
 #if GR_TEST_UTILS
-SkString GrMagnifierEffect::dumpInfo() const {
+SkString GrMagnifierEffect::onDumpInfo() const {
     return SkStringPrintf(
-            "MagnifierEffect(bounds=int4(%d, %d, %d, %d), srcRect=float4(%f, %f, %f, %f), "
-            "xInvZoom=%f, yInvZoom=%f, xInvInset=%f, yInvInset=%f)",
+            "(bounds=int4(%d, %d, %d, %d), srcRect=float4(%f, %f, %f, %f), xInvZoom=%f, "
+            "yInvZoom=%f, xInvInset=%f, yInvInset=%f)",
             bounds.left(), bounds.top(), bounds.right(), bounds.bottom(), srcRect.left(),
             srcRect.top(), srcRect.right(), srcRect.bottom(), xInvZoom, yInvZoom, xInvInset,
             yInvInset);