Fix clang 12 Wsuggest-override and Wsuggest-destructor-override
Change-Id: Ic44e24057b95bb014504f02a736fb4341afc8971
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/304856
Commit-Queue: Mike Klein <mtklein@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
diff --git a/tools/using_skia_and_harfbuzz.cpp b/tools/using_skia_and_harfbuzz.cpp
index 03fcf30..7f8d593 100644
--- a/tools/using_skia_and_harfbuzz.cpp
+++ b/tools/using_skia_and_harfbuzz.cpp
@@ -77,8 +77,8 @@
}
struct DoubleOption : Option<double> {
- virtual void set(std::string _value) { value = atof(_value.c_str()); }
- virtual std::string valueToString() {
+ void set(std::string _value) override { value = atof(_value.c_str()); }
+ std::string valueToString() override {
std::ostringstream stm;
stm << value;
return stm.str();
@@ -90,8 +90,8 @@
};
struct StringOption : Option<std::string> {
- virtual void set(std::string _value) { value = _value; }
- virtual std::string valueToString() { return value; }
+ void set(std::string _value) override { value = _value; }
+ std::string valueToString() override { return value; }
StringOption(std::string _selector,
std::string _description,
std::string defaultValue)