| commit | d116561ddcca3f961b30cd9e485d81b654bc10ec | [log] [tgz] |
|---|---|---|
| author | caryclark <caryclark@google.com> | Wed Feb 10 04:34:08 2016 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Wed Feb 10 04:34:08 2016 -0800 |
| tree | b303ed66952c05e329b818b22a945f163eedd37c | |
| parent | 64e75330916f670cf9db9eb7a850afc325b18645 [diff] |
Revert of Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. (patchset #3 id:40001 of https://codereview.chromium.org/1681643002/ ) Reason for revert: breaks various android builds, e.g. https://android-build.storage.googleapis.com/builds/git_master-skia-linux-bullhead-userdebug/2596406/acb02999d48ace628601452700d4b4f8dcd5ed71b426e6ecdb1c7f5bc5452f7b/logs/build_error.log?Signature=BkLEdMOdi0LelP0v939QECdTZzznSD2dLFIkPu52E7%2BPr5Oj1ktq5nNlxGZn%2F4ZhCKXAw2%2FNHxy27nNJ8lffcgXn7PhQpa82bP%2B8F%2Bbyo9j%2BT%2B3etmOdQFEejJSRsEv2RrVWtKsKYRX%2FuZinrF9yD37jUpSbKNZvmvIbKa4V4IQ%3D&GoogleAccessId=701025073339-mqn0q2nvir9iurm6q5d00tdv7blbgvjr%40developer.gserviceaccount.com&Expires=1455108483 external/skia/bench/../tools/debugger/SkDrawCommand.cpp:602:9: error: use of undeclared identifier 'free' free(data); Original issue's description: > Moved Canvas->JSON and JSON->Canvas functionality into SkDebugCanvas. > SkJSONCanvas and SkJSONRenderer will be deleted once the debug server > has been updated. > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1681643002 > > Committed: https://skia.googlesource.com/skia/+/32fff1ba0c759d97ab78320b7ae46dd7696a4e6e > > Committed: https://skia.googlesource.com/skia/+/46cb6d6b82b0ab71033aef91419e8beae25bb8a4 TBR=jcgregorio@google.com,joshualitt@chromium.org,ethannicholas@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1683093002