| commit | d2c77912339410fd24b21331b6703b1929919401 | [log] [tgz] |
|---|---|---|
| author | ethannicholas <ethannicholas@google.com> | Thu Feb 25 13:43:16 2016 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Thu Feb 25 13:43:16 2016 -0800 |
| tree | 49f07f756206e651855b6acabc37c5a595d1e83a | |
| parent | 436d9851b510004e1bdfb88da42ea45203751fc5 [diff] |
Revert of Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder (patchset #3 id:40001 of https://codereview.chromium.org/1730903007/ ) Reason for revert: Got a GL-related crash in nanobench: https://uberchromegw.corp.google.com/i/client.skia.android/builders/Perf-Android-GCC-Nexus10-GPU-MaliT604-Arm7-Release/builds/3815/steps/nanobench/logs/stdio Given we're about to branch and this is the only GL-related change in the blamelist, I'm going to assume this is responsible and revert. Original issue's description: > Make GrDrawContext::internalDrawPath cons up its own GrPipelineBuilder > > Hopefully, this better defines (and reduces) the lifetime and reuse of GrPipelineBuilder objects in GrDrawContext. > > TBR=bsalomon@google.com > > GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1730903007 > > Committed: https://skia.googlesource.com/skia/+/00fddebe56fabea67dcc08762805c1294eebf5bf TBR=joshualitt@chromium.org,bsalomon@google.com,robertphillips@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Review URL: https://codereview.chromium.org/1737373002