commit d6cfe72549243def6e1a7af6cd92f0f9863a7697
author Herb Derby <herb@google.com> Mon Oct 05 15:50:47 2020 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Oct 06 15:19:06 2020 +0000
tree d53d1f0ea73572d2063c257b16232ad472b415f6
parent 8e5cf441141c491266736f7714124135bcc93efe

Add flag to switch op allocation to new

Added a flag to switch from using the memory pool to
using new and delete for GrOp allocation.

Just add the following to your gn args.
extra_cflags = [
    "-DGR_OP_ALLOCATE_USE_NEW",
]

Change-Id: Icea4a6df047cff2cd5e50032f0bd4b714a5740d4
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/322625
Commit-Queue: Herb Derby <herb@google.com>
Reviewed-by: Michael Ludwig <michaelludwig@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

tests/DrawOpAtlasTest.cpp

diff --git a/tests/DrawOpAtlasTest.cpp b/tests/DrawOpAtlasTest.cpp
index eec3a07..d3c8462 100644
--- a/tests/DrawOpAtlasTest.cpp
+++ b/tests/DrawOpAtlasTest.cpp
@@ -195,7 +195,6 @@
 
     auto gpu = context->priv().getGpu();
     auto resourceProvider = context->priv().resourceProvider();
-    auto opMemoryPool = context->priv().opMemoryPool();
 
     auto rtc = GrRenderTargetContext::Make(
             context, GrColorType::kRGBA_8888, nullptr, SkBackingFit::kApprox, {32, 32});
@@ -240,7 +239,10 @@
     flushState.setOpArgs(&opArgs);
     op->prepare(&flushState);
     flushState.setOpArgs(nullptr);
-    opMemoryPool->release(std::move(op));
+    #if !defined(GR_OP_ALLOCATE_USE_NEW)
+        auto opMemoryPool = context->priv().opMemoryPool();
+        opMemoryPool->release(std::move(op));
+    #endif
 }
 
 void test_atlas_config(skiatest::Reporter* reporter, int maxTextureSize, size_t maxBytes,