commit d84c1e65a67530bd595f7c4f4d6f1b7016b2fca2
author Mike Klein <mtklein@google.com> Tue Sep 04 10:15:58 2018 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Sep 04 15:46:42 2018 +0000
tree e4c1f1ff47bb97c22ee347b01d0a483977362b7a
parent 434b80f82fee3c21ae330363354ae2669ed137f5

drop warnings and -Werror from is_official_builds

People using is_official_build don't really want to see warnings.
They're for devs, not users.

The somewhat odd update to gn/BUILDCONFIG.gn keeps command
line flag precedence (later == more important) unchanged.

Change-Id: I1a04a35f066b7408021d474535f0dbf4928e21d3
Reviewed-on: https://skia-review.googlesource.com/151380
Commit-Queue: Brian Salomon <bsalomon@google.com>
Auto-Submit: Mike Klein <mtklein@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

gn/BUILD.gn

diff --git a/gn/BUILD.gn b/gn/BUILD.gn
index d6fd5c2..3dcdbed 100644
--- a/gn/BUILD.gn
+++ b/gn/BUILD.gn
@@ -94,7 +94,6 @@
     cflags += [
       "-fstrict-aliasing",
       "-fPIC",
-      "-Werror",
     ]
     cflags_cc += [ "-std=c++14" ]
 
@@ -308,6 +307,7 @@
     ]
   } else {
     cflags += [
+      "-Werror",
       "-Wall",
       "-Wextra",
       "-Winit-self",