| commit | d8f4f42b03a3b144c0b191354c59fd1a0ec75f75 | [log] [tgz] |
|---|---|---|
| author | Michael Ludwig <michaelludwig@google.com> | Wed Jun 24 18:58:18 2020 +0000 |
| committer | Skia Commit-Bot <skia-commit-bot@chromium.org> | Wed Jun 24 18:58:25 2020 +0000 |
| tree | e47eea32a4887bb6c0af50fb4d7cde1fe5b31f6a | |
| parent | 287c28c0475a1519d2e12756e497e69d454887d9 [diff] |
Revert "Simplify GrClip API" This reverts commit 9716414e93f7b279e547595fab08b68235c4b2be. Reason for revert: clipRRect elision seems to trigger precision issues on Nexus5x, see https://chrome-gpu-gold.skia.org/search?fdiffmax=-1&fref=false&frgbamax=255&frgbamin=0&head=true&include=false&issue=2264837&limit=50&master=false&match=name&metric=combined&neg=false&offset=0&pos=false&query=source_type%3Dchrome-gpu&sort=desc&unt=true Original change's description: > Simplify GrClip API > > Removes quickContains(SkRect), quickContains(SkRRect), and isRRect(). > Replaces these three functions with preApply() that conservatively > determines the clip effect up to a single rrect intersection. The major > motivation for this is the new GrClipStack implementation. preApply() > and apply() will be able to reuse much more code compared to separating > the preApply functionality across the older three functions that were > removed. Additionally, preApply is able to convey more information for > less work, since it can usually determine being skipped or unclipped while > determining if the clip is a single rrect. > > As part of using this API, the attemptQuadOptimiziation and the equivalent > rrect optimization are overhauled. Hopefully legibility is improved, and > the rrect case is now applied outside of the android framework (but with > tighter AA requirements). > > Bug: skia:10205 > Change-Id: I33249dd75a28a611495f87b211cb7ec74ebb7ba4 > Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298506 > Reviewed-by: Brian Salomon <bsalomon@google.com> > Reviewed-by: Chris Dalton <csmartdalton@google.com> > Commit-Queue: Michael Ludwig <michaelludwig@google.com> TBR=bsalomon@google.com,csmartdalton@google.com,michaelludwig@google.com Change-Id: I850cbf92eea9cf5f2db5528a93251f02dbd6fee2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: skia:10205 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/298753 Reviewed-by: Michael Ludwig <michaelludwig@google.com> Commit-Queue: Michael Ludwig <michaelludwig@google.com>