commit d9d33c33dee064da260301faa313703e465d44c5
author Ethan Nicholas <ethannicholas@google.com> Tue Jun 12 11:05:59 2018 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Jun 12 19:16:03 2018 +0000
tree f2e9a592acde1715d71381d8ff7c97fdaf58edac
parent 22be4c4801f957f2820b9001b02b892f4b87a157

renamed SkSL's assert macros

Since SkSL needs to run outside of Skia, it was originally using its
own ASSERT macro, which mapped to SkASSERT when inside of Skia. This is
causing conflicts with one or two other ASSERT macros defined around
Skia, so to avoid that I am switching SkSL over to just use Skia's
standard naming for these macros.

Bug: skia:
Change-Id: I115435d7282da03d076c6080f7b13d1972b9eb9f
Reviewed-on: https://skia-review.googlesource.com/134322
Reviewed-by: Greg Daniel <egdaniel@google.com>
Commit-Queue: Ethan Nicholas <ethannicholas@google.com>

src/sksl/SkSLMetalCodeGenerator.cpp

diff --git a/src/sksl/SkSLMetalCodeGenerator.cpp b/src/sksl/SkSLMetalCodeGenerator.cpp
index 01f3220..af2366e 100644
--- a/src/sksl/SkSLMetalCodeGenerator.cpp
+++ b/src/sksl/SkSLMetalCodeGenerator.cpp
@@ -163,7 +163,7 @@
 
 void MetalCodeGenerator::writeIntrinsicCall(const FunctionCall& c) {
     auto i = fIntrinsicMap.find(c.fFunction.fName);
-    ASSERT(i != fIntrinsicMap.end());
+    SkASSERT(i != fIntrinsicMap.end());
     Intrinsic intrinsic = i->second;
     int32_t intrinsicId = intrinsic.second;
     switch (intrinsic.first) {
@@ -257,7 +257,7 @@
             if (c.fArguments[1]->fType == *fContext.fFloat3_Type) {
                 this->write(".xy)"); // FIXME - add projection functionality
             } else {
-                ASSERT(c.fArguments[1]->fType == *fContext.fFloat2_Type);
+                SkASSERT(c.fArguments[1]->fType == *fContext.fFloat2_Type);
                 this->write(")");
             }
             break;
@@ -443,7 +443,7 @@
         this->writeExpression(*b.fLeft, kAssignment_Precedence);
         this->write(" ");
         String op = Compiler::OperatorName(b.fOperator);
-        ASSERT(op.endsWith("="));
+        SkASSERT(op.endsWith("="));
         this->write(op.substr(0, op.size() - 1).c_str());
         this->write(" ");
     } else {
@@ -525,7 +525,7 @@
                 this->write("vertex Outputs main0");
                 break;
             default:
-                ASSERT(false);
+                SkASSERT(false);
         }
         this->write("(Inputs _in [[stage_in]]");
         if (-1 != fUniformBuffer) {
@@ -627,7 +627,7 @@
     }
     this->writeLine(") {");
 
-    ASSERT(!fProgram.fSettings.fFragColorIsInOut);
+    SkASSERT(!fProgram.fSettings.fFragColorIsInOut);
 
     if ("main" == f.fDeclaration.fName) {
         if (fNeedsGlobalStructInit) {
@@ -682,7 +682,7 @@
                 this->writeLine("return *_out;"); // FIXME - detect if function already has return
                 break;
             default:
-                ASSERT(false);
+                SkASSERT(false);
         }
     }
     fIndentation--;
@@ -793,7 +793,7 @@
 }
 
 void MetalCodeGenerator::writeVarDeclarations(const VarDeclarations& decl, bool global) {
-    ASSERT(decl.fVars.size() > 0);
+    SkASSERT(decl.fVars.size() > 0);
     bool wroteType = false;
     for (const auto& stmt : decl.fVars) {
         VarDeclaration& var = (VarDeclaration&) *stmt;