commit d9e0181405c9853ffd20502555200205a5ab09b1
author bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Wed Aug 29 19:35:44 2012 +0000
committer bsalomon@google.com <bsalomon@google.com@2bbb7eff-a529-9590-31e7-b0007b416f81> Wed Aug 29 19:35:44 2012 +0000
tree 7b026a6615e4b76d5eba16de2d1d6ffaa80f1449
parent 57cdcc091bf8ff4c6da90c6dac8ca3780bfe3b3c

Linux warning fixes

Review URL: https://codereview.appspot.com/6500045/



git-svn-id: http://skia.googlecode.com/svn/trunk@5337 2bbb7eff-a529-9590-31e7-b0007b416f81

src/gpu/GrMemoryPool.cpp

diff --git a/src/gpu/GrMemoryPool.cpp b/src/gpu/GrMemoryPool.cpp
index 01f303f..17d70ab 100644
--- a/src/gpu/GrMemoryPool.cpp
+++ b/src/gpu/GrMemoryPool.cpp
@@ -110,7 +110,7 @@
     block->fLiveCount = 0;
     block->fFreeSize = size;
     block->fCurrPtr = reinterpret_cast<intptr_t>(block) + kHeaderSize;
-    block->fPrevPtr = NULL;
+    block->fPrevPtr = 0; // gcc warns on assigning NULL to an intptr_t.
     return block;
 }
 

src/gpu/gl/GrGLSL.cpp

diff --git a/src/gpu/gl/GrGLSL.cpp b/src/gpu/gl/GrGLSL.cpp
index 21e9183..c995a34 100644
--- a/src/gpu/gl/GrGLSL.cpp
+++ b/src/gpu/gl/GrGLSL.cpp
@@ -115,7 +115,7 @@
             outAppend->append(GrGLSLZerosVecf(4));
             return kZeros_GrSLConstantVec;
         } else {
-            outAppend->appendf(GrGLSLOnesVecf(4));
+            outAppend->append(GrGLSLOnesVecf(4));
             return kOnes_GrSLConstantVec;
         }
     } else if (!has0) {

src/gpu/gl/GrGLShaderBuilder.cpp

diff --git a/src/gpu/gl/GrGLShaderBuilder.cpp b/src/gpu/gl/GrGLShaderBuilder.cpp
index 5aa3a54..c061468 100644
--- a/src/gpu/gl/GrGLShaderBuilder.cpp
+++ b/src/gpu/gl/GrGLShaderBuilder.cpp
@@ -77,10 +77,10 @@
     , fFSInputs(kVarsPerBlock)
     , fFSOutputs(kMaxFSOutputs)
     , fUsesGS(false)
-    , fTexCoordVaryingType(kVoid_GrSLType)
     , fContext(ctx)
     , fUniformManager(uniformManager)
-    , fCurrentStage(kNonStageIdx) {
+    , fCurrentStage(kNonStageIdx)
+    , fTexCoordVaryingType(kVoid_GrSLType) {
 }
 
 void GrGLShaderBuilder::computeSwizzle(uint32_t configFlags) {

src/image/SkImage_Raster.cpp

diff --git a/src/image/SkImage_Raster.cpp b/src/image/SkImage_Raster.cpp
index daed241..c9a132d 100644
--- a/src/image/SkImage_Raster.cpp
+++ b/src/image/SkImage_Raster.cpp
@@ -43,7 +43,7 @@
         }
 
         int64_t size = (int64_t)info.fHeight * rowBytes;
-        if (size > kMaxPixelByteSize) {
+        if (size > (int64_t)kMaxPixelByteSize) {
             return false;
         }
         return true;