commit dabd4f0b799318cb6e90b69ae1ec0ed0b6d32f60
author halcanary <halcanary@google.com> Wed Aug 03 11:16:56 2016 -0700
committer Commit bot <commit-bot@chromium.org> Wed Aug 03 11:16:57 2016 -0700
tree 440e9e2677dbbf17b2b8e2ce10a7131b99641eb7
parent 62e1a1a4ba9926c9b515eb603173ea4202ac28ae

SkPDF: PDFShader code modernized.

Motivation:  reduce code complexity.

SkCanon stores SkPDFShader::State next to SkDFObject, not inside.

many places use sk_sp<T> rather than T* to represent ownership.

SkPDFShader::State no longer holds bitmap.

SkPDFShader::State gets move constructor, no longer heap-allocated.

Classes removed:
  SkPDFFunctionShader
  SkPDFAlphaFunctionShader
  SkPDFImageShader

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2193973002

Review-Url: https://codereview.chromium.org/2193973002

src/pdf/SkPDFGraphicState.h

diff --git a/src/pdf/SkPDFGraphicState.h b/src/pdf/SkPDFGraphicState.h
index 6b3f7cc..84491ba 100644
--- a/src/pdf/SkPDFGraphicState.h
+++ b/src/pdf/SkPDFGraphicState.h
@@ -51,7 +51,7 @@
      *
      *  These are not de-duped.
      */
-    static sk_sp<SkPDFDict> GetSMaskGraphicState(SkPDFObject* sMask,
+    static sk_sp<SkPDFDict> GetSMaskGraphicState(sk_sp<SkPDFObject> sMask,
                                                  bool invert,
                                                  SkPDFSMaskMode sMaskMode,
                                                  SkPDFCanon* canon);