commit dd5f655594962ad678ef62cc9c273de79175d37f
author Brian Osman <brianosman@google.com> Tue Dec 17 13:04:30 2019 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Tue Dec 17 18:35:33 2019 +0000
tree e3ad7d229af280df511fa5793036fdb234aa4084
parent 484384bf30f7ecd75a27a7e83df2c0a171f94a41

Don't allocate invalidation messages for generators that make uncacheable textures

Fixes a memory leak in Flutter.

Change-Id: Ia86ea8d4d78539dc28acb207e834861f274c0a5c
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/260538
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>

src/gpu/GrBackendTextureImageGenerator.h

diff --git a/src/gpu/GrBackendTextureImageGenerator.h b/src/gpu/GrBackendTextureImageGenerator.h
index 887ff21..d9980c5 100644
--- a/src/gpu/GrBackendTextureImageGenerator.h
+++ b/src/gpu/GrBackendTextureImageGenerator.h
@@ -42,6 +42,7 @@
     TexGenType onCanGenerateTexture() const override { return TexGenType::kCheap; }
     sk_sp<GrTextureProxy> onGenerateTexture(GrRecordingContext*, const SkImageInfo&,
                                             const SkIPoint&, bool willNeedMipMaps) override;
+    bool onTexturesAreCacheable() const override { return false; }
 
 private:
     GrBackendTextureImageGenerator(const SkImageInfo& info, GrTexture*, GrSurfaceOrigin,