commit deb4c169690c777acb27ee8ce67d70d3f6eb2a2c
author jamesr@chromium.org <jamesr@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> Thu Nov 29 21:17:16 2012 +0000
committer jamesr@chromium.org <jamesr@chromium.org@2bbb7eff-a529-9590-31e7-b0007b416f81> Thu Nov 29 21:17:16 2012 +0000
tree f8e8c8dcc5d9a9d864095403b36def0c94bcb195
parent 5fac58c91d8053dcc05c5bc72cfccee9246d9add

Keep track of identity SkMatrix44s

This keeps a bool on SkMatrix44 indicating if we know for sure that the matrix
is identity, similar to the TypeMask on SkMatrix. This is useful to early-out
of potentially expensive matrix math at the cost of some memory.
Review URL: https://codereview.appspot.com/6854113

git-svn-id: http://skia.googlecode.com/svn/trunk@6620 2bbb7eff-a529-9590-31e7-b0007b416f81

src/utils/SkMatrix44.cpp

diff --git a/src/utils/SkMatrix44.cpp b/src/utils/SkMatrix44.cpp
index 7dd174a..a69111c 100644
--- a/src/utils/SkMatrix44.cpp
+++ b/src/utils/SkMatrix44.cpp
@@ -23,6 +23,9 @@
 }
 
 bool SkMatrix44::operator==(const SkMatrix44& other) const {
+    if (fIdentity && other.fIdentity)
+        return true;
+
     const SkMScalar* a = &fMat[0][0];
     const SkMScalar* b = &other.fMat[0][0];
     for (int i = 0; i < 16; ++i) {
@@ -90,6 +93,7 @@
 #elif defined SK_MSCALAR_IS_FLOAT
     memcpy(dst, src, 16 * sizeof(float));
 #endif
+    fIdentity = false;
 }
 
 void SkMatrix44::setColMajord(const double src[]) {
@@ -101,6 +105,7 @@
         dst[i] = SkMScalarToDouble(src[i]);
     }
 #endif
+    fIdentity = false;
 }
 
 void SkMatrix44::setRowMajorf(const float src[]) {
@@ -113,6 +118,7 @@
         src += 4;
         dst += 1;
     }
+    fIdentity = false;
 }
 
 void SkMatrix44::setRowMajord(const double src[]) {
@@ -125,11 +131,15 @@
         src += 4;
         dst += 1;
     }
+    fIdentity = false;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
 
 bool SkMatrix44::isIdentity() const {
+    if (fIdentity)
+        return true;
+
     static const SkMScalar  sIdentityMat[4][4] = {
         { 1, 0, 0, 0 },
         { 0, 1, 0, 0 },
@@ -144,6 +154,7 @@
 void SkMatrix44::setIdentity() {
     sk_bzero(fMat, sizeof(fMat));
     fMat[0][0] = fMat[1][1] = fMat[2][2] = fMat[3][3] = 1;
+    fIdentity = true;
 }
 
 void SkMatrix44::set3x3(SkMScalar m00, SkMScalar m01, SkMScalar m02,
@@ -154,6 +165,7 @@
     fMat[1][0] = m10; fMat[1][1] = m11; fMat[1][2] = m12; fMat[1][3] = 0;
     fMat[2][0] = m20; fMat[2][1] = m21; fMat[2][2] = m22; fMat[2][3] = 0;
     fMat[3][0] = 0;   fMat[3][1] = 0;   fMat[3][2] = 0;   fMat[3][3] = 1;
+    fIdentity = false;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -164,6 +176,7 @@
     fMat[3][1] = ty;
     fMat[3][2] = tz;
     fMat[3][3] = 1;
+    fIdentity = false;
 }
 
 void SkMatrix44::preTranslate(SkMScalar dx, SkMScalar dy, SkMScalar dz) {
@@ -176,6 +189,7 @@
     fMat[3][0] += dx;
     fMat[3][1] += dy;
     fMat[3][2] += dz;
+    fIdentity = false;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -186,6 +200,7 @@
     fMat[1][1] = sy;
     fMat[2][2] = sz;
     fMat[3][3] = 1;
+    fIdentity = false;
 }
 
 void SkMatrix44::preScale(SkMScalar sx, SkMScalar sy, SkMScalar sz) {
@@ -200,6 +215,7 @@
         fMat[i][1] *= sy;
         fMat[i][2] *= sz;
     }
+    fIdentity = false;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -263,6 +279,7 @@
         }
     }
     memcpy(fMat, result, sizeof(result));
+    fIdentity = false;
 }
 
 ///////////////////////////////////////////////////////////////////////////////
@@ -363,6 +380,7 @@
             inverse->fMat[i][j] = SkDoubleToMScalar(tmp[i][j] * invDet);
         }
     }
+    inverse->fIdentity = false;
     return true;
 }
 
@@ -444,6 +462,7 @@
 
 SkMatrix44& SkMatrix44::operator=(const SkMatrix& src) {
     initFromMatrix(fMat, src);
+    fIdentity = src.isIdentity();
     return *this;
 }