commit | e1b74b73589f9b5e0c389bbeaebc92b267345722 | [log] [tgz] |
---|---|---|
author | Nam Se Hyun <3580430+namse@users.noreply.github.com> | Sat Sep 04 17:24:18 2021 +0000 |
committer | Kevin Lubick <kjlubick@google.com> | Tue Sep 07 12:11:14 2021 +0000 |
tree | 13a9232dfb448dfcf7479c5bb6ec3d12dbe891d2 | |
parent | 10fa1c84b4b2352fc03fa848ceb2dbe145bd8261 [diff] |
Fix EmbindObject's deleteLater to deleteAfter I found that CanvasKit's `EmbindObject` type has wrong function name, `deleteAfter`. I cound't find any information of function `deleteAfter` even in google searching. so i digged it. ![image](https://user-images.githubusercontent.com/3580430/132103177-9c7c32a3-2107-4b97-9698-f52da5833ba1.png) I have no idea with `deleteAfter`, but `EmbindObject` has the function name `deleteLater`, not `deleteAfter`. Below is the code of Embind. https://github.com/emscripten-core/emscripten/blob/dd5733ac80881e55e1f6757caabf617b6b2a7cec/src/embind/embind.js#L1782 This is an imported pull request from https://github.com/google/skia/pull/86 GitOrigin-RevId: 0738dc792404e8a08ba666c0662795b55beb7a5d Change-Id: I0a7af3d4f313d36e8cdc09d631f9199e948eca29 Reviewed-on: https://skia-review.googlesource.com/c/skia/+/445736 Reviewed-by: Kevin Lubick <kjlubick@google.com> Commit-Queue: Kevin Lubick <kjlubick@google.com>