Remove unused dstColorSpace from getROPixels
Bug: skia:
Change-Id: Id5f03f2c82706f5f82c24ff735805c85ad0b069d
Reviewed-on: https://skia-review.googlesource.com/c/163883
Commit-Queue: Brian Osman <brianosman@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>
Auto-Submit: Brian Osman <brianosman@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
diff --git a/src/image/SkImage_GpuBase.cpp b/src/image/SkImage_GpuBase.cpp
index b7067e7..ff07a51 100644
--- a/src/image/SkImage_GpuBase.cpp
+++ b/src/image/SkImage_GpuBase.cpp
@@ -47,18 +47,12 @@
//////////////////////////////////////////////////////////////////////////////////////////////////
-bool SkImage_GpuBase::getROPixels(SkBitmap* dst, SkColorSpace*, CachingHint chint) const {
+bool SkImage_GpuBase::getROPixels(SkBitmap* dst, CachingHint chint) const {
if (!fContext->contextPriv().resourceProvider()) {
// DDL TODO: buffer up the readback so it occurs when the DDL is drawn?
return false;
}
- // The SkColorSpace parameter "dstColorSpace" is really just a hint about how/where the bitmap
- // will be used. The client doesn't expect that we convert to that color space, it's intended
- // for codec-backed images, to drive our decoding heuristic. In theory we *could* read directly
- // into that color space (to save the client some effort in whatever they're about to do), but
- // that would make our use of the bitmap cache incorrect (or much less efficient, assuming we
- // rolled the dstColorSpace into the key).
const auto desc = SkBitmapCacheDesc::Make(this);
if (SkBitmapCache::Find(desc, dst)) {
SkASSERT(dst->isImmutable());