tree c667982cc4c74753b4419fbd71ce019d3d974bba
parent 3a35f0b263cbdad011ffff6e5032f5996e946239
author John Stiles <johnstiles@google.com> 1624572310 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> 1624619159 +0000

Add format-specifier warnings to SkDebugf.

This CL fixes up many existing format-specifier violations in Skia.
Note that GCC has a warning for formatting nothing, so existing calls to
`SkDebugf("")` have been removed, or replaced with `SkDebugf("%s", "")`.
These were apparently meant to be used as a place to set a breakpoint.

Some of our clients also use SkDebug with bad format specifiers, so this
check is currently only enabled when SKIA_IMPLEMENTATION is true.

Change-Id: I8177a1298a624c6936adc24e0d8f481362a356d0
Bug: skia:12143
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/420902
Auto-Submit: John Stiles <johnstiles@google.com>
Commit-Queue: Brian Osman <brianosman@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>