commit e68b5bd4e6e9bdf5a69932fafbd17817572971e4
author Chris Dalton <csmartdalton@google.com> Mon Jul 29 16:05:15 2019 -0600
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Jul 29 22:23:49 2019 +0000
tree d1a9fdf543f953c644323ce4049096ec0b744194
parent 07931aaeaafc0027082b570f074df23097b74098

don't try to format includes on windows

It's not going to work:
   - windows\style\paths don't work well in Python
   - something seems to be slipping in extra \r, probably print?

Change-Id: I6d9a0cc0bff403b9b45412b0e92290a9346bcf14
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/230641
Reviewed-by: Chris Dalton <csmartdalton@google.com>
Commit-Queue: Mike Klein <mtklein@google.com>

PRESUBMIT.py

diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index cee3c5c..99c0fd3 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -198,7 +198,8 @@
   cmd = ['python',
          'tools/rewrite_includes.py',
          '--dry-run'] + files
-  if 0 != subprocess.call(cmd):
+  # TODO(mtklein): tools/rewrite_includes.py doesn't work on Windows.
+  if 'win32' not in sys.platform and 0 != subprocess.call(cmd):
     return [output_api.PresubmitError('`%s` failed' % ' '.join(cmd))]
   return []