commit edf8a762190eccc6d2a7ab3a095d131e9fd101bc
author Mike Reed <reed@google.com> Mon May 22 13:41:36 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon May 22 18:08:13 2017 +0000
tree b9b9bc13a8f24168b34ab03a56da08c9bf9104df
parent ffc2e4b64db1bad164d630454d4ddde1ec75c859

add helper static to SkColorSpaceXform

Bug: skia:
Change-Id: I62525b392dfbae3d7075cf7f14e30780bad41279
Reviewed-on: https://skia-review.googlesource.com/17485
Reviewed-by: Matt Sarett <msarett@google.com>
Commit-Queue: Mike Reed <reed@google.com>

include/core/SkColorSpaceXform.h

diff --git a/include/core/SkColorSpaceXform.h b/include/core/SkColorSpaceXform.h
index ccd36bc..1e761a9 100644
--- a/include/core/SkColorSpaceXform.h
+++ b/include/core/SkColorSpaceXform.h
@@ -60,6 +60,15 @@
 
     virtual ~SkColorSpaceXform() {}
 
+    enum AlphaOp {
+        kPreserve_AlphaOp,      // just transfer src-alpha to dst-alpha
+        kPremul_AlphaOp,        // like kPreserve, but multiplies RGB by it
+        kSrcIsOpaque_AlphaOp,   // src alphas are all 1, this is a perf hint
+    };
+    static bool Apply(SkColorSpace* dstCS, ColorFormat dstFormat, void* dst,
+                      SkColorSpace* srcCS, ColorFormat srcFormat, const void* src,
+                      int count, AlphaOp);
+
 protected:
     SkColorSpaceXform() {}
 };

src/core/SkColorSpaceXform.cpp

diff --git a/src/core/SkColorSpaceXform.cpp b/src/core/SkColorSpaceXform.cpp
index 56eadfc..195de48 100644
--- a/src/core/SkColorSpaceXform.cpp
+++ b/src/core/SkColorSpaceXform.cpp
@@ -1137,6 +1137,18 @@
                                                      alphaType);
 }
 
+bool SkColorSpaceXform::Apply(SkColorSpace* dstCS, ColorFormat dstFormat, void* dst,
+                              SkColorSpace* srcCS, ColorFormat srcFormat, const void* src,
+                              int count, AlphaOp op) {
+    SkAlphaType at;
+    switch (op) {
+        case kPreserve_AlphaOp:    at = kUnpremul_SkAlphaType; break;
+        case kPremul_AlphaOp:      at = kPremul_SkAlphaType;   break;
+        case kSrcIsOpaque_AlphaOp: at = kOpaque_SkAlphaType;   break;
+    }
+    return New(srcCS, dstCS)->apply(dstFormat, dst, srcFormat, src, count, at);
+}
+
 ///////////////////////////////////////////////////////////////////////////////////////////////////
 
 template <ColorSpaceMatch kCSM>

src/core/SkDraw_vertices.cpp

diff --git a/src/core/SkDraw_vertices.cpp b/src/core/SkDraw_vertices.cpp
index ceeb3c2..ff33d5d 100644
--- a/src/core/SkDraw_vertices.cpp
+++ b/src/core/SkDraw_vertices.cpp
@@ -402,15 +402,11 @@
             dst[i] = SkPM4f_from_SkColor(src[i], nullptr);
         }
     } else {
-        // For now, we want premul to happen on the colors before interplation. If we later want
-        // to apply it after the interp, pass kUnpremul here.
-        SkAlphaType alphaVerb = kPremul_SkAlphaType;
         auto srcCS = SkColorSpace::MakeSRGB();
         auto dstCS = as_CSB(deviceCS)->makeLinearGamma();
-        SkColorSpaceXform::New(srcCS.get(),
-                               dstCS.get())->apply(SkColorSpaceXform::kRGBA_F32_ColorFormat, dst,
-                                                   SkColorSpaceXform::kBGRA_8888_ColorFormat, src,
-                                                   count, alphaVerb);
+        SkColorSpaceXform::Apply(dstCS.get(), SkColorSpaceXform::kRGBA_F32_ColorFormat, dst,
+                                 srcCS.get(), SkColorSpaceXform::kBGRA_8888_ColorFormat, src,
+                                 count, SkColorSpaceXform::kPremul_AlphaOp);
     }
     return dst;
 }