commit eee4d6e4e8cc5c4c79f065abcc3ce609f71238f9
author Robert Phillips <robertphillips@google.com> Mon Jun 05 09:26:07 2017 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Mon Jun 05 14:03:10 2017 +0000
tree 9a855a9892a8b3017370164355b88c2a4ac9c89c
parent 9beafc41afa3c78ffa12649dcde73628c277da9c

Make instantiate return a Boolean

From an off-line conversation:
The longer term idea will be to create a helper class isolates the
ability to instantiate proxies until flush time. The peek* methods
could then be moved to GrSurfaceProxy.

Change-Id: I8e8c02c098475b77d515791c0d6b81f7e4a327dd
Reviewed-on: https://skia-review.googlesource.com/18076
Commit-Queue: Robert Phillips <robertphillips@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

include/private/GrSurfaceProxy.h

diff --git a/include/private/GrSurfaceProxy.h b/include/private/GrSurfaceProxy.h
index be8c194..bded2c1 100644
--- a/include/private/GrSurfaceProxy.h
+++ b/include/private/GrSurfaceProxy.h
@@ -244,7 +244,7 @@
      */
     UniqueID uniqueID() const { return fUniqueID; }
 
-    virtual GrSurface* instantiate(GrResourceProvider* resourceProvider) = 0;
+    virtual bool instantiate(GrResourceProvider* resourceProvider) = 0;
 
     /**
      * Helper that gets the width and height of the surface as a bounding rectangle.
@@ -347,9 +347,9 @@
         return this->internalHasPendingWrite();
     }
 
-    GrSurface* instantiateImpl(GrResourceProvider* resourceProvider, int sampleCnt,
-                               GrSurfaceFlags flags, bool isMipMapped,
-                               SkDestinationSurfaceColorMode mipColorMode);
+    bool instantiateImpl(GrResourceProvider* resourceProvider, int sampleCnt,
+                         GrSurfaceFlags flags, bool isMipMapped,
+                         SkDestinationSurfaceColorMode mipColorMode);
 
     // For wrapped resources, 'fConfig', 'fWidth', 'fHeight', and 'fOrigin; will always be filled in
     // from the wrapped resource.