commit f3e2b3cba36f3ea4b7837b741d3d8c79762a6cef
author Robert Phillips <robertphillips@google.com> Fri Sep 18 14:07:43 2020 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Sep 18 19:42:32 2020 +0000
tree 0de6bab6c9368b9f3e75cd3a00a35040bb3f8657
parent be0a9ca63d9dee16957a619bb1ca64a5dfe348b6

Switch the thread-safe proxy cache over to using an arena for its entries

Bug: 1108408
Change-Id: Ib0260f72be3ac04fc1cf82c857bf4e99ec4ea239
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/317770
Reviewed-by: Adlai Holler <adlai@google.com>
Commit-Queue: Robert Phillips <robertphillips@google.com>

src/gpu/GrThreadSafeUniquelyKeyedProxyViewCache.cpp

diff --git a/src/gpu/GrThreadSafeUniquelyKeyedProxyViewCache.cpp b/src/gpu/GrThreadSafeUniquelyKeyedProxyViewCache.cpp
index c2fd7dd..0c305d2 100644
--- a/src/gpu/GrThreadSafeUniquelyKeyedProxyViewCache.cpp
+++ b/src/gpu/GrThreadSafeUniquelyKeyedProxyViewCache.cpp
@@ -10,7 +10,7 @@
 GrThreadSafeUniquelyKeyedProxyViewCache::GrThreadSafeUniquelyKeyedProxyViewCache() {}
 
 GrThreadSafeUniquelyKeyedProxyViewCache::~GrThreadSafeUniquelyKeyedProxyViewCache() {
-    fUniquelyKeyedProxyViews.foreach([](Entry* v) { delete v; });
+    fUniquelyKeyedProxyViews.foreach([this](Entry* v) { this->recycleEntry(v); });
 }
 
 #if GR_TEST_UTILS
@@ -30,7 +30,7 @@
 void GrThreadSafeUniquelyKeyedProxyViewCache::dropAllRefs() {
     SkAutoSpinlock lock{fSpinLock};
 
-    fUniquelyKeyedProxyViews.foreach([](Entry* v) { delete v; });
+    fUniquelyKeyedProxyViews.foreach([this](Entry* v) { this->recycleEntry(v); });
     fUniquelyKeyedProxyViews.reset();
 }
 
@@ -58,8 +58,7 @@
                                                                 const GrSurfaceProxyView& view) {
     Entry* tmp = fUniquelyKeyedProxyViews.find(key);
     if (!tmp) {
-        // TODO: block allocate here?
-        tmp = new Entry(key, view);
+        tmp = this->getEntry(key, view);
         fUniquelyKeyedProxyViews.add(tmp);
     }