commit f4def3488589108fca0fa94e605377f2bb59cf90
author Kevin Lubick <kjlubick@google.com> Thu Oct 04 12:52:50 2018 -0400
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Fri Oct 05 18:18:30 2018 +0000
tree d4f1249a7ef249594e3784a43fbc515f3aa6ab3c
parent b3d6145cb7e15d59efa1df7e2c9c38fc253a45a0

Move dumpJSON behind the SK_ENABLE_DUMP_GPU flag

This should trim the code size of a WASM CanvasKit by 10-20KB.

Bug: skia:
Change-Id: Ibf0f8596c04e891e8f7cbc2fa4f1d1852f7cb462
Reviewed-on: https://skia-review.googlesource.com/c/159261
Reviewed-by: Brian Osman <brianosman@google.com>
Commit-Queue: Kevin Lubick <kjlubick@google.com>

BUILD.gn

diff --git a/BUILD.gn b/BUILD.gn
index 886c275..acc3b9d 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -121,6 +121,9 @@
   }
   if (skia_enable_flutter_defines) {
     defines += flutter_defines
+
+    # Flutter always wants this https://github.com/flutter/flutter/issues/11402
+    defines += [ "SK_ENABLE_DUMP_GPU" ]
   }
   if (!skia_enable_gpu) {
     defines += [ "SK_SUPPORT_GPU=0" ]
@@ -639,6 +642,10 @@
   if (skia_enable_atlas_text) {
     sources += skia_atlas_text_sources
   }
+
+  if (is_debug) {
+    public_defines += [ "SK_ENABLE_DUMP_GPU" ]
+  }
 }
 
 optional("heif") {