commit f9d610179d7d4198b57b12d06f8d1ca09f580df3
author scroggo <scroggo@google.com> Mon Dec 15 12:54:51 2014 -0800
committer Commit bot <commit-bot@chromium.org> Mon Dec 15 12:54:51 2014 -0800
tree d53f2e440ad0173132c5902d0b4a04c8fd5cfcf1
parent 9a0d6d6c88b87b3d0195e5633403325b6e922b8c

There can be only one (SkRandom)!

Remove SkLCGRandom. We already decided the new one was better, which is
why we wrote the new SkRandom.

Convert GMs that were using SkLCGRandom to use the improved SkRandom.
Motivated by the fact that these GMs draw differently on some runs. We
believe this to be a result of using the old SkLCGRandom.

Add each of the tests that were using SkLCGRandom to ignore-tests.txt,
since we expect they'll draw differently using SkRandom.

Move a trimmed down version of SkLCGRandom into SkDiscretePathEffect.
In order to preserve the old behavior, trim down SkLCGRandom to only
the methods used by SkDiscretePathEffect, and hide it in
SkDiscretePathEffect's cpp file.

BUG=skia:3241

Review URL: https://codereview.chromium.org/805963002

tests/StrokerTest.cpp

diff --git a/tests/StrokerTest.cpp b/tests/StrokerTest.cpp
index 03e0624..b588cc6 100755
--- a/tests/StrokerTest.cpp
+++ b/tests/StrokerTest.cpp
@@ -116,18 +116,18 @@
 	cubicPairSetTest(tests, tests_count);
 }
 
-static SkScalar unbounded(SkLCGRandom& r) {
+static SkScalar unbounded(SkRandom& r) {
     uint32_t val = r.nextU();
     return SkBits2Float(val);
 }
 
-static SkScalar unboundedPos(SkLCGRandom& r) {
+static SkScalar unboundedPos(SkRandom& r) {
     uint32_t val = r.nextU() & 0x7fffffff;
     return SkBits2Float(val);
 }
 
 DEF_TEST(QuadStrokerUnbounded, reporter) {
-    SkLCGRandom r;
+    SkRandom r;
     SkPaint p;
     p.setStyle(SkPaint::kStroke_Style);
 #if defined(SK_DEBUG) && QUAD_STROKE_APPROXIMATION
@@ -165,7 +165,7 @@
 }
 
 DEF_TEST(CubicStrokerUnbounded, reporter) {
-    SkLCGRandom r;
+    SkRandom r;
     SkPaint p;
     p.setStyle(SkPaint::kStroke_Style);
 #if defined(SK_DEBUG) && QUAD_STROKE_APPROXIMATION
@@ -206,7 +206,7 @@
 }
 
 DEF_TEST(QuadStrokerConstrained, reporter) {
-    SkLCGRandom r;
+    SkRandom r;
     SkPaint p;
     p.setStyle(SkPaint::kStroke_Style);
 #if defined(SK_DEBUG) && QUAD_STROKE_APPROXIMATION
@@ -257,7 +257,7 @@
 }
 
 DEF_TEST(CubicStrokerConstrained, reporter) {
-    SkLCGRandom r;
+    SkRandom r;
     SkPaint p;
     p.setStyle(SkPaint::kStroke_Style);
 #if defined(SK_DEBUG) && QUAD_STROKE_APPROXIMATION
@@ -316,7 +316,7 @@
 }
 
 DEF_TEST(QuadStrokerRange, reporter) {
-    SkLCGRandom r;
+    SkRandom r;
     SkPaint p;
     p.setStyle(SkPaint::kStroke_Style);
 #if defined(SK_DEBUG) && QUAD_STROKE_APPROXIMATION
@@ -361,7 +361,7 @@
 }
 
 DEF_TEST(CubicStrokerRange, reporter) {
-    SkLCGRandom r;
+    SkRandom r;
     SkPaint p;
     p.setStyle(SkPaint::kStroke_Style);
 #if defined(SK_DEBUG) && QUAD_STROKE_APPROXIMATION