| commit | 71aca549914c868d50cd51ddff3fb7a5bfe250cd | [log] [tgz] |
|---|---|---|
| author | mtklein <mtklein@chromium.org> | Mon Mar 07 12:28:17 2016 -0800 |
| committer | Commit bot <commit-bot@chromium.org> | Mon Mar 07 12:28:17 2016 -0800 |
| tree | 1409d9973ad64ef6aea7ec2ef2addefe0f531e6d | |
| parent | aecc018f86d911198b7c7775cee04f61bd10b430 [diff] |
add virtual ~Effect() Today we make an sk_sp<Effect> from an sk_sp<EffectImpl>. But when the sk_sp<Effect> dies, it calls ~Effect(), not ~EffectImpl(). Making ~Effect() virtual fixes this. This should make our Google3 tests sized-delete clean, unblocking those folks. Review URL: https://codereview.chromium.org/1769093002