Remove unnecessary Blocks from the inliner.
If we aren't wrapping the inlined function body in a loop, there's no
need to add a scopeless Block; we've already got one. This doesn't
affect the final output meaningfully--it just suppresses a newline--but
it's one fewer IRNode allocation.
Change-Id: Ib7b0014e908586d8acfcf6c23520873fad31d0b7
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/345163
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Brian Osman <brianosman@google.com>
Auto-Submit: John Stiles <johnstiles@google.com>
diff --git a/src/sksl/SkSLInliner.cpp b/src/sksl/SkSLInliner.cpp
index 3950d00..c63707e 100644
--- a/src/sksl/SkSLInliner.cpp
+++ b/src/sksl/SkSLInliner.cpp
@@ -744,11 +744,8 @@
std::move(innerBlock),
symbolTable));
} else {
- // No early returns, so we can just dump the code into a scopeless block.
- auto innerBlock = std::make_unique<Block>(offset, StatementArray{},
- /*symbols=*/nullptr, /*isScope=*/false);
- inlineStatements = &innerBlock->children();
- inlinedBody.children().push_back(std::move(innerBlock));
+ // No early returns, so we can just dump the code into our existing scopeless block.
+ inlineStatements = &inlinedBody.children();
}
inlineStatements->reserve_back(body.children().size() + argsToCopyBack.size());