Enable ClangTidy check modernize-make-unique.
The majority of existing call sites were automatically updated using
clang-tidy -fix. A small handful required a manual update,
e.g. CppCodeGen.
This check is a bit lenient, and in particular will not flag cases like
`std::unique_ptr<Base>(new Derived())` which is still pretty common
throughout our codebase. This CL does not attempt to replace all the
cases that ClangTidy does not flag.
Change-Id: I5eba48ef880e25d22de80f321a68c389ba769e36
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307459
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
diff --git a/src/codec/SkBmpRLECodec.cpp b/src/codec/SkBmpRLECodec.cpp
index 86ebac4..2b40647 100644
--- a/src/codec/SkBmpRLECodec.cpp
+++ b/src/codec/SkBmpRLECodec.cpp
@@ -5,9 +5,12 @@
* found in the LICENSE file.
*/
+#include "src/codec/SkBmpRLECodec.h"
+
+#include <memory>
+
#include "include/core/SkStream.h"
#include "include/private/SkColorData.h"
-#include "src/codec/SkBmpRLECodec.h"
#include "src/codec/SkCodecPriv.h"
/*
@@ -552,7 +555,7 @@
SkSampler* SkBmpRLECodec::getSampler(bool createIfNecessary) {
if (!fSampler && createIfNecessary) {
- fSampler.reset(new SkBmpRLESampler(this));
+ fSampler = std::make_unique<SkBmpRLESampler>(this);
}
return fSampler.get();