Enable ClangTidy check modernize-make-unique.
The majority of existing call sites were automatically updated using
clang-tidy -fix. A small handful required a manual update,
e.g. CppCodeGen.
This check is a bit lenient, and in particular will not flag cases like
`std::unique_ptr<Base>(new Derived())` which is still pretty common
throughout our codebase. This CL does not attempt to replace all the
cases that ClangTidy does not flag.
Change-Id: I5eba48ef880e25d22de80f321a68c389ba769e36
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307459
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
diff --git a/src/gpu/gl/GrGLGpuProgramCache.cpp b/src/gpu/gl/GrGLGpuProgramCache.cpp
index dab80f0..5fc828f 100644
--- a/src/gpu/gl/GrGLGpuProgramCache.cpp
+++ b/src/gpu/gl/GrGLGpuProgramCache.cpp
@@ -5,6 +5,8 @@
* found in the LICENSE file.
*/
+#include <memory>
+
#include "src/gpu/gl/GrGLGpu.h"
#include "include/gpu/GrContextOptions.h"
@@ -96,7 +98,7 @@
return nullptr;
}
fGpu->fStats.incNumCompilationSuccesses();
- entry = fMap.insert(desc, std::unique_ptr<Entry>(new Entry(std::move(program))));
+ entry = fMap.insert(desc, std::make_unique<Entry>(std::move(program)));
*stat = Stats::ProgramCacheResult::kMiss;
}
@@ -120,6 +122,6 @@
return false;
}
- fMap.insert(desc, std::unique_ptr<Entry>(new Entry(precompiledProgram)));
+ fMap.insert(desc, std::make_unique<Entry>(precompiledProgram));
return true;
}