Enable ClangTidy check modernize-make-unique.
The majority of existing call sites were automatically updated using
clang-tidy -fix. A small handful required a manual update,
e.g. CppCodeGen.
This check is a bit lenient, and in particular will not flag cases like
`std::unique_ptr<Base>(new Derived())` which is still pretty common
throughout our codebase. This CL does not attempt to replace all the
cases that ClangTidy does not flag.
Change-Id: I5eba48ef880e25d22de80f321a68c389ba769e36
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307459
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
diff --git a/src/xml/SkDOM.cpp b/src/xml/SkDOM.cpp
index 0f39135..feee5a8 100644
--- a/src/xml/SkDOM.cpp
+++ b/src/xml/SkDOM.cpp
@@ -7,6 +7,8 @@
#include "src/xml/SkDOM.h"
+#include <memory>
+
#include "include/core/SkStream.h"
#include "include/private/SkTo.h"
#include "src/xml/SkXMLParser.h"
@@ -344,7 +346,7 @@
SkXMLParser* SkDOM::beginParsing() {
SkASSERT(!fParser);
- fParser.reset(new SkDOMParser(&fAlloc));
+ fParser = std::make_unique<SkDOMParser>(&fAlloc);
return fParser.get();
}