Enable ClangTidy check modernize-make-unique.
The majority of existing call sites were automatically updated using
clang-tidy -fix. A small handful required a manual update,
e.g. CppCodeGen.
This check is a bit lenient, and in particular will not flag cases like
`std::unique_ptr<Base>(new Derived())` which is still pretty common
throughout our codebase. This CL does not attempt to replace all the
cases that ClangTidy does not flag.
Change-Id: I5eba48ef880e25d22de80f321a68c389ba769e36
Reviewed-on: https://skia-review.googlesource.com/c/skia/+/307459
Commit-Queue: John Stiles <johnstiles@google.com>
Reviewed-by: Mike Klein <mtklein@google.com>
diff --git a/tests/VkDrawableTest.cpp b/tests/VkDrawableTest.cpp
index 38378dc..d1df68d 100644
--- a/tests/VkDrawableTest.cpp
+++ b/tests/VkDrawableTest.cpp
@@ -192,10 +192,10 @@
}
std::unique_ptr<GpuDrawHandler> draw;
if (fDContext) {
- draw.reset(new DrawHandlerImport(this, ImportDraw, ImportSubmitted, matrix,
- clipBounds, bufferInfo));
+ draw = std::make_unique<DrawHandlerImport>(this, ImportDraw, ImportSubmitted, matrix,
+ clipBounds, bufferInfo);
} else {
- draw.reset(new DrawHandlerBasic(fInterface, fWidth, fHeight));
+ draw = std::make_unique<DrawHandlerBasic>(fInterface, fWidth, fHeight);
}
return draw;
}