Having updated the documentation of GrCustomStage to argue that all custom stages must be
immutable, this CL makes that true for ConvolutionEffect.
http://codereview.appspot.com/6398043/
git-svn-id: http://skia.googlecode.com/svn/trunk@4613 2bbb7eff-a529-9590-31e7-b0007b416f81
diff --git a/src/gpu/effects/GrConvolutionEffect.h b/src/gpu/effects/GrConvolutionEffect.h
index 58cad83..e04e802 100644
--- a/src/gpu/effects/GrConvolutionEffect.h
+++ b/src/gpu/effects/GrConvolutionEffect.h
@@ -21,19 +21,15 @@
public:
+ /// Convolve with an arbitrary user-specified kernel
GrConvolutionEffect(GrTexture*, Direction,
int halfWidth, const float* kernel = NULL);
+
+ /// Convolve with a gaussian kernel
+ GrConvolutionEffect(GrTexture*, Direction,
+ int halfWidth, float gaussianSigma);
virtual ~GrConvolutionEffect();
- void setKernel(const float* kernel) {
- memcpy(fKernel, kernel, this->width());
- }
-
- /**
- * Helper to set the kernel to a Gaussian. Replaces the existing kernel.
- */
- void setGaussianKernel(float sigma);
-
const float* kernel() const { return fKernel; }
static const char* Name() { return "Convolution"; }