blob: 1c2a9c984b384af2ef7db2390a58e2e38b81a1e6 [file] [log] [blame]
reed@google.comac10a2d2010-12-22 21:39:39 +00001/*
Greg Danielf41b2bd2019-08-22 16:19:24 -04002 * Copyright 2019 Google Inc.
epoger@google.comec3ed6a2011-07-28 14:26:00 +00003 *
4 * Use of this source code is governed by a BSD-style license that can be
5 * found in the LICENSE file.
reed@google.comac10a2d2010-12-22 21:39:39 +00006 */
7
Greg Danielf41b2bd2019-08-22 16:19:24 -04008#include "src/gpu/GrOpsTask.h"
Brian Salomon4d2d6f42019-07-26 14:15:11 -04009
Robert Phillipsb7bfbc22020-07-01 12:55:01 -040010#include "include/gpu/GrRecordingContext.h"
Mike Kleinc0bd9f92019-04-23 12:05:21 -050011#include "src/core/SkRectPriv.h"
12#include "src/core/SkTraceEvent.h"
Greg Danielc0d69152020-10-08 14:59:00 -040013#include "src/gpu/GrAttachment.h"
Greg Danielf91aeb22019-06-18 09:58:02 -040014#include "src/gpu/GrAuditTrail.h"
Mike Kleinc0bd9f92019-04-23 12:05:21 -050015#include "src/gpu/GrCaps.h"
16#include "src/gpu/GrGpu.h"
Mike Kleinc0bd9f92019-04-23 12:05:21 -050017#include "src/gpu/GrMemoryPool.h"
Greg Daniele227fe42019-08-21 13:52:24 -040018#include "src/gpu/GrOpFlushState.h"
Greg Daniel2d41d0d2019-08-26 11:08:51 -040019#include "src/gpu/GrOpsRenderPass.h"
Mike Kleinc0bd9f92019-04-23 12:05:21 -050020#include "src/gpu/GrRecordingContextPriv.h"
Chris Dalton674f77a2019-09-30 20:49:39 -060021#include "src/gpu/GrRenderTarget.h"
Mike Kleinc0bd9f92019-04-23 12:05:21 -050022#include "src/gpu/GrResourceAllocator.h"
Brian Salomoneebe7352020-12-09 16:37:04 -050023#include "src/gpu/GrSurfaceDrawContext.h"
Brian Salomon4cfae3b2020-07-23 10:33:24 -040024#include "src/gpu/GrTexture.h"
Michael Ludwig663afe52019-06-03 16:46:19 -040025#include "src/gpu/geometry/GrRect.h"
Mike Kleinc0bd9f92019-04-23 12:05:21 -050026#include "src/gpu/ops/GrClearOp.h"
Robert Phillipsf2361d22016-10-25 14:20:06 -040027
reed@google.comac10a2d2010-12-22 21:39:39 +000028////////////////////////////////////////////////////////////////////////////////
29
Brian Salomon09d994e2016-12-21 11:14:46 -050030// Experimentally we have found that most combining occurs within the first 10 comparisons.
Brian Salomon588cec72018-11-14 13:56:37 -050031static const int kMaxOpMergeDistance = 10;
32static const int kMaxOpChainDistance = 10;
33
34////////////////////////////////////////////////////////////////////////////////
35
Greg Daniel524e28b2019-11-01 11:48:53 -040036using DstProxyView = GrXferProcessor::DstProxyView;
Brian Salomon588cec72018-11-14 13:56:37 -050037
38////////////////////////////////////////////////////////////////////////////////
39
40static inline bool can_reorder(const SkRect& a, const SkRect& b) { return !GrRectsOverlap(a, b); }
41
42////////////////////////////////////////////////////////////////////////////////
43
Herb Derbyc76d4092020-10-07 16:46:15 -040044inline GrOpsTask::OpChain::List::List(GrOp::Owner op)
Brian Salomon588cec72018-11-14 13:56:37 -050045 : fHead(std::move(op)), fTail(fHead.get()) {
46 this->validate();
47}
48
Greg Danielf41b2bd2019-08-22 16:19:24 -040049inline GrOpsTask::OpChain::List::List(List&& that) { *this = std::move(that); }
Brian Salomon588cec72018-11-14 13:56:37 -050050
Greg Danielf41b2bd2019-08-22 16:19:24 -040051inline GrOpsTask::OpChain::List& GrOpsTask::OpChain::List::operator=(List&& that) {
Brian Salomon588cec72018-11-14 13:56:37 -050052 fHead = std::move(that.fHead);
53 fTail = that.fTail;
54 that.fTail = nullptr;
55 this->validate();
56 return *this;
57}
58
Herb Derbyc76d4092020-10-07 16:46:15 -040059inline GrOp::Owner GrOpsTask::OpChain::List::popHead() {
Brian Salomon588cec72018-11-14 13:56:37 -050060 SkASSERT(fHead);
61 auto temp = fHead->cutChain();
62 std::swap(temp, fHead);
63 if (!fHead) {
64 SkASSERT(fTail == temp.get());
65 fTail = nullptr;
66 }
67 return temp;
68}
69
Herb Derbyc76d4092020-10-07 16:46:15 -040070inline GrOp::Owner GrOpsTask::OpChain::List::removeOp(GrOp* op) {
Brian Salomon588cec72018-11-14 13:56:37 -050071#ifdef SK_DEBUG
72 auto head = op;
73 while (head->prevInChain()) { head = head->prevInChain(); }
74 SkASSERT(head == fHead.get());
75#endif
76 auto prev = op->prevInChain();
77 if (!prev) {
78 SkASSERT(op == fHead.get());
79 return this->popHead();
80 }
81 auto temp = prev->cutChain();
82 if (auto next = temp->cutChain()) {
83 prev->chainConcat(std::move(next));
84 } else {
85 SkASSERT(fTail == op);
86 fTail = prev;
87 }
88 this->validate();
89 return temp;
90}
91
Herb Derbyc76d4092020-10-07 16:46:15 -040092inline void GrOpsTask::OpChain::List::pushHead(GrOp::Owner op) {
Brian Salomon588cec72018-11-14 13:56:37 -050093 SkASSERT(op);
94 SkASSERT(op->isChainHead());
95 SkASSERT(op->isChainTail());
96 if (fHead) {
97 op->chainConcat(std::move(fHead));
98 fHead = std::move(op);
99 } else {
100 fHead = std::move(op);
101 fTail = fHead.get();
102 }
103}
104
Herb Derbyc76d4092020-10-07 16:46:15 -0400105inline void GrOpsTask::OpChain::List::pushTail(GrOp::Owner op) {
Brian Salomon588cec72018-11-14 13:56:37 -0500106 SkASSERT(op->isChainTail());
107 fTail->chainConcat(std::move(op));
108 fTail = fTail->nextInChain();
109}
110
Greg Danielf41b2bd2019-08-22 16:19:24 -0400111inline void GrOpsTask::OpChain::List::validate() const {
Brian Salomon588cec72018-11-14 13:56:37 -0500112#ifdef SK_DEBUG
113 if (fHead) {
114 SkASSERT(fTail);
115 fHead->validateChain(fTail);
116 }
117#endif
118}
119
120////////////////////////////////////////////////////////////////////////////////
121
Herb Derbyc76d4092020-10-07 16:46:15 -0400122GrOpsTask::OpChain::OpChain(GrOp::Owner op,
Greg Danielf41b2bd2019-08-22 16:19:24 -0400123 GrProcessorSet::Analysis processorAnalysis,
Greg Daniel524e28b2019-11-01 11:48:53 -0400124 GrAppliedClip* appliedClip, const DstProxyView* dstProxyView)
Chris Dalton945ee652019-01-23 09:10:36 -0700125 : fList{std::move(op)}
126 , fProcessorAnalysis(processorAnalysis)
127 , fAppliedClip(appliedClip) {
128 if (fProcessorAnalysis.requiresDstTexture()) {
Greg Daniel524e28b2019-11-01 11:48:53 -0400129 SkASSERT(dstProxyView && dstProxyView->proxy());
130 fDstProxyView = *dstProxyView;
Brian Salomon588cec72018-11-14 13:56:37 -0500131 }
132 fBounds = fList.head()->bounds();
133}
134
Greg Danielf41b2bd2019-08-22 16:19:24 -0400135void GrOpsTask::OpChain::visitProxies(const GrOp::VisitProxyFunc& func) const {
Brian Salomon588cec72018-11-14 13:56:37 -0500136 if (fList.empty()) {
137 return;
138 }
139 for (const auto& op : GrOp::ChainRange<>(fList.head())) {
Chris Dalton1706cbf2019-05-21 19:35:29 -0600140 op.visitProxies(func);
Brian Salomon588cec72018-11-14 13:56:37 -0500141 }
Greg Daniel524e28b2019-11-01 11:48:53 -0400142 if (fDstProxyView.proxy()) {
Brian Salomon7e67dca2020-07-21 09:27:25 -0400143 func(fDstProxyView.proxy(), GrMipmapped::kNo);
Brian Salomon588cec72018-11-14 13:56:37 -0500144 }
145 if (fAppliedClip) {
146 fAppliedClip->visitProxies(func);
147 }
148}
149
Herb Derbye32e1ab2020-10-27 10:29:46 -0400150void GrOpsTask::OpChain::deleteOps() {
Brian Salomon588cec72018-11-14 13:56:37 -0500151 while (!fList.empty()) {
Herb Derbyc76d4092020-10-07 16:46:15 -0400152 // Since the value goes out of scope immediately, the GrOp::Owner deletes the op.
153 fList.popHead();
Brian Salomon588cec72018-11-14 13:56:37 -0500154 }
155}
156
157// Concatenates two op chains and attempts to merge ops across the chains. Assumes that we know that
158// the two chains are chainable. Returns the new chain.
Greg Danielf41b2bd2019-08-22 16:19:24 -0400159GrOpsTask::OpChain::List GrOpsTask::OpChain::DoConcat(
Michael Ludwig28b0c5d2019-12-19 14:51:00 -0500160 List chainA, List chainB, const GrCaps& caps, GrRecordingContext::Arenas* arenas,
161 GrAuditTrail* auditTrail) {
Brian Salomon588cec72018-11-14 13:56:37 -0500162 // We process ops in chain b from head to tail. We attempt to merge with nodes in a, starting
163 // at chain a's tail and working toward the head. We produce one of the following outcomes:
164 // 1) b's head is merged into an op in a.
165 // 2) An op from chain a is merged into b's head. (In this case b's head gets processed again.)
166 // 3) b's head is popped from chain a and added at the tail of a.
167 // After result 3 we don't want to attempt to merge the next head of b with the new tail of a,
168 // as we assume merges were already attempted when chain b was created. So we keep track of the
169 // original tail of a and start our iteration of a there. We also track the bounds of the nodes
170 // appended to chain a that will be skipped for bounds testing. If the original tail of a is
171 // merged into an op in b (case 2) then we advance the "original tail" towards the head of a.
172 GrOp* origATail = chainA.tail();
173 SkRect skipBounds = SkRectPriv::MakeLargestInverted();
174 do {
175 int numMergeChecks = 0;
176 bool merged = false;
177 bool noSkip = (origATail == chainA.tail());
178 SkASSERT(noSkip == (skipBounds == SkRectPriv::MakeLargestInverted()));
179 bool canBackwardMerge = noSkip || can_reorder(chainB.head()->bounds(), skipBounds);
180 SkRect forwardMergeBounds = skipBounds;
181 GrOp* a = origATail;
182 while (a) {
183 bool canForwardMerge =
184 (a == chainA.tail()) || can_reorder(a->bounds(), forwardMergeBounds);
185 if (canForwardMerge || canBackwardMerge) {
Herb Derbye25c3002020-10-27 15:57:27 -0400186 auto result = a->combineIfPossible(
187 chainB.head(), arenas->recordTimeAllocator(), caps);
Brian Salomon588cec72018-11-14 13:56:37 -0500188 SkASSERT(result != GrOp::CombineResult::kCannotCombine);
189 merged = (result == GrOp::CombineResult::kMerged);
Robert Phillips9548c3b422019-01-08 12:35:43 -0500190 GrOP_INFO("\t\t: (%s opID: %u) -> Combining with (%s, opID: %u)\n",
Brian Salomon588cec72018-11-14 13:56:37 -0500191 chainB.head()->name(), chainB.head()->uniqueID(), a->name(),
192 a->uniqueID());
Brian Salomon588cec72018-11-14 13:56:37 -0500193 }
194 if (merged) {
Brian Salomon52a6ed32018-11-26 10:30:58 -0500195 GR_AUDIT_TRAIL_OPS_RESULT_COMBINED(auditTrail, a, chainB.head());
Brian Salomon588cec72018-11-14 13:56:37 -0500196 if (canBackwardMerge) {
Herb Derbyc76d4092020-10-07 16:46:15 -0400197 // The GrOp::Owner releases the op.
198 chainB.popHead();
Brian Salomon588cec72018-11-14 13:56:37 -0500199 } else {
200 // We merged the contents of b's head into a. We will replace b's head with a in
201 // chain b.
202 SkASSERT(canForwardMerge);
203 if (a == origATail) {
204 origATail = a->prevInChain();
205 }
Herb Derbyc76d4092020-10-07 16:46:15 -0400206 GrOp::Owner detachedA = chainA.removeOp(a);
207 // The GrOp::Owner releases the op.
208 chainB.popHead();
Brian Salomon588cec72018-11-14 13:56:37 -0500209 chainB.pushHead(std::move(detachedA));
210 if (chainA.empty()) {
211 // We merged all the nodes in chain a to chain b.
212 return chainB;
213 }
214 }
215 break;
216 } else {
217 if (++numMergeChecks == kMaxOpMergeDistance) {
218 break;
219 }
220 forwardMergeBounds.joinNonEmptyArg(a->bounds());
221 canBackwardMerge =
222 canBackwardMerge && can_reorder(chainB.head()->bounds(), a->bounds());
223 a = a->prevInChain();
224 }
225 }
226 // If we weren't able to merge b's head then pop b's head from chain b and make it the new
227 // tail of a.
228 if (!merged) {
229 chainA.pushTail(chainB.popHead());
230 skipBounds.joinNonEmptyArg(chainA.tail()->bounds());
231 }
232 } while (!chainB.empty());
233 return chainA;
234}
235
Chris Dalton945ee652019-01-23 09:10:36 -0700236// Attempts to concatenate the given chain onto our own and merge ops across the chains. Returns
237// whether the operation succeeded. On success, the provided list will be returned empty.
Greg Danielf41b2bd2019-08-22 16:19:24 -0400238bool GrOpsTask::OpChain::tryConcat(
Greg Daniel524e28b2019-11-01 11:48:53 -0400239 List* list, GrProcessorSet::Analysis processorAnalysis, const DstProxyView& dstProxyView,
Chris Dalton945ee652019-01-23 09:10:36 -0700240 const GrAppliedClip* appliedClip, const SkRect& bounds, const GrCaps& caps,
Michael Ludwig28b0c5d2019-12-19 14:51:00 -0500241 GrRecordingContext::Arenas* arenas, GrAuditTrail* auditTrail) {
Chris Dalton6f6ae6a2019-01-18 12:10:36 -0700242 SkASSERT(!fList.empty());
243 SkASSERT(!list->empty());
Greg Daniel524e28b2019-11-01 11:48:53 -0400244 SkASSERT(fProcessorAnalysis.requiresDstTexture() == SkToBool(fDstProxyView.proxy()));
245 SkASSERT(processorAnalysis.requiresDstTexture() == SkToBool(dstProxyView.proxy()));
Brian Salomon588cec72018-11-14 13:56:37 -0500246 // All returns use explicit tuple constructor rather than {a, b} to work around old GCC bug.
Chris Dalton6f6ae6a2019-01-18 12:10:36 -0700247 if (fList.head()->classID() != list->head()->classID() ||
248 SkToBool(fAppliedClip) != SkToBool(appliedClip) ||
249 (fAppliedClip && *fAppliedClip != *appliedClip) ||
Chris Dalton945ee652019-01-23 09:10:36 -0700250 (fProcessorAnalysis.requiresNonOverlappingDraws() !=
251 processorAnalysis.requiresNonOverlappingDraws()) ||
252 (fProcessorAnalysis.requiresNonOverlappingDraws() &&
253 // Non-overlaping draws are only required when Ganesh will either insert a barrier,
254 // or read back a new dst texture between draws. In either case, we can neither
255 // chain nor combine overlapping Ops.
256 GrRectsTouchOrOverlap(fBounds, bounds)) ||
257 (fProcessorAnalysis.requiresDstTexture() != processorAnalysis.requiresDstTexture()) ||
Greg Daniel524e28b2019-11-01 11:48:53 -0400258 (fProcessorAnalysis.requiresDstTexture() && fDstProxyView != dstProxyView)) {
Chris Dalton6f6ae6a2019-01-18 12:10:36 -0700259 return false;
Brian Salomon588cec72018-11-14 13:56:37 -0500260 }
Chris Daltonee21e6b2019-01-22 14:04:43 -0700261
Brian Salomon588cec72018-11-14 13:56:37 -0500262 SkDEBUGCODE(bool first = true;)
263 do {
Herb Derbye25c3002020-10-27 15:57:27 -0400264 switch (fList.tail()->combineIfPossible(list->head(), arenas->recordTimeAllocator(), caps))
265 {
Brian Salomon588cec72018-11-14 13:56:37 -0500266 case GrOp::CombineResult::kCannotCombine:
267 // If an op supports chaining then it is required that chaining is transitive and
268 // that if any two ops in two different chains can merge then the two chains
269 // may also be chained together. Thus, we should only hit this on the first
270 // iteration.
271 SkASSERT(first);
Chris Dalton6f6ae6a2019-01-18 12:10:36 -0700272 return false;
Brian Salomon588cec72018-11-14 13:56:37 -0500273 case GrOp::CombineResult::kMayChain:
Adlai Holler5ba50af2020-04-29 21:11:14 -0400274 fList = DoConcat(std::move(fList), std::exchange(*list, List()), caps, arenas,
Michael Ludwig28b0c5d2019-12-19 14:51:00 -0500275 auditTrail);
Chris Daltonee21e6b2019-01-22 14:04:43 -0700276 // The above exchange cleared out 'list'. The list needs to be empty now for the
277 // loop to terminate.
278 SkASSERT(list->empty());
279 break;
Brian Salomon588cec72018-11-14 13:56:37 -0500280 case GrOp::CombineResult::kMerged: {
Robert Phillips9548c3b422019-01-08 12:35:43 -0500281 GrOP_INFO("\t\t: (%s opID: %u) -> Combining with (%s, opID: %u)\n",
Chris Dalton6f6ae6a2019-01-18 12:10:36 -0700282 list->tail()->name(), list->tail()->uniqueID(), list->head()->name(),
283 list->head()->uniqueID());
284 GR_AUDIT_TRAIL_OPS_RESULT_COMBINED(auditTrail, fList.tail(), list->head());
Herb Derbyc76d4092020-10-07 16:46:15 -0400285 // The GrOp::Owner releases the op.
286 list->popHead();
Brian Salomon588cec72018-11-14 13:56:37 -0500287 break;
288 }
289 }
290 SkDEBUGCODE(first = false);
Chris Dalton6f6ae6a2019-01-18 12:10:36 -0700291 } while (!list->empty());
Chris Daltonee21e6b2019-01-22 14:04:43 -0700292
293 // The new ops were successfully merged and/or chained onto our own.
294 fBounds.joinPossiblyEmptyRect(bounds);
Chris Dalton6f6ae6a2019-01-18 12:10:36 -0700295 return true;
Brian Salomon588cec72018-11-14 13:56:37 -0500296}
297
Michael Ludwig28b0c5d2019-12-19 14:51:00 -0500298bool GrOpsTask::OpChain::prependChain(OpChain* that, const GrCaps& caps,
299 GrRecordingContext::Arenas* arenas,
300 GrAuditTrail* auditTrail) {
Greg Daniel524e28b2019-11-01 11:48:53 -0400301 if (!that->tryConcat(&fList, fProcessorAnalysis, fDstProxyView, fAppliedClip, fBounds, caps,
Michael Ludwig28b0c5d2019-12-19 14:51:00 -0500302 arenas, auditTrail)) {
Brian Salomon588cec72018-11-14 13:56:37 -0500303 this->validate();
304 // append failed
305 return false;
306 }
Chris Dalton6f6ae6a2019-01-18 12:10:36 -0700307
Brian Salomon588cec72018-11-14 13:56:37 -0500308 // 'that' owns the combined chain. Move it into 'this'.
Chris Dalton6f6ae6a2019-01-18 12:10:36 -0700309 SkASSERT(fList.empty());
Brian Salomon588cec72018-11-14 13:56:37 -0500310 fList = std::move(that->fList);
Chris Daltonee21e6b2019-01-22 14:04:43 -0700311 fBounds = that->fBounds;
Brian Salomon588cec72018-11-14 13:56:37 -0500312
Greg Daniel524e28b2019-11-01 11:48:53 -0400313 that->fDstProxyView.setProxyView({});
John Stiles59e18dc2020-07-22 18:18:12 -0400314 if (that->fAppliedClip && that->fAppliedClip->hasCoverageFragmentProcessor()) {
315 // Obliterates the processor.
316 that->fAppliedClip->detachCoverageFragmentProcessor();
Brian Salomon588cec72018-11-14 13:56:37 -0500317 }
318 this->validate();
319 return true;
320}
321
Herb Derbyc76d4092020-10-07 16:46:15 -0400322GrOp::Owner GrOpsTask::OpChain::appendOp(
323 GrOp::Owner op, GrProcessorSet::Analysis processorAnalysis,
Greg Daniel524e28b2019-11-01 11:48:53 -0400324 const DstProxyView* dstProxyView, const GrAppliedClip* appliedClip, const GrCaps& caps,
Michael Ludwig28b0c5d2019-12-19 14:51:00 -0500325 GrRecordingContext::Arenas* arenas, GrAuditTrail* auditTrail) {
Greg Daniel524e28b2019-11-01 11:48:53 -0400326 const GrXferProcessor::DstProxyView noDstProxyView;
327 if (!dstProxyView) {
328 dstProxyView = &noDstProxyView;
Brian Salomon588cec72018-11-14 13:56:37 -0500329 }
330 SkASSERT(op->isChainHead() && op->isChainTail());
331 SkRect opBounds = op->bounds();
332 List chain(std::move(op));
Chris Dalton945ee652019-01-23 09:10:36 -0700333 if (!this->tryConcat(
Michael Ludwig28b0c5d2019-12-19 14:51:00 -0500334 &chain, processorAnalysis, *dstProxyView, appliedClip, opBounds, caps,
335 arenas, auditTrail)) {
Brian Salomon588cec72018-11-14 13:56:37 -0500336 // append failed, give the op back to the caller.
337 this->validate();
338 return chain.popHead();
339 }
Chris Dalton6f6ae6a2019-01-18 12:10:36 -0700340
341 SkASSERT(chain.empty());
Brian Salomon588cec72018-11-14 13:56:37 -0500342 this->validate();
343 return nullptr;
344}
345
Greg Danielf41b2bd2019-08-22 16:19:24 -0400346inline void GrOpsTask::OpChain::validate() const {
Brian Salomon588cec72018-11-14 13:56:37 -0500347#ifdef SK_DEBUG
348 fList.validate();
349 for (const auto& op : GrOp::ChainRange<>(fList.head())) {
350 // Not using SkRect::contains because we allow empty rects.
351 SkASSERT(fBounds.fLeft <= op.bounds().fLeft && fBounds.fTop <= op.bounds().fTop &&
352 fBounds.fRight >= op.bounds().fRight && fBounds.fBottom >= op.bounds().fBottom);
353 }
354#endif
355}
356
357////////////////////////////////////////////////////////////////////////////////
bsalomon489147c2015-12-14 12:13:09 -0800358
Brian Salomon982127b2021-01-21 10:43:35 -0500359GrOpsTask::GrOpsTask(GrDrawingManager* drawingMgr,
360 GrRecordingContext::Arenas arenas,
Greg Daniel16f5c652019-10-29 11:26:01 -0400361 GrSurfaceProxyView view,
Greg Danielf41b2bd2019-08-22 16:19:24 -0400362 GrAuditTrail* auditTrail)
Adlai Holler33d569e2020-06-16 14:30:08 -0400363 : GrRenderTask()
Michael Ludwig28b0c5d2019-12-19 14:51:00 -0500364 , fArenas(arenas)
Greg Danielf41b2bd2019-08-22 16:19:24 -0400365 , fAuditTrail(auditTrail)
Brian Salomon982127b2021-01-21 10:43:35 -0500366 , fTargetSwizzle(view.swizzle())
367 , fTargetOrigin(view.origin())
368 SkDEBUGCODE(, fNumClips(0)) {
Adlai Holler93439d92021-01-26 09:20:39 -0500369 fClipAllocators.push_back(std::make_unique<SkArenaAlloc>(4096));
Brian Salomon982127b2021-01-21 10:43:35 -0500370 this->addTarget(drawingMgr, view.detachProxy());
bsalomon4061b122015-05-29 10:26:19 -0700371}
372
Greg Danielf41b2bd2019-08-22 16:19:24 -0400373void GrOpsTask::deleteOps() {
Brian Salomon588cec72018-11-14 13:56:37 -0500374 for (auto& chain : fOpChains) {
Herb Derbye32e1ab2020-10-27 10:29:46 -0400375 chain.deleteOps();
Robert Phillipsc994a932018-06-19 13:09:54 -0400376 }
Brian Salomon588cec72018-11-14 13:56:37 -0500377 fOpChains.reset();
Robert Phillipsc994a932018-06-19 13:09:54 -0400378}
379
Greg Danielf41b2bd2019-08-22 16:19:24 -0400380GrOpsTask::~GrOpsTask() {
Robert Phillipsc994a932018-06-19 13:09:54 -0400381 this->deleteOps();
bsalomon@google.com25fb21f2011-06-21 18:17:25 +0000382}
383
Adlai Hollerabe45182020-11-17 09:22:13 -0500384void GrOpsTask::addOp(GrDrawingManager* drawingMgr, GrOp::Owner op,
385 GrTextureResolveManager textureResolveManager, const GrCaps& caps) {
386 auto addDependency = [&](GrSurfaceProxy* p, GrMipmapped mipmapped) {
387 this->addDependency(drawingMgr, p, mipmapped, textureResolveManager, caps);
388 };
389
390 op->visitProxies(addDependency);
391
392 this->recordOp(std::move(op), GrProcessorSet::EmptySetAnalysis(), nullptr, nullptr, caps);
393}
394
395void GrOpsTask::addDrawOp(GrDrawingManager* drawingMgr, GrOp::Owner op,
396 const GrProcessorSet::Analysis& processorAnalysis,
397 GrAppliedClip&& clip, const DstProxyView& dstProxyView,
398 GrTextureResolveManager textureResolveManager, const GrCaps& caps) {
399 auto addDependency = [&](GrSurfaceProxy* p, GrMipmapped mipmapped) {
400 this->addSampledTexture(p);
401 this->addDependency(drawingMgr, p, mipmapped, textureResolveManager, caps);
402 };
403
404 op->visitProxies(addDependency);
405 clip.visitProxies(addDependency);
406 if (dstProxyView.proxy()) {
407 if (GrDstSampleTypeUsesTexture(dstProxyView.dstSampleType())) {
408 this->addSampledTexture(dstProxyView.proxy());
409 }
410 addDependency(dstProxyView.proxy(), GrMipmapped::kNo);
Brian Salomon982127b2021-01-21 10:43:35 -0500411 if (this->target(0) == dstProxyView.proxy()) {
Adlai Hollerabe45182020-11-17 09:22:13 -0500412 // Since we are sampling and drawing to the same surface we will need to use
413 // texture barriers.
414 SkASSERT(GrDstSampleTypeDirectlySamplesDst(dstProxyView.dstSampleType()));
415 fRenderPassXferBarriers |= GrXferBarrierFlags::kTexture;
416 }
417 SkASSERT(dstProxyView.dstSampleType() != GrDstSampleType::kAsInputAttachment ||
418 dstProxyView.offset().isZero());
419 }
420
421 if (processorAnalysis.usesNonCoherentHWBlending()) {
422 fRenderPassXferBarriers |= GrXferBarrierFlags::kBlend;
423 }
424
425 this->recordOp(std::move(op), processorAnalysis, clip.doesClip() ? &clip : nullptr,
426 &dstProxyView, caps);
427}
428
Adlai Hollerd71b7b02020-06-08 15:55:00 -0400429void GrOpsTask::endFlush(GrDrawingManager* drawingMgr) {
Greg Danielf41b2bd2019-08-22 16:19:24 -0400430 fLastClipStackGenID = SK_InvalidUniqueID;
431 this->deleteOps();
Adlai Holler93439d92021-01-26 09:20:39 -0500432 fClipAllocators.reset();
Chris Dalton706a6ff2017-11-29 22:01:06 -0700433
Adlai Holler9e2c50e2021-02-09 14:41:52 -0500434 fDeferredProxies.reset();
Greg Danielb20d7e52019-09-03 13:54:39 -0400435 fSampledProxies.reset();
Greg Danielf41b2bd2019-08-22 16:19:24 -0400436 fAuditTrail = nullptr;
Adlai Hollerd71b7b02020-06-08 15:55:00 -0400437
438 GrRenderTask::endFlush(drawingMgr);
Greg Danielf21bf9e2019-08-22 20:12:20 +0000439}
440
Robert Phillips29f38542019-10-16 09:20:25 -0400441void GrOpsTask::onPrePrepare(GrRecordingContext* context) {
Robert Phillips7327c9d2019-10-08 16:32:56 -0400442 SkASSERT(this->isClosed());
Robert Phillips7327c9d2019-10-08 16:32:56 -0400443 // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
444 // can end up with GrOpsTasks that only have a discard load op and no ops. For vulkan validation
445 // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
446 // we shouldn't end up with GrOpsTasks with only discard.
447 if (this->isNoOp() || (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
448 return;
449 }
Greg Daniel0a0ad5b2021-01-29 22:49:30 -0500450 TRACE_EVENT0("skia.gpu", TRACE_FUNC);
Robert Phillips7327c9d2019-10-08 16:32:56 -0400451
Brian Salomon982127b2021-01-21 10:43:35 -0500452 GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
Robert Phillips7327c9d2019-10-08 16:32:56 -0400453 for (const auto& chain : fOpChains) {
454 if (chain.shouldExecute()) {
Robert Phillips8053c972019-11-21 10:44:53 -0500455 chain.head()->prePrepare(context,
Brian Salomon982127b2021-01-21 10:43:35 -0500456 dstView,
Robert Phillips8053c972019-11-21 10:44:53 -0500457 chain.appliedClip(),
Greg Danield358cbe2020-09-11 09:33:54 -0400458 chain.dstProxyView(),
Greg Daniel42dbca52020-11-20 10:22:43 -0500459 fRenderPassXferBarriers,
460 fColorLoadOp);
Robert Phillips7327c9d2019-10-08 16:32:56 -0400461 }
462 }
463}
464
Greg Danielf41b2bd2019-08-22 16:19:24 -0400465void GrOpsTask::onPrepare(GrOpFlushState* flushState) {
Brian Salomon982127b2021-01-21 10:43:35 -0500466 SkASSERT(this->target(0)->peekRenderTarget());
Robert Phillips6cdc22c2017-05-11 16:29:14 -0400467 SkASSERT(this->isClosed());
Greg Daniel94ed83f2019-09-27 13:05:43 -0400468 // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
469 // can end up with GrOpsTasks that only have a discard load op and no ops. For vulkan validation
470 // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
471 // we shouldn't end up with GrOpsTasks with only discard.
472 if (this->isNoOp() || (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
473 return;
474 }
Greg Daniel0a0ad5b2021-01-29 22:49:30 -0500475 TRACE_EVENT0("skia.gpu", TRACE_FUNC);
robertphillipsa106c622015-10-16 09:07:06 -0700476
Greg Danielb20d7e52019-09-03 13:54:39 -0400477 flushState->setSampledProxyArray(&fSampledProxies);
Brian Salomon982127b2021-01-21 10:43:35 -0500478 GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
Brian Salomon1e41f4a2016-12-07 15:05:04 -0500479 // Loop over the ops that haven't yet been prepared.
Brian Salomon588cec72018-11-14 13:56:37 -0500480 for (const auto& chain : fOpChains) {
Greg Daniel15ecdf92019-08-30 15:35:23 -0400481 if (chain.shouldExecute()) {
Stan Iliev2af578d2017-08-16 13:00:28 -0400482#ifdef SK_BUILD_FOR_ANDROID_FRAMEWORK
Brian Salomon5f394272019-07-02 14:07:49 -0400483 TRACE_EVENT0("skia.gpu", chain.head()->name());
Stan Iliev2af578d2017-08-16 13:00:28 -0400484#endif
Robert Phillips901aff02019-10-08 12:32:56 -0400485 GrOpFlushState::OpArgs opArgs(chain.head(),
Brian Salomon982127b2021-01-21 10:43:35 -0500486 dstView,
Robert Phillips901aff02019-10-08 12:32:56 -0400487 chain.appliedClip(),
Greg Danield358cbe2020-09-11 09:33:54 -0400488 chain.dstProxyView(),
Greg Daniel42dbca52020-11-20 10:22:43 -0500489 fRenderPassXferBarriers,
490 fColorLoadOp);
Robert Phillips405413f2019-10-04 10:39:28 -0400491
Brian Salomon29b60c92017-10-31 14:42:10 -0400492 flushState->setOpArgs(&opArgs);
Robert Phillipsdf70f152019-11-15 14:57:05 -0500493
494 // Temporary debugging helper: for debugging prePrepare w/o going through DDLs
495 // Delete once most of the GrOps have an onPrePrepare.
Adlai Holler33d569e2020-06-16 14:30:08 -0400496 // chain.head()->prePrepare(flushState->gpu()->getContext(), &this->target(0),
Robert Phillipsdf70f152019-11-15 14:57:05 -0500497 // chain.appliedClip());
498
Robert Phillips7327c9d2019-10-08 16:32:56 -0400499 // GrOp::prePrepare may or may not have been called at this point
Brian Salomon588cec72018-11-14 13:56:37 -0500500 chain.head()->prepare(flushState);
Brian Salomon29b60c92017-10-31 14:42:10 -0400501 flushState->setOpArgs(nullptr);
bsalomonaecc0182016-03-07 11:50:44 -0800502 }
bsalomon512be532015-09-10 10:42:55 -0700503 }
Greg Danielb20d7e52019-09-03 13:54:39 -0400504 flushState->setSampledProxyArray(nullptr);
robertphillipsa13e2022015-11-11 12:01:09 -0800505}
bsalomon512be532015-09-10 10:42:55 -0700506
Greg Danielc0d69152020-10-08 14:59:00 -0400507static GrOpsRenderPass* create_render_pass(GrGpu* gpu,
508 GrRenderTarget* rt,
509 GrAttachment* stencil,
510 GrSurfaceOrigin origin,
511 const SkIRect& bounds,
512 GrLoadOp colorLoadOp,
Brian Salomon07bc9a22020-12-02 13:37:16 -0500513 const std::array<float, 4>& loadClearColor,
Greg Danielc0d69152020-10-08 14:59:00 -0400514 GrLoadOp stencilLoadOp,
515 GrStoreOp stencilStoreOp,
516 const SkTArray<GrSurfaceProxy*, true>& sampledProxies,
517 GrXferBarrierFlags renderPassXferBarriers) {
Greg Daniel2d41d0d2019-08-26 11:08:51 -0400518 const GrOpsRenderPass::LoadAndStoreInfo kColorLoadStoreInfo {
Robert Phillips6b47c7d2017-08-29 07:24:09 -0400519 colorLoadOp,
520 GrStoreOp::kStore,
521 loadClearColor
Robert Phillips178ce3e2017-04-13 09:15:47 -0400522 };
523
Robert Phillips95214472017-08-08 18:00:03 -0400524 // TODO:
525 // We would like to (at this level) only ever clear & discard. We would need
Greg Danielf41b2bd2019-08-22 16:19:24 -0400526 // to stop splitting up higher level OpsTasks for copyOps to achieve that.
Robert Phillips95214472017-08-08 18:00:03 -0400527 // Note: we would still need SB loads and stores but they would happen at a
528 // lower level (inside the VK command buffer).
Greg Daniel2d41d0d2019-08-26 11:08:51 -0400529 const GrOpsRenderPass::StencilLoadAndStoreInfo stencilLoadAndStoreInfo {
Robert Phillips6b47c7d2017-08-29 07:24:09 -0400530 stencilLoadOp,
Chris Dalton674f77a2019-09-30 20:49:39 -0600531 stencilStoreOp,
Robert Phillips95214472017-08-08 18:00:03 -0400532 };
533
Robert Phillips96f22372020-05-20 12:31:18 -0400534 return gpu->getOpsRenderPass(rt, stencil, origin, bounds,
Greg Daniel9a18b082020-08-14 14:03:50 -0400535 kColorLoadStoreInfo, stencilLoadAndStoreInfo, sampledProxies,
Greg Daniel21774362020-09-14 10:36:43 -0400536 renderPassXferBarriers);
Robert Phillips178ce3e2017-04-13 09:15:47 -0400537}
538
Brian Salomon25a88092016-12-01 09:36:50 -0500539// TODO: this is where GrOp::renderTarget is used (which is fine since it
Robert Phillips294870f2016-11-11 12:38:40 -0500540// is at flush time). However, we need to store the RenderTargetProxy in the
Brian Salomon1e41f4a2016-12-07 15:05:04 -0500541// Ops and instantiate them here.
Greg Danielf41b2bd2019-08-22 16:19:24 -0400542bool GrOpsTask::onExecute(GrOpFlushState* flushState) {
Greg Daniel94ed83f2019-09-27 13:05:43 -0400543 // TODO: remove the check for discard here once reduced op splitting is turned on. Currently we
544 // can end up with GrOpsTasks that only have a discard load op and no ops. For vulkan validation
545 // we need to keep that discard and not drop it. Once we have reduce op list splitting enabled
546 // we shouldn't end up with GrOpsTasks with only discard.
547 if (this->isNoOp() || (fClippedContentBounds.isEmpty() && fColorLoadOp != GrLoadOp::kDiscard)) {
bsalomondc438982016-08-31 11:53:49 -0700548 return false;
egdanielb4021cf2016-07-28 08:53:07 -0700549 }
Robert Phillips4a395042017-04-24 16:27:17 +0000550
Adlai Holler33d569e2020-06-16 14:30:08 -0400551 SkASSERT(this->numTargets() == 1);
Brian Salomon982127b2021-01-21 10:43:35 -0500552 GrRenderTargetProxy* proxy = this->target(0)->asRenderTargetProxy();
Greg Daniel16f5c652019-10-29 11:26:01 -0400553 SkASSERT(proxy);
Brian Salomon5f394272019-07-02 14:07:49 -0400554 TRACE_EVENT0("skia.gpu", TRACE_FUNC);
Robert Phillips6cdc22c2017-05-11 16:29:14 -0400555
Michael Ludwigc39d0c82019-01-15 10:03:43 -0500556 // Make sure load ops are not kClear if the GPU needs to use draws for clears
557 SkASSERT(fColorLoadOp != GrLoadOp::kClear ||
558 !flushState->gpu()->caps()->performColorClearsAsDraws());
Chris Dalton674f77a2019-09-30 20:49:39 -0600559
560 const GrCaps& caps = *flushState->gpu()->caps();
Greg Daniel16f5c652019-10-29 11:26:01 -0400561 GrRenderTarget* renderTarget = proxy->peekRenderTarget();
Chris Dalton674f77a2019-09-30 20:49:39 -0600562 SkASSERT(renderTarget);
Chris Dalton0b68dda2019-11-07 21:08:03 -0700563
Greg Danielc0d69152020-10-08 14:59:00 -0400564 GrAttachment* stencil = nullptr;
Chris Dalton0b68dda2019-11-07 21:08:03 -0700565 if (int numStencilSamples = proxy->numStencilSamples()) {
566 if (!flushState->resourceProvider()->attachStencilAttachment(
567 renderTarget, numStencilSamples)) {
568 SkDebugf("WARNING: failed to attach a stencil buffer. Rendering will be skipped.\n");
569 return false;
570 }
Brian Salomonf7f54332020-07-28 09:23:35 -0400571 stencil = renderTarget->getStencilAttachment();
Chris Dalton0b68dda2019-11-07 21:08:03 -0700572 }
573
Chris Daltonf00b95b2019-11-07 21:14:41 -0700574 SkASSERT(!stencil || stencil->numSamples() == proxy->numStencilSamples());
Chris Dalton674f77a2019-09-30 20:49:39 -0600575
576 GrLoadOp stencilLoadOp;
577 switch (fInitialStencilContent) {
578 case StencilContent::kDontCare:
579 stencilLoadOp = GrLoadOp::kDiscard;
580 break;
581 case StencilContent::kUserBitsCleared:
582 SkASSERT(!caps.performStencilClearsAsDraws());
583 SkASSERT(stencil);
584 if (caps.discardStencilValuesAfterRenderPass()) {
585 // Always clear the stencil if it is being discarded after render passes. This is
586 // also an optimization because we are on a tiler and it avoids loading the values
587 // from memory.
588 stencilLoadOp = GrLoadOp::kClear;
589 break;
590 }
591 if (!stencil->hasPerformedInitialClear()) {
592 stencilLoadOp = GrLoadOp::kClear;
593 stencil->markHasPerformedInitialClear();
594 break;
595 }
596 // renderTargetContexts are required to leave the user stencil bits in a cleared state
597 // once finished, meaning the stencil values will always remain cleared after the
598 // initial clear. Just fall through to reloading the existing (cleared) stencil values
599 // from memory.
John Stiles30212b72020-06-11 17:55:07 -0400600 [[fallthrough]];
Chris Dalton674f77a2019-09-30 20:49:39 -0600601 case StencilContent::kPreserved:
602 SkASSERT(stencil);
603 stencilLoadOp = GrLoadOp::kLoad;
604 break;
605 }
606
Brian Salomon1aa1f5f2020-12-11 17:25:17 -0500607 // NOTE: If fMustPreserveStencil is set, then we are executing a surfaceDrawContext that split
Chris Dalton674f77a2019-09-30 20:49:39 -0600608 // its opsTask.
609 //
610 // FIXME: We don't currently flag render passes that don't use stencil at all. In that case
611 // their store op might be "discard", and we currently make the assumption that a discard will
612 // not invalidate what's already in main memory. This is probably ok for now, but certainly
613 // something we want to address soon.
614 GrStoreOp stencilStoreOp = (caps.discardStencilValuesAfterRenderPass() && !fMustPreserveStencil)
615 ? GrStoreOp::kDiscard
616 : GrStoreOp::kStore;
617
Brian Salomon982127b2021-01-21 10:43:35 -0500618 GrOpsRenderPass* renderPass = create_render_pass(flushState->gpu(),
619 proxy->peekRenderTarget(),
620 stencil,
621 fTargetOrigin,
622 fClippedContentBounds,
623 fColorLoadOp,
624 fLoadClearColor,
625 stencilLoadOp,
626 stencilStoreOp,
627 fSampledProxies,
628 fRenderPassXferBarriers);
Greg Daniel21774362020-09-14 10:36:43 -0400629
Greg Danielfa3adf72019-11-07 09:53:41 -0500630 if (!renderPass) {
631 return false;
632 }
Greg Daniel2d41d0d2019-08-26 11:08:51 -0400633 flushState->setOpsRenderPass(renderPass);
634 renderPass->begin();
Robert Phillips6cdc22c2017-05-11 16:29:14 -0400635
Brian Salomon982127b2021-01-21 10:43:35 -0500636 GrSurfaceProxyView dstView(sk_ref_sp(this->target(0)), fTargetOrigin, fTargetSwizzle);
637
Robert Phillips6cdc22c2017-05-11 16:29:14 -0400638 // Draw all the generated geometry.
Brian Salomon588cec72018-11-14 13:56:37 -0500639 for (const auto& chain : fOpChains) {
Greg Daniel15ecdf92019-08-30 15:35:23 -0400640 if (!chain.shouldExecute()) {
bsalomonaecc0182016-03-07 11:50:44 -0800641 continue;
642 }
Stan Iliev2af578d2017-08-16 13:00:28 -0400643#ifdef SK_BUILD_FOR_ANDROID_FRAMEWORK
Brian Salomon5f394272019-07-02 14:07:49 -0400644 TRACE_EVENT0("skia.gpu", chain.head()->name());
Stan Iliev2af578d2017-08-16 13:00:28 -0400645#endif
Robert Phillips178ce3e2017-04-13 09:15:47 -0400646
Robert Phillips405413f2019-10-04 10:39:28 -0400647 GrOpFlushState::OpArgs opArgs(chain.head(),
Brian Salomon982127b2021-01-21 10:43:35 -0500648 dstView,
Robert Phillips405413f2019-10-04 10:39:28 -0400649 chain.appliedClip(),
Greg Danield358cbe2020-09-11 09:33:54 -0400650 chain.dstProxyView(),
Greg Daniel42dbca52020-11-20 10:22:43 -0500651 fRenderPassXferBarriers,
652 fColorLoadOp);
Robert Phillips178ce3e2017-04-13 09:15:47 -0400653
Brian Salomon29b60c92017-10-31 14:42:10 -0400654 flushState->setOpArgs(&opArgs);
Brian Salomon588cec72018-11-14 13:56:37 -0500655 chain.head()->execute(flushState, chain.bounds());
Brian Salomon29b60c92017-10-31 14:42:10 -0400656 flushState->setOpArgs(nullptr);
bsalomon512be532015-09-10 10:42:55 -0700657 }
Robert Phillips178ce3e2017-04-13 09:15:47 -0400658
Greg Daniel2d41d0d2019-08-26 11:08:51 -0400659 renderPass->end();
660 flushState->gpu()->submit(renderPass);
661 flushState->setOpsRenderPass(nullptr);
ethannicholas22793252016-01-30 09:59:10 -0800662
bsalomondc438982016-08-31 11:53:49 -0700663 return true;
bsalomona73239a2015-04-28 13:35:17 -0700664}
665
Brian Salomon07bc9a22020-12-02 13:37:16 -0500666void GrOpsTask::setColorLoadOp(GrLoadOp op, std::array<float, 4> color) {
Michael Ludwigc39d0c82019-01-15 10:03:43 -0500667 fColorLoadOp = op;
668 fLoadClearColor = color;
Chris Dalton16a33c62019-09-24 22:19:17 -0600669 if (GrLoadOp::kClear == fColorLoadOp) {
Brian Salomon982127b2021-01-21 10:43:35 -0500670 GrSurfaceProxy* proxy = this->target(0);
Greg Daniel16f5c652019-10-29 11:26:01 -0400671 SkASSERT(proxy);
Michael Ludwigd1d997e2020-06-04 15:52:44 -0400672 fTotalBounds = proxy->backingStoreBoundsRect();
Chris Dalton16a33c62019-09-24 22:19:17 -0600673 }
Michael Ludwigc39d0c82019-01-15 10:03:43 -0500674}
675
Adlai Holler9c3b6df2021-02-08 11:31:57 -0500676void GrOpsTask::reset() {
Adlai Holler9e2c50e2021-02-09 14:41:52 -0500677 fDeferredProxies.reset();
Adlai Holler9c3b6df2021-02-08 11:31:57 -0500678 fSampledProxies.reset();
679 fClipAllocators.reset();
680 fClippedContentBounds = SkIRect::MakeEmpty();
681 fTotalBounds = SkRect::MakeEmpty();
Adlai Holler026851a2021-03-29 14:47:11 -0400682 this->deleteOps();
Adlai Holler9c3b6df2021-02-08 11:31:57 -0500683 fRenderPassXferBarriers = GrXferBarrierFlags::kNone;
684}
685
Adlai Holler93439d92021-01-26 09:20:39 -0500686int GrOpsTask::mergeFrom(SkSpan<const sk_sp<GrRenderTask>> tasks) {
Adlai Holler9c3b6df2021-02-08 11:31:57 -0500687 // Find the index of the last color-clearing task. -1 indicates this or "there are none."
688 int indexOfLastColorClear = -1;
Adlai Holler93439d92021-01-26 09:20:39 -0500689 int mergedCount = 0;
690 for (const sk_sp<GrRenderTask>& task : tasks) {
691 auto opsTask = task->asOpsTask();
692 if (!opsTask || opsTask->target(0) != this->target(0)) {
693 break;
694 }
695 SkASSERT(fTargetSwizzle == opsTask->fTargetSwizzle);
696 SkASSERT(fTargetOrigin == opsTask->fTargetOrigin);
Adlai Holler9c3b6df2021-02-08 11:31:57 -0500697 if (GrLoadOp::kClear == opsTask->fColorLoadOp) {
698 indexOfLastColorClear = &task - tasks.begin();
699 }
Adlai Holler93439d92021-01-26 09:20:39 -0500700 mergedCount += 1;
Adlai Holler9c3b6df2021-02-08 11:31:57 -0500701 }
702 if (0 == mergedCount) {
703 return 0;
704 }
705
706 SkSpan<const sk_sp<GrOpsTask>> opsTasks(reinterpret_cast<const sk_sp<GrOpsTask>*>(tasks.data()),
707 SkToSizeT(mergedCount));
708 if (indexOfLastColorClear >= 0) {
709 // If any dropped task needs to preserve stencil, for now just bail on the merge.
710 // Could keep the merge and insert a clear op, but might be tricky due to closed task.
711 if (fMustPreserveStencil) {
712 return 0;
713 }
714 for (const auto& opsTask : opsTasks.first(indexOfLastColorClear)) {
715 if (opsTask->fMustPreserveStencil) {
716 return 0;
717 }
718 }
719 // Clear `this` and forget about the tasks pre-color-clear.
720 this->reset();
721 opsTasks = opsTasks.last(opsTasks.count() - indexOfLastColorClear);
722 // Copy the color-clear into `this`.
723 fColorLoadOp = GrLoadOp::kClear;
724 fLoadClearColor = opsTasks.front()->fLoadClearColor;
725 }
Adlai Holler9e2c50e2021-02-09 14:41:52 -0500726 int addlDeferredProxyCount = 0;
Adlai Holler9c3b6df2021-02-08 11:31:57 -0500727 int addlProxyCount = 0;
728 int addlOpChainCount = 0;
729 for (const auto& opsTask : opsTasks) {
Adlai Holler9e2c50e2021-02-09 14:41:52 -0500730 addlDeferredProxyCount += opsTask->fDeferredProxies.count();
Adlai Holler93439d92021-01-26 09:20:39 -0500731 addlProxyCount += opsTask->fSampledProxies.count();
732 addlOpChainCount += opsTask->fOpChains.count();
733 fClippedContentBounds.join(opsTask->fClippedContentBounds);
734 fTotalBounds.join(opsTask->fTotalBounds);
735 fRenderPassXferBarriers |= opsTask->fRenderPassXferBarriers;
736 SkDEBUGCODE(fNumClips += opsTask->fNumClips);
Adlai Holler93439d92021-01-26 09:20:39 -0500737 }
Adlai Holler9c3b6df2021-02-08 11:31:57 -0500738
Adlai Holler93439d92021-01-26 09:20:39 -0500739 fLastClipStackGenID = SK_InvalidUniqueID;
Adlai Holler9e2c50e2021-02-09 14:41:52 -0500740 fDeferredProxies.reserve_back(addlDeferredProxyCount);
Adlai Holler93439d92021-01-26 09:20:39 -0500741 fSampledProxies.reserve_back(addlProxyCount);
742 fOpChains.reserve_back(addlOpChainCount);
Adlai Holler9c3b6df2021-02-08 11:31:57 -0500743 fClipAllocators.reserve_back(opsTasks.count());
744 for (const auto& opsTask : opsTasks) {
Adlai Holler9e2c50e2021-02-09 14:41:52 -0500745 fDeferredProxies.move_back_n(opsTask->fDeferredProxies.count(),
746 opsTask->fDeferredProxies.data());
Adlai Holler93439d92021-01-26 09:20:39 -0500747 fSampledProxies.move_back_n(opsTask->fSampledProxies.count(),
748 opsTask->fSampledProxies.data());
749 fOpChains.move_back_n(opsTask->fOpChains.count(),
750 opsTask->fOpChains.data());
751 SkASSERT(1 == opsTask->fClipAllocators.count());
752 fClipAllocators.push_back(std::move(opsTask->fClipAllocators[0]));
753 opsTask->fClipAllocators.reset();
Adlai Holler9e2c50e2021-02-09 14:41:52 -0500754 opsTask->fDeferredProxies.reset();
Adlai Holler93439d92021-01-26 09:20:39 -0500755 opsTask->fSampledProxies.reset();
756 opsTask->fOpChains.reset();
757 }
Adlai Holler9c3b6df2021-02-08 11:31:57 -0500758 fMustPreserveStencil = opsTasks.back()->fMustPreserveStencil;
Adlai Holler93439d92021-01-26 09:20:39 -0500759 return mergedCount;
760}
761
Greg Danielf41b2bd2019-08-22 16:19:24 -0400762bool GrOpsTask::resetForFullscreenClear(CanDiscardPreviousOps canDiscardPreviousOps) {
Chris Dalton6b982802019-06-27 13:53:46 -0600763 if (CanDiscardPreviousOps::kYes == canDiscardPreviousOps || this->isEmpty()) {
Robert Phillipsc994a932018-06-19 13:09:54 -0400764 this->deleteOps();
Adlai Holler9e2c50e2021-02-09 14:41:52 -0500765 fDeferredProxies.reset();
Greg Danielb20d7e52019-09-03 13:54:39 -0400766 fSampledProxies.reset();
Greg Daniel070cbaf2019-01-03 17:35:54 -0500767
Greg Danielf41b2bd2019-08-22 16:19:24 -0400768 // If the opsTask is using a render target which wraps a vulkan command buffer, we can't do
769 // a clear load since we cannot change the render pass that we are using. Thus we fall back
770 // to making a clear op in this case.
Brian Salomon982127b2021-01-21 10:43:35 -0500771 return !this->target(0)->asRenderTargetProxy()->wrapsVkSecondaryCB();
bsalomonfd8d0132016-08-11 11:25:33 -0700772 }
Robert Phillips380b90c2017-08-30 07:41:07 -0400773
Greg Danielf41b2bd2019-08-22 16:19:24 -0400774 // Could not empty the task, so an op must be added to handle the clear
Michael Ludwigc39d0c82019-01-15 10:03:43 -0500775 return false;
bsalomon9f129de2016-08-10 16:31:05 -0700776}
777
Greg Danielf41b2bd2019-08-22 16:19:24 -0400778void GrOpsTask::discard() {
779 // Discard calls to in-progress opsTasks are ignored. Calls at the start update the
780 // opsTasks' color & stencil load ops.
781 if (this->isEmpty()) {
782 fColorLoadOp = GrLoadOp::kDiscard;
Chris Dalton674f77a2019-09-30 20:49:39 -0600783 fInitialStencilContent = StencilContent::kDontCare;
Chris Dalton16a33c62019-09-24 22:19:17 -0600784 fTotalBounds.setEmpty();
Greg Danielf41b2bd2019-08-22 16:19:24 -0400785 }
786}
787
bsalomon@google.com25fb21f2011-06-21 18:17:25 +0000788////////////////////////////////////////////////////////////////////////////////
bsalomon@google.com86afc2a2011-02-16 16:12:19 +0000789
John Stiles1e0136e2020-08-12 18:44:00 -0400790#if GR_TEST_UTILS
Robert Phillips047d5bb2021-01-08 13:39:19 -0500791void GrOpsTask::dump(const SkString& label,
792 SkString indent,
793 bool printDependencies,
794 bool close) const {
795 GrRenderTask::dump(label, indent, printDependencies, false);
Greg Danielf41b2bd2019-08-22 16:19:24 -0400796
Robert Phillips047d5bb2021-01-08 13:39:19 -0500797 SkDebugf("%sfColorLoadOp: ", indent.c_str());
Chris Dalton674f77a2019-09-30 20:49:39 -0600798 switch (fColorLoadOp) {
799 case GrLoadOp::kLoad:
800 SkDebugf("kLoad\n");
801 break;
802 case GrLoadOp::kClear:
Brian Salomon07bc9a22020-12-02 13:37:16 -0500803 SkDebugf("kClear {%g, %g, %g, %g}\n",
804 fLoadClearColor[0],
805 fLoadClearColor[1],
806 fLoadClearColor[2],
807 fLoadClearColor[3]);
Chris Dalton674f77a2019-09-30 20:49:39 -0600808 break;
809 case GrLoadOp::kDiscard:
810 SkDebugf("kDiscard\n");
811 break;
812 }
813
Robert Phillips047d5bb2021-01-08 13:39:19 -0500814 SkDebugf("%sfInitialStencilContent: ", indent.c_str());
Chris Dalton674f77a2019-09-30 20:49:39 -0600815 switch (fInitialStencilContent) {
816 case StencilContent::kDontCare:
817 SkDebugf("kDontCare\n");
818 break;
819 case StencilContent::kUserBitsCleared:
820 SkDebugf("kUserBitsCleared\n");
821 break;
822 case StencilContent::kPreserved:
823 SkDebugf("kPreserved\n");
824 break;
825 }
Greg Danielf41b2bd2019-08-22 16:19:24 -0400826
Robert Phillips047d5bb2021-01-08 13:39:19 -0500827 SkDebugf("%s%d ops:\n", indent.c_str(), fOpChains.count());
Greg Danielf41b2bd2019-08-22 16:19:24 -0400828 for (int i = 0; i < fOpChains.count(); ++i) {
Robert Phillips047d5bb2021-01-08 13:39:19 -0500829 SkDebugf("%s*******************************\n", indent.c_str());
Greg Danielf41b2bd2019-08-22 16:19:24 -0400830 if (!fOpChains[i].head()) {
Robert Phillips047d5bb2021-01-08 13:39:19 -0500831 SkDebugf("%s%d: <combined forward or failed instantiation>\n", indent.c_str(), i);
Greg Danielf41b2bd2019-08-22 16:19:24 -0400832 } else {
Robert Phillips047d5bb2021-01-08 13:39:19 -0500833 SkDebugf("%s%d: %s\n", indent.c_str(), i, fOpChains[i].head()->name());
Greg Danielf41b2bd2019-08-22 16:19:24 -0400834 SkRect bounds = fOpChains[i].bounds();
Robert Phillips047d5bb2021-01-08 13:39:19 -0500835 SkDebugf("%sClippedBounds: [L: %.2f, T: %.2f, R: %.2f, B: %.2f]\n",
836 indent.c_str(),
837 bounds.fLeft, bounds.fTop, bounds.fRight, bounds.fBottom);
Greg Danielf41b2bd2019-08-22 16:19:24 -0400838 for (const auto& op : GrOp::ChainRange<>(fOpChains[i].head())) {
839 SkString info = SkTabString(op.dumpInfo(), 1);
Robert Phillips047d5bb2021-01-08 13:39:19 -0500840 SkDebugf("%s%s\n", indent.c_str(), info.c_str());
Greg Danielf41b2bd2019-08-22 16:19:24 -0400841 bounds = op.bounds();
Robert Phillips047d5bb2021-01-08 13:39:19 -0500842 SkDebugf("%s\tClippedBounds: [L: %.2f, T: %.2f, R: %.2f, B: %.2f]\n",
843 indent.c_str(),
844 bounds.fLeft, bounds.fTop, bounds.fRight, bounds.fBottom);
Greg Danielf41b2bd2019-08-22 16:19:24 -0400845 }
846 }
847 }
Robert Phillips047d5bb2021-01-08 13:39:19 -0500848
849 if (close) {
850 SkDebugf("%s--------------------------------------------------------------\n\n",
851 indent.c_str());
852 }
Greg Danielf41b2bd2019-08-22 16:19:24 -0400853}
John Stiles1e0136e2020-08-12 18:44:00 -0400854#endif
Greg Danielf41b2bd2019-08-22 16:19:24 -0400855
John Stiles1e0136e2020-08-12 18:44:00 -0400856#ifdef SK_DEBUG
Michael Ludwigfcdd0612019-11-25 08:34:31 -0500857void GrOpsTask::visitProxies_debugOnly(const GrOp::VisitProxyFunc& func) const {
Brian Salomon7e67dca2020-07-21 09:27:25 -0400858 auto textureFunc = [ func ] (GrSurfaceProxy* tex, GrMipmapped mipmapped) {
Greg Danieldcf9ca12019-08-27 14:30:21 -0400859 func(tex, mipmapped);
860 };
861
Greg Danielf41b2bd2019-08-22 16:19:24 -0400862 for (const OpChain& chain : fOpChains) {
Greg Danieldcf9ca12019-08-27 14:30:21 -0400863 chain.visitProxies(textureFunc);
Greg Danielf41b2bd2019-08-22 16:19:24 -0400864 }
865}
866
867#endif
868
869////////////////////////////////////////////////////////////////////////////////
870
Brian Salomond63638b2021-03-05 14:00:07 -0500871void GrOpsTask::onCanSkip() {
872 this->deleteOps();
873 fDeferredProxies.reset();
874 fColorLoadOp = GrLoadOp::kLoad;
875 SkASSERT(this->isNoOp());
876}
877
Greg Danielf41b2bd2019-08-22 16:19:24 -0400878bool GrOpsTask::onIsUsed(GrSurfaceProxy* proxyToCheck) const {
879 bool used = false;
880
Brian Salomon7e67dca2020-07-21 09:27:25 -0400881 auto visit = [ proxyToCheck, &used ] (GrSurfaceProxy* p, GrMipmapped) {
Greg Danielf41b2bd2019-08-22 16:19:24 -0400882 if (p == proxyToCheck) {
883 used = true;
884 }
885 };
886 for (const OpChain& recordedOp : fOpChains) {
887 recordedOp.visitProxies(visit);
888 }
889
890 return used;
891}
892
Greg Danielf41b2bd2019-08-22 16:19:24 -0400893void GrOpsTask::gatherProxyIntervals(GrResourceAllocator* alloc) const {
Adlai Holler9e2c50e2021-02-09 14:41:52 -0500894 for (int i = 0; i < fDeferredProxies.count(); ++i) {
895 SkASSERT(!fDeferredProxies[i]->isInstantiated());
896 // We give all the deferred proxies a write usage at the very start of flushing. This
897 // locks them out of being reused for the entire flush until they are read - and then
898 // they can be recycled. This is a bit unfortunate because a flush can proceed in waves
899 // with sub-flushes. The deferred proxies only need to be pinned from the start of
900 // the sub-flush in which they appear.
901 alloc->addInterval(fDeferredProxies[i], 0, 0, GrResourceAllocator::ActualUse::kNo);
902 }
903
Brian Salomon982127b2021-01-21 10:43:35 -0500904 GrSurfaceProxy* targetProxy = this->target(0);
Greg Daniel16f5c652019-10-29 11:26:01 -0400905
Greg Danielf41b2bd2019-08-22 16:19:24 -0400906 // Add the interval for all the writes to this GrOpsTasks's target
Brian Salomon588cec72018-11-14 13:56:37 -0500907 if (fOpChains.count()) {
Robert Phillips3bf3d4a2019-03-27 07:09:09 -0400908 unsigned int cur = alloc->curOp();
909
Adlai Holler7f7a5df2021-02-09 17:41:10 +0000910 alloc->addInterval(targetProxy, cur, cur + fOpChains.count() - 1,
911 GrResourceAllocator::ActualUse::kYes);
Robert Phillipsf8e25022017-11-08 15:24:31 -0500912 } else {
913 // This can happen if there is a loadOp (e.g., a clear) but no other draws. In this case we
914 // still need to add an interval for the destination so we create a fake op# for
915 // the missing clear op.
Adlai Holler7f7a5df2021-02-09 17:41:10 +0000916 alloc->addInterval(targetProxy, alloc->curOp(), alloc->curOp(),
917 GrResourceAllocator::ActualUse::kYes);
Robert Phillipsf8e25022017-11-08 15:24:31 -0500918 alloc->incOps();
919 }
Robert Phillipsd375dbf2017-09-14 12:45:25 -0400920
Brian Salomon7e67dca2020-07-21 09:27:25 -0400921 auto gather = [ alloc SkDEBUGCODE(, this) ] (GrSurfaceProxy* p, GrMipmapped) {
Brian Salomon982127b2021-01-21 10:43:35 -0500922 alloc->addInterval(p,
923 alloc->curOp(),
Adlai Holler7f7a5df2021-02-09 17:41:10 +0000924 alloc->curOp(),
925 GrResourceAllocator::ActualUse::kYes
Brian Salomon982127b2021-01-21 10:43:35 -0500926 SkDEBUGCODE(, this->target(0) == p));
Robert Phillipsd375dbf2017-09-14 12:45:25 -0400927 };
Brian Salomon588cec72018-11-14 13:56:37 -0500928 for (const OpChain& recordedOp : fOpChains) {
Chris Dalton1706cbf2019-05-21 19:35:29 -0600929 recordedOp.visitProxies(gather);
Robert Phillipsf8e25022017-11-08 15:24:31 -0500930
Robert Phillips3bf3d4a2019-03-27 07:09:09 -0400931 // Even though the op may have been (re)moved we still need to increment the op count to
Robert Phillipsf8e25022017-11-08 15:24:31 -0500932 // keep all the math consistent.
933 alloc->incOps();
Robert Phillipsd375dbf2017-09-14 12:45:25 -0400934 }
935}
936
Greg Danielf41b2bd2019-08-22 16:19:24 -0400937void GrOpsTask::recordOp(
Herb Derbyc76d4092020-10-07 16:46:15 -0400938 GrOp::Owner op, GrProcessorSet::Analysis processorAnalysis, GrAppliedClip* clip,
Greg Daniel524e28b2019-11-01 11:48:53 -0400939 const DstProxyView* dstProxyView, const GrCaps& caps) {
Ethan Nicholas029b22c2018-10-18 16:49:56 -0400940 SkDEBUGCODE(op->validate();)
Greg Daniel524e28b2019-11-01 11:48:53 -0400941 SkASSERT(processorAnalysis.requiresDstTexture() == (dstProxyView && dstProxyView->proxy()));
Brian Salomon982127b2021-01-21 10:43:35 -0500942 GrSurfaceProxy* proxy = this->target(0);
Greg Daniel16f5c652019-10-29 11:26:01 -0400943 SkASSERT(proxy);
Robert Phillipsee683652017-04-26 11:53:10 -0400944
Greg Danielf41b2bd2019-08-22 16:19:24 -0400945 // A closed GrOpsTask should never receive new/more ops
robertphillips6a186652015-10-20 07:37:58 -0700946 SkASSERT(!this->isClosed());
Brian Salomon19ec80f2018-11-16 13:27:30 -0500947 if (!op->bounds().isFinite()) {
Brian Salomon19ec80f2018-11-16 13:27:30 -0500948 return;
949 }
robertphillipsa106c622015-10-16 09:07:06 -0700950
Chris Dalton16a33c62019-09-24 22:19:17 -0600951 // Account for this op's bounds before we attempt to combine.
952 // NOTE: The caller should have already called "op->setClippedBounds()" by now, if applicable.
953 fTotalBounds.join(op->bounds());
954
Brian Salomon1e41f4a2016-12-07 15:05:04 -0500955 // Check if there is an op we can combine with by linearly searching back until we either
956 // 1) check every op
bsalomon512be532015-09-10 10:42:55 -0700957 // 2) intersect with something
958 // 3) find a 'blocker'
Greg Daniel16f5c652019-10-29 11:26:01 -0400959 GR_AUDIT_TRAIL_ADD_OP(fAuditTrail, op.get(), proxy->uniqueID());
Greg Danielf41b2bd2019-08-22 16:19:24 -0400960 GrOP_INFO("opsTask: %d Recording (%s, opID: %u)\n"
Robert Phillipsf5442bb2017-04-17 14:18:34 -0400961 "\tBounds [L: %.2f, T: %.2f R: %.2f B: %.2f]\n",
962 this->uniqueID(),
Brian Salomon1e41f4a2016-12-07 15:05:04 -0500963 op->name(),
964 op->uniqueID(),
Robert Phillips1119dc32017-04-11 12:54:57 -0400965 op->bounds().fLeft, op->bounds().fTop,
966 op->bounds().fRight, op->bounds().fBottom);
Brian Salomon1e41f4a2016-12-07 15:05:04 -0500967 GrOP_INFO(SkTabString(op->dumpInfo(), 1).c_str());
Brian Salomon25a88092016-12-01 09:36:50 -0500968 GrOP_INFO("\tOutcome:\n");
Brian Osman788b9162020-02-07 10:36:46 -0500969 int maxCandidates = std::min(kMaxOpChainDistance, fOpChains.count());
Robert Phillips318c4192017-05-17 09:36:38 -0400970 if (maxCandidates) {
bsalomon512be532015-09-10 10:42:55 -0700971 int i = 0;
972 while (true) {
Brian Salomon588cec72018-11-14 13:56:37 -0500973 OpChain& candidate = fOpChains.fromBack(i);
Greg Daniel524e28b2019-11-01 11:48:53 -0400974 op = candidate.appendOp(std::move(op), processorAnalysis, dstProxyView, clip, caps,
Michael Ludwig28b0c5d2019-12-19 14:51:00 -0500975 &fArenas, fAuditTrail);
Brian Salomon588cec72018-11-14 13:56:37 -0500976 if (!op) {
977 return;
bsalomon512be532015-09-10 10:42:55 -0700978 }
Brian Salomona7682c82018-10-24 10:04:37 -0400979 // Stop going backwards if we would cause a painter's order violation.
Brian Salomon588cec72018-11-14 13:56:37 -0500980 if (!can_reorder(candidate.bounds(), op->bounds())) {
981 GrOP_INFO("\t\tBackward: Intersects with chain (%s, head opID: %u)\n",
982 candidate.head()->name(), candidate.head()->uniqueID());
bsalomon512be532015-09-10 10:42:55 -0700983 break;
984 }
Brian Salomon588cec72018-11-14 13:56:37 -0500985 if (++i == maxCandidates) {
Robert Phillipsf5442bb2017-04-17 14:18:34 -0400986 GrOP_INFO("\t\tBackward: Reached max lookback or beginning of op array %d\n", i);
bsalomon512be532015-09-10 10:42:55 -0700987 break;
988 }
989 }
990 } else {
Robert Phillipsf5442bb2017-04-17 14:18:34 -0400991 GrOP_INFO("\t\tBackward: FirstOp\n");
bsalomon512be532015-09-10 10:42:55 -0700992 }
Brian Salomon54d212e2017-03-21 14:22:38 -0400993 if (clip) {
Adlai Holler93439d92021-01-26 09:20:39 -0500994 clip = fClipAllocators[0]->make<GrAppliedClip>(std::move(*clip));
Robert Phillipsc84c0302017-05-08 15:35:11 -0400995 SkDEBUGCODE(fNumClips++;)
Brian Salomon54d212e2017-03-21 14:22:38 -0400996 }
Greg Daniel524e28b2019-11-01 11:48:53 -0400997 fOpChains.emplace_back(std::move(op), processorAnalysis, clip, dstProxyView);
bsalomon512be532015-09-10 10:42:55 -0700998}
999
Greg Danielf41b2bd2019-08-22 16:19:24 -04001000void GrOpsTask::forwardCombine(const GrCaps& caps) {
Robert Phillipsf5442bb2017-04-17 14:18:34 -04001001 SkASSERT(!this->isClosed());
Greg Danielf41b2bd2019-08-22 16:19:24 -04001002 GrOP_INFO("opsTask: %d ForwardCombine %d ops:\n", this->uniqueID(), fOpChains.count());
Robert Phillips48567ac2017-06-01 08:46:00 -04001003
Brian Salomon588cec72018-11-14 13:56:37 -05001004 for (int i = 0; i < fOpChains.count() - 1; ++i) {
1005 OpChain& chain = fOpChains[i];
Brian Osman788b9162020-02-07 10:36:46 -05001006 int maxCandidateIdx = std::min(i + kMaxOpChainDistance, fOpChains.count() - 1);
bsalomonaecc0182016-03-07 11:50:44 -08001007 int j = i + 1;
1008 while (true) {
Brian Salomon588cec72018-11-14 13:56:37 -05001009 OpChain& candidate = fOpChains[j];
Michael Ludwig28b0c5d2019-12-19 14:51:00 -05001010 if (candidate.prependChain(&chain, caps, &fArenas, fAuditTrail)) {
bsalomonaecc0182016-03-07 11:50:44 -08001011 break;
1012 }
Robert Phillipsc84c0302017-05-08 15:35:11 -04001013 // Stop traversing if we would cause a painter's order violation.
Brian Salomon588cec72018-11-14 13:56:37 -05001014 if (!can_reorder(chain.bounds(), candidate.bounds())) {
1015 GrOP_INFO(
1016 "\t\t%d: chain (%s head opID: %u) -> "
1017 "Intersects with chain (%s, head opID: %u)\n",
1018 i, chain.head()->name(), chain.head()->uniqueID(), candidate.head()->name(),
1019 candidate.head()->uniqueID());
bsalomonaecc0182016-03-07 11:50:44 -08001020 break;
1021 }
Brian Salomona7682c82018-10-24 10:04:37 -04001022 if (++j > maxCandidateIdx) {
Brian Salomon588cec72018-11-14 13:56:37 -05001023 GrOP_INFO("\t\t%d: chain (%s opID: %u) -> Reached max lookahead or end of array\n",
1024 i, chain.head()->name(), chain.head()->uniqueID());
bsalomonaecc0182016-03-07 11:50:44 -08001025 break;
1026 }
1027 }
1028 }
1029}
1030
Robert Phillips07f675d2020-11-16 13:44:01 -05001031GrRenderTask::ExpectedOutcome GrOpsTask::onMakeClosed(const GrCaps& caps,
1032 SkIRect* targetUpdateBounds) {
Chris Dalton16a33c62019-09-24 22:19:17 -06001033 this->forwardCombine(caps);
1034 if (!this->isNoOp()) {
Brian Salomon982127b2021-01-21 10:43:35 -05001035 GrSurfaceProxy* proxy = this->target(0);
Michael Ludwigd1d997e2020-06-04 15:52:44 -04001036 // Use the entire backing store bounds since the GPU doesn't clip automatically to the
1037 // logical dimensions.
1038 SkRect clippedContentBounds = proxy->backingStoreBoundsRect();
Adlai Holler33d569e2020-06-16 14:30:08 -04001039 // TODO: If we can fix up GLPrograms test to always intersect the target proxy bounds
Greg Daniel16f5c652019-10-29 11:26:01 -04001040 // then we can simply assert here that the bounds intersect.
Chris Dalton16a33c62019-09-24 22:19:17 -06001041 if (clippedContentBounds.intersect(fTotalBounds)) {
Greg Daniel94ed83f2019-09-27 13:05:43 -04001042 clippedContentBounds.roundOut(&fClippedContentBounds);
Brian Salomon982127b2021-01-21 10:43:35 -05001043 *targetUpdateBounds = GrNativeRect::MakeIRectRelativeTo(
1044 fTargetOrigin,
1045 this->target(0)->backingStoreDimensions().height(),
1046 fClippedContentBounds);
Chris Dalton16a33c62019-09-24 22:19:17 -06001047 return ExpectedOutcome::kTargetDirty;
1048 }
1049 }
1050 return ExpectedOutcome::kTargetUnchanged;
1051}