halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2015 Google Inc. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license that can be |
| 5 | * found in the LICENSE file. |
| 6 | */ |
| 7 | |
Leon Scroggins III | 932efed | 2016-12-16 11:39:51 -0500 | [diff] [blame] | 8 | #include "FakeStreams.h" |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 9 | #include "Resources.h" |
msarett | 3d9d7a7 | 2015-10-21 10:27:10 -0700 | [diff] [blame] | 10 | #include "SkAndroidCodec.h" |
Hal Canary | 95e3c05 | 2017-01-11 12:44:43 -0500 | [diff] [blame] | 11 | #include "SkAutoMalloc.h" |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 12 | #include "SkBitmap.h" |
Leon Scroggins III | cbf66a2 | 2018-02-16 12:03:03 -0500 | [diff] [blame] | 13 | #include "SkCanvas.h" |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 14 | #include "SkCodec.h" |
msarett | edd2dcf | 2016-01-14 13:12:26 -0800 | [diff] [blame] | 15 | #include "SkCodecImageGenerator.h" |
Ben Wagner | b607a8f | 2018-03-12 13:46:21 -0400 | [diff] [blame] | 16 | #include "SkColor.h" |
| 17 | #include "SkColorSpace.h" |
Matt Sarett | 0e032be | 2017-03-15 17:50:08 -0400 | [diff] [blame] | 18 | #include "SkColorSpacePriv.h" |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 19 | #include "SkData.h" |
Ben Wagner | b607a8f | 2018-03-12 13:46:21 -0400 | [diff] [blame] | 20 | #include "SkEncodedImageFormat.h" |
Kevin Lubick | c456b73 | 2017-01-11 17:21:57 +0000 | [diff] [blame] | 21 | #include "SkFrontBufferedStream.h" |
Ben Wagner | b607a8f | 2018-03-12 13:46:21 -0400 | [diff] [blame] | 22 | #include "SkImage.h" |
| 23 | #include "SkImageGenerator.h" |
| 24 | #include "SkImageInfo.h" |
Ben Wagner | 501c17c | 2018-03-12 20:04:31 +0000 | [diff] [blame] | 25 | #include "SkJpegEncoder.h" |
Ben Wagner | b607a8f | 2018-03-12 13:46:21 -0400 | [diff] [blame] | 26 | #include "SkMD5.h" |
| 27 | #include "SkMakeUnique.h" |
| 28 | #include "SkMalloc.h" |
| 29 | #include "SkMatrix44.h" |
| 30 | #include "SkPixmap.h" |
Hal Canary | 95e3c05 | 2017-01-11 12:44:43 -0500 | [diff] [blame] | 31 | #include "SkPngChunkReader.h" |
Matt Sarett | c367d03 | 2017-05-05 11:13:26 -0400 | [diff] [blame] | 32 | #include "SkPngEncoder.h" |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 33 | #include "SkRandom.h" |
Ben Wagner | b607a8f | 2018-03-12 13:46:21 -0400 | [diff] [blame] | 34 | #include "SkRect.h" |
| 35 | #include "SkRefCnt.h" |
| 36 | #include "SkSize.h" |
scroggo | cf98fa9 | 2015-11-23 08:14:40 -0800 | [diff] [blame] | 37 | #include "SkStream.h" |
scroggo | b9a1e34 | 2015-11-30 06:25:31 -0800 | [diff] [blame] | 38 | #include "SkStreamPriv.h" |
Ben Wagner | b607a8f | 2018-03-12 13:46:21 -0400 | [diff] [blame] | 39 | #include "SkString.h" |
| 40 | #include "SkTemplates.h" |
| 41 | #include "SkTypes.h" |
Leon Scroggins III | cbf66a2 | 2018-02-16 12:03:03 -0500 | [diff] [blame] | 42 | #include "SkUnPreMultiply.h" |
Matt Sarett | 04c3731 | 2017-05-05 14:02:13 -0400 | [diff] [blame] | 43 | #include "SkWebpEncoder.h" |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 44 | #include "Test.h" |
Ben Wagner | 501c17c | 2018-03-12 20:04:31 +0000 | [diff] [blame] | 45 | #include "png.h" |
Ben Wagner | 501c17c | 2018-03-12 20:04:31 +0000 | [diff] [blame] | 46 | #include "sk_tool_utils.h" |
Ben Wagner | 1a462bd | 2018-03-12 13:46:21 -0400 | [diff] [blame] | 47 | |
Ben Wagner | b607a8f | 2018-03-12 13:46:21 -0400 | [diff] [blame] | 48 | #include <setjmp.h> |
| 49 | #include <cstring> |
| 50 | #include <memory> |
| 51 | #include <utility> |
| 52 | #include <vector> |
| 53 | |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 54 | #if PNG_LIBPNG_VER_MAJOR == 1 && PNG_LIBPNG_VER_MINOR < 5 |
| 55 | // FIXME (scroggo): Google3 needs to be updated to use a newer version of libpng. In |
| 56 | // the meantime, we had to break some pieces of SkPngCodec in order to support Google3. |
| 57 | // The parts that are broken are likely not used by Google3. |
| 58 | #define SK_PNG_DISABLE_TESTS |
| 59 | #endif |
| 60 | |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 61 | static void md5(const SkBitmap& bm, SkMD5::Digest* digest) { |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 62 | SkASSERT(bm.getPixels()); |
| 63 | SkMD5 md5; |
| 64 | size_t rowLen = bm.info().bytesPerPixel() * bm.width(); |
| 65 | for (int y = 0; y < bm.height(); ++y) { |
halcanary | 1e90304 | 2016-04-25 10:29:36 -0700 | [diff] [blame] | 66 | md5.write(bm.getAddr(0, y), rowLen); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 67 | } |
| 68 | md5.finish(*digest); |
| 69 | } |
| 70 | |
scroggo | 9b2cdbf4 | 2015-07-10 12:07:02 -0700 | [diff] [blame] | 71 | /** |
| 72 | * Compute the digest for bm and compare it to a known good digest. |
| 73 | * @param r Reporter to assert that bm's digest matches goodDigest. |
| 74 | * @param goodDigest The known good digest to compare to. |
| 75 | * @param bm The bitmap to test. |
| 76 | */ |
| 77 | static void compare_to_good_digest(skiatest::Reporter* r, const SkMD5::Digest& goodDigest, |
| 78 | const SkBitmap& bm) { |
| 79 | SkMD5::Digest digest; |
| 80 | md5(bm, &digest); |
| 81 | REPORTER_ASSERT(r, digest == goodDigest); |
| 82 | } |
| 83 | |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 84 | /** |
| 85 | * Test decoding an SkCodec to a particular SkImageInfo. |
| 86 | * |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame] | 87 | * Calling getPixels(info) should return expectedResult, and if goodDigest is non nullptr, |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 88 | * the resulting decode should match. |
| 89 | */ |
scroggo | 7b5e553 | 2016-02-04 06:14:24 -0800 | [diff] [blame] | 90 | template<typename Codec> |
| 91 | static void test_info(skiatest::Reporter* r, Codec* codec, const SkImageInfo& info, |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 92 | SkCodec::Result expectedResult, const SkMD5::Digest* goodDigest) { |
| 93 | SkBitmap bm; |
| 94 | bm.allocPixels(info); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 95 | |
| 96 | SkCodec::Result result = codec->getPixels(info, bm.getPixels(), bm.rowBytes()); |
| 97 | REPORTER_ASSERT(r, result == expectedResult); |
| 98 | |
| 99 | if (goodDigest) { |
| 100 | compare_to_good_digest(r, *goodDigest, bm); |
| 101 | } |
| 102 | } |
| 103 | |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 104 | SkIRect generate_random_subset(SkRandom* rand, int w, int h) { |
| 105 | SkIRect rect; |
| 106 | do { |
| 107 | rect.fLeft = rand->nextRangeU(0, w); |
| 108 | rect.fTop = rand->nextRangeU(0, h); |
| 109 | rect.fRight = rand->nextRangeU(0, w); |
| 110 | rect.fBottom = rand->nextRangeU(0, h); |
| 111 | rect.sort(); |
| 112 | } while (rect.isEmpty()); |
| 113 | return rect; |
| 114 | } |
| 115 | |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 116 | static void test_incremental_decode(skiatest::Reporter* r, SkCodec* codec, const SkImageInfo& info, |
| 117 | const SkMD5::Digest& goodDigest) { |
| 118 | SkBitmap bm; |
| 119 | bm.allocPixels(info); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 120 | |
| 121 | REPORTER_ASSERT(r, SkCodec::kSuccess == codec->startIncrementalDecode(info, bm.getPixels(), |
| 122 | bm.rowBytes())); |
| 123 | |
| 124 | REPORTER_ASSERT(r, SkCodec::kSuccess == codec->incrementalDecode()); |
| 125 | |
| 126 | compare_to_good_digest(r, goodDigest, bm); |
| 127 | } |
| 128 | |
| 129 | // Test in stripes, similar to DM's kStripe_Mode |
| 130 | static void test_in_stripes(skiatest::Reporter* r, SkCodec* codec, const SkImageInfo& info, |
| 131 | const SkMD5::Digest& goodDigest) { |
| 132 | SkBitmap bm; |
| 133 | bm.allocPixels(info); |
| 134 | bm.eraseColor(SK_ColorYELLOW); |
| 135 | |
| 136 | const int height = info.height(); |
| 137 | // Note that if numStripes does not evenly divide height there will be an extra |
| 138 | // stripe. |
| 139 | const int numStripes = 4; |
| 140 | |
| 141 | if (numStripes > height) { |
| 142 | // Image is too small. |
| 143 | return; |
| 144 | } |
| 145 | |
| 146 | const int stripeHeight = height / numStripes; |
| 147 | |
| 148 | // Iterate through the image twice. Once to decode odd stripes, and once for even. |
| 149 | for (int oddEven = 1; oddEven >= 0; oddEven--) { |
| 150 | for (int y = oddEven * stripeHeight; y < height; y += 2 * stripeHeight) { |
| 151 | SkIRect subset = SkIRect::MakeLTRB(0, y, info.width(), |
| 152 | SkTMin(y + stripeHeight, height)); |
| 153 | SkCodec::Options options; |
| 154 | options.fSubset = ⊂ |
| 155 | if (SkCodec::kSuccess != codec->startIncrementalDecode(info, bm.getAddr(0, y), |
| 156 | bm.rowBytes(), &options)) { |
| 157 | ERRORF(r, "failed to start incremental decode!\ttop: %i\tbottom%i\n", |
| 158 | subset.top(), subset.bottom()); |
| 159 | return; |
| 160 | } |
| 161 | if (SkCodec::kSuccess != codec->incrementalDecode()) { |
| 162 | ERRORF(r, "failed incremental decode starting from line %i\n", y); |
| 163 | return; |
| 164 | } |
| 165 | } |
| 166 | } |
| 167 | |
| 168 | compare_to_good_digest(r, goodDigest, bm); |
| 169 | } |
| 170 | |
scroggo | 7b5e553 | 2016-02-04 06:14:24 -0800 | [diff] [blame] | 171 | template<typename Codec> |
Leon Scroggins III | b41321b | 2018-12-11 10:37:07 -0500 | [diff] [blame] | 172 | static void test_codec(skiatest::Reporter* r, const char* path, Codec* codec, SkBitmap& bm, |
| 173 | const SkImageInfo& info, const SkISize& size, SkCodec::Result expectedResult, |
| 174 | SkMD5::Digest* digest, const SkMD5::Digest* goodDigest) { |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 175 | |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 176 | REPORTER_ASSERT(r, info.dimensions() == size); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 177 | bm.allocPixels(info); |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 178 | |
| 179 | SkCodec::Result result = codec->getPixels(info, bm.getPixels(), bm.rowBytes()); |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 180 | REPORTER_ASSERT(r, result == expectedResult); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 181 | |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 182 | md5(bm, digest); |
| 183 | if (goodDigest) { |
| 184 | REPORTER_ASSERT(r, *digest == *goodDigest); |
| 185 | } |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 186 | |
msarett | 8ff6ca6 | 2015-09-18 12:06:04 -0700 | [diff] [blame] | 187 | { |
| 188 | // Test decoding to 565 |
| 189 | SkImageInfo info565 = info.makeColorType(kRGB_565_SkColorType); |
scroggo | ba58489 | 2016-05-20 13:56:13 -0700 | [diff] [blame] | 190 | if (info.alphaType() == kOpaque_SkAlphaType) { |
| 191 | // Decoding to 565 should succeed. |
| 192 | SkBitmap bm565; |
| 193 | bm565.allocPixels(info565); |
scroggo | ba58489 | 2016-05-20 13:56:13 -0700 | [diff] [blame] | 194 | |
| 195 | // This will allow comparison even if the image is incomplete. |
| 196 | bm565.eraseColor(SK_ColorBLACK); |
| 197 | |
Leon Scroggins III | b41321b | 2018-12-11 10:37:07 -0500 | [diff] [blame] | 198 | auto actualResult = codec->getPixels(info565, bm565.getPixels(), bm565.rowBytes()); |
| 199 | if (actualResult == expectedResult) { |
| 200 | SkMD5::Digest digest565; |
| 201 | md5(bm565, &digest565); |
scroggo | ba58489 | 2016-05-20 13:56:13 -0700 | [diff] [blame] | 202 | |
Leon Scroggins III | b41321b | 2018-12-11 10:37:07 -0500 | [diff] [blame] | 203 | // A request for non-opaque should also succeed. |
| 204 | for (auto alpha : { kPremul_SkAlphaType, kUnpremul_SkAlphaType }) { |
| 205 | info565 = info565.makeAlphaType(alpha); |
| 206 | test_info(r, codec, info565, expectedResult, &digest565); |
| 207 | } |
| 208 | } else { |
| 209 | ERRORF(r, "Decoding %s to 565 failed with result \"%s\"\n\t\t\t\texpected:\"%s\"", |
| 210 | path, |
| 211 | SkCodec::ResultToString(actualResult), |
| 212 | SkCodec::ResultToString(expectedResult)); |
scroggo | ba58489 | 2016-05-20 13:56:13 -0700 | [diff] [blame] | 213 | } |
| 214 | } else { |
| 215 | test_info(r, codec, info565, SkCodec::kInvalidConversion, nullptr); |
| 216 | } |
| 217 | } |
| 218 | |
| 219 | if (codec->getInfo().colorType() == kGray_8_SkColorType) { |
| 220 | SkImageInfo grayInfo = codec->getInfo(); |
| 221 | SkBitmap grayBm; |
| 222 | grayBm.allocPixels(grayInfo); |
scroggo | ba58489 | 2016-05-20 13:56:13 -0700 | [diff] [blame] | 223 | |
| 224 | grayBm.eraseColor(SK_ColorBLACK); |
| 225 | |
| 226 | REPORTER_ASSERT(r, expectedResult == codec->getPixels(grayInfo, |
| 227 | grayBm.getPixels(), grayBm.rowBytes())); |
| 228 | |
| 229 | SkMD5::Digest grayDigest; |
| 230 | md5(grayBm, &grayDigest); |
| 231 | |
| 232 | for (auto alpha : { kPremul_SkAlphaType, kUnpremul_SkAlphaType }) { |
| 233 | grayInfo = grayInfo.makeAlphaType(alpha); |
| 234 | test_info(r, codec, grayInfo, expectedResult, &grayDigest); |
| 235 | } |
msarett | 8ff6ca6 | 2015-09-18 12:06:04 -0700 | [diff] [blame] | 236 | } |
| 237 | |
| 238 | // Verify that re-decoding gives the same result. It is interesting to check this after |
| 239 | // a decode to 565, since choosing to decode to 565 may result in some of the decode |
| 240 | // options being modified. These options should return to their defaults on another |
| 241 | // decode to kN32, so the new digest should match the old digest. |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 242 | test_info(r, codec, info, expectedResult, digest); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 243 | |
| 244 | { |
| 245 | // Check alpha type conversions |
| 246 | if (info.alphaType() == kOpaque_SkAlphaType) { |
| 247 | test_info(r, codec, info.makeAlphaType(kUnpremul_SkAlphaType), |
scroggo | c5560be | 2016-02-03 09:42:42 -0800 | [diff] [blame] | 248 | expectedResult, digest); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 249 | test_info(r, codec, info.makeAlphaType(kPremul_SkAlphaType), |
scroggo | c5560be | 2016-02-03 09:42:42 -0800 | [diff] [blame] | 250 | expectedResult, digest); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 251 | } else { |
| 252 | // Decoding to opaque should fail |
| 253 | test_info(r, codec, info.makeAlphaType(kOpaque_SkAlphaType), |
halcanary | 96fcdcc | 2015-08-27 07:41:13 -0700 | [diff] [blame] | 254 | SkCodec::kInvalidConversion, nullptr); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 255 | SkAlphaType otherAt = info.alphaType(); |
| 256 | if (kPremul_SkAlphaType == otherAt) { |
| 257 | otherAt = kUnpremul_SkAlphaType; |
| 258 | } else { |
| 259 | otherAt = kPremul_SkAlphaType; |
| 260 | } |
| 261 | // The other non-opaque alpha type should always succeed, but not match. |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 262 | test_info(r, codec, info.makeAlphaType(otherAt), expectedResult, nullptr); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 263 | } |
| 264 | } |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 265 | } |
| 266 | |
scroggo | bed1ed6 | 2016-02-11 10:24:55 -0800 | [diff] [blame] | 267 | static bool supports_partial_scanlines(const char path[]) { |
scroggo | 2c3b218 | 2015-10-09 08:40:59 -0700 | [diff] [blame] | 268 | static const char* const exts[] = { |
| 269 | "jpg", "jpeg", "png", "webp" |
| 270 | "JPG", "JPEG", "PNG", "WEBP" |
| 271 | }; |
| 272 | |
| 273 | for (uint32_t i = 0; i < SK_ARRAY_COUNT(exts); i++) { |
| 274 | if (SkStrEndsWith(path, exts[i])) { |
| 275 | return true; |
| 276 | } |
| 277 | } |
| 278 | return false; |
| 279 | } |
| 280 | |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 281 | // FIXME: Break up this giant function |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 282 | static void check(skiatest::Reporter* r, |
| 283 | const char path[], |
| 284 | SkISize size, |
| 285 | bool supportsScanlineDecoding, |
| 286 | bool supportsSubsetDecoding, |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 287 | bool supportsIncomplete, |
| 288 | bool supportsNewScanlineDecoding = false) { |
Nigel Tao | 9b9453e | 2018-08-01 09:59:38 +1000 | [diff] [blame] | 289 | // If we're testing incomplete decodes, let's run the same test on full decodes. |
| 290 | if (supportsIncomplete) { |
| 291 | check(r, path, size, supportsScanlineDecoding, supportsSubsetDecoding, false, |
| 292 | supportsNewScanlineDecoding); |
| 293 | } |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 294 | |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 295 | std::unique_ptr<SkStream> stream(GetResourceAsStream(path)); |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 296 | if (!stream) { |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 297 | return; |
| 298 | } |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 299 | |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 300 | std::unique_ptr<SkCodec> codec(nullptr); |
Nigel Tao | 9b9453e | 2018-08-01 09:59:38 +1000 | [diff] [blame] | 301 | if (supportsIncomplete) { |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 302 | size_t size = stream->getLength(); |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 303 | codec = SkCodec::MakeFromData(SkData::MakeFromStream(stream.get(), 2 * size / 3)); |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 304 | } else { |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 305 | codec = SkCodec::MakeFromStream(std::move(stream)); |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 306 | } |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 307 | if (!codec) { |
| 308 | ERRORF(r, "Unable to decode '%s'", path); |
| 309 | return; |
| 310 | } |
| 311 | |
| 312 | // Test full image decodes with SkCodec |
| 313 | SkMD5::Digest codecDigest; |
scroggo | ef0fed3 | 2016-02-18 05:59:25 -0800 | [diff] [blame] | 314 | const SkImageInfo info = codec->getInfo().makeColorType(kN32_SkColorType); |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 315 | SkBitmap bm; |
Nigel Tao | 9b9453e | 2018-08-01 09:59:38 +1000 | [diff] [blame] | 316 | SkCodec::Result expectedResult = |
| 317 | supportsIncomplete ? SkCodec::kIncompleteInput : SkCodec::kSuccess; |
Leon Scroggins III | b41321b | 2018-12-11 10:37:07 -0500 | [diff] [blame] | 318 | test_codec(r, path, codec.get(), bm, info, size, expectedResult, &codecDigest, nullptr); |
scroggo | d1bc574 | 2015-08-12 08:31:44 -0700 | [diff] [blame] | 319 | |
| 320 | // Scanline decoding follows. |
scroggo | d8d6855 | 2016-06-06 11:26:17 -0700 | [diff] [blame] | 321 | |
Nigel Tao | 9b9453e | 2018-08-01 09:59:38 +1000 | [diff] [blame] | 322 | if (supportsNewScanlineDecoding && !supportsIncomplete) { |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 323 | test_incremental_decode(r, codec.get(), info, codecDigest); |
scroggo | 19b9153 | 2016-10-24 09:03:26 -0700 | [diff] [blame] | 324 | // This is only supported by codecs that use incremental decoding to |
| 325 | // support subset decodes - png and jpeg (once SkJpegCodec is |
| 326 | // converted). |
| 327 | if (SkStrEndsWith(path, "png") || SkStrEndsWith(path, "PNG")) { |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 328 | test_in_stripes(r, codec.get(), info, codecDigest); |
scroggo | 19b9153 | 2016-10-24 09:03:26 -0700 | [diff] [blame] | 329 | } |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 330 | } |
| 331 | |
| 332 | // Need to call startScanlineDecode() first. |
| 333 | REPORTER_ASSERT(r, codec->getScanlines(bm.getAddr(0, 0), 1, 0) == 0); |
| 334 | REPORTER_ASSERT(r, !codec->skipScanlines(1)); |
scroggo | 46c5747 | 2015-09-30 08:57:13 -0700 | [diff] [blame] | 335 | const SkCodec::Result startResult = codec->startScanlineDecode(info); |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 336 | if (supportsScanlineDecoding) { |
| 337 | bm.eraseColor(SK_ColorYELLOW); |
msarett | c0e80c1 | 2015-07-01 06:50:35 -0700 | [diff] [blame] | 338 | |
scroggo | 46c5747 | 2015-09-30 08:57:13 -0700 | [diff] [blame] | 339 | REPORTER_ASSERT(r, startResult == SkCodec::kSuccess); |
scroggo | 9b2cdbf4 | 2015-07-10 12:07:02 -0700 | [diff] [blame] | 340 | |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 341 | for (int y = 0; y < info.height(); y++) { |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 342 | const int lines = codec->getScanlines(bm.getAddr(0, y), 1, 0); |
Nigel Tao | 9b9453e | 2018-08-01 09:59:38 +1000 | [diff] [blame] | 343 | if (!supportsIncomplete) { |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 344 | REPORTER_ASSERT(r, 1 == lines); |
| 345 | } |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 346 | } |
| 347 | // verify that scanline decoding gives the same result. |
scroggo | 46c5747 | 2015-09-30 08:57:13 -0700 | [diff] [blame] | 348 | if (SkCodec::kTopDown_SkScanlineOrder == codec->getScanlineOrder()) { |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 349 | compare_to_good_digest(r, codecDigest, bm); |
msarett | 5406d6f | 2015-08-31 06:55:13 -0700 | [diff] [blame] | 350 | } |
scroggo | 46c5747 | 2015-09-30 08:57:13 -0700 | [diff] [blame] | 351 | |
| 352 | // Cannot continue to decode scanlines beyond the end |
| 353 | REPORTER_ASSERT(r, codec->getScanlines(bm.getAddr(0, 0), 1, 0) |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 354 | == 0); |
scroggo | 46c5747 | 2015-09-30 08:57:13 -0700 | [diff] [blame] | 355 | |
| 356 | // Interrupting a scanline decode with a full decode starts from |
| 357 | // scratch |
| 358 | REPORTER_ASSERT(r, codec->startScanlineDecode(info) == SkCodec::kSuccess); |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 359 | const int lines = codec->getScanlines(bm.getAddr(0, 0), 1, 0); |
Nigel Tao | 9b9453e | 2018-08-01 09:59:38 +1000 | [diff] [blame] | 360 | if (!supportsIncomplete) { |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 361 | REPORTER_ASSERT(r, lines == 1); |
| 362 | } |
scroggo | 46c5747 | 2015-09-30 08:57:13 -0700 | [diff] [blame] | 363 | REPORTER_ASSERT(r, codec->getPixels(bm.info(), bm.getPixels(), bm.rowBytes()) |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 364 | == expectedResult); |
scroggo | 46c5747 | 2015-09-30 08:57:13 -0700 | [diff] [blame] | 365 | REPORTER_ASSERT(r, codec->getScanlines(bm.getAddr(0, 0), 1, 0) |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 366 | == 0); |
scroggo | 46c5747 | 2015-09-30 08:57:13 -0700 | [diff] [blame] | 367 | REPORTER_ASSERT(r, codec->skipScanlines(1) |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 368 | == 0); |
msarett | 80803ff | 2015-10-16 10:54:12 -0700 | [diff] [blame] | 369 | |
| 370 | // Test partial scanline decodes |
scroggo | bed1ed6 | 2016-02-11 10:24:55 -0800 | [diff] [blame] | 371 | if (supports_partial_scanlines(path) && info.width() >= 3) { |
msarett | 80803ff | 2015-10-16 10:54:12 -0700 | [diff] [blame] | 372 | SkCodec::Options options; |
| 373 | int width = info.width(); |
| 374 | int height = info.height(); |
| 375 | SkIRect subset = SkIRect::MakeXYWH(2 * (width / 3), 0, width / 3, height); |
| 376 | options.fSubset = ⊂ |
| 377 | |
Leon Scroggins | 571b30f | 2017-07-11 17:35:31 +0000 | [diff] [blame] | 378 | const auto partialStartResult = codec->startScanlineDecode(info, &options); |
msarett | 80803ff | 2015-10-16 10:54:12 -0700 | [diff] [blame] | 379 | REPORTER_ASSERT(r, partialStartResult == SkCodec::kSuccess); |
| 380 | |
| 381 | for (int y = 0; y < height; y++) { |
| 382 | const int lines = codec->getScanlines(bm.getAddr(0, y), 1, 0); |
Nigel Tao | 9b9453e | 2018-08-01 09:59:38 +1000 | [diff] [blame] | 383 | if (!supportsIncomplete) { |
msarett | 80803ff | 2015-10-16 10:54:12 -0700 | [diff] [blame] | 384 | REPORTER_ASSERT(r, 1 == lines); |
| 385 | } |
| 386 | } |
| 387 | } |
scroggo | 5842154 | 2015-04-01 11:25:20 -0700 | [diff] [blame] | 388 | } else { |
scroggo | 46c5747 | 2015-09-30 08:57:13 -0700 | [diff] [blame] | 389 | REPORTER_ASSERT(r, startResult == SkCodec::kUnimplemented); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 390 | } |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 391 | |
| 392 | // The rest of this function tests decoding subsets, and will decode an arbitrary number of |
| 393 | // random subsets. |
| 394 | // Do not attempt to decode subsets of an image of only once pixel, since there is no |
| 395 | // meaningful subset. |
| 396 | if (size.width() * size.height() == 1) { |
| 397 | return; |
| 398 | } |
| 399 | |
| 400 | SkRandom rand; |
| 401 | SkIRect subset; |
| 402 | SkCodec::Options opts; |
| 403 | opts.fSubset = ⊂ |
| 404 | for (int i = 0; i < 5; i++) { |
| 405 | subset = generate_random_subset(&rand, size.width(), size.height()); |
| 406 | SkASSERT(!subset.isEmpty()); |
| 407 | const bool supported = codec->getValidSubset(&subset); |
| 408 | REPORTER_ASSERT(r, supported == supportsSubsetDecoding); |
| 409 | |
| 410 | SkImageInfo subsetInfo = info.makeWH(subset.width(), subset.height()); |
| 411 | SkBitmap bm; |
| 412 | bm.allocPixels(subsetInfo); |
Leon Scroggins | 571b30f | 2017-07-11 17:35:31 +0000 | [diff] [blame] | 413 | const auto result = codec->getPixels(bm.info(), bm.getPixels(), bm.rowBytes(), &opts); |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 414 | |
| 415 | if (supportsSubsetDecoding) { |
Leon Scroggins III | 58f100c | 2016-12-20 09:49:25 -0500 | [diff] [blame] | 416 | if (expectedResult == SkCodec::kSuccess) { |
| 417 | REPORTER_ASSERT(r, result == expectedResult); |
Leon Scroggins III | 58f100c | 2016-12-20 09:49:25 -0500 | [diff] [blame] | 418 | } |
scroggo | b636b45 | 2015-07-22 07:16:20 -0700 | [diff] [blame] | 419 | // Webp is the only codec that supports subsets, and it will have modified the subset |
| 420 | // to have even left/top. |
| 421 | REPORTER_ASSERT(r, SkIsAlign2(subset.fLeft) && SkIsAlign2(subset.fTop)); |
| 422 | } else { |
| 423 | // No subsets will work. |
| 424 | REPORTER_ASSERT(r, result == SkCodec::kUnimplemented); |
| 425 | } |
| 426 | } |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 427 | |
scroggo | bed1ed6 | 2016-02-11 10:24:55 -0800 | [diff] [blame] | 428 | // SkAndroidCodec tests |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 429 | if (supportsScanlineDecoding || supportsSubsetDecoding || supportsNewScanlineDecoding) { |
scroggo | 2c3b218 | 2015-10-09 08:40:59 -0700 | [diff] [blame] | 430 | |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 431 | std::unique_ptr<SkStream> stream(GetResourceAsStream(path)); |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 432 | if (!stream) { |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 433 | return; |
| 434 | } |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 435 | |
Leon Scroggins III | 7397d7a | 2018-01-04 13:26:30 -0500 | [diff] [blame] | 436 | auto androidCodec = SkAndroidCodec::MakeFromCodec(std::move(codec)); |
scroggo | 7b5e553 | 2016-02-04 06:14:24 -0800 | [diff] [blame] | 437 | if (!androidCodec) { |
msarett | cc7f305 | 2015-10-05 14:20:27 -0700 | [diff] [blame] | 438 | ERRORF(r, "Unable to decode '%s'", path); |
| 439 | return; |
| 440 | } |
| 441 | |
| 442 | SkBitmap bm; |
scroggo | bed1ed6 | 2016-02-11 10:24:55 -0800 | [diff] [blame] | 443 | SkMD5::Digest androidCodecDigest; |
Leon Scroggins III | b41321b | 2018-12-11 10:37:07 -0500 | [diff] [blame] | 444 | test_codec(r, path, androidCodec.get(), bm, info, size, expectedResult, &androidCodecDigest, |
scroggo | 7b5e553 | 2016-02-04 06:14:24 -0800 | [diff] [blame] | 445 | &codecDigest); |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 446 | } |
| 447 | |
Nigel Tao | 9b9453e | 2018-08-01 09:59:38 +1000 | [diff] [blame] | 448 | if (!supportsIncomplete) { |
scroggo | ef0fed3 | 2016-02-18 05:59:25 -0800 | [diff] [blame] | 449 | // Test SkCodecImageGenerator |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 450 | std::unique_ptr<SkStream> stream(GetResourceAsStream(path)); |
| 451 | sk_sp<SkData> fullData(SkData::MakeFromStream(stream.get(), stream->getLength())); |
| 452 | std::unique_ptr<SkImageGenerator> gen( |
Mike Reed | 185130c | 2017-02-15 15:14:16 -0500 | [diff] [blame] | 453 | SkCodecImageGenerator::MakeFromEncodedCodec(fullData)); |
msarett | edd2dcf | 2016-01-14 13:12:26 -0800 | [diff] [blame] | 454 | SkBitmap bm; |
| 455 | bm.allocPixels(info); |
msarett | edd2dcf | 2016-01-14 13:12:26 -0800 | [diff] [blame] | 456 | REPORTER_ASSERT(r, gen->getPixels(info, bm.getPixels(), bm.rowBytes())); |
| 457 | compare_to_good_digest(r, codecDigest, bm); |
scroggo | ef0fed3 | 2016-02-18 05:59:25 -0800 | [diff] [blame] | 458 | |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 459 | #ifndef SK_PNG_DISABLE_TESTS |
scroggo | d8d6855 | 2016-06-06 11:26:17 -0700 | [diff] [blame] | 460 | // Test using SkFrontBufferedStream, as Android does |
Mike Reed | 98c5d92 | 2017-09-15 21:39:47 -0400 | [diff] [blame] | 461 | auto bufferedStream = SkFrontBufferedStream::Make( |
| 462 | SkMemoryStream::Make(std::move(fullData)), SkCodec::MinBufferedBytesNeeded()); |
scroggo | d8d6855 | 2016-06-06 11:26:17 -0700 | [diff] [blame] | 463 | REPORTER_ASSERT(r, bufferedStream); |
Mike Reed | 98c5d92 | 2017-09-15 21:39:47 -0400 | [diff] [blame] | 464 | codec = SkCodec::MakeFromStream(std::move(bufferedStream)); |
scroggo | d8d6855 | 2016-06-06 11:26:17 -0700 | [diff] [blame] | 465 | REPORTER_ASSERT(r, codec); |
| 466 | if (codec) { |
| 467 | test_info(r, codec.get(), info, SkCodec::kSuccess, &codecDigest); |
scroggo | ef0fed3 | 2016-02-18 05:59:25 -0800 | [diff] [blame] | 468 | } |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 469 | #endif |
msarett | edd2dcf | 2016-01-14 13:12:26 -0800 | [diff] [blame] | 470 | } |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 471 | } |
| 472 | |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 473 | DEF_TEST(Codec_wbmp, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 474 | check(r, "images/mandrill.wbmp", SkISize::Make(512, 512), true, false, true); |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 475 | } |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 476 | |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 477 | DEF_TEST(Codec_webp, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 478 | check(r, "images/baby_tux.webp", SkISize::Make(386, 395), false, true, true); |
| 479 | check(r, "images/color_wheel.webp", SkISize::Make(128, 128), false, true, true); |
| 480 | check(r, "images/yellow_rose.webp", SkISize::Make(400, 301), false, true, true); |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 481 | } |
scroggo | 6f5e619 | 2015-06-18 12:53:43 -0700 | [diff] [blame] | 482 | |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 483 | DEF_TEST(Codec_bmp, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 484 | check(r, "images/randPixels.bmp", SkISize::Make(8, 8), true, false, true); |
| 485 | check(r, "images/rle.bmp", SkISize::Make(320, 240), true, false, true); |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 486 | } |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 487 | |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 488 | DEF_TEST(Codec_ico, r) { |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 489 | // FIXME: We are not ready to test incomplete ICOs |
msarett | 68b204e | 2015-04-01 12:09:21 -0700 | [diff] [blame] | 490 | // These two tests examine interestingly different behavior: |
| 491 | // Decodes an embedded BMP image |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 492 | check(r, "images/color_wheel.ico", SkISize::Make(128, 128), true, false, false); |
msarett | 68b204e | 2015-04-01 12:09:21 -0700 | [diff] [blame] | 493 | // Decodes an embedded PNG image |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 494 | check(r, "images/google_chrome.ico", SkISize::Make(256, 256), false, false, false, true); |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 495 | } |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 496 | |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 497 | DEF_TEST(Codec_gif, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 498 | check(r, "images/box.gif", SkISize::Make(200, 55), false, false, true, true); |
| 499 | check(r, "images/color_wheel.gif", SkISize::Make(128, 128), false, false, true, true); |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 500 | // randPixels.gif is too small to test incomplete |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 501 | check(r, "images/randPixels.gif", SkISize::Make(8, 8), false, false, false, true); |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 502 | } |
msarett | 438b2ad | 2015-04-09 12:43:10 -0700 | [diff] [blame] | 503 | |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 504 | DEF_TEST(Codec_jpg, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 505 | check(r, "images/CMYK.jpg", SkISize::Make(642, 516), true, false, true); |
| 506 | check(r, "images/color_wheel.jpg", SkISize::Make(128, 128), true, false, true); |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 507 | // grayscale.jpg is too small to test incomplete |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 508 | check(r, "images/grayscale.jpg", SkISize::Make(128, 128), true, false, false); |
| 509 | check(r, "images/mandrill_512_q075.jpg", SkISize::Make(512, 512), true, false, true); |
msarett | e6dd004 | 2015-10-09 11:07:34 -0700 | [diff] [blame] | 510 | // randPixels.jpg is too small to test incomplete |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 511 | check(r, "images/randPixels.jpg", SkISize::Make(8, 8), true, false, false); |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 512 | } |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 513 | |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 514 | DEF_TEST(Codec_png, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 515 | check(r, "images/arrow.png", SkISize::Make(187, 312), false, false, true, true); |
| 516 | check(r, "images/baby_tux.png", SkISize::Make(240, 246), false, false, true, true); |
| 517 | check(r, "images/color_wheel.png", SkISize::Make(128, 128), false, false, true, true); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 518 | // half-transparent-white-pixel.png is too small to test incomplete |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 519 | check(r, "images/half-transparent-white-pixel.png", SkISize::Make(1, 1), false, false, false, true); |
| 520 | check(r, "images/mandrill_128.png", SkISize::Make(128, 128), false, false, true, true); |
Brian Osman | ccb21bf | 2018-07-09 14:57:48 -0400 | [diff] [blame] | 521 | // mandrill_16.png is too small (relative to embedded sRGB profile) to test incomplete |
| 522 | check(r, "images/mandrill_16.png", SkISize::Make(16, 16), false, false, false, true); |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 523 | check(r, "images/mandrill_256.png", SkISize::Make(256, 256), false, false, true, true); |
| 524 | check(r, "images/mandrill_32.png", SkISize::Make(32, 32), false, false, true, true); |
| 525 | check(r, "images/mandrill_512.png", SkISize::Make(512, 512), false, false, true, true); |
| 526 | check(r, "images/mandrill_64.png", SkISize::Make(64, 64), false, false, true, true); |
| 527 | check(r, "images/plane.png", SkISize::Make(250, 126), false, false, true, true); |
| 528 | check(r, "images/plane_interlaced.png", SkISize::Make(250, 126), false, false, true, true); |
| 529 | check(r, "images/randPixels.png", SkISize::Make(8, 8), false, false, true, true); |
| 530 | check(r, "images/yellow_rose.png", SkISize::Make(400, 301), false, false, true, true); |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 531 | } |
yujieqin | 916de9f | 2016-01-25 08:26:16 -0800 | [diff] [blame] | 532 | |
yujieqin | f236ee4 | 2016-02-29 07:14:42 -0800 | [diff] [blame] | 533 | // Disable RAW tests for Win32. |
| 534 | #if defined(SK_CODEC_DECODES_RAW) && (!defined(_WIN32)) |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 535 | DEF_TEST(Codec_raw, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 536 | check(r, "images/sample_1mp.dng", SkISize::Make(600, 338), false, false, false); |
| 537 | check(r, "images/sample_1mp_rotated.dng", SkISize::Make(600, 338), false, false, false); |
| 538 | check(r, "images/dng_with_preview.dng", SkISize::Make(600, 338), true, false, false); |
halcanary | a096d7a | 2015-03-27 12:16:53 -0700 | [diff] [blame] | 539 | } |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 540 | #endif |
scroggo | 0a7e69c | 2015-04-03 07:22:22 -0700 | [diff] [blame] | 541 | |
| 542 | static void test_invalid_stream(skiatest::Reporter* r, const void* stream, size_t len) { |
scroggo | 2c3b218 | 2015-10-09 08:40:59 -0700 | [diff] [blame] | 543 | // Neither of these calls should return a codec. Bots should catch us if we leaked anything. |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 544 | REPORTER_ASSERT(r, !SkCodec::MakeFromStream( |
| 545 | skstd::make_unique<SkMemoryStream>(stream, len, false))); |
| 546 | REPORTER_ASSERT(r, !SkAndroidCodec::MakeFromStream( |
| 547 | skstd::make_unique<SkMemoryStream>(stream, len, false))); |
scroggo | 0a7e69c | 2015-04-03 07:22:22 -0700 | [diff] [blame] | 548 | } |
| 549 | |
| 550 | // Ensure that SkCodec::NewFromStream handles freeing the passed in SkStream, |
| 551 | // even on failure. Test some bad streams. |
| 552 | DEF_TEST(Codec_leaks, r) { |
| 553 | // No codec should claim this as their format, so this tests SkCodec::NewFromStream. |
| 554 | const char nonSupportedStream[] = "hello world"; |
| 555 | // The other strings should look like the beginning of a file type, so we'll call some |
| 556 | // internal version of NewFromStream, which must also delete the stream on failure. |
| 557 | const unsigned char emptyPng[] = { 0x89, 0x50, 0x4e, 0x47, 0x0d, 0x0a, 0x1a, 0x0a }; |
| 558 | const unsigned char emptyJpeg[] = { 0xFF, 0xD8, 0xFF }; |
| 559 | const char emptyWebp[] = "RIFF1234WEBPVP"; |
| 560 | const char emptyBmp[] = { 'B', 'M' }; |
| 561 | const char emptyIco[] = { '\x00', '\x00', '\x01', '\x00' }; |
| 562 | const char emptyGif[] = "GIFVER"; |
| 563 | |
| 564 | test_invalid_stream(r, nonSupportedStream, sizeof(nonSupportedStream)); |
| 565 | test_invalid_stream(r, emptyPng, sizeof(emptyPng)); |
| 566 | test_invalid_stream(r, emptyJpeg, sizeof(emptyJpeg)); |
| 567 | test_invalid_stream(r, emptyWebp, sizeof(emptyWebp)); |
| 568 | test_invalid_stream(r, emptyBmp, sizeof(emptyBmp)); |
| 569 | test_invalid_stream(r, emptyIco, sizeof(emptyIco)); |
| 570 | test_invalid_stream(r, emptyGif, sizeof(emptyGif)); |
| 571 | } |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 572 | |
scroggo | 2c3b218 | 2015-10-09 08:40:59 -0700 | [diff] [blame] | 573 | DEF_TEST(Codec_null, r) { |
scroggo | bed1ed6 | 2016-02-11 10:24:55 -0800 | [diff] [blame] | 574 | // Attempting to create an SkCodec or an SkAndroidCodec with null should not |
scroggo | 2c3b218 | 2015-10-09 08:40:59 -0700 | [diff] [blame] | 575 | // crash. |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 576 | REPORTER_ASSERT(r, !SkCodec::MakeFromStream(nullptr)); |
| 577 | REPORTER_ASSERT(r, !SkAndroidCodec::MakeFromStream(nullptr)); |
scroggo | 2c3b218 | 2015-10-09 08:40:59 -0700 | [diff] [blame] | 578 | } |
| 579 | |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 580 | static void test_dimensions(skiatest::Reporter* r, const char path[]) { |
| 581 | // Create the codec from the resource file |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 582 | std::unique_ptr<SkStream> stream(GetResourceAsStream(path)); |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 583 | if (!stream) { |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 584 | return; |
| 585 | } |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 586 | std::unique_ptr<SkAndroidCodec> codec(SkAndroidCodec::MakeFromStream(std::move(stream))); |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 587 | if (!codec) { |
| 588 | ERRORF(r, "Unable to create codec '%s'", path); |
| 589 | return; |
| 590 | } |
| 591 | |
| 592 | // Check that the decode is successful for a variety of scales |
scroggo | 501b734 | 2015-11-03 07:55:11 -0800 | [diff] [blame] | 593 | for (int sampleSize = 1; sampleSize < 32; sampleSize++) { |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 594 | // Scale the output dimensions |
msarett | 3d9d7a7 | 2015-10-21 10:27:10 -0700 | [diff] [blame] | 595 | SkISize scaledDims = codec->getSampledDimensions(sampleSize); |
msarett | b32758a | 2015-08-18 13:22:46 -0700 | [diff] [blame] | 596 | SkImageInfo scaledInfo = codec->getInfo() |
| 597 | .makeWH(scaledDims.width(), scaledDims.height()) |
| 598 | .makeColorType(kN32_SkColorType); |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 599 | |
| 600 | // Set up for the decode |
| 601 | size_t rowBytes = scaledDims.width() * sizeof(SkPMColor); |
Mike Reed | f0ffb89 | 2017-10-03 14:47:21 -0400 | [diff] [blame] | 602 | size_t totalBytes = scaledInfo.computeByteSize(rowBytes); |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 603 | SkAutoTMalloc<SkPMColor> pixels(totalBytes); |
| 604 | |
msarett | 3d9d7a7 | 2015-10-21 10:27:10 -0700 | [diff] [blame] | 605 | SkAndroidCodec::AndroidOptions options; |
| 606 | options.fSampleSize = sampleSize; |
scroggo | eb602a5 | 2015-07-09 08:16:03 -0700 | [diff] [blame] | 607 | SkCodec::Result result = |
msarett | 3d9d7a7 | 2015-10-21 10:27:10 -0700 | [diff] [blame] | 608 | codec->getAndroidPixels(scaledInfo, pixels.get(), rowBytes, &options); |
scroggo | eb602a5 | 2015-07-09 08:16:03 -0700 | [diff] [blame] | 609 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 610 | } |
| 611 | } |
| 612 | |
| 613 | // Ensure that onGetScaledDimensions returns valid image dimensions to use for decodes |
| 614 | DEF_TEST(Codec_Dimensions, r) { |
| 615 | // JPG |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 616 | test_dimensions(r, "images/CMYK.jpg"); |
| 617 | test_dimensions(r, "images/color_wheel.jpg"); |
| 618 | test_dimensions(r, "images/grayscale.jpg"); |
| 619 | test_dimensions(r, "images/mandrill_512_q075.jpg"); |
| 620 | test_dimensions(r, "images/randPixels.jpg"); |
msarett | b32758a | 2015-08-18 13:22:46 -0700 | [diff] [blame] | 621 | |
| 622 | // Decoding small images with very large scaling factors is a potential |
| 623 | // source of bugs and crashes. We disable these tests in Gold because |
| 624 | // tiny images are not very useful to look at. |
| 625 | // Here we make sure that we do not crash or access illegal memory when |
| 626 | // performing scaled decodes on small images. |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 627 | test_dimensions(r, "images/1x1.png"); |
| 628 | test_dimensions(r, "images/2x2.png"); |
| 629 | test_dimensions(r, "images/3x3.png"); |
| 630 | test_dimensions(r, "images/3x1.png"); |
| 631 | test_dimensions(r, "images/1x1.png"); |
| 632 | test_dimensions(r, "images/16x1.png"); |
| 633 | test_dimensions(r, "images/1x16.png"); |
| 634 | test_dimensions(r, "images/mandrill_16.png"); |
msarett | b32758a | 2015-08-18 13:22:46 -0700 | [diff] [blame] | 635 | |
yujieqin | 916de9f | 2016-01-25 08:26:16 -0800 | [diff] [blame] | 636 | // RAW |
yujieqin | f236ee4 | 2016-02-29 07:14:42 -0800 | [diff] [blame] | 637 | // Disable RAW tests for Win32. |
| 638 | #if defined(SK_CODEC_DECODES_RAW) && (!defined(_WIN32)) |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 639 | test_dimensions(r, "images/sample_1mp.dng"); |
| 640 | test_dimensions(r, "images/sample_1mp_rotated.dng"); |
| 641 | test_dimensions(r, "images/dng_with_preview.dng"); |
msarett | 8e49ca3 | 2016-01-25 13:10:58 -0800 | [diff] [blame] | 642 | #endif |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 643 | } |
| 644 | |
msarett | d0375bc | 2015-08-12 08:08:56 -0700 | [diff] [blame] | 645 | static void test_invalid(skiatest::Reporter* r, const char path[]) { |
Leon Scroggins III | fee7cba | 2018-02-13 16:41:03 -0500 | [diff] [blame] | 646 | auto data = GetResourceAsData(path); |
| 647 | if (!data) { |
Leon Scroggins III | ce6d93a | 2018-02-15 09:25:11 -0500 | [diff] [blame] | 648 | ERRORF(r, "Failed to get resource %s", path); |
msarett | 4b17fa3 | 2015-04-23 08:53:39 -0700 | [diff] [blame] | 649 | return; |
| 650 | } |
Leon Scroggins III | fee7cba | 2018-02-13 16:41:03 -0500 | [diff] [blame] | 651 | |
| 652 | REPORTER_ASSERT(r, !SkCodec::MakeFromData(data)); |
msarett | 4b17fa3 | 2015-04-23 08:53:39 -0700 | [diff] [blame] | 653 | } |
msarett | e16b04a | 2015-04-15 07:32:19 -0700 | [diff] [blame] | 654 | |
msarett | 4b17fa3 | 2015-04-23 08:53:39 -0700 | [diff] [blame] | 655 | DEF_TEST(Codec_Empty, r) { |
Leon Scroggins III | fee7cba | 2018-02-13 16:41:03 -0500 | [diff] [blame] | 656 | if (GetResourcePath().isEmpty()) { |
| 657 | return; |
| 658 | } |
| 659 | |
msarett | 4b17fa3 | 2015-04-23 08:53:39 -0700 | [diff] [blame] | 660 | // Test images that should not be able to create a codec |
msarett | d0375bc | 2015-08-12 08:08:56 -0700 | [diff] [blame] | 661 | test_invalid(r, "empty_images/zero-dims.gif"); |
| 662 | test_invalid(r, "empty_images/zero-embedded.ico"); |
| 663 | test_invalid(r, "empty_images/zero-width.bmp"); |
| 664 | test_invalid(r, "empty_images/zero-height.bmp"); |
| 665 | test_invalid(r, "empty_images/zero-width.jpg"); |
| 666 | test_invalid(r, "empty_images/zero-height.jpg"); |
| 667 | test_invalid(r, "empty_images/zero-width.png"); |
| 668 | test_invalid(r, "empty_images/zero-height.png"); |
| 669 | test_invalid(r, "empty_images/zero-width.wbmp"); |
| 670 | test_invalid(r, "empty_images/zero-height.wbmp"); |
| 671 | // This image is an ico with an embedded mask-bmp. This is illegal. |
| 672 | test_invalid(r, "invalid_images/mask-bmp-ico.ico"); |
Matt Sarett | 5c49617 | 2017-02-07 17:01:16 -0500 | [diff] [blame] | 673 | // It is illegal for a webp frame to not be fully contained by the canvas. |
| 674 | test_invalid(r, "invalid_images/invalid-offset.webp"); |
Leon Scroggins III | d87fbee | 2016-12-02 16:47:53 -0500 | [diff] [blame] | 675 | #if defined(SK_CODEC_DECODES_RAW) && (!defined(_WIN32)) |
| 676 | test_invalid(r, "empty_images/zero_height.tiff"); |
| 677 | #endif |
Leon Scroggins III | fc4ee22 | 2017-07-14 11:48:52 -0400 | [diff] [blame] | 678 | test_invalid(r, "invalid_images/b37623797.ico"); |
Leon Scroggins III | fee7cba | 2018-02-13 16:41:03 -0500 | [diff] [blame] | 679 | test_invalid(r, "invalid_images/osfuzz6295.webp"); |
Leon Scroggins III | ce6d93a | 2018-02-15 09:25:11 -0500 | [diff] [blame] | 680 | test_invalid(r, "invalid_images/osfuzz6288.bmp"); |
Leon Scroggins III | 31476b7 | 2018-02-22 16:09:33 -0500 | [diff] [blame] | 681 | test_invalid(r, "invalid_images/ossfuzz6347"); |
msarett | 4b17fa3 | 2015-04-23 08:53:39 -0700 | [diff] [blame] | 682 | } |
msarett | 99f567e | 2015-08-05 12:58:26 -0700 | [diff] [blame] | 683 | |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 684 | #ifdef PNG_READ_UNKNOWN_CHUNKS_SUPPORTED |
| 685 | |
| 686 | #ifndef SK_PNG_DISABLE_TESTS // reading chunks does not work properly with older versions. |
| 687 | // It does not appear that anyone in Google3 is reading chunks. |
| 688 | |
scroggo | cf98fa9 | 2015-11-23 08:14:40 -0800 | [diff] [blame] | 689 | static void codex_test_write_fn(png_structp png_ptr, png_bytep data, png_size_t len) { |
| 690 | SkWStream* sk_stream = (SkWStream*)png_get_io_ptr(png_ptr); |
| 691 | if (!sk_stream->write(data, len)) { |
| 692 | png_error(png_ptr, "sk_write_fn Error!"); |
| 693 | } |
| 694 | } |
| 695 | |
scroggo | cf98fa9 | 2015-11-23 08:14:40 -0800 | [diff] [blame] | 696 | DEF_TEST(Codec_pngChunkReader, r) { |
| 697 | // Create a dummy bitmap. Use unpremul RGBA for libpng. |
| 698 | SkBitmap bm; |
| 699 | const int w = 1; |
| 700 | const int h = 1; |
| 701 | const SkImageInfo bmInfo = SkImageInfo::Make(w, h, kRGBA_8888_SkColorType, |
| 702 | kUnpremul_SkAlphaType); |
| 703 | bm.setInfo(bmInfo); |
| 704 | bm.allocPixels(); |
| 705 | bm.eraseColor(SK_ColorBLUE); |
| 706 | SkMD5::Digest goodDigest; |
| 707 | md5(bm, &goodDigest); |
| 708 | |
| 709 | // Write to a png file. |
| 710 | png_structp png = png_create_write_struct(PNG_LIBPNG_VER_STRING, nullptr, nullptr, nullptr); |
| 711 | REPORTER_ASSERT(r, png); |
| 712 | if (!png) { |
| 713 | return; |
| 714 | } |
| 715 | |
| 716 | png_infop info = png_create_info_struct(png); |
| 717 | REPORTER_ASSERT(r, info); |
| 718 | if (!info) { |
| 719 | png_destroy_write_struct(&png, nullptr); |
| 720 | return; |
| 721 | } |
| 722 | |
| 723 | if (setjmp(png_jmpbuf(png))) { |
| 724 | ERRORF(r, "failed writing png"); |
| 725 | png_destroy_write_struct(&png, &info); |
| 726 | return; |
| 727 | } |
| 728 | |
| 729 | SkDynamicMemoryWStream wStream; |
| 730 | png_set_write_fn(png, (void*) (&wStream), codex_test_write_fn, nullptr); |
| 731 | |
| 732 | png_set_IHDR(png, info, (png_uint_32)w, (png_uint_32)h, 8, |
| 733 | PNG_COLOR_TYPE_RGB_ALPHA, PNG_INTERLACE_NONE, |
| 734 | PNG_COMPRESSION_TYPE_DEFAULT, PNG_FILTER_TYPE_DEFAULT); |
| 735 | |
| 736 | // Create some chunks that match the Android framework's use. |
| 737 | static png_unknown_chunk gUnknowns[] = { |
msarett | 133eaaa | 2016-01-07 11:03:25 -0800 | [diff] [blame] | 738 | { "npOl", (png_byte*)"outline", sizeof("outline"), PNG_HAVE_IHDR }, |
| 739 | { "npLb", (png_byte*)"layoutBounds", sizeof("layoutBounds"), PNG_HAVE_IHDR }, |
| 740 | { "npTc", (png_byte*)"ninePatchData", sizeof("ninePatchData"), PNG_HAVE_IHDR }, |
scroggo | cf98fa9 | 2015-11-23 08:14:40 -0800 | [diff] [blame] | 741 | }; |
| 742 | |
| 743 | png_set_keep_unknown_chunks(png, PNG_HANDLE_CHUNK_ALWAYS, (png_byte*)"npOl\0npLb\0npTc\0", 3); |
| 744 | png_set_unknown_chunks(png, info, gUnknowns, SK_ARRAY_COUNT(gUnknowns)); |
| 745 | #if PNG_LIBPNG_VER < 10600 |
| 746 | /* Deal with unknown chunk location bug in 1.5.x and earlier */ |
msarett | 133eaaa | 2016-01-07 11:03:25 -0800 | [diff] [blame] | 747 | png_set_unknown_chunk_location(png, info, 0, PNG_HAVE_IHDR); |
| 748 | png_set_unknown_chunk_location(png, info, 1, PNG_HAVE_IHDR); |
scroggo | cf98fa9 | 2015-11-23 08:14:40 -0800 | [diff] [blame] | 749 | #endif |
| 750 | |
| 751 | png_write_info(png, info); |
| 752 | |
| 753 | for (int j = 0; j < h; j++) { |
| 754 | png_bytep row = (png_bytep)(bm.getAddr(0, j)); |
| 755 | png_write_rows(png, &row, 1); |
| 756 | } |
| 757 | png_write_end(png, info); |
| 758 | png_destroy_write_struct(&png, &info); |
| 759 | |
| 760 | class ChunkReader : public SkPngChunkReader { |
| 761 | public: |
| 762 | ChunkReader(skiatest::Reporter* r) |
| 763 | : fReporter(r) |
| 764 | { |
| 765 | this->reset(); |
| 766 | } |
| 767 | |
| 768 | bool readChunk(const char tag[], const void* data, size_t length) override { |
| 769 | for (size_t i = 0; i < SK_ARRAY_COUNT(gUnknowns); ++i) { |
| 770 | if (!strcmp(tag, (const char*) gUnknowns[i].name)) { |
| 771 | // Tag matches. This should have been the first time we see it. |
| 772 | REPORTER_ASSERT(fReporter, !fSeen[i]); |
| 773 | fSeen[i] = true; |
| 774 | |
| 775 | // Data and length should match |
| 776 | REPORTER_ASSERT(fReporter, length == gUnknowns[i].size); |
| 777 | REPORTER_ASSERT(fReporter, !strcmp((const char*) data, |
| 778 | (const char*) gUnknowns[i].data)); |
| 779 | return true; |
| 780 | } |
| 781 | } |
| 782 | ERRORF(fReporter, "Saw an unexpected unknown chunk."); |
| 783 | return true; |
| 784 | } |
| 785 | |
| 786 | bool allHaveBeenSeen() { |
| 787 | bool ret = true; |
| 788 | for (auto seen : fSeen) { |
| 789 | ret &= seen; |
| 790 | } |
| 791 | return ret; |
| 792 | } |
| 793 | |
| 794 | void reset() { |
| 795 | sk_bzero(fSeen, sizeof(fSeen)); |
| 796 | } |
| 797 | |
| 798 | private: |
| 799 | skiatest::Reporter* fReporter; // Unowned |
| 800 | bool fSeen[3]; |
| 801 | }; |
| 802 | |
| 803 | ChunkReader chunkReader(r); |
| 804 | |
| 805 | // Now read the file with SkCodec. |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 806 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromData(wStream.detachAsData(), &chunkReader)); |
scroggo | cf98fa9 | 2015-11-23 08:14:40 -0800 | [diff] [blame] | 807 | REPORTER_ASSERT(r, codec); |
| 808 | if (!codec) { |
| 809 | return; |
| 810 | } |
| 811 | |
| 812 | // Now compare to the original. |
| 813 | SkBitmap decodedBm; |
| 814 | decodedBm.setInfo(codec->getInfo()); |
| 815 | decodedBm.allocPixels(); |
| 816 | SkCodec::Result result = codec->getPixels(codec->getInfo(), decodedBm.getPixels(), |
| 817 | decodedBm.rowBytes()); |
| 818 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
| 819 | |
| 820 | if (decodedBm.colorType() != bm.colorType()) { |
| 821 | SkBitmap tmp; |
Matt Sarett | 68b8e3d | 2017-04-28 11:15:22 -0400 | [diff] [blame] | 822 | bool success = sk_tool_utils::copy_to(&tmp, bm.colorType(), decodedBm); |
scroggo | cf98fa9 | 2015-11-23 08:14:40 -0800 | [diff] [blame] | 823 | REPORTER_ASSERT(r, success); |
| 824 | if (!success) { |
| 825 | return; |
| 826 | } |
| 827 | |
| 828 | tmp.swap(decodedBm); |
| 829 | } |
| 830 | |
| 831 | compare_to_good_digest(r, goodDigest, decodedBm); |
| 832 | REPORTER_ASSERT(r, chunkReader.allHaveBeenSeen()); |
| 833 | |
| 834 | // Decoding again will read the chunks again. |
| 835 | chunkReader.reset(); |
| 836 | REPORTER_ASSERT(r, !chunkReader.allHaveBeenSeen()); |
| 837 | result = codec->getPixels(codec->getInfo(), decodedBm.getPixels(), decodedBm.rowBytes()); |
| 838 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
| 839 | REPORTER_ASSERT(r, chunkReader.allHaveBeenSeen()); |
| 840 | } |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 841 | #endif // SK_PNG_DISABLE_TESTS |
scroggo | cf98fa9 | 2015-11-23 08:14:40 -0800 | [diff] [blame] | 842 | #endif // PNG_READ_UNKNOWN_CHUNKS_SUPPORTED |
scroggo | b9a1e34 | 2015-11-30 06:25:31 -0800 | [diff] [blame] | 843 | |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 844 | // Stream that can only peek up to a limit |
| 845 | class LimitedPeekingMemStream : public SkStream { |
| 846 | public: |
reed | 42943c8 | 2016-09-12 12:01:44 -0700 | [diff] [blame] | 847 | LimitedPeekingMemStream(sk_sp<SkData> data, size_t limit) |
| 848 | : fStream(std::move(data)) |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 849 | , fLimit(limit) {} |
| 850 | |
| 851 | size_t peek(void* buf, size_t bytes) const override { |
| 852 | return fStream.peek(buf, SkTMin(bytes, fLimit)); |
| 853 | } |
| 854 | size_t read(void* buf, size_t bytes) override { |
| 855 | return fStream.read(buf, bytes); |
| 856 | } |
| 857 | bool rewind() override { |
| 858 | return fStream.rewind(); |
| 859 | } |
| 860 | bool isAtEnd() const override { |
msarett | ff2a6c8 | 2016-09-07 11:23:28 -0700 | [diff] [blame] | 861 | return fStream.isAtEnd(); |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 862 | } |
| 863 | private: |
| 864 | SkMemoryStream fStream; |
| 865 | const size_t fLimit; |
| 866 | }; |
| 867 | |
yujieqin | f236ee4 | 2016-02-29 07:14:42 -0800 | [diff] [blame] | 868 | // Disable RAW tests for Win32. |
| 869 | #if defined(SK_CODEC_DECODES_RAW) && (!defined(_WIN32)) |
yujieqin | 9c7a8a4 | 2016-02-05 08:21:19 -0800 | [diff] [blame] | 870 | // Test that the RawCodec works also for not asset stream. This will test the code path using |
| 871 | // SkRawBufferedStream instead of SkRawAssetStream. |
yujieqin | 9c7a8a4 | 2016-02-05 08:21:19 -0800 | [diff] [blame] | 872 | DEF_TEST(Codec_raw_notseekable, r) { |
Mike Reed | 0933bc9 | 2017-12-09 01:27:41 +0000 | [diff] [blame] | 873 | constexpr char path[] = "images/dng_with_preview.dng"; |
| 874 | sk_sp<SkData> data(GetResourceAsData(path)); |
yujieqin | 9c7a8a4 | 2016-02-05 08:21:19 -0800 | [diff] [blame] | 875 | if (!data) { |
| 876 | SkDebugf("Missing resource '%s'\n", path); |
| 877 | return; |
| 878 | } |
| 879 | |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 880 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream( |
| 881 | skstd::make_unique<NotAssetMemStream>(std::move(data)))); |
yujieqin | 9c7a8a4 | 2016-02-05 08:21:19 -0800 | [diff] [blame] | 882 | REPORTER_ASSERT(r, codec); |
| 883 | |
| 884 | test_info(r, codec.get(), codec->getInfo(), SkCodec::kSuccess, nullptr); |
| 885 | } |
| 886 | #endif |
| 887 | |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 888 | // Test that even if webp_parse_header fails to peek enough, it will fall back to read() |
| 889 | // + rewind() and succeed. |
| 890 | DEF_TEST(Codec_webp_peek, r) { |
Mike Reed | 0933bc9 | 2017-12-09 01:27:41 +0000 | [diff] [blame] | 891 | constexpr char path[] = "images/baby_tux.webp"; |
| 892 | auto data = GetResourceAsData(path); |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 893 | if (!data) { |
| 894 | SkDebugf("Missing resource '%s'\n", path); |
| 895 | return; |
| 896 | } |
| 897 | |
| 898 | // The limit is less than webp needs to peek or read. |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 899 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream( |
| 900 | skstd::make_unique<LimitedPeekingMemStream>(data, 25))); |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 901 | REPORTER_ASSERT(r, codec); |
| 902 | |
scroggo | 7b5e553 | 2016-02-04 06:14:24 -0800 | [diff] [blame] | 903 | test_info(r, codec.get(), codec->getInfo(), SkCodec::kSuccess, nullptr); |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 904 | |
| 905 | // Similarly, a stream which does not peek should still succeed. |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 906 | codec = SkCodec::MakeFromStream(skstd::make_unique<LimitedPeekingMemStream>(data, 0)); |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 907 | REPORTER_ASSERT(r, codec); |
| 908 | |
scroggo | 7b5e553 | 2016-02-04 06:14:24 -0800 | [diff] [blame] | 909 | test_info(r, codec.get(), codec->getInfo(), SkCodec::kSuccess, nullptr); |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 910 | } |
| 911 | |
msarett | 7f7ec20 | 2016-03-01 12:12:27 -0800 | [diff] [blame] | 912 | // SkCodec's wbmp decoder was initially unnecessarily restrictive. |
| 913 | // It required the second byte to be zero. The wbmp specification allows |
| 914 | // a couple of bits to be 1 (so long as they do not overlap with 0x9F). |
| 915 | // Test that SkCodec now supports an image with these bits set. |
Leon Scroggins III | 8392634 | 2016-12-06 10:58:02 -0500 | [diff] [blame] | 916 | DEF_TEST(Codec_wbmp_restrictive, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 917 | const char* path = "images/mandrill.wbmp"; |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 918 | std::unique_ptr<SkStream> stream(GetResourceAsStream(path)); |
scroggo | b9a1e34 | 2015-11-30 06:25:31 -0800 | [diff] [blame] | 919 | if (!stream) { |
scroggo | b9a1e34 | 2015-11-30 06:25:31 -0800 | [diff] [blame] | 920 | return; |
| 921 | } |
| 922 | |
| 923 | // Modify the stream to contain a second byte with some bits set. |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 924 | auto data = SkCopyStreamToData(stream.get()); |
scroggo | b9a1e34 | 2015-11-30 06:25:31 -0800 | [diff] [blame] | 925 | uint8_t* writeableData = static_cast<uint8_t*>(data->writable_data()); |
| 926 | writeableData[1] = static_cast<uint8_t>(~0x9F); |
| 927 | |
msarett | 7f7ec20 | 2016-03-01 12:12:27 -0800 | [diff] [blame] | 928 | // SkCodec should support this. |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 929 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromData(data)); |
scroggo | b9a1e34 | 2015-11-30 06:25:31 -0800 | [diff] [blame] | 930 | REPORTER_ASSERT(r, codec); |
| 931 | if (!codec) { |
| 932 | return; |
| 933 | } |
scroggo | 7b5e553 | 2016-02-04 06:14:24 -0800 | [diff] [blame] | 934 | test_info(r, codec.get(), codec->getInfo(), SkCodec::kSuccess, nullptr); |
scroggo | b9a1e34 | 2015-11-30 06:25:31 -0800 | [diff] [blame] | 935 | } |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 936 | |
| 937 | // wbmp images have a header that can be arbitrarily large, depending on the |
| 938 | // size of the image. We cap the size at 65535, meaning we only need to look at |
| 939 | // 8 bytes to determine whether we can read the image. This is important |
Leon Scroggins III | 04be2b5 | 2017-08-17 15:13:20 -0400 | [diff] [blame] | 940 | // because SkCodec only passes a limited number of bytes to SkWbmpCodec to |
| 941 | // determine whether the image is a wbmp. |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 942 | DEF_TEST(Codec_wbmp_max_size, r) { |
| 943 | const unsigned char maxSizeWbmp[] = { 0x00, 0x00, // Header |
| 944 | 0x83, 0xFF, 0x7F, // W: 65535 |
| 945 | 0x83, 0xFF, 0x7F }; // H: 65535 |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 946 | std::unique_ptr<SkStream> stream(new SkMemoryStream(maxSizeWbmp, sizeof(maxSizeWbmp), false)); |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 947 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream))); |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 948 | |
| 949 | REPORTER_ASSERT(r, codec); |
| 950 | if (!codec) return; |
| 951 | |
| 952 | REPORTER_ASSERT(r, codec->getInfo().width() == 65535); |
| 953 | REPORTER_ASSERT(r, codec->getInfo().height() == 65535); |
| 954 | |
| 955 | // Now test an image which is too big. Any image with a larger header (i.e. |
| 956 | // has bigger width/height) is also too big. |
| 957 | const unsigned char tooBigWbmp[] = { 0x00, 0x00, // Header |
| 958 | 0x84, 0x80, 0x00, // W: 65536 |
| 959 | 0x84, 0x80, 0x00 }; // H: 65536 |
| 960 | stream.reset(new SkMemoryStream(tooBigWbmp, sizeof(tooBigWbmp), false)); |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 961 | codec = SkCodec::MakeFromStream(std::move(stream)); |
scroggo | db30be2 | 2015-12-08 18:54:13 -0800 | [diff] [blame] | 962 | |
| 963 | REPORTER_ASSERT(r, !codec); |
| 964 | } |
msarett | 2812f03 | 2016-07-18 15:56:08 -0700 | [diff] [blame] | 965 | |
| 966 | DEF_TEST(Codec_jpeg_rewind, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 967 | const char* path = "images/mandrill_512_q075.jpg"; |
Leon Scroggins III | 4288657 | 2017-01-27 13:16:28 -0500 | [diff] [blame] | 968 | sk_sp<SkData> data(GetResourceAsData(path)); |
| 969 | if (!data) { |
msarett | 2812f03 | 2016-07-18 15:56:08 -0700 | [diff] [blame] | 970 | return; |
| 971 | } |
Leon Scroggins III | 4288657 | 2017-01-27 13:16:28 -0500 | [diff] [blame] | 972 | |
| 973 | data = SkData::MakeSubset(data.get(), 0, data->size() / 2); |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 974 | std::unique_ptr<SkAndroidCodec> codec(SkAndroidCodec::MakeFromData(data)); |
msarett | 2812f03 | 2016-07-18 15:56:08 -0700 | [diff] [blame] | 975 | if (!codec) { |
| 976 | ERRORF(r, "Unable to create codec '%s'.", path); |
| 977 | return; |
| 978 | } |
| 979 | |
| 980 | const int width = codec->getInfo().width(); |
| 981 | const int height = codec->getInfo().height(); |
| 982 | size_t rowBytes = sizeof(SkPMColor) * width; |
| 983 | SkAutoMalloc pixelStorage(height * rowBytes); |
| 984 | |
| 985 | // Perform a sampled decode. |
| 986 | SkAndroidCodec::AndroidOptions opts; |
| 987 | opts.fSampleSize = 12; |
Leon Scroggins III | 4288657 | 2017-01-27 13:16:28 -0500 | [diff] [blame] | 988 | auto sampledInfo = codec->getInfo().makeWH(width / 12, height / 12); |
| 989 | auto result = codec->getAndroidPixels(sampledInfo, pixelStorage.get(), rowBytes, &opts); |
| 990 | REPORTER_ASSERT(r, SkCodec::kIncompleteInput == result); |
msarett | 2812f03 | 2016-07-18 15:56:08 -0700 | [diff] [blame] | 991 | |
| 992 | // Rewind the codec and perform a full image decode. |
Matt Sarett | 74b16ed | 2017-01-25 11:58:11 -0500 | [diff] [blame] | 993 | result = codec->getPixels(codec->getInfo(), pixelStorage.get(), rowBytes); |
Leon Scroggins III | 4288657 | 2017-01-27 13:16:28 -0500 | [diff] [blame] | 994 | REPORTER_ASSERT(r, SkCodec::kIncompleteInput == result); |
Matt Sarett | 74b16ed | 2017-01-25 11:58:11 -0500 | [diff] [blame] | 995 | |
| 996 | // Now perform a subset decode. |
| 997 | { |
| 998 | opts.fSampleSize = 1; |
| 999 | SkIRect subset = SkIRect::MakeWH(100, 100); |
| 1000 | opts.fSubset = ⊂ |
| 1001 | result = codec->getAndroidPixels(codec->getInfo().makeWH(100, 100), pixelStorage.get(), |
| 1002 | rowBytes, &opts); |
Leon Scroggins III | 4288657 | 2017-01-27 13:16:28 -0500 | [diff] [blame] | 1003 | // Though we only have half the data, it is enough to decode this subset. |
Matt Sarett | 74b16ed | 2017-01-25 11:58:11 -0500 | [diff] [blame] | 1004 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
| 1005 | } |
| 1006 | |
| 1007 | // Perform another full image decode. ASAN will detect if we look at the subset when it is |
| 1008 | // out of scope. This would happen if we depend on the old state in the codec. |
Leon Scroggins III | 4288657 | 2017-01-27 13:16:28 -0500 | [diff] [blame] | 1009 | // This tests two layers of bugs: both SkJpegCodec::readRows and SkCodec::fillIncompleteImage |
| 1010 | // used to look at the old subset. |
Matt Sarett | 74b16ed | 2017-01-25 11:58:11 -0500 | [diff] [blame] | 1011 | opts.fSubset = nullptr; |
| 1012 | result = codec->getAndroidPixels(codec->getInfo(), pixelStorage.get(), rowBytes, &opts); |
Leon Scroggins III | 4288657 | 2017-01-27 13:16:28 -0500 | [diff] [blame] | 1013 | REPORTER_ASSERT(r, SkCodec::kIncompleteInput == result); |
msarett | 2812f03 | 2016-07-18 15:56:08 -0700 | [diff] [blame] | 1014 | } |
msarett | 549ca32 | 2016-08-17 08:54:08 -0700 | [diff] [blame] | 1015 | |
msarett | 35bb74b | 2016-08-22 07:41:28 -0700 | [diff] [blame] | 1016 | static void check_color_xform(skiatest::Reporter* r, const char* path) { |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1017 | std::unique_ptr<SkAndroidCodec> codec(SkAndroidCodec::MakeFromStream(GetResourceAsStream(path))); |
msarett | 35bb74b | 2016-08-22 07:41:28 -0700 | [diff] [blame] | 1018 | |
| 1019 | SkAndroidCodec::AndroidOptions opts; |
| 1020 | opts.fSampleSize = 3; |
| 1021 | const int subsetWidth = codec->getInfo().width() / 2; |
| 1022 | const int subsetHeight = codec->getInfo().height() / 2; |
| 1023 | SkIRect subset = SkIRect::MakeWH(subsetWidth, subsetHeight); |
| 1024 | opts.fSubset = ⊂ |
| 1025 | |
| 1026 | const int dstWidth = subsetWidth / opts.fSampleSize; |
| 1027 | const int dstHeight = subsetHeight / opts.fSampleSize; |
Brian Osman | 499afea | 2018-05-23 13:12:18 -0400 | [diff] [blame] | 1028 | auto colorSpace = SkColorSpace::MakeRGB(g2Dot2_TransferFn, SkColorSpace::kAdobeRGB_Gamut); |
msarett | 35bb74b | 2016-08-22 07:41:28 -0700 | [diff] [blame] | 1029 | SkImageInfo dstInfo = codec->getInfo().makeWH(dstWidth, dstHeight) |
| 1030 | .makeColorType(kN32_SkColorType) |
| 1031 | .makeColorSpace(colorSpace); |
| 1032 | |
| 1033 | size_t rowBytes = dstInfo.minRowBytes(); |
Mike Reed | f0ffb89 | 2017-10-03 14:47:21 -0400 | [diff] [blame] | 1034 | SkAutoMalloc pixelStorage(dstInfo.computeByteSize(rowBytes)); |
msarett | 35bb74b | 2016-08-22 07:41:28 -0700 | [diff] [blame] | 1035 | SkCodec::Result result = codec->getAndroidPixels(dstInfo, pixelStorage.get(), rowBytes, &opts); |
| 1036 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
| 1037 | } |
| 1038 | |
| 1039 | DEF_TEST(Codec_ColorXform, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1040 | check_color_xform(r, "images/mandrill_512_q075.jpg"); |
| 1041 | check_color_xform(r, "images/mandrill_512.png"); |
msarett | 35bb74b | 2016-08-22 07:41:28 -0700 | [diff] [blame] | 1042 | } |
| 1043 | |
msarett | f17b71f | 2016-09-12 14:30:03 -0700 | [diff] [blame] | 1044 | static bool color_type_match(SkColorType origColorType, SkColorType codecColorType) { |
| 1045 | switch (origColorType) { |
| 1046 | case kRGBA_8888_SkColorType: |
| 1047 | case kBGRA_8888_SkColorType: |
| 1048 | return kRGBA_8888_SkColorType == codecColorType || |
| 1049 | kBGRA_8888_SkColorType == codecColorType; |
| 1050 | default: |
| 1051 | return origColorType == codecColorType; |
| 1052 | } |
| 1053 | } |
| 1054 | |
| 1055 | static bool alpha_type_match(SkAlphaType origAlphaType, SkAlphaType codecAlphaType) { |
| 1056 | switch (origAlphaType) { |
| 1057 | case kUnpremul_SkAlphaType: |
| 1058 | case kPremul_SkAlphaType: |
| 1059 | return kUnpremul_SkAlphaType == codecAlphaType || |
| 1060 | kPremul_SkAlphaType == codecAlphaType; |
| 1061 | default: |
| 1062 | return origAlphaType == codecAlphaType; |
| 1063 | } |
| 1064 | } |
| 1065 | |
| 1066 | static void check_round_trip(skiatest::Reporter* r, SkCodec* origCodec, const SkImageInfo& info) { |
| 1067 | SkBitmap bm1; |
Leon Scroggins | 571b30f | 2017-07-11 17:35:31 +0000 | [diff] [blame] | 1068 | bm1.allocPixels(info); |
| 1069 | SkCodec::Result result = origCodec->getPixels(info, bm1.getPixels(), bm1.rowBytes()); |
msarett | f17b71f | 2016-09-12 14:30:03 -0700 | [diff] [blame] | 1070 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
msarett | 9b09cd8 | 2016-08-29 14:47:49 -0700 | [diff] [blame] | 1071 | |
| 1072 | // Encode the image to png. |
Leon Scroggins III | 0098ccb | 2018-09-24 15:24:31 -0400 | [diff] [blame] | 1073 | auto data = SkEncodeBitmap(bm1, SkEncodedImageFormat::kPNG, 100); |
msarett | 9b09cd8 | 2016-08-29 14:47:49 -0700 | [diff] [blame] | 1074 | |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1075 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromData(data)); |
msarett | f17b71f | 2016-09-12 14:30:03 -0700 | [diff] [blame] | 1076 | REPORTER_ASSERT(r, color_type_match(info.colorType(), codec->getInfo().colorType())); |
| 1077 | REPORTER_ASSERT(r, alpha_type_match(info.alphaType(), codec->getInfo().alphaType())); |
msarett | 9b09cd8 | 2016-08-29 14:47:49 -0700 | [diff] [blame] | 1078 | |
| 1079 | SkBitmap bm2; |
Leon Scroggins | 571b30f | 2017-07-11 17:35:31 +0000 | [diff] [blame] | 1080 | bm2.allocPixels(info); |
| 1081 | result = codec->getPixels(info, bm2.getPixels(), bm2.rowBytes()); |
msarett | 9b09cd8 | 2016-08-29 14:47:49 -0700 | [diff] [blame] | 1082 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
| 1083 | |
| 1084 | SkMD5::Digest d1, d2; |
| 1085 | md5(bm1, &d1); |
| 1086 | md5(bm2, &d2); |
| 1087 | REPORTER_ASSERT(r, d1 == d2); |
| 1088 | } |
| 1089 | |
| 1090 | DEF_TEST(Codec_PngRoundTrip, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1091 | auto codec = SkCodec::MakeFromStream(GetResourceAsStream("images/mandrill_512_q075.jpg")); |
msarett | 549ca32 | 2016-08-17 08:54:08 -0700 | [diff] [blame] | 1092 | |
msarett | f17b71f | 2016-09-12 14:30:03 -0700 | [diff] [blame] | 1093 | SkColorType colorTypesOpaque[] = { |
| 1094 | kRGB_565_SkColorType, kRGBA_8888_SkColorType, kBGRA_8888_SkColorType |
| 1095 | }; |
| 1096 | for (SkColorType colorType : colorTypesOpaque) { |
| 1097 | SkImageInfo newInfo = codec->getInfo().makeColorType(colorType); |
| 1098 | check_round_trip(r, codec.get(), newInfo); |
| 1099 | } |
| 1100 | |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1101 | codec = SkCodec::MakeFromStream(GetResourceAsStream("images/grayscale.jpg")); |
msarett | f17b71f | 2016-09-12 14:30:03 -0700 | [diff] [blame] | 1102 | check_round_trip(r, codec.get(), codec->getInfo()); |
| 1103 | |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1104 | codec = SkCodec::MakeFromStream(GetResourceAsStream("images/yellow_rose.png")); |
msarett | f17b71f | 2016-09-12 14:30:03 -0700 | [diff] [blame] | 1105 | |
| 1106 | SkColorType colorTypesWithAlpha[] = { |
| 1107 | kRGBA_8888_SkColorType, kBGRA_8888_SkColorType |
| 1108 | }; |
| 1109 | SkAlphaType alphaTypes[] = { |
| 1110 | kUnpremul_SkAlphaType, kPremul_SkAlphaType |
| 1111 | }; |
| 1112 | for (SkColorType colorType : colorTypesWithAlpha) { |
| 1113 | for (SkAlphaType alphaType : alphaTypes) { |
| 1114 | // Set color space to nullptr because color correct premultiplies do not round trip. |
| 1115 | SkImageInfo newInfo = codec->getInfo().makeColorType(colorType) |
| 1116 | .makeAlphaType(alphaType) |
| 1117 | .makeColorSpace(nullptr); |
| 1118 | check_round_trip(r, codec.get(), newInfo); |
| 1119 | } |
| 1120 | } |
| 1121 | |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1122 | codec = SkCodec::MakeFromStream(GetResourceAsStream("images/index8.png")); |
msarett | f17b71f | 2016-09-12 14:30:03 -0700 | [diff] [blame] | 1123 | |
| 1124 | for (SkAlphaType alphaType : alphaTypes) { |
| 1125 | SkImageInfo newInfo = codec->getInfo().makeAlphaType(alphaType) |
| 1126 | .makeColorSpace(nullptr); |
| 1127 | check_round_trip(r, codec.get(), newInfo); |
| 1128 | } |
msarett | 549ca32 | 2016-08-17 08:54:08 -0700 | [diff] [blame] | 1129 | } |
msarett | 2ecc35f | 2016-09-08 11:55:16 -0700 | [diff] [blame] | 1130 | |
| 1131 | static void test_conversion_possible(skiatest::Reporter* r, const char* path, |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1132 | bool supportsScanlineDecoder, |
| 1133 | bool supportsIncrementalDecoder) { |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 1134 | std::unique_ptr<SkStream> stream(GetResourceAsStream(path)); |
Leon Scroggins III | c9942a1 | 2017-01-30 09:59:28 -0500 | [diff] [blame] | 1135 | if (!stream) { |
| 1136 | return; |
| 1137 | } |
| 1138 | |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1139 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream))); |
Leon Scroggins III | c9942a1 | 2017-01-30 09:59:28 -0500 | [diff] [blame] | 1140 | if (!codec) { |
| 1141 | ERRORF(r, "failed to create a codec for %s", path); |
| 1142 | return; |
| 1143 | } |
| 1144 | |
msarett | 2ecc35f | 2016-09-08 11:55:16 -0700 | [diff] [blame] | 1145 | SkImageInfo infoF16 = codec->getInfo().makeColorType(kRGBA_F16_SkColorType); |
| 1146 | |
| 1147 | SkBitmap bm; |
| 1148 | bm.allocPixels(infoF16); |
| 1149 | SkCodec::Result result = codec->getPixels(infoF16, bm.getPixels(), bm.rowBytes()); |
Mike Klein | ce4cf72 | 2018-05-10 11:29:15 -0400 | [diff] [blame] | 1150 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1151 | |
| 1152 | result = codec->startScanlineDecode(infoF16); |
| 1153 | if (supportsScanlineDecoder) { |
Mike Klein | ce4cf72 | 2018-05-10 11:29:15 -0400 | [diff] [blame] | 1154 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1155 | } else { |
Leon Scroggins III | 0741818 | 2017-08-15 12:24:02 -0400 | [diff] [blame] | 1156 | REPORTER_ASSERT(r, SkCodec::kUnimplemented == result |
Mike Klein | ce4cf72 | 2018-05-10 11:29:15 -0400 | [diff] [blame] | 1157 | || SkCodec::kSuccess == result); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1158 | } |
| 1159 | |
| 1160 | result = codec->startIncrementalDecode(infoF16, bm.getPixels(), bm.rowBytes()); |
| 1161 | if (supportsIncrementalDecoder) { |
Mike Klein | ce4cf72 | 2018-05-10 11:29:15 -0400 | [diff] [blame] | 1162 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1163 | } else { |
Leon Scroggins III | 0741818 | 2017-08-15 12:24:02 -0400 | [diff] [blame] | 1164 | REPORTER_ASSERT(r, SkCodec::kUnimplemented == result |
Mike Klein | ce4cf72 | 2018-05-10 11:29:15 -0400 | [diff] [blame] | 1165 | || SkCodec::kSuccess == result); |
msarett | 2ecc35f | 2016-09-08 11:55:16 -0700 | [diff] [blame] | 1166 | } |
| 1167 | |
Brian Osman | 36703d9 | 2017-12-12 14:09:31 -0500 | [diff] [blame] | 1168 | infoF16 = infoF16.makeColorSpace(infoF16.colorSpace()->makeLinearGamma()); |
msarett | 2ecc35f | 2016-09-08 11:55:16 -0700 | [diff] [blame] | 1169 | result = codec->getPixels(infoF16, bm.getPixels(), bm.rowBytes()); |
| 1170 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1171 | result = codec->startScanlineDecode(infoF16); |
| 1172 | if (supportsScanlineDecoder) { |
msarett | 2ecc35f | 2016-09-08 11:55:16 -0700 | [diff] [blame] | 1173 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1174 | } else { |
| 1175 | REPORTER_ASSERT(r, SkCodec::kUnimplemented == result); |
| 1176 | } |
| 1177 | |
| 1178 | result = codec->startIncrementalDecode(infoF16, bm.getPixels(), bm.rowBytes()); |
| 1179 | if (supportsIncrementalDecoder) { |
| 1180 | REPORTER_ASSERT(r, SkCodec::kSuccess == result); |
| 1181 | } else { |
| 1182 | REPORTER_ASSERT(r, SkCodec::kUnimplemented == result); |
msarett | 2ecc35f | 2016-09-08 11:55:16 -0700 | [diff] [blame] | 1183 | } |
| 1184 | } |
| 1185 | |
| 1186 | DEF_TEST(Codec_F16ConversionPossible, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1187 | test_conversion_possible(r, "images/color_wheel.webp", false, false); |
| 1188 | test_conversion_possible(r, "images/mandrill_512_q075.jpg", true, false); |
| 1189 | test_conversion_possible(r, "images/yellow_rose.png", false, true); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1190 | } |
| 1191 | |
scroggo | 19b9153 | 2016-10-24 09:03:26 -0700 | [diff] [blame] | 1192 | static void decode_frame(skiatest::Reporter* r, SkCodec* codec, size_t frame) { |
| 1193 | SkBitmap bm; |
| 1194 | auto info = codec->getInfo().makeColorType(kN32_SkColorType); |
| 1195 | bm.allocPixels(info); |
| 1196 | |
| 1197 | SkCodec::Options opts; |
| 1198 | opts.fFrameIndex = frame; |
| 1199 | REPORTER_ASSERT(r, SkCodec::kSuccess == codec->getPixels(info, |
Leon Scroggins | 571b30f | 2017-07-11 17:35:31 +0000 | [diff] [blame] | 1200 | bm.getPixels(), bm.rowBytes(), &opts)); |
scroggo | 19b9153 | 2016-10-24 09:03:26 -0700 | [diff] [blame] | 1201 | } |
| 1202 | |
Leon Scroggins III | 1f6af6b | 2017-06-12 16:41:09 -0400 | [diff] [blame] | 1203 | // For an animated GIF, we should only read enough to decode frame 0 if the |
| 1204 | // client never calls getFrameInfo and only decodes frame 0. |
scroggo | 19b9153 | 2016-10-24 09:03:26 -0700 | [diff] [blame] | 1205 | DEF_TEST(Codec_skipFullParse, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1206 | auto path = "images/test640x479.gif"; |
Mike Reed | 71f867c | 2017-07-23 13:14:10 -0400 | [diff] [blame] | 1207 | auto streamObj = GetResourceAsStream(path); |
| 1208 | if (!streamObj) { |
scroggo | 19b9153 | 2016-10-24 09:03:26 -0700 | [diff] [blame] | 1209 | return; |
| 1210 | } |
Mike Reed | 71f867c | 2017-07-23 13:14:10 -0400 | [diff] [blame] | 1211 | SkStream* stream = streamObj.get(); |
scroggo | 19b9153 | 2016-10-24 09:03:26 -0700 | [diff] [blame] | 1212 | |
| 1213 | // Note that we cheat and hold on to the stream pointer, but SkCodec will |
| 1214 | // take ownership. We will not refer to the stream after the SkCodec |
| 1215 | // deletes it. |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1216 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(streamObj))); |
scroggo | 19b9153 | 2016-10-24 09:03:26 -0700 | [diff] [blame] | 1217 | if (!codec) { |
| 1218 | ERRORF(r, "Failed to create codec for %s", path); |
| 1219 | return; |
| 1220 | } |
| 1221 | |
| 1222 | REPORTER_ASSERT(r, stream->hasPosition()); |
| 1223 | const size_t sizePosition = stream->getPosition(); |
| 1224 | REPORTER_ASSERT(r, stream->hasLength() && sizePosition < stream->getLength()); |
| 1225 | |
| 1226 | // This should read more of the stream, but not the whole stream. |
| 1227 | decode_frame(r, codec.get(), 0); |
| 1228 | const size_t positionAfterFirstFrame = stream->getPosition(); |
| 1229 | REPORTER_ASSERT(r, positionAfterFirstFrame > sizePosition |
| 1230 | && positionAfterFirstFrame < stream->getLength()); |
| 1231 | |
Leon Scroggins III | 1f6af6b | 2017-06-12 16:41:09 -0400 | [diff] [blame] | 1232 | // There is more data in the stream. |
scroggo | 19b9153 | 2016-10-24 09:03:26 -0700 | [diff] [blame] | 1233 | auto frameInfo = codec->getFrameInfo(); |
| 1234 | REPORTER_ASSERT(r, frameInfo.size() == 4); |
Leon Scroggins III | 1f6af6b | 2017-06-12 16:41:09 -0400 | [diff] [blame] | 1235 | REPORTER_ASSERT(r, stream->getPosition() > positionAfterFirstFrame); |
scroggo | 19b9153 | 2016-10-24 09:03:26 -0700 | [diff] [blame] | 1236 | } |
| 1237 | |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1238 | // Only rewinds up to a limit. |
| 1239 | class LimitedRewindingStream : public SkStream { |
| 1240 | public: |
Mike Reed | 71f867c | 2017-07-23 13:14:10 -0400 | [diff] [blame] | 1241 | static std::unique_ptr<SkStream> Make(const char path[], size_t limit) { |
| 1242 | auto stream = GetResourceAsStream(path); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1243 | if (!stream) { |
| 1244 | return nullptr; |
| 1245 | } |
Mike Reed | 71f867c | 2017-07-23 13:14:10 -0400 | [diff] [blame] | 1246 | return std::unique_ptr<SkStream>(new LimitedRewindingStream(std::move(stream), limit)); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1247 | } |
| 1248 | |
| 1249 | size_t read(void* buffer, size_t size) override { |
| 1250 | const size_t bytes = fStream->read(buffer, size); |
| 1251 | fPosition += bytes; |
| 1252 | return bytes; |
| 1253 | } |
| 1254 | |
| 1255 | bool isAtEnd() const override { |
| 1256 | return fStream->isAtEnd(); |
| 1257 | } |
| 1258 | |
| 1259 | bool rewind() override { |
| 1260 | if (fPosition <= fLimit && fStream->rewind()) { |
| 1261 | fPosition = 0; |
| 1262 | return true; |
| 1263 | } |
| 1264 | |
| 1265 | return false; |
| 1266 | } |
| 1267 | |
| 1268 | private: |
Ben Wagner | 145dbcd | 2016-11-03 14:40:50 -0400 | [diff] [blame] | 1269 | std::unique_ptr<SkStream> fStream; |
| 1270 | const size_t fLimit; |
| 1271 | size_t fPosition; |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1272 | |
Mike Reed | 71f867c | 2017-07-23 13:14:10 -0400 | [diff] [blame] | 1273 | LimitedRewindingStream(std::unique_ptr<SkStream> stream, size_t limit) |
| 1274 | : fStream(std::move(stream)) |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1275 | , fLimit(limit) |
| 1276 | , fPosition(0) |
| 1277 | { |
| 1278 | SkASSERT(fStream); |
| 1279 | } |
| 1280 | }; |
| 1281 | |
| 1282 | DEF_TEST(Codec_fallBack, r) { |
| 1283 | // SkAndroidCodec needs to be able to fall back to scanline decoding |
| 1284 | // if incremental decoding does not work. Make sure this does not |
| 1285 | // require a rewind. |
| 1286 | |
| 1287 | // Formats that currently do not support incremental decoding |
| 1288 | auto files = { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1289 | "images/CMYK.jpg", |
| 1290 | "images/color_wheel.ico", |
| 1291 | "images/mandrill.wbmp", |
| 1292 | "images/randPixels.bmp", |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1293 | }; |
| 1294 | for (auto file : files) { |
Leon Scroggins III | 04be2b5 | 2017-08-17 15:13:20 -0400 | [diff] [blame] | 1295 | auto stream = LimitedRewindingStream::Make(file, SkCodec::MinBufferedBytesNeeded()); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1296 | if (!stream) { |
| 1297 | SkDebugf("Missing resources (%s). Set --resourcePath.\n", file); |
| 1298 | return; |
| 1299 | } |
| 1300 | |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1301 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream))); |
scroggo | 8e6c7ad | 2016-09-16 08:20:38 -0700 | [diff] [blame] | 1302 | if (!codec) { |
| 1303 | ERRORF(r, "Failed to create codec for %s,", file); |
| 1304 | continue; |
| 1305 | } |
| 1306 | |
| 1307 | SkImageInfo info = codec->getInfo().makeColorType(kN32_SkColorType); |
| 1308 | SkBitmap bm; |
| 1309 | bm.allocPixels(info); |
| 1310 | |
| 1311 | if (SkCodec::kUnimplemented != codec->startIncrementalDecode(info, bm.getPixels(), |
| 1312 | bm.rowBytes())) { |
| 1313 | ERRORF(r, "Is scanline decoding now implemented for %s?", file); |
| 1314 | continue; |
| 1315 | } |
| 1316 | |
| 1317 | // Scanline decoding should not require a rewind. |
| 1318 | SkCodec::Result result = codec->startScanlineDecode(info); |
| 1319 | if (SkCodec::kSuccess != result) { |
| 1320 | ERRORF(r, "Scanline decoding failed for %s with %i", file, result); |
| 1321 | } |
| 1322 | } |
msarett | 2ecc35f | 2016-09-08 11:55:16 -0700 | [diff] [blame] | 1323 | } |
scroggo | c46cdd4 | 2016-10-10 06:45:32 -0700 | [diff] [blame] | 1324 | |
| 1325 | // This test verifies that we fixed an assert statement that fired when reusing a png codec |
| 1326 | // after scaling. |
| 1327 | DEF_TEST(Codec_reusePng, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1328 | std::unique_ptr<SkStream> stream(GetResourceAsStream("images/plane.png")); |
scroggo | c46cdd4 | 2016-10-10 06:45:32 -0700 | [diff] [blame] | 1329 | if (!stream) { |
| 1330 | return; |
| 1331 | } |
| 1332 | |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1333 | std::unique_ptr<SkAndroidCodec> codec(SkAndroidCodec::MakeFromStream(std::move(stream))); |
scroggo | c46cdd4 | 2016-10-10 06:45:32 -0700 | [diff] [blame] | 1334 | if (!codec) { |
| 1335 | ERRORF(r, "Failed to create codec\n"); |
| 1336 | return; |
| 1337 | } |
| 1338 | |
| 1339 | SkAndroidCodec::AndroidOptions opts; |
| 1340 | opts.fSampleSize = 5; |
| 1341 | auto size = codec->getSampledDimensions(opts.fSampleSize); |
| 1342 | auto info = codec->getInfo().makeWH(size.fWidth, size.fHeight).makeColorType(kN32_SkColorType); |
| 1343 | SkBitmap bm; |
| 1344 | bm.allocPixels(info); |
| 1345 | auto result = codec->getAndroidPixels(info, bm.getPixels(), bm.rowBytes(), &opts); |
| 1346 | REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
| 1347 | |
| 1348 | info = codec->getInfo().makeColorType(kN32_SkColorType); |
| 1349 | bm.allocPixels(info); |
| 1350 | opts.fSampleSize = 1; |
| 1351 | result = codec->getAndroidPixels(info, bm.getPixels(), bm.rowBytes(), &opts); |
| 1352 | REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
| 1353 | } |
scroggo | e61b3b4 | 2016-10-10 07:17:32 -0700 | [diff] [blame] | 1354 | |
| 1355 | DEF_TEST(Codec_rowsDecoded, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1356 | auto file = "images/plane_interlaced.png"; |
scroggo | e61b3b4 | 2016-10-10 07:17:32 -0700 | [diff] [blame] | 1357 | std::unique_ptr<SkStream> stream(GetResourceAsStream(file)); |
| 1358 | if (!stream) { |
| 1359 | return; |
| 1360 | } |
| 1361 | |
| 1362 | // This is enough to read the header etc, but no rows. |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1363 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromData(SkData::MakeFromStream(stream.get(), 99))); |
scroggo | e61b3b4 | 2016-10-10 07:17:32 -0700 | [diff] [blame] | 1364 | if (!codec) { |
| 1365 | ERRORF(r, "Failed to create codec\n"); |
| 1366 | return; |
| 1367 | } |
| 1368 | |
| 1369 | auto info = codec->getInfo().makeColorType(kN32_SkColorType); |
| 1370 | SkBitmap bm; |
| 1371 | bm.allocPixels(info); |
| 1372 | auto result = codec->startIncrementalDecode(info, bm.getPixels(), bm.rowBytes()); |
| 1373 | REPORTER_ASSERT(r, result == SkCodec::kSuccess); |
| 1374 | |
| 1375 | // This is an arbitrary value. The important fact is that it is not zero, and rowsDecoded |
| 1376 | // should get set to zero by incrementalDecode. |
| 1377 | int rowsDecoded = 77; |
| 1378 | result = codec->incrementalDecode(&rowsDecoded); |
| 1379 | REPORTER_ASSERT(r, result == SkCodec::kIncompleteInput); |
| 1380 | REPORTER_ASSERT(r, rowsDecoded == 0); |
| 1381 | } |
Matt Sarett | 29121eb | 2016-10-17 14:32:46 -0400 | [diff] [blame] | 1382 | |
Matt Sarett | d59948a | 2017-04-26 10:59:48 -0400 | [diff] [blame] | 1383 | static void test_invalid_images(skiatest::Reporter* r, const char* path, |
| 1384 | SkCodec::Result expectedResult) { |
Mike Reed | 71f867c | 2017-07-23 13:14:10 -0400 | [diff] [blame] | 1385 | auto stream = GetResourceAsStream(path); |
Leon Scroggins III | b3b2453 | 2017-01-18 12:39:07 -0500 | [diff] [blame] | 1386 | if (!stream) { |
| 1387 | return; |
| 1388 | } |
| 1389 | |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1390 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream))); |
Leon Scroggins III | b3b2453 | 2017-01-18 12:39:07 -0500 | [diff] [blame] | 1391 | REPORTER_ASSERT(r, codec); |
| 1392 | |
Matt Sarett | d59948a | 2017-04-26 10:59:48 -0400 | [diff] [blame] | 1393 | test_info(r, codec.get(), codec->getInfo().makeColorType(kN32_SkColorType), expectedResult, |
| 1394 | nullptr); |
| 1395 | } |
| 1396 | |
| 1397 | DEF_TEST(Codec_InvalidImages, r) { |
| 1398 | // ASAN will complain if there is an issue. |
Leon Scroggins III | 674a184 | 2017-07-06 12:26:09 -0400 | [diff] [blame] | 1399 | test_invalid_images(r, "invalid_images/skbug5887.gif", SkCodec::kErrorInInput); |
Matt Sarett | d59948a | 2017-04-26 10:59:48 -0400 | [diff] [blame] | 1400 | test_invalid_images(r, "invalid_images/many-progressive-scans.jpg", SkCodec::kInvalidInput); |
| 1401 | test_invalid_images(r, "invalid_images/b33251605.bmp", SkCodec::kIncompleteInput); |
| 1402 | test_invalid_images(r, "invalid_images/bad_palette.png", SkCodec::kInvalidInput); |
| 1403 | } |
| 1404 | |
| 1405 | static void test_invalid_header(skiatest::Reporter* r, const char* path) { |
Mike Reed | 0933bc9 | 2017-12-09 01:27:41 +0000 | [diff] [blame] | 1406 | auto data = GetResourceAsData(path); |
| 1407 | if (!data) { |
| 1408 | return; |
| 1409 | } |
| 1410 | std::unique_ptr<SkStreamAsset> stream(new SkMemoryStream(std::move(data))); |
Mike Reed | 847068c | 2017-07-26 11:35:53 -0400 | [diff] [blame] | 1411 | if (!stream) { |
Matt Sarett | d59948a | 2017-04-26 10:59:48 -0400 | [diff] [blame] | 1412 | return; |
| 1413 | } |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1414 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream))); |
Matt Sarett | d59948a | 2017-04-26 10:59:48 -0400 | [diff] [blame] | 1415 | REPORTER_ASSERT(r, !codec); |
| 1416 | } |
| 1417 | |
| 1418 | DEF_TEST(Codec_InvalidHeader, r) { |
| 1419 | test_invalid_header(r, "invalid_images/int_overflow.ico"); |
| 1420 | |
| 1421 | // These files report values that have caused problems with SkFILEStreams. |
| 1422 | // They are invalid, and should not create SkCodecs. |
| 1423 | test_invalid_header(r, "invalid_images/b33651913.bmp"); |
| 1424 | test_invalid_header(r, "invalid_images/b34778578.bmp"); |
Leon Scroggins III | b3b2453 | 2017-01-18 12:39:07 -0500 | [diff] [blame] | 1425 | } |
| 1426 | |
Leon Scroggins III | e93ec68 | 2018-10-26 09:25:51 -0400 | [diff] [blame] | 1427 | /* |
| 1428 | For the Codec_InvalidAnimated test, immediately below, |
| 1429 | resources/invalid_images/skbug6046.gif is: |
| 1430 | |
| 1431 | 00000000: 4749 4638 3961 2000 0000 0000 002c ff00 GIF89a ......,.. |
| 1432 | 00000010: 7400 0600 0000 4001 0021 f904 0a00 0000 t.....@..!...... |
| 1433 | 00000020: 002c ff00 0000 ff00 7400 0606 0606 0601 .,......t....... |
| 1434 | 00000030: 0021 f904 0000 0000 002c ff00 0000 ffcc .!.......,...... |
| 1435 | 00000040: 1b36 5266 deba 543d .6Rf..T= |
| 1436 | |
| 1437 | It nominally contains 3 frames, but all of them are invalid. It came from a |
| 1438 | fuzzer doing random mutations and copies. The breakdown: |
| 1439 | |
| 1440 | @000 6 bytes magic "GIF89a" |
| 1441 | @006 7 bytes Logical Screen Descriptor: 0x20 0x00 ... 0x00 |
| 1442 | - width = 32 |
| 1443 | - height = 0 |
| 1444 | - flags = 0x00 |
| 1445 | - background color index, pixel aspect ratio bytes ignored |
| 1446 | @00D 10 bytes Image Descriptor header: 0x2C 0xFF ... 0x40 |
| 1447 | - origin_x = 255 |
| 1448 | - origin_y = 116 |
| 1449 | - width = 6 |
| 1450 | - height = 0 |
| 1451 | - flags = 0x40, interlaced |
| 1452 | @017 2 bytes Image Descriptor body (pixel data): 0x01 0x00 |
| 1453 | - lit_width = 1, INVALID, OUTSIDE THE RANGE [2, 8] |
| 1454 | - 0x00 byte means "end of data" for this frame |
| 1455 | @019 8 bytes Graphic Control Extension: 0x21 0xF9 ... 0x00 |
| 1456 | - valid, but irrelevant here. |
| 1457 | @021 10 bytes Image Descriptor header: 0x2C 0xFF ... 0x06 |
| 1458 | - origin_x = 255 |
| 1459 | - origin_y = 0 |
| 1460 | - width = 255 |
| 1461 | - height = 116 |
| 1462 | - flags = 0x06, INVALID, 0x80 BIT ZERO IMPLIES 0x07 BITS SHOULD BE ZERO |
| 1463 | @02B 14 bytes Image Descriptor body (pixel data): 0x06 0x06 ... 0x00 |
| 1464 | - lit_width = 6 |
| 1465 | - 0x06 precedes a 6 byte block of data |
| 1466 | - 0x04 precedes a 4 byte block of data |
| 1467 | - 0x00 byte means "end of data" for this frame |
| 1468 | @039 10 bytes Image Descriptor header: 0x2C 0xFF ... 0x06 |
| 1469 | - origin_x = 255 |
| 1470 | - origin_y = 0 |
| 1471 | - width = 52479 |
| 1472 | - height = 13851 |
| 1473 | - flags = 0x52, INVALID, 0x80 BIT ZERO IMPLIES 0x07 BITS SHOULD BE ZERO |
| 1474 | @043 5 bytes Image Descriptor body (pixel data): 0x66 0xDE ... unexpected-EOF |
| 1475 | - lit_width = 102, INVALID, OUTSIDE THE RANGE [2, 8] |
| 1476 | - 0xDE precedes a 222 byte block of data, INVALIDLY TRUNCATED |
| 1477 | |
| 1478 | On Image Descriptor flags INVALIDITY, |
| 1479 | https://www.w3.org/Graphics/GIF/spec-gif89a.txt section 20.c says that "Size of |
| 1480 | Local Color Table [the low 3 bits]... should be 0 if there is no Local Color |
| 1481 | Table specified [the high bit]." |
| 1482 | |
| 1483 | On LZW literal width (also known as Minimum Code Size) INVALIDITY outside of |
| 1484 | the range [2, 8], https://www.w3.org/Graphics/GIF/spec-gif89a.txt Appendix F |
| 1485 | says that "Normally this will be the same as the number of [palette index] |
| 1486 | bits. Because of some algorithmic constraints however, black & white images |
| 1487 | which have one color bit must be indicated as having a code size of 2." |
| 1488 | |
| 1489 | In practice, some GIF decoders, including the old third_party/gif code, don't |
| 1490 | enforce this. It says: "currentFrame->setDataSize(this->getOneByte())" with the |
| 1491 | only further check being against an upper bound of SK_MAX_DICTIONARY_ENTRY_BITS |
| 1492 | (the constant 12). |
| 1493 | */ |
| 1494 | |
Leon Scroggins III | 56e3209 | 2016-12-12 17:10:46 -0500 | [diff] [blame] | 1495 | DEF_TEST(Codec_InvalidAnimated, r) { |
| 1496 | // ASAN will complain if there is an issue. |
| 1497 | auto path = "invalid_images/skbug6046.gif"; |
Mike Reed | 71f867c | 2017-07-23 13:14:10 -0400 | [diff] [blame] | 1498 | auto stream = GetResourceAsStream(path); |
Leon Scroggins III | 56e3209 | 2016-12-12 17:10:46 -0500 | [diff] [blame] | 1499 | if (!stream) { |
| 1500 | return; |
| 1501 | } |
| 1502 | |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1503 | std::unique_ptr<SkCodec> codec(SkCodec::MakeFromStream(std::move(stream))); |
Leon Scroggins III | 56e3209 | 2016-12-12 17:10:46 -0500 | [diff] [blame] | 1504 | REPORTER_ASSERT(r, codec); |
| 1505 | if (!codec) { |
| 1506 | return; |
| 1507 | } |
| 1508 | |
| 1509 | const auto info = codec->getInfo().makeColorType(kN32_SkColorType); |
| 1510 | SkBitmap bm; |
| 1511 | bm.allocPixels(info); |
| 1512 | |
| 1513 | auto frameInfos = codec->getFrameInfo(); |
| 1514 | SkCodec::Options opts; |
Leon Scroggins III | 249b8e3 | 2017-04-17 12:46:33 -0400 | [diff] [blame] | 1515 | for (int i = 0; static_cast<size_t>(i) < frameInfos.size(); i++) { |
Leon Scroggins III | 56e3209 | 2016-12-12 17:10:46 -0500 | [diff] [blame] | 1516 | opts.fFrameIndex = i; |
Leon Scroggins III | 33deb7e | 2017-06-07 12:31:51 -0400 | [diff] [blame] | 1517 | const auto reqFrame = frameInfos[i].fRequiredFrame; |
Nigel Tao | 66bc524 | 2018-08-22 10:56:03 +1000 | [diff] [blame] | 1518 | opts.fPriorFrame = reqFrame == i - 1 ? reqFrame : SkCodec::kNoFrame; |
Leon Scroggins III | 56e3209 | 2016-12-12 17:10:46 -0500 | [diff] [blame] | 1519 | auto result = codec->startIncrementalDecode(info, bm.getPixels(), bm.rowBytes(), &opts); |
Leon Scroggins III | e93ec68 | 2018-10-26 09:25:51 -0400 | [diff] [blame] | 1520 | |
| 1521 | #ifdef SK_HAS_WUFFS_LIBRARY |
| 1522 | // We are transitioning from an old GIF implementation to a new (Wuffs) |
| 1523 | // GIF implementation. |
| 1524 | // |
| 1525 | // This test (without SK_HAS_WUFFS_LIBRARY) is overly specific to the |
| 1526 | // old implementation. As a fuzzer-discovered test, it's likely that |
| 1527 | // what's fundamentally being tested isn't that decoding an invalid GIF |
| 1528 | // leads to kSuccess, but that decoding an invalid GIF doesn't lead to |
| 1529 | // an ASAN violation. |
| 1530 | // |
| 1531 | // Each of the 3 frames of the source GIF image is fundamentally |
| 1532 | // invalid, as per the "breakdown" comment above. The old |
| 1533 | // implementation is happy to call startIncrementalDecode 3 times. The |
| 1534 | // new implementation is happy for the first two times, but on the 3rd, |
| 1535 | // SkCodec::startIncrementalDecode calls SkCodec::handleFrameIndex |
| 1536 | // which calls SkCodec::getPixels on the requiredFrame (the 0'th |
| 1537 | // frame), and the new implementation subsequently hits the |
| 1538 | // invalid-ness and returns kErrorInInput instead of kSuccess. |
| 1539 | // |
| 1540 | // Once the transition is complete, we can remove the #ifdef and delete |
| 1541 | // the rest of the test function. |
| 1542 | if (i == 2) { |
| 1543 | if (result != SkCodec::kErrorInInput) { |
| 1544 | ERRORF(r, "Unexpected result for decoding frame %i (out of %i) with error %i\n", i, |
| 1545 | frameInfos.size(), result); |
| 1546 | } |
| 1547 | return; |
| 1548 | } |
| 1549 | #endif |
Leon Scroggins III | 56e3209 | 2016-12-12 17:10:46 -0500 | [diff] [blame] | 1550 | if (result != SkCodec::kSuccess) { |
| 1551 | ERRORF(r, "Failed to start decoding frame %i (out of %i) with error %i\n", i, |
| 1552 | frameInfos.size(), result); |
| 1553 | continue; |
| 1554 | } |
| 1555 | |
| 1556 | codec->incrementalDecode(); |
| 1557 | } |
| 1558 | } |
Matt Sarett | 0e032be | 2017-03-15 17:50:08 -0400 | [diff] [blame] | 1559 | |
Matt Sarett | 5df93de | 2017-03-22 21:52:47 +0000 | [diff] [blame] | 1560 | static void encode_format(SkDynamicMemoryWStream* stream, const SkPixmap& pixmap, |
Matt Sarett | c367d03 | 2017-05-05 11:13:26 -0400 | [diff] [blame] | 1561 | SkEncodedImageFormat format) { |
Matt Sarett | 5df93de | 2017-03-22 21:52:47 +0000 | [diff] [blame] | 1562 | switch (format) { |
| 1563 | case SkEncodedImageFormat::kPNG: |
Brian Osman | b62f50c | 2018-07-12 14:44:27 -0400 | [diff] [blame] | 1564 | SkPngEncoder::Encode(stream, pixmap, SkPngEncoder::Options()); |
Matt Sarett | 5df93de | 2017-03-22 21:52:47 +0000 | [diff] [blame] | 1565 | break; |
| 1566 | case SkEncodedImageFormat::kJPEG: |
Matt Sarett | 26b44df | 2017-05-02 16:04:56 -0400 | [diff] [blame] | 1567 | SkJpegEncoder::Encode(stream, pixmap, SkJpegEncoder::Options()); |
Matt Sarett | 5df93de | 2017-03-22 21:52:47 +0000 | [diff] [blame] | 1568 | break; |
Matt Sarett | 3dbef9f | 2017-04-05 22:33:22 +0000 | [diff] [blame] | 1569 | case SkEncodedImageFormat::kWEBP: |
Brian Osman | b62f50c | 2018-07-12 14:44:27 -0400 | [diff] [blame] | 1570 | SkWebpEncoder::Encode(stream, pixmap, SkWebpEncoder::Options()); |
Matt Sarett | 3dbef9f | 2017-04-05 22:33:22 +0000 | [diff] [blame] | 1571 | break; |
Matt Sarett | 5df93de | 2017-03-22 21:52:47 +0000 | [diff] [blame] | 1572 | default: |
| 1573 | SkASSERT(false); |
| 1574 | break; |
| 1575 | } |
| 1576 | } |
| 1577 | |
Brian Osman | b62f50c | 2018-07-12 14:44:27 -0400 | [diff] [blame] | 1578 | static void test_encode_icc(skiatest::Reporter* r, SkEncodedImageFormat format) { |
Matt Sarett | 0e032be | 2017-03-15 17:50:08 -0400 | [diff] [blame] | 1579 | // Test with sRGB color space. |
| 1580 | SkBitmap srgbBitmap; |
| 1581 | SkImageInfo srgbInfo = SkImageInfo::MakeS32(1, 1, kOpaque_SkAlphaType); |
| 1582 | srgbBitmap.allocPixels(srgbInfo); |
| 1583 | *srgbBitmap.getAddr32(0, 0) = 0; |
| 1584 | SkPixmap pixmap; |
| 1585 | srgbBitmap.peekPixels(&pixmap); |
| 1586 | SkDynamicMemoryWStream srgbBuf; |
Brian Osman | b62f50c | 2018-07-12 14:44:27 -0400 | [diff] [blame] | 1587 | encode_format(&srgbBuf, pixmap, format); |
Matt Sarett | 0e032be | 2017-03-15 17:50:08 -0400 | [diff] [blame] | 1588 | sk_sp<SkData> srgbData = srgbBuf.detachAsData(); |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1589 | std::unique_ptr<SkCodec> srgbCodec(SkCodec::MakeFromData(srgbData)); |
Mike Klein | e28a6b5 | 2018-07-25 13:05:17 -0400 | [diff] [blame] | 1590 | REPORTER_ASSERT(r, srgbCodec->getInfo().colorSpace() == sk_srgb_singleton()); |
Matt Sarett | 0e032be | 2017-03-15 17:50:08 -0400 | [diff] [blame] | 1591 | |
| 1592 | // Test with P3 color space. |
| 1593 | SkDynamicMemoryWStream p3Buf; |
| 1594 | sk_sp<SkColorSpace> p3 = SkColorSpace::MakeRGB(SkColorSpace::kSRGB_RenderTargetGamma, |
| 1595 | SkColorSpace::kDCIP3_D65_Gamut); |
| 1596 | pixmap.setColorSpace(p3); |
Brian Osman | b62f50c | 2018-07-12 14:44:27 -0400 | [diff] [blame] | 1597 | encode_format(&p3Buf, pixmap, format); |
Matt Sarett | 0e032be | 2017-03-15 17:50:08 -0400 | [diff] [blame] | 1598 | sk_sp<SkData> p3Data = p3Buf.detachAsData(); |
Mike Reed | ede7bac | 2017-07-23 15:30:02 -0400 | [diff] [blame] | 1599 | std::unique_ptr<SkCodec> p3Codec(SkCodec::MakeFromData(p3Data)); |
Matt Sarett | 0e032be | 2017-03-15 17:50:08 -0400 | [diff] [blame] | 1600 | REPORTER_ASSERT(r, p3Codec->getInfo().colorSpace()->gammaCloseToSRGB()); |
Mike Klein | 4429a4f | 2018-10-04 09:06:00 -0400 | [diff] [blame] | 1601 | SkMatrix44 mat0, mat1; |
Matt Sarett | 0e032be | 2017-03-15 17:50:08 -0400 | [diff] [blame] | 1602 | bool success = p3->toXYZD50(&mat0); |
| 1603 | REPORTER_ASSERT(r, success); |
| 1604 | success = p3Codec->getInfo().colorSpace()->toXYZD50(&mat1); |
| 1605 | REPORTER_ASSERT(r, success); |
| 1606 | |
| 1607 | for (int i = 0; i < 4; i++) { |
| 1608 | for (int j = 0; j < 4; j++) { |
Matt Sarett | 5df93de | 2017-03-22 21:52:47 +0000 | [diff] [blame] | 1609 | REPORTER_ASSERT(r, color_space_almost_equal(mat0.get(i, j), mat1.get(i, j))); |
Matt Sarett | 0e032be | 2017-03-15 17:50:08 -0400 | [diff] [blame] | 1610 | } |
| 1611 | } |
| 1612 | } |
Matt Sarett | 5df93de | 2017-03-22 21:52:47 +0000 | [diff] [blame] | 1613 | |
| 1614 | DEF_TEST(Codec_EncodeICC, r) { |
Brian Osman | b62f50c | 2018-07-12 14:44:27 -0400 | [diff] [blame] | 1615 | test_encode_icc(r, SkEncodedImageFormat::kPNG); |
| 1616 | test_encode_icc(r, SkEncodedImageFormat::kJPEG); |
| 1617 | test_encode_icc(r, SkEncodedImageFormat::kWEBP); |
Matt Sarett | 5df93de | 2017-03-22 21:52:47 +0000 | [diff] [blame] | 1618 | } |
Leon Scroggins III | e567746 | 2017-09-27 16:31:08 -0400 | [diff] [blame] | 1619 | |
| 1620 | DEF_TEST(Codec_webp_rowsDecoded, r) { |
Hal Canary | c465d13 | 2017-12-08 10:21:31 -0500 | [diff] [blame] | 1621 | const char* path = "images/baby_tux.webp"; |
Leon Scroggins III | e567746 | 2017-09-27 16:31:08 -0400 | [diff] [blame] | 1622 | sk_sp<SkData> data(GetResourceAsData(path)); |
| 1623 | if (!data) { |
| 1624 | return; |
| 1625 | } |
| 1626 | |
| 1627 | // Truncate this file so that the header is available but no rows can be |
| 1628 | // decoded. This should create a codec but fail to decode. |
| 1629 | size_t truncatedSize = 5000; |
| 1630 | sk_sp<SkData> subset = SkData::MakeSubset(data.get(), 0, truncatedSize); |
| 1631 | std::unique_ptr<SkCodec> codec = SkCodec::MakeFromData(std::move(subset)); |
| 1632 | if (!codec) { |
| 1633 | ERRORF(r, "Failed to create a codec for %s truncated to only %lu bytes", |
| 1634 | path, truncatedSize); |
| 1635 | return; |
| 1636 | } |
| 1637 | |
| 1638 | test_info(r, codec.get(), codec->getInfo(), SkCodec::kInvalidInput, nullptr); |
| 1639 | } |
Leon Scroggins III | cbf66a2 | 2018-02-16 12:03:03 -0500 | [diff] [blame] | 1640 | |
Leon Scroggins III | e93ec68 | 2018-10-26 09:25:51 -0400 | [diff] [blame] | 1641 | /* |
| 1642 | For the Codec_ossfuzz6274 test, immediately below, |
| 1643 | resources/invalid_images/ossfuzz6274.gif is: |
| 1644 | |
| 1645 | 00000000: 4749 4638 3961 2000 2000 f120 2020 2020 GIF89a . .. |
| 1646 | 00000010: 2020 2020 2020 2020 2021 f903 ff20 2020 !... |
| 1647 | 00000020: 002c 0000 0000 2000 2000 2000 00 .,.... . . .. |
| 1648 | |
| 1649 | @000 6 bytes magic "GIF89a" |
| 1650 | @006 7 bytes Logical Screen Descriptor: 0x20 0x00 ... 0x00 |
| 1651 | - width = 32 |
| 1652 | - height = 32 |
| 1653 | - flags = 0xF1, global color table, 4 RGB entries |
| 1654 | - background color index, pixel aspect ratio bytes ignored |
| 1655 | @00D 12 bytes Color Table: 0x20 0x20 ... 0x20 |
| 1656 | @019 20 bytes Graphic Control Extension: 0x21 0xF9 ... unexpected-EOF |
| 1657 | - 0x03 precedes a 3 byte block of data, INVALID, MUST BE 4 |
| 1658 | - 0x20 precedes a 32 byte block of data, INVALIDly truncated |
| 1659 | |
| 1660 | https://www.w3.org/Graphics/GIF/spec-gif89a.txt section 23.c says that the |
| 1661 | block size (for an 0x21 0xF9 Graphic Control Extension) must be "the fixed |
| 1662 | value 4". |
| 1663 | */ |
| 1664 | |
Leon Scroggins III | cbf66a2 | 2018-02-16 12:03:03 -0500 | [diff] [blame] | 1665 | DEF_TEST(Codec_ossfuzz6274, r) { |
| 1666 | if (GetResourcePath().isEmpty()) { |
| 1667 | return; |
| 1668 | } |
| 1669 | |
| 1670 | const char* file = "invalid_images/ossfuzz6274.gif"; |
| 1671 | auto image = GetResourceAsImage(file); |
Leon Scroggins III | e93ec68 | 2018-10-26 09:25:51 -0400 | [diff] [blame] | 1672 | |
| 1673 | #ifdef SK_HAS_WUFFS_LIBRARY |
| 1674 | // We are transitioning from an old GIF implementation to a new (Wuffs) GIF |
| 1675 | // implementation. |
| 1676 | // |
| 1677 | // This test (without SK_HAS_WUFFS_LIBRARY) is overly specific to the old |
| 1678 | // implementation. In the new implementation, the MakeFromStream factory |
| 1679 | // method returns a nullptr SkImage*, instead of returning a non-null but |
| 1680 | // otherwise all-transparent SkImage*. |
| 1681 | // |
| 1682 | // Either way, the end-to-end result is the same - the source input is |
| 1683 | // rejected as an invalid GIF image - but the two implementations differ in |
| 1684 | // how that's represented. |
| 1685 | // |
| 1686 | // Once the transition is complete, we can remove the #ifdef and delete the |
| 1687 | // rest of the test function. |
| 1688 | // |
| 1689 | // See Codec_GifTruncated3 for the equivalent of the rest of the test |
| 1690 | // function, on different (but still truncated) source data. |
| 1691 | if (image) { |
| 1692 | ERRORF(r, "Invalid data gave non-nullptr image"); |
| 1693 | } |
| 1694 | return; |
| 1695 | #endif |
| 1696 | |
Leon Scroggins III | cbf66a2 | 2018-02-16 12:03:03 -0500 | [diff] [blame] | 1697 | if (!image) { |
| 1698 | ERRORF(r, "Missing %s", file); |
| 1699 | return; |
| 1700 | } |
| 1701 | |
| 1702 | REPORTER_ASSERT(r, image->width() == 32); |
| 1703 | REPORTER_ASSERT(r, image->height() == 32); |
| 1704 | |
| 1705 | SkBitmap bm; |
| 1706 | if (!bm.tryAllocPixels(SkImageInfo::MakeN32Premul(32, 32))) { |
| 1707 | ERRORF(r, "Failed to allocate pixels"); |
| 1708 | return; |
| 1709 | } |
| 1710 | |
| 1711 | bm.eraseColor(SK_ColorTRANSPARENT); |
| 1712 | |
| 1713 | SkCanvas canvas(bm); |
| 1714 | canvas.drawImage(image, 0, 0, nullptr); |
| 1715 | |
| 1716 | for (int i = 0; i < image->width(); ++i) |
| 1717 | for (int j = 0; j < image->height(); ++j) { |
| 1718 | SkColor actual = SkUnPreMultiply::PMColorToColor(*bm.getAddr32(i, j)); |
| 1719 | if (actual != SK_ColorTRANSPARENT) { |
| 1720 | ERRORF(r, "did not initialize pixels! %i, %i is %x", i, j, actual); |
| 1721 | } |
| 1722 | } |
| 1723 | } |
Leon Scroggins III | 9e8a594 | 2018-02-28 16:24:18 -0500 | [diff] [blame] | 1724 | |
Leon Scroggins III | 665949a | 2018-06-26 10:49:42 -0400 | [diff] [blame] | 1725 | DEF_TEST(Codec_78329453, r) { |
| 1726 | if (GetResourcePath().isEmpty()) { |
| 1727 | return; |
| 1728 | } |
| 1729 | |
| 1730 | const char* file = "images/b78329453.jpeg"; |
| 1731 | auto data = GetResourceAsData(file); |
| 1732 | if (!data) { |
| 1733 | ERRORF(r, "Missing %s", file); |
| 1734 | return; |
| 1735 | } |
| 1736 | |
| 1737 | auto codec = SkAndroidCodec::MakeFromCodec(SkCodec::MakeFromData(data)); |
| 1738 | if (!codec) { |
| 1739 | ERRORF(r, "failed to create codec from %s", file); |
| 1740 | return; |
| 1741 | } |
| 1742 | |
| 1743 | // A bug in jpeg_skip_scanlines resulted in an infinite loop for this specific |
| 1744 | // sample size on this image. Other sample sizes could have had the same result, |
| 1745 | // but the ones tested by DM happen to not. |
| 1746 | constexpr int kSampleSize = 19; |
| 1747 | const auto size = codec->getSampledDimensions(kSampleSize); |
| 1748 | auto info = codec->getInfo().makeWH(size.width(), size.height()); |
| 1749 | SkBitmap bm; |
| 1750 | bm.allocPixels(info); |
| 1751 | bm.eraseColor(SK_ColorTRANSPARENT); |
| 1752 | |
| 1753 | SkAndroidCodec::AndroidOptions options; |
| 1754 | options.fSampleSize = kSampleSize; |
| 1755 | auto result = codec->getAndroidPixels(info, bm.getPixels(), bm.rowBytes(), &options); |
| 1756 | if (result != SkCodec::kSuccess) { |
| 1757 | ERRORF(r, "failed to decode with error %s", SkCodec::ResultToString(result)); |
| 1758 | } |
| 1759 | } |
| 1760 | |
Leon Scroggins III | 36f7e32 | 2018-08-27 11:55:46 -0400 | [diff] [blame] | 1761 | DEF_TEST(Codec_A8, r) { |
| 1762 | if (GetResourcePath().isEmpty()) { |
| 1763 | return; |
| 1764 | } |
| 1765 | |
| 1766 | const char* file = "images/mandrill_cmyk.jpg"; |
| 1767 | auto data = GetResourceAsData(file); |
| 1768 | if (!data) { |
| 1769 | ERRORF(r, "missing %s", file); |
| 1770 | return; |
| 1771 | } |
| 1772 | |
| 1773 | auto codec = SkCodec::MakeFromData(std::move(data)); |
| 1774 | auto info = codec->getInfo().makeColorType(kAlpha_8_SkColorType); |
| 1775 | SkBitmap bm; |
| 1776 | bm.allocPixels(info); |
| 1777 | REPORTER_ASSERT(r, codec->getPixels(bm.pixmap()) == SkCodec::kInvalidConversion); |
| 1778 | } |
| 1779 | |
Leon Scroggins III | 9e8a594 | 2018-02-28 16:24:18 -0500 | [diff] [blame] | 1780 | DEF_TEST(Codec_crbug807324, r) { |
| 1781 | if (GetResourcePath().isEmpty()) { |
| 1782 | return; |
| 1783 | } |
| 1784 | |
| 1785 | const char* file = "images/crbug807324.png"; |
| 1786 | auto image = GetResourceAsImage(file); |
| 1787 | if (!image) { |
| 1788 | ERRORF(r, "Missing %s", file); |
| 1789 | return; |
| 1790 | } |
| 1791 | |
| 1792 | const int kWidth = image->width(); |
| 1793 | const int kHeight = image->height(); |
| 1794 | |
| 1795 | SkBitmap bm; |
| 1796 | if (!bm.tryAllocPixels(SkImageInfo::MakeN32Premul(kWidth, kHeight))) { |
| 1797 | ERRORF(r, "Could not allocate pixels (%i x %i)", kWidth, kHeight); |
| 1798 | return; |
| 1799 | } |
| 1800 | |
| 1801 | bm.eraseColor(SK_ColorTRANSPARENT); |
| 1802 | |
| 1803 | SkCanvas canvas(bm); |
| 1804 | canvas.drawImage(image, 0, 0, nullptr); |
| 1805 | |
| 1806 | for (int i = 0; i < kWidth; ++i) |
| 1807 | for (int j = 0; j < kHeight; ++j) { |
| 1808 | if (*bm.getAddr32(i, j) == SK_ColorTRANSPARENT) { |
| 1809 | ERRORF(r, "image should not be transparent! %i, %i is 0", i, j); |
| 1810 | return; |
| 1811 | } |
| 1812 | } |
| 1813 | } |