blob: 71475a811008c8f5f41c5d00b23e565acb5944ed [file] [log] [blame]
mtklein7fbfbbe2016-07-21 12:25:45 -07001# Copyright 2016 Google Inc.
2#
3# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
6declare_args() {
Kevin Lubick2677a9a2017-03-28 15:45:41 -04007 extra_asmflags = []
Mike Klein121563e2016-10-04 17:09:13 -04008 extra_cflags = []
9 extra_cflags_c = []
10 extra_cflags_cc = []
11 extra_ldflags = []
mtkleincab0bb72016-08-26 13:43:19 -070012
Herb Derby76073c12016-12-08 19:00:40 -050013 malloc = ""
mtklein7fbfbbe2016-07-21 12:25:45 -070014}
Mike Klein82364ba2016-10-24 16:49:15 -040015
Mike Klein87c36f22016-11-13 10:29:25 -050016is_clang = is_android || is_ios || is_mac || (cc == "clang" && cxx == "clang++")
17if (!is_clang && !is_win) {
Mike Klein461d3282016-10-11 13:51:55 -040018 is_clang = exec_script("is_clang.py",
19 [
20 cc,
21 cxx,
22 ],
23 "value")
24}
mtkleinf347c512016-09-26 08:40:12 -070025
Mike Klein7d302882016-11-03 14:06:31 -040026if (is_ios) {
Matthew Leibowitz3150ec62017-03-14 16:22:32 -040027 if (is_tvos) {
28 sdk = "appletvos"
29 if (target_cpu == "x86" || target_cpu == "x64") {
30 sdk = "appletvsimulator"
31 }
32 } else {
33 sdk = "iphoneos"
34 if (target_cpu == "x86" || target_cpu == "x64") {
35 sdk = "iphonesimulator"
36 }
Mike Klein7a5e0f32017-03-13 09:25:33 -070037 }
38 ios_sysroot = exec_script("find_ios_sysroot.py", [ sdk ], "trim string")
Mike Klein7d302882016-11-03 14:06:31 -040039}
40
mtkleinb9be9792016-09-16 14:44:18 -070041config("default") {
42 asmflags = []
43 cflags = []
44 cflags_c = []
45 cflags_cc = []
46 defines = []
47 ldflags = []
Herb Derby76073c12016-12-08 19:00:40 -050048 libs = []
mtkleinb9be9792016-09-16 14:44:18 -070049
50 if (is_win) {
51 cflags += [
52 "/FS", # Preserve previous PDB behavior.
herbb6318bf2016-09-16 13:29:57 -070053 "/bigobj", # Some of our files are bigger than the regular limits.
Mike Kleinc7165c22016-10-12 23:58:06 -040054 "/WX", # Treat warnings as errors.
Ben Wagnere6b274e2017-01-03 17:09:59 -050055 "/utf-8", # Set Source and Executable character sets to UTF-8.
herbb6318bf2016-09-16 13:29:57 -070056 ]
mtkleinb9be9792016-09-16 14:44:18 -070057 defines += [
Mike Kleinc7165c22016-10-12 23:58:06 -040058 "_CRT_SECURE_NO_WARNINGS", # Disables warnings about sscanf().
59 "_HAS_EXCEPTIONS=0", # Disables exceptions in MSVC STL.
mtkleinb9be9792016-09-16 14:44:18 -070060 "WIN32_LEAN_AND_MEAN",
61 "NOMINMAX",
herbb6318bf2016-09-16 13:29:57 -070062 ]
Mike Klein0f61faa2016-10-11 16:26:57 -040063 include_dirs = [
Ben Wagner4e8472c2017-03-20 16:53:05 -040064 #2017
65 "$windk/VC/Tools/MSVC/14.10.25017/include",
66
67 #2015
Mike Kleind3016832016-10-12 15:52:44 -040068 "$windk/VC/include",
Mike Kleincc300a12016-10-12 16:25:27 -040069
Mike Kleind3016832016-10-12 15:52:44 -040070 # For local builds.
Ben Wagner4e8472c2017-03-20 16:53:05 -040071 # 2017
72 "$windk/../../../Windows Kits/10/Include/10.0.14393.0/shared",
73 "$windk/../../../Windows Kits/10/Include/10.0.14393.0/ucrt",
74 "$windk/../../../Windows Kits/10/Include/10.0.14393.0/um",
75 "$windk/../../../Windows Kits/10/Include/10.0.14393.0/winrt",
76
77 # 2015
Mike Klein0f61faa2016-10-11 16:26:57 -040078 "$windk/../Windows Kits/8.1/Include/shared",
Ben Wagner4e8472c2017-03-20 16:53:05 -040079 "$windk/../Windows Kits/10/Include/10.0.10150.0/ucrt",
Mike Klein3eb71212016-10-11 17:08:53 -040080 "$windk/../Windows Kits/8.1/Include/um",
Brian Osman21d742d2017-01-10 13:31:33 -050081 "$windk/../Windows Kits/8.1/Include/winrt",
Mike Kleincc300a12016-10-12 16:25:27 -040082
Mike Kleind3016832016-10-12 15:52:44 -040083 # For builds using win_toolchain asset.
Brian Osman3f289332017-01-10 10:38:23 -050084 "$windk/win_sdk/Include/10.0.14393.0/shared",
85 "$windk/win_sdk/Include/10.0.14393.0/ucrt",
86 "$windk/win_sdk/Include/10.0.14393.0/um",
Brian Osman21d742d2017-01-10 13:31:33 -050087 "$windk/win_sdk/Include/10.0.14393.0/winrt",
Mike Klein0f61faa2016-10-11 16:26:57 -040088 ]
Mike Klein3eb71212016-10-11 17:08:53 -040089 lib_dirs = [
Mike Kleind3016832016-10-12 15:52:44 -040090 # For local builds.
Ben Wagner4e8472c2017-03-20 16:53:05 -040091 # 2017
92 "$windk/../../../Windows Kits/10/Lib/10.0.14393.0/ucrt/$target_cpu",
93 "$windk/../../../Windows Kits/10/Lib/10.0.14393.0/um/$target_cpu",
94
95 #2015
Mike Klein0bc5a762016-10-12 22:42:55 -040096 "$windk/../Windows Kits/10/Lib/10.0.10150.0/ucrt/$target_cpu",
97 "$windk/../Windows Kits/8.1/Lib/winv6.3/um/$target_cpu",
Mike Kleincc300a12016-10-12 16:25:27 -040098
Mike Kleind3016832016-10-12 15:52:44 -040099 # For builds using win_toolchain asset.
Brian Osman3f289332017-01-10 10:38:23 -0500100 "$windk/win_sdk/Lib/10.0.14393.0/ucrt/$target_cpu",
101 "$windk/win_sdk/Lib/10.0.14393.0/um/$target_cpu",
Mike Klein3eb71212016-10-11 17:08:53 -0400102 ]
Ben Wagner4e8472c2017-03-20 16:53:05 -0400103
104 #2017
105 lib_dirs += [ "$windk/VC/Tools/MSVC/14.10.25017/lib/$target_cpu" ]
106
107 #2015
Mike Klein0bc5a762016-10-12 22:42:55 -0400108 if (target_cpu == "x86") {
109 lib_dirs += [ "$windk/VC/lib" ]
110 } else {
111 lib_dirs += [ "$windk/VC/lib/amd64" ]
112 }
mtkleinb9be9792016-09-16 14:44:18 -0700113 } else {
114 cflags += [
herbb6318bf2016-09-16 13:29:57 -0700115 "-fstrict-aliasing",
116 "-fPIC",
herbb6318bf2016-09-16 13:29:57 -0700117 "-Werror",
mtklein2b3c2a32016-09-08 08:39:34 -0700118 ]
Mike Klein28f5b772017-04-06 23:04:42 -0400119 cflags_cc += [ "-std=c++11" ]
Mike Kleineec23d12017-03-26 20:11:48 -0400120
121 # The main idea is to slim the exported API, but these flags also improve link time on Mac.
122 # These would make stack traces worse on Linux, so we don't just set them willy-nilly.
Mike Klein8cb66482017-03-28 14:16:22 -0400123 if (is_component_build || is_ios || is_mac) {
Mike Kleineec23d12017-03-26 20:11:48 -0400124 cflags += [ "-fvisibility=hidden" ]
125 cflags_cc += [ "-fvisibility-inlines-hidden" ]
126 }
mtkleinb9be9792016-09-16 14:44:18 -0700127 }
herbb6318bf2016-09-16 13:29:57 -0700128
mtkleinb9be9792016-09-16 14:44:18 -0700129 if (current_cpu == "arm") {
130 cflags += [
131 "-march=armv7-a",
132 "-mfpu=neon",
133 "-mthumb",
134 ]
135 } else if (current_cpu == "mipsel") {
Derek Sollenberger19b2a562017-06-27 11:55:05 -0400136 cflags += [ "-march=mips32r2" ]
137 } else if (current_cpu == "mips64el") {
138 asmflags += [ "-integrated-as" ]
139 cflags += [ "-integrated-as" ]
Mike Klein5d8cf292016-10-12 19:36:09 -0400140 } else if (current_cpu == "x86" && !is_win) {
mtkleinb9be9792016-09-16 14:44:18 -0700141 asmflags += [ "-m32" ]
142 cflags += [
143 "-m32",
144 "-msse2",
145 "-mfpmath=sse",
146 ]
147 ldflags += [ "-m32" ]
148 }
herbb6318bf2016-09-16 13:29:57 -0700149
Herb Derby76073c12016-12-08 19:00:40 -0500150 if (malloc != "" && !is_win) {
151 cflags += [
152 "-fno-builtin-malloc",
153 "-fno-builtin-calloc",
154 "-fno-builtin-realloc",
155 "-fno-builtin-free",
156 ]
157 libs += [ malloc ]
158 }
159
mtkleinb9be9792016-09-16 14:44:18 -0700160 if (is_android) {
Derek Sollenberger19b2a562017-06-27 11:55:05 -0400161 asmflags += [ "--target=$ndk_target" ]
mtkleinb9be9792016-09-16 14:44:18 -0700162 cflags += [
Derek Sollenberger19b2a562017-06-27 11:55:05 -0400163 "--sysroot=$ndk/sysroot",
164 "-isystem$ndk/sysroot/usr/include/$ndk_target",
165 "-D__ANDROID_API__=$ndk_api",
mtkleinb9be9792016-09-16 14:44:18 -0700166 "--target=$ndk_target",
mtkleinb9be9792016-09-16 14:44:18 -0700167 ]
168 cflags_cc += [
169 "-isystem$ndk/sources/android/support/include",
Mike Kleinb7ce80b2016-12-14 13:17:53 -0500170 "-isystem$ndk/sources/cxx-stl/gnu-libstdc++/4.9/include",
171 "-isystem$ndk/sources/cxx-stl/gnu-libstdc++/4.9/libs/$ndk_stdlib/include",
mtkleinb9be9792016-09-16 14:44:18 -0700172 ]
173 ldflags += [
174 "--sysroot=$ndk/platforms/$ndk_platform",
175 "--target=$ndk_target",
176 "-B$ndk/toolchains/$ndk_gccdir-4.9/prebuilt/$ndk_host/$ndk_target/bin",
mtkleinb9be9792016-09-16 14:44:18 -0700177 ]
178 lib_dirs = [
Mike Kleinb7ce80b2016-12-14 13:17:53 -0500179 "$ndk/sources/cxx-stl/gnu-libstdc++/4.9/libs/$ndk_stdlib",
mtkleinb9be9792016-09-16 14:44:18 -0700180 "$ndk/toolchains/$ndk_gccdir-4.9/prebuilt/$ndk_host/lib/gcc/$ndk_target/4.9.x",
181 ]
herbb6318bf2016-09-16 13:29:57 -0700182
Mike Klein4fdc5432016-10-11 11:21:36 -0400183 if (current_cpu == "mips64el") {
Derek Sollenberger19b2a562017-06-27 11:55:05 -0400184 # The r15b NDK deployed on our bots fails to find /usr/lib64 in the
185 # MIPS64 sysroots, so we must point Clang at /usr/lib64 manually.
Mike Klein4fdc5432016-10-11 11:21:36 -0400186 lib_dirs += [ "$ndk/platforms/$ndk_platform/usr/lib64" ]
Mike Klein978cceb2016-12-08 10:29:27 -0500187 ldflags += [ "-B$ndk/platforms/$ndk_platform/usr/lib64" ]
Mike Klein4fdc5432016-10-11 11:21:36 -0400188 }
189
Mike Kleinb7ce80b2016-12-14 13:17:53 -0500190 libs += [ "gnustl_static" ]
mtklein2b3c2a32016-09-08 08:39:34 -0700191 }
mtklein7fbfbbe2016-07-21 12:25:45 -0700192
Mike Klein7d302882016-11-03 14:06:31 -0400193 if (is_ios) {
Mike Kleinb48fd3c2017-01-23 11:58:53 -0500194 _target = target_cpu
195 if (target_cpu == "arm") {
196 _target = "armv7"
Mike Klein7a5e0f32017-03-13 09:25:33 -0700197 } else if (target_cpu == "x86") {
198 _target = "i386"
199 } else if (target_cpu == "x64") {
200 _target = "x86_64"
Mike Kleinb48fd3c2017-01-23 11:58:53 -0500201 }
Mike Klein4fe2b152017-02-17 15:36:01 -0500202 asmflags += [
203 "-isysroot",
204 ios_sysroot,
205 "-arch",
206 _target,
207 ]
Mike Klein7d302882016-11-03 14:06:31 -0400208 cflags += [
Mike Klein6749af42016-11-07 15:38:48 -0500209 "-isysroot",
210 ios_sysroot,
211 "-arch",
Mike Kleinb48fd3c2017-01-23 11:58:53 -0500212 _target,
Mike Klein7d302882016-11-03 14:06:31 -0400213 ]
214 cflags_cc += [ "-stdlib=libc++" ]
215 ldflags += [
Mike Klein6749af42016-11-07 15:38:48 -0500216 "-isysroot",
217 ios_sysroot,
218 "-arch",
Mike Kleinb48fd3c2017-01-23 11:58:53 -0500219 _target,
Mike Klein7d302882016-11-03 14:06:31 -0400220 "-stdlib=libc++",
221 ]
Herb Derby76073c12016-12-08 19:00:40 -0500222 libs += [ "objc" ]
Mike Klein7d302882016-11-03 14:06:31 -0400223 }
224
mtkleinb9be9792016-09-16 14:44:18 -0700225 if (is_linux) {
Herb Derby76073c12016-12-08 19:00:40 -0500226 libs += [ "pthread" ]
mtkleinb9be9792016-09-16 14:44:18 -0700227 }
228
229 if (sanitize != "") {
230 # You can either pass the sanitizers directly, e.g. "address,undefined",
231 # or pass one of the couple common aliases used by the bots.
232 sanitizers = sanitize
233 if (sanitize == "ASAN") {
234 sanitizers = "address,bool,function,integer-divide-by-zero,nonnull-attribute,null,object-size,return,returns-nonnull-attribute,shift,signed-integer-overflow,unreachable,vla-bound,vptr"
235 } else if (sanitize == "TSAN") {
236 sanitizers = "thread"
237 } else if (sanitize == "MSAN") {
238 sanitizers = "memory"
239 }
240
241 cflags += [
242 "-fsanitize=$sanitizers",
243 "-fno-sanitize-recover=$sanitizers",
244 "-fsanitize-blacklist=" + rebase_path("../tools/xsan.blacklist"),
245 ]
246 ldflags += [ "-fsanitize=$sanitizers" ]
247 if (sanitizers == "memory") {
248 cflags += [ "-fsanitize-memory-track-origins" ]
249 cflags_cc += [ "-stdlib=libc++" ]
250 ldflags += [ "-stdlib=libc++" ]
251 }
252 }
253}
254
Mike Klein6e55fef2016-10-26 11:41:47 -0400255config("no_exceptions") {
256 # Exceptions are disabled by default on Windows. (Use /EHsc to enable them.)
257 if (!is_win) {
258 cflags_cc = [ "-fno-exceptions" ]
259 }
260}
261
Mike Kleinc7165c22016-10-12 23:58:06 -0400262config("warnings") {
263 cflags = []
264 cflags_cc = []
Mike Klein43c25262016-10-20 10:17:47 -0400265 cflags_objc = []
Greg Daniel6b7e0e22017-07-12 16:21:09 -0400266 cflags_objcc = []
Mike Kleinc7165c22016-10-12 23:58:06 -0400267 if (is_win) {
268 cflags += [
269 "/W3", # Turn on lots of warnings.
270
271 # Disable a bunch of warnings:
272 "/wd4244", # conversion from 'float' to 'int', possible loss of data
273 "/wd4267", # conversion from 'size_t' to 'int', possible loss of data
274 "/wd4800", # forcing value to bool 'true' or 'false' (performance warning)
275
276 # Probably only triggers when /EHsc is enabled.
277 "/wd4291", # no matching operator delete found;
278 # memory will not be freed if initialization throws an exception
279 ]
280 } else {
281 cflags += [
282 "-Wall",
283 "-Wextra",
284 "-Winit-self",
285 "-Wpointer-arith",
286 "-Wsign-compare",
287 "-Wvla",
288
289 "-Wno-deprecated-declarations",
Mike Kleindb402ca2016-12-13 12:46:05 -0500290 "-Wno-maybe-uninitialized",
Mike Kleinc7165c22016-10-12 23:58:06 -0400291 ]
292 cflags_cc += [ "-Wnon-virtual-dtor" ]
293
294 if (is_clang) {
295 cflags += [
296 "-Weverything",
297 "-Wno-unknown-warning-option", # Let older Clangs ignore newer Clangs' warnings.
298 ]
299
Mike Kleinb48fd3c2017-01-23 11:58:53 -0500300 if ((target_cpu == "x86" && is_android) ||
301 (target_cpu == "arm" && is_ios)) {
302 # Clang seems to think new/malloc will only be 4-byte aligned on x86 Android and 32-bit iOS.
Mike Kleinc7165c22016-10-12 23:58:06 -0400303 # We're pretty sure it's actually 8-byte alignment.
304 cflags += [ "-Wno-over-aligned" ]
305 }
306
307 cflags += [
308 "-Wno-cast-align",
309 "-Wno-conditional-uninitialized",
310 "-Wno-conversion",
311 "-Wno-disabled-macro-expansion",
312 "-Wno-documentation",
313 "-Wno-documentation-unknown-command",
314 "-Wno-double-promotion",
315 "-Wno-exit-time-destructors", # TODO: OK outside libskia
316 "-Wno-float-conversion",
317 "-Wno-float-equal",
318 "-Wno-format-nonliteral",
319 "-Wno-global-constructors", # TODO: OK outside libskia
320 "-Wno-gnu-zero-variadic-macro-arguments",
321 "-Wno-missing-prototypes",
322 "-Wno-missing-variable-declarations",
323 "-Wno-pedantic",
324 "-Wno-reserved-id-macro",
325 "-Wno-shadow",
326 "-Wno-shift-sign-overflow",
327 "-Wno-sign-conversion",
Matt Sarettd3ed4022017-01-04 17:13:44 -0500328 "-Wno-signed-enum-bitfield",
Mike Kleinc7165c22016-10-12 23:58:06 -0400329 "-Wno-switch-enum",
330 "-Wno-undef",
331 "-Wno-unreachable-code",
332 "-Wno-unreachable-code-break",
333 "-Wno-unreachable-code-return",
334 "-Wno-unused-macros",
335 "-Wno-unused-member-function",
336 ]
337 cflags_cc += [
338 "-Wno-abstract-vbase-init",
Mike Kleinc7165c22016-10-12 23:58:06 -0400339 "-Wno-weak-vtables",
340 ]
341
342 # We are unlikely to want to fix these.
343 cflags += [
344 "-Wno-covered-switch-default",
345 "-Wno-deprecated",
346 "-Wno-implicit-fallthrough",
347 "-Wno-missing-noreturn",
348 "-Wno-old-style-cast",
349 "-Wno-padded",
350 ]
351 cflags_cc += [
352 "-Wno-c++98-compat",
353 "-Wno-c++98-compat-pedantic",
354 "-Wno-undefined-func-template",
355 ]
Mike Klein43c25262016-10-20 10:17:47 -0400356 cflags_objc += [
357 "-Wno-direct-ivar-access",
358 "-Wno-objc-interface-ivars",
359 ]
Greg Daniel6b7e0e22017-07-12 16:21:09 -0400360 cflags_objcc += [
361 "-Wno-direct-ivar-access",
362 "-Wno-objcc-interface-ivars",
363 ]
Mike Kleinc7165c22016-10-12 23:58:06 -0400364 }
365 }
366}
Mike Klein50500ad2016-11-16 12:13:44 -0500367config("warnings_except_public_headers") {
368 if (!is_win) {
369 cflags = [ "-Wno-unused-parameter" ]
370 }
371}
Mike Kleinc7165c22016-10-12 23:58:06 -0400372
Mike Klein121563e2016-10-04 17:09:13 -0400373config("extra_flags") {
Kevin Lubick2677a9a2017-03-28 15:45:41 -0400374 asmflags = extra_asmflags
Mike Klein121563e2016-10-04 17:09:13 -0400375 cflags = extra_cflags
376 cflags_c = extra_cflags_c
377 cflags_cc = extra_cflags_cc
378 ldflags = extra_ldflags
379}
380
mtkleinb9be9792016-09-16 14:44:18 -0700381config("debug_symbols") {
382 # It's annoying to wait for full debug symbols to push over
383 # to Android devices. -gline-tables-only is a lot slimmer.
384 if (is_android) {
385 cflags = [ "-gline-tables-only" ]
Mike Kleincc300a12016-10-12 16:25:27 -0400386 } else if (is_win) {
387 cflags = [ "/Zi" ]
Mike Klein5286d6c2016-10-13 13:19:25 -0400388 ldflags = [ "/DEBUG" ]
Mike Kleincc300a12016-10-12 16:25:27 -0400389 } else {
mtkleinb9be9792016-09-16 14:44:18 -0700390 cflags = [ "-g" ]
391 }
392}
393
394config("no_rtti") {
395 if (sanitize != "ASAN") { # -fsanitize=vptr requires RTTI
Mike Kleincc300a12016-10-12 16:25:27 -0400396 if (is_win) {
397 cflags_cc = [ "/GR-" ]
398 } else {
mtkleinb9be9792016-09-16 14:44:18 -0700399 cflags_cc = [ "-fno-rtti" ]
400 }
401 }
402}
403
404config("release") {
Mike Kleincc300a12016-10-12 16:25:27 -0400405 if (is_win) {
Mike Klein916ca1d2016-10-20 13:34:18 -0400406 cflags = [
407 "/O2",
408 "/Zc:inline",
Mike Klein8ffb2602016-10-20 15:45:02 -0400409 "/GS-",
Mike Klein916ca1d2016-10-20 13:34:18 -0400410 ]
Mike Klein90a381f2016-10-20 13:52:38 -0400411 ldflags = [
412 "/OPT:ICF",
413 "/OPT:REF",
414 ]
Mike Kleincc300a12016-10-12 16:25:27 -0400415 } else {
Mike Klein0bcfeac2016-10-19 22:24:10 -0400416 cflags = [
417 "-O3",
Mike Kleinbd9be4d2017-02-10 07:59:39 -0500418 "-fdata-sections",
419 "-ffunction-sections",
Mike Klein0bcfeac2016-10-19 22:24:10 -0400420 ]
Mike Kleinbd9be4d2017-02-10 07:59:39 -0500421 if (is_mac || is_ios) {
422 ldflags = [ "-dead_strip" ]
423 } else {
424 ldflags = [ "-Wl,--gc-sections" ]
425 }
herbb6318bf2016-09-16 13:29:57 -0700426 }
mtkleinb9be9792016-09-16 14:44:18 -0700427 defines = [ "NDEBUG" ]
mtklein7fbfbbe2016-07-21 12:25:45 -0700428}
429
430config("executable") {
Mike Kleinc5875fb2016-12-06 10:46:02 -0500431 if (is_android) {
432 ldflags = [ "-pie" ]
433 } else if (is_mac) {
mtklein7fbfbbe2016-07-21 12:25:45 -0700434 ldflags = [ "-Wl,-rpath,@loader_path/." ]
435 } else if (is_linux) {
mtkleina846c722016-09-15 10:44:15 -0700436 ldflags = [
437 "-rdynamic",
438 "-Wl,-rpath,\$ORIGIN",
439 ]
Mike Klein4b6b5032016-11-06 11:54:19 -0500440 } else if (is_win) {
441 ldflags = [
442 "/SUBSYSTEM:CONSOLE", # Quiet "no subsystem specified; CONSOLE assumed".
443 "/INCREMENTAL:NO", # Quiet warnings about failing to incrementally link by never trying to.
444 ]
mtklein7fbfbbe2016-07-21 12:25:45 -0700445 }
446}