John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2020 Google LLC |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license that can be |
| 5 | * found in the LICENSE file. |
| 6 | */ |
| 7 | |
| 8 | #include "src/sksl/SkSLInliner.h" |
| 9 | |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 10 | #include <limits.h> |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 11 | #include <memory> |
| 12 | #include <unordered_set> |
| 13 | |
Ethan Nicholas | daed259 | 2021-03-04 14:30:25 -0500 | [diff] [blame] | 14 | #include "include/private/SkSLLayout.h" |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 15 | #include "src/sksl/SkSLAnalysis.h" |
| 16 | #include "src/sksl/ir/SkSLBinaryExpression.h" |
| 17 | #include "src/sksl/ir/SkSLBoolLiteral.h" |
| 18 | #include "src/sksl/ir/SkSLBreakStatement.h" |
| 19 | #include "src/sksl/ir/SkSLConstructor.h" |
John Stiles | 7384b37 | 2021-04-01 13:48:15 -0400 | [diff] [blame] | 20 | #include "src/sksl/ir/SkSLConstructorArray.h" |
John Stiles | 8cad637 | 2021-04-07 12:31:13 -0400 | [diff] [blame] | 21 | #include "src/sksl/ir/SkSLConstructorCompound.h" |
| 22 | #include "src/sksl/ir/SkSLConstructorCompoundCast.h" |
John Stiles | e118278 | 2021-03-30 22:09:37 -0400 | [diff] [blame] | 23 | #include "src/sksl/ir/SkSLConstructorDiagonalMatrix.h" |
John Stiles | 5abb9e1 | 2021-04-06 13:47:19 -0400 | [diff] [blame] | 24 | #include "src/sksl/ir/SkSLConstructorMatrixResize.h" |
John Stiles | fd7252f | 2021-04-04 22:24:40 -0400 | [diff] [blame] | 25 | #include "src/sksl/ir/SkSLConstructorScalarCast.h" |
John Stiles | 2938eea | 2021-04-01 18:58:25 -0400 | [diff] [blame] | 26 | #include "src/sksl/ir/SkSLConstructorSplat.h" |
John Stiles | d47330f | 2021-04-08 23:25:52 -0400 | [diff] [blame] | 27 | #include "src/sksl/ir/SkSLConstructorStruct.h" |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 28 | #include "src/sksl/ir/SkSLContinueStatement.h" |
| 29 | #include "src/sksl/ir/SkSLDiscardStatement.h" |
| 30 | #include "src/sksl/ir/SkSLDoStatement.h" |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 31 | #include "src/sksl/ir/SkSLExpressionStatement.h" |
| 32 | #include "src/sksl/ir/SkSLExternalFunctionCall.h" |
Brian Osman | be0b3b7 | 2021-01-06 14:27:35 -0500 | [diff] [blame] | 33 | #include "src/sksl/ir/SkSLExternalFunctionReference.h" |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 34 | #include "src/sksl/ir/SkSLField.h" |
| 35 | #include "src/sksl/ir/SkSLFieldAccess.h" |
| 36 | #include "src/sksl/ir/SkSLFloatLiteral.h" |
| 37 | #include "src/sksl/ir/SkSLForStatement.h" |
| 38 | #include "src/sksl/ir/SkSLFunctionCall.h" |
| 39 | #include "src/sksl/ir/SkSLFunctionDeclaration.h" |
| 40 | #include "src/sksl/ir/SkSLFunctionDefinition.h" |
| 41 | #include "src/sksl/ir/SkSLFunctionReference.h" |
| 42 | #include "src/sksl/ir/SkSLIfStatement.h" |
| 43 | #include "src/sksl/ir/SkSLIndexExpression.h" |
John Stiles | 98c1f82 | 2020-09-09 14:18:53 -0400 | [diff] [blame] | 44 | #include "src/sksl/ir/SkSLInlineMarker.h" |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 45 | #include "src/sksl/ir/SkSLIntLiteral.h" |
| 46 | #include "src/sksl/ir/SkSLInterfaceBlock.h" |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 47 | #include "src/sksl/ir/SkSLNop.h" |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 48 | #include "src/sksl/ir/SkSLPostfixExpression.h" |
| 49 | #include "src/sksl/ir/SkSLPrefixExpression.h" |
| 50 | #include "src/sksl/ir/SkSLReturnStatement.h" |
| 51 | #include "src/sksl/ir/SkSLSetting.h" |
| 52 | #include "src/sksl/ir/SkSLSwitchCase.h" |
| 53 | #include "src/sksl/ir/SkSLSwitchStatement.h" |
| 54 | #include "src/sksl/ir/SkSLSwizzle.h" |
| 55 | #include "src/sksl/ir/SkSLTernaryExpression.h" |
| 56 | #include "src/sksl/ir/SkSLUnresolvedFunction.h" |
| 57 | #include "src/sksl/ir/SkSLVarDeclarations.h" |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 58 | #include "src/sksl/ir/SkSLVariable.h" |
| 59 | #include "src/sksl/ir/SkSLVariableReference.h" |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 60 | |
| 61 | namespace SkSL { |
| 62 | namespace { |
| 63 | |
John Stiles | 031a767 | 2020-11-13 16:13:18 -0500 | [diff] [blame] | 64 | static constexpr int kInlinedStatementLimit = 2500; |
| 65 | |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 66 | static int count_returns_at_end_of_control_flow(const FunctionDefinition& funcDef) { |
| 67 | class CountReturnsAtEndOfControlFlow : public ProgramVisitor { |
| 68 | public: |
| 69 | CountReturnsAtEndOfControlFlow(const FunctionDefinition& funcDef) { |
| 70 | this->visitProgramElement(funcDef); |
| 71 | } |
| 72 | |
John Stiles | 5b408a3 | 2021-03-17 09:53:32 -0400 | [diff] [blame] | 73 | bool visitExpression(const Expression& expr) override { |
| 74 | // Do not recurse into expressions. |
| 75 | return false; |
| 76 | } |
| 77 | |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 78 | bool visitStatement(const Statement& stmt) override { |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 79 | switch (stmt.kind()) { |
| 80 | case Statement::Kind::kBlock: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 81 | // Check only the last statement of a block. |
Ethan Nicholas | 7bd6043 | 2020-09-25 14:31:59 -0400 | [diff] [blame] | 82 | const auto& block = stmt.as<Block>(); |
| 83 | return block.children().size() && |
| 84 | this->visitStatement(*block.children().back()); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 85 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 86 | case Statement::Kind::kSwitch: |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 87 | case Statement::Kind::kDo: |
| 88 | case Statement::Kind::kFor: |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 89 | // Don't introspect switches or loop structures at all. |
| 90 | return false; |
| 91 | |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 92 | case Statement::Kind::kReturn: |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 93 | ++fNumReturns; |
| 94 | [[fallthrough]]; |
| 95 | |
| 96 | default: |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 97 | return INHERITED::visitStatement(stmt); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 98 | } |
| 99 | } |
| 100 | |
| 101 | int fNumReturns = 0; |
| 102 | using INHERITED = ProgramVisitor; |
| 103 | }; |
| 104 | |
| 105 | return CountReturnsAtEndOfControlFlow{funcDef}.fNumReturns; |
| 106 | } |
| 107 | |
John Stiles | 991b09d | 2020-09-10 13:33:40 -0400 | [diff] [blame] | 108 | static bool contains_recursive_call(const FunctionDeclaration& funcDecl) { |
| 109 | class ContainsRecursiveCall : public ProgramVisitor { |
| 110 | public: |
| 111 | bool visit(const FunctionDeclaration& funcDecl) { |
| 112 | fFuncDecl = &funcDecl; |
Ethan Nicholas | ed84b73 | 2020-10-08 11:45:44 -0400 | [diff] [blame] | 113 | return funcDecl.definition() ? this->visitProgramElement(*funcDecl.definition()) |
| 114 | : false; |
John Stiles | 991b09d | 2020-09-10 13:33:40 -0400 | [diff] [blame] | 115 | } |
| 116 | |
| 117 | bool visitExpression(const Expression& expr) override { |
Ethan Nicholas | 0dec992 | 2020-10-05 15:51:52 -0400 | [diff] [blame] | 118 | if (expr.is<FunctionCall>() && expr.as<FunctionCall>().function().matches(*fFuncDecl)) { |
John Stiles | 991b09d | 2020-09-10 13:33:40 -0400 | [diff] [blame] | 119 | return true; |
| 120 | } |
| 121 | return INHERITED::visitExpression(expr); |
| 122 | } |
| 123 | |
| 124 | bool visitStatement(const Statement& stmt) override { |
Ethan Nicholas | ceb6214 | 2020-10-09 16:51:18 -0400 | [diff] [blame] | 125 | if (stmt.is<InlineMarker>() && |
| 126 | stmt.as<InlineMarker>().function().matches(*fFuncDecl)) { |
John Stiles | 991b09d | 2020-09-10 13:33:40 -0400 | [diff] [blame] | 127 | return true; |
| 128 | } |
| 129 | return INHERITED::visitStatement(stmt); |
| 130 | } |
| 131 | |
| 132 | const FunctionDeclaration* fFuncDecl; |
| 133 | using INHERITED = ProgramVisitor; |
| 134 | }; |
| 135 | |
| 136 | return ContainsRecursiveCall{}.visit(funcDecl); |
| 137 | } |
| 138 | |
John Stiles | 6d69608 | 2020-10-01 10:18:54 -0400 | [diff] [blame] | 139 | static std::unique_ptr<Statement>* find_parent_statement( |
| 140 | const std::vector<std::unique_ptr<Statement>*>& stmtStack) { |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 141 | SkASSERT(!stmtStack.empty()); |
| 142 | |
| 143 | // Walk the statement stack from back to front, ignoring the last element (which is the |
| 144 | // enclosing statement). |
| 145 | auto iter = stmtStack.rbegin(); |
| 146 | ++iter; |
| 147 | |
| 148 | // Anything counts as a parent statement other than a scopeless Block. |
| 149 | for (; iter != stmtStack.rend(); ++iter) { |
John Stiles | 6d69608 | 2020-10-01 10:18:54 -0400 | [diff] [blame] | 150 | std::unique_ptr<Statement>* stmt = *iter; |
| 151 | if (!(*stmt)->is<Block>() || (*stmt)->as<Block>().isScope()) { |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 152 | return stmt; |
| 153 | } |
| 154 | } |
| 155 | |
| 156 | // There wasn't any parent statement to be found. |
| 157 | return nullptr; |
| 158 | } |
| 159 | |
John Stiles | e41b4ee | 2020-09-28 12:28:16 -0400 | [diff] [blame] | 160 | std::unique_ptr<Expression> clone_with_ref_kind(const Expression& expr, |
| 161 | VariableReference::RefKind refKind) { |
| 162 | std::unique_ptr<Expression> clone = expr.clone(); |
John Stiles | 47c0a74 | 2021-02-09 09:30:35 -0500 | [diff] [blame] | 163 | Analysis::UpdateRefKind(clone.get(), refKind); |
John Stiles | e41b4ee | 2020-09-28 12:28:16 -0400 | [diff] [blame] | 164 | return clone; |
| 165 | } |
| 166 | |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 167 | class CountReturnsWithLimit : public ProgramVisitor { |
| 168 | public: |
| 169 | CountReturnsWithLimit(const FunctionDefinition& funcDef, int limit) : fLimit(limit) { |
| 170 | this->visitProgramElement(funcDef); |
| 171 | } |
| 172 | |
John Stiles | 5b408a3 | 2021-03-17 09:53:32 -0400 | [diff] [blame] | 173 | bool visitExpression(const Expression& expr) override { |
| 174 | // Do not recurse into expressions. |
| 175 | return false; |
| 176 | } |
| 177 | |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 178 | bool visitStatement(const Statement& stmt) override { |
| 179 | switch (stmt.kind()) { |
| 180 | case Statement::Kind::kReturn: { |
| 181 | ++fNumReturns; |
| 182 | fDeepestReturn = std::max(fDeepestReturn, fScopedBlockDepth); |
| 183 | return (fNumReturns >= fLimit) || INHERITED::visitStatement(stmt); |
| 184 | } |
John Stiles | c5ff486 | 2020-12-22 13:47:05 -0500 | [diff] [blame] | 185 | case Statement::Kind::kVarDeclaration: { |
| 186 | if (fScopedBlockDepth > 1) { |
| 187 | fVariablesInBlocks = true; |
| 188 | } |
| 189 | return INHERITED::visitStatement(stmt); |
| 190 | } |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 191 | case Statement::Kind::kBlock: { |
| 192 | int depthIncrement = stmt.as<Block>().isScope() ? 1 : 0; |
| 193 | fScopedBlockDepth += depthIncrement; |
| 194 | bool result = INHERITED::visitStatement(stmt); |
| 195 | fScopedBlockDepth -= depthIncrement; |
John Stiles | c5ff486 | 2020-12-22 13:47:05 -0500 | [diff] [blame] | 196 | if (fNumReturns == 0 && fScopedBlockDepth <= 1) { |
| 197 | // If closing this block puts us back at the top level, and we haven't |
| 198 | // encountered any return statements yet, any vardecls we may have encountered |
| 199 | // up until this point can be ignored. They are out of scope now, and they were |
| 200 | // never used in a return statement. |
| 201 | fVariablesInBlocks = false; |
| 202 | } |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 203 | return result; |
| 204 | } |
| 205 | default: |
| 206 | return INHERITED::visitStatement(stmt); |
| 207 | } |
| 208 | } |
| 209 | |
| 210 | int fNumReturns = 0; |
| 211 | int fDeepestReturn = 0; |
| 212 | int fLimit = 0; |
| 213 | int fScopedBlockDepth = 0; |
John Stiles | c5ff486 | 2020-12-22 13:47:05 -0500 | [diff] [blame] | 214 | bool fVariablesInBlocks = false; |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 215 | using INHERITED = ProgramVisitor; |
| 216 | }; |
| 217 | |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 218 | } // namespace |
| 219 | |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 220 | Inliner::ReturnComplexity Inliner::GetReturnComplexity(const FunctionDefinition& funcDef) { |
| 221 | int returnsAtEndOfControlFlow = count_returns_at_end_of_control_flow(funcDef); |
| 222 | CountReturnsWithLimit counter{funcDef, returnsAtEndOfControlFlow + 1}; |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 223 | if (counter.fNumReturns > returnsAtEndOfControlFlow) { |
| 224 | return ReturnComplexity::kEarlyReturns; |
| 225 | } |
John Stiles | c5ff486 | 2020-12-22 13:47:05 -0500 | [diff] [blame] | 226 | if (counter.fNumReturns > 1) { |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 227 | return ReturnComplexity::kScopedReturns; |
| 228 | } |
John Stiles | c5ff486 | 2020-12-22 13:47:05 -0500 | [diff] [blame] | 229 | if (counter.fVariablesInBlocks && counter.fDeepestReturn > 1) { |
| 230 | return ReturnComplexity::kScopedReturns; |
| 231 | } |
John Stiles | 8937cd4 | 2021-03-17 19:32:59 +0000 | [diff] [blame] | 232 | return ReturnComplexity::kSingleSafeReturn; |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 233 | } |
| 234 | |
John Stiles | b61ee90 | 2020-09-21 12:26:59 -0400 | [diff] [blame] | 235 | void Inliner::ensureScopedBlocks(Statement* inlinedBody, Statement* parentStmt) { |
| 236 | // No changes necessary if this statement isn't actually a block. |
| 237 | if (!inlinedBody || !inlinedBody->is<Block>()) { |
| 238 | return; |
| 239 | } |
| 240 | |
| 241 | // No changes necessary if the parent statement doesn't require a scope. |
| 242 | if (!parentStmt || !(parentStmt->is<IfStatement>() || parentStmt->is<ForStatement>() || |
Brian Osman | d6f2338 | 2020-12-15 17:08:59 -0500 | [diff] [blame] | 243 | parentStmt->is<DoStatement>())) { |
John Stiles | b61ee90 | 2020-09-21 12:26:59 -0400 | [diff] [blame] | 244 | return; |
| 245 | } |
| 246 | |
| 247 | Block& block = inlinedBody->as<Block>(); |
| 248 | |
| 249 | // The inliner will create inlined function bodies as a Block containing multiple statements, |
| 250 | // but no scope. Normally, this is fine, but if this block is used as the statement for a |
| 251 | // do/for/if/while, this isn't actually possible to represent textually; a scope must be added |
| 252 | // for the generated code to match the intent. In the case of Blocks nested inside other Blocks, |
| 253 | // we add the scope to the outermost block if needed. Zero-statement blocks have similar |
| 254 | // issues--if we don't represent the Block textually somehow, we run the risk of accidentally |
| 255 | // absorbing the following statement into our loop--so we also add a scope to these. |
| 256 | for (Block* nestedBlock = █; ) { |
Ethan Nicholas | 7bd6043 | 2020-09-25 14:31:59 -0400 | [diff] [blame] | 257 | if (nestedBlock->isScope()) { |
John Stiles | b61ee90 | 2020-09-21 12:26:59 -0400 | [diff] [blame] | 258 | // We found an explicit scope; all is well. |
| 259 | return; |
| 260 | } |
Ethan Nicholas | 7bd6043 | 2020-09-25 14:31:59 -0400 | [diff] [blame] | 261 | if (nestedBlock->children().size() != 1) { |
John Stiles | b61ee90 | 2020-09-21 12:26:59 -0400 | [diff] [blame] | 262 | // We found a block with multiple (or zero) statements, but no scope? Let's add a scope |
| 263 | // to the outermost block. |
Ethan Nicholas | 7bd6043 | 2020-09-25 14:31:59 -0400 | [diff] [blame] | 264 | block.setIsScope(true); |
John Stiles | b61ee90 | 2020-09-21 12:26:59 -0400 | [diff] [blame] | 265 | return; |
| 266 | } |
Ethan Nicholas | 7bd6043 | 2020-09-25 14:31:59 -0400 | [diff] [blame] | 267 | if (!nestedBlock->children()[0]->is<Block>()) { |
John Stiles | b61ee90 | 2020-09-21 12:26:59 -0400 | [diff] [blame] | 268 | // This block has exactly one thing inside, and it's not another block. No need to scope |
| 269 | // it. |
| 270 | return; |
| 271 | } |
| 272 | // We have to go deeper. |
Ethan Nicholas | 7bd6043 | 2020-09-25 14:31:59 -0400 | [diff] [blame] | 273 | nestedBlock = &nestedBlock->children()[0]->as<Block>(); |
John Stiles | b61ee90 | 2020-09-21 12:26:59 -0400 | [diff] [blame] | 274 | } |
| 275 | } |
| 276 | |
John Stiles | 10d39d9 | 2021-05-04 16:13:14 -0400 | [diff] [blame] | 277 | void Inliner::reset() { |
Ethan Nicholas | 6f4eee2 | 2021-01-11 12:37:42 -0500 | [diff] [blame] | 278 | fMangler.reset(); |
John Stiles | 031a767 | 2020-11-13 16:13:18 -0500 | [diff] [blame] | 279 | fInlinedStatementCounter = 0; |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 280 | } |
| 281 | |
| 282 | std::unique_ptr<Expression> Inliner::inlineExpression(int offset, |
| 283 | VariableRewriteMap* varMap, |
John Stiles | d7cc093 | 2020-11-30 12:24:27 -0500 | [diff] [blame] | 284 | SymbolTable* symbolTableForExpression, |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 285 | const Expression& expression) { |
| 286 | auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> { |
| 287 | if (e) { |
John Stiles | d7cc093 | 2020-11-30 12:24:27 -0500 | [diff] [blame] | 288 | return this->inlineExpression(offset, varMap, symbolTableForExpression, *e); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 289 | } |
| 290 | return nullptr; |
| 291 | }; |
John Stiles | 8e3b6be | 2020-10-13 11:14:08 -0400 | [diff] [blame] | 292 | auto argList = [&](const ExpressionArray& originalArgs) -> ExpressionArray { |
| 293 | ExpressionArray args; |
John Stiles | f4bda74 | 2020-10-14 16:57:41 -0400 | [diff] [blame] | 294 | args.reserve_back(originalArgs.size()); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 295 | for (const std::unique_ptr<Expression>& arg : originalArgs) { |
| 296 | args.push_back(expr(arg)); |
| 297 | } |
| 298 | return args; |
| 299 | }; |
| 300 | |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 301 | switch (expression.kind()) { |
| 302 | case Expression::Kind::kBinary: { |
John Stiles | 6a1a98c | 2021-01-14 18:35:34 -0500 | [diff] [blame] | 303 | const BinaryExpression& binaryExpr = expression.as<BinaryExpression>(); |
John Stiles | e2aec43 | 2021-03-01 09:27:48 -0500 | [diff] [blame] | 304 | return BinaryExpression::Make(*fContext, |
| 305 | expr(binaryExpr.left()), |
| 306 | binaryExpr.getOperator(), |
| 307 | expr(binaryExpr.right())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 308 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 309 | case Expression::Kind::kBoolLiteral: |
| 310 | case Expression::Kind::kIntLiteral: |
| 311 | case Expression::Kind::kFloatLiteral: |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 312 | return expression.clone(); |
John Stiles | 7384b37 | 2021-04-01 13:48:15 -0400 | [diff] [blame] | 313 | case Expression::Kind::kConstructorArray: { |
| 314 | const ConstructorArray& ctor = expression.as<ConstructorArray>(); |
| 315 | return ConstructorArray::Make(*fContext, offset, |
| 316 | *ctor.type().clone(symbolTableForExpression), |
| 317 | argList(ctor.arguments())); |
| 318 | } |
John Stiles | 8cad637 | 2021-04-07 12:31:13 -0400 | [diff] [blame] | 319 | case Expression::Kind::kConstructorCompound: { |
| 320 | const ConstructorCompound& ctor = expression.as<ConstructorCompound>(); |
| 321 | return ConstructorCompound::Make(*fContext, offset, |
John Stiles | 2bec8ab | 2021-04-06 18:40:04 -0400 | [diff] [blame] | 322 | *ctor.type().clone(symbolTableForExpression), |
| 323 | argList(ctor.arguments())); |
| 324 | } |
John Stiles | 8cad637 | 2021-04-07 12:31:13 -0400 | [diff] [blame] | 325 | case Expression::Kind::kConstructorCompoundCast: { |
| 326 | const ConstructorCompoundCast& ctor = expression.as<ConstructorCompoundCast>(); |
| 327 | return ConstructorCompoundCast::Make(*fContext, offset, |
John Stiles | 268a73f | 2021-04-07 12:30:22 -0400 | [diff] [blame] | 328 | *ctor.type().clone(symbolTableForExpression), |
| 329 | expr(ctor.argument())); |
| 330 | } |
John Stiles | e118278 | 2021-03-30 22:09:37 -0400 | [diff] [blame] | 331 | case Expression::Kind::kConstructorDiagonalMatrix: { |
| 332 | const ConstructorDiagonalMatrix& ctor = expression.as<ConstructorDiagonalMatrix>(); |
| 333 | return ConstructorDiagonalMatrix::Make(*fContext, offset, |
| 334 | *ctor.type().clone(symbolTableForExpression), |
| 335 | expr(ctor.argument())); |
| 336 | } |
John Stiles | 5abb9e1 | 2021-04-06 13:47:19 -0400 | [diff] [blame] | 337 | case Expression::Kind::kConstructorMatrixResize: { |
| 338 | const ConstructorMatrixResize& ctor = expression.as<ConstructorMatrixResize>(); |
| 339 | return ConstructorMatrixResize::Make(*fContext, offset, |
| 340 | *ctor.type().clone(symbolTableForExpression), |
| 341 | expr(ctor.argument())); |
| 342 | } |
John Stiles | fd7252f | 2021-04-04 22:24:40 -0400 | [diff] [blame] | 343 | case Expression::Kind::kConstructorScalarCast: { |
| 344 | const ConstructorScalarCast& ctor = expression.as<ConstructorScalarCast>(); |
| 345 | return ConstructorScalarCast::Make(*fContext, offset, |
| 346 | *ctor.type().clone(symbolTableForExpression), |
| 347 | expr(ctor.argument())); |
| 348 | } |
John Stiles | 2938eea | 2021-04-01 18:58:25 -0400 | [diff] [blame] | 349 | case Expression::Kind::kConstructorSplat: { |
| 350 | const ConstructorSplat& ctor = expression.as<ConstructorSplat>(); |
| 351 | return ConstructorSplat::Make(*fContext, offset, |
| 352 | *ctor.type().clone(symbolTableForExpression), |
| 353 | expr(ctor.argument())); |
| 354 | } |
John Stiles | d47330f | 2021-04-08 23:25:52 -0400 | [diff] [blame] | 355 | case Expression::Kind::kConstructorStruct: { |
| 356 | const ConstructorStruct& ctor = expression.as<ConstructorStruct>(); |
| 357 | return ConstructorStruct::Make(*fContext, offset, |
| 358 | *ctor.type().clone(symbolTableForExpression), |
| 359 | argList(ctor.arguments())); |
| 360 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 361 | case Expression::Kind::kExternalFunctionCall: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 362 | const ExternalFunctionCall& externalCall = expression.as<ExternalFunctionCall>(); |
Ethan Nicholas | 444ccc6 | 2020-10-09 10:16:22 -0400 | [diff] [blame] | 363 | return std::make_unique<ExternalFunctionCall>(offset, &externalCall.function(), |
Ethan Nicholas | 6e86ec9 | 2020-09-30 14:29:56 -0400 | [diff] [blame] | 364 | argList(externalCall.arguments())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 365 | } |
Brian Osman | be0b3b7 | 2021-01-06 14:27:35 -0500 | [diff] [blame] | 366 | case Expression::Kind::kExternalFunctionReference: |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 367 | return expression.clone(); |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 368 | case Expression::Kind::kFieldAccess: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 369 | const FieldAccess& f = expression.as<FieldAccess>(); |
John Stiles | 06d600f | 2021-03-08 09:18:21 -0500 | [diff] [blame] | 370 | return FieldAccess::Make(*fContext, expr(f.base()), f.fieldIndex(), f.ownerKind()); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 371 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 372 | case Expression::Kind::kFunctionCall: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 373 | const FunctionCall& funcCall = expression.as<FunctionCall>(); |
John Stiles | cd7ba50 | 2021-03-19 10:54:59 -0400 | [diff] [blame] | 374 | return FunctionCall::Make(*fContext, |
| 375 | offset, |
| 376 | funcCall.type().clone(symbolTableForExpression), |
| 377 | funcCall.function(), |
| 378 | argList(funcCall.arguments())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 379 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 380 | case Expression::Kind::kFunctionReference: |
Brian Osman | 2b3b35f | 2020-09-08 09:17:36 -0400 | [diff] [blame] | 381 | return expression.clone(); |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 382 | case Expression::Kind::kIndex: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 383 | const IndexExpression& idx = expression.as<IndexExpression>(); |
John Stiles | 51d3398 | 2021-03-08 09:18:07 -0500 | [diff] [blame] | 384 | return IndexExpression::Make(*fContext, expr(idx.base()), expr(idx.index())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 385 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 386 | case Expression::Kind::kPrefix: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 387 | const PrefixExpression& p = expression.as<PrefixExpression>(); |
John Stiles | b0eb20f | 2021-02-26 15:29:33 -0500 | [diff] [blame] | 388 | return PrefixExpression::Make(*fContext, p.getOperator(), expr(p.operand())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 389 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 390 | case Expression::Kind::kPostfix: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 391 | const PostfixExpression& p = expression.as<PostfixExpression>(); |
John Stiles | 52d3b01 | 2021-02-26 15:56:48 -0500 | [diff] [blame] | 392 | return PostfixExpression::Make(*fContext, expr(p.operand()), p.getOperator()); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 393 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 394 | case Expression::Kind::kSetting: |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 395 | return expression.clone(); |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 396 | case Expression::Kind::kSwizzle: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 397 | const Swizzle& s = expression.as<Swizzle>(); |
John Stiles | 6e88e04 | 2021-02-19 14:09:38 -0500 | [diff] [blame] | 398 | return Swizzle::Make(*fContext, expr(s.base()), s.components()); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 399 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 400 | case Expression::Kind::kTernary: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 401 | const TernaryExpression& t = expression.as<TernaryExpression>(); |
John Stiles | 90518f7 | 2021-02-26 20:44:54 -0500 | [diff] [blame] | 402 | return TernaryExpression::Make(*fContext, expr(t.test()), |
| 403 | expr(t.ifTrue()), expr(t.ifFalse())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 404 | } |
Brian Osman | 83ba930 | 2020-09-11 13:33:46 -0400 | [diff] [blame] | 405 | case Expression::Kind::kTypeReference: |
| 406 | return expression.clone(); |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 407 | case Expression::Kind::kVariableReference: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 408 | const VariableReference& v = expression.as<VariableReference>(); |
Ethan Nicholas | 7868692 | 2020-10-08 06:46:27 -0400 | [diff] [blame] | 409 | auto varMapIter = varMap->find(v.variable()); |
John Stiles | e41b4ee | 2020-09-28 12:28:16 -0400 | [diff] [blame] | 410 | if (varMapIter != varMap->end()) { |
Ethan Nicholas | 7868692 | 2020-10-08 06:46:27 -0400 | [diff] [blame] | 411 | return clone_with_ref_kind(*varMapIter->second, v.refKind()); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 412 | } |
| 413 | return v.clone(); |
| 414 | } |
| 415 | default: |
| 416 | SkASSERT(false); |
| 417 | return nullptr; |
| 418 | } |
| 419 | } |
| 420 | |
| 421 | std::unique_ptr<Statement> Inliner::inlineStatement(int offset, |
| 422 | VariableRewriteMap* varMap, |
| 423 | SymbolTable* symbolTableForStatement, |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 424 | std::unique_ptr<Expression>* resultExpr, |
| 425 | ReturnComplexity returnComplexity, |
Brian Osman | 3887a01 | 2020-09-30 13:22:27 -0400 | [diff] [blame] | 426 | const Statement& statement, |
| 427 | bool isBuiltinCode) { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 428 | auto stmt = [&](const std::unique_ptr<Statement>& s) -> std::unique_ptr<Statement> { |
| 429 | if (s) { |
John Stiles | a5f3c31 | 2020-09-22 12:05:16 -0400 | [diff] [blame] | 430 | return this->inlineStatement(offset, varMap, symbolTableForStatement, resultExpr, |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 431 | returnComplexity, *s, isBuiltinCode); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 432 | } |
| 433 | return nullptr; |
| 434 | }; |
Ethan Nicholas | 7bd6043 | 2020-09-25 14:31:59 -0400 | [diff] [blame] | 435 | auto blockStmts = [&](const Block& block) { |
John Stiles | 8f2a0cf | 2020-10-13 12:48:21 -0400 | [diff] [blame] | 436 | StatementArray result; |
John Stiles | f4bda74 | 2020-10-14 16:57:41 -0400 | [diff] [blame] | 437 | result.reserve_back(block.children().size()); |
Ethan Nicholas | 7bd6043 | 2020-09-25 14:31:59 -0400 | [diff] [blame] | 438 | for (const std::unique_ptr<Statement>& child : block.children()) { |
| 439 | result.push_back(stmt(child)); |
| 440 | } |
| 441 | return result; |
| 442 | }; |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 443 | auto expr = [&](const std::unique_ptr<Expression>& e) -> std::unique_ptr<Expression> { |
| 444 | if (e) { |
John Stiles | d7cc093 | 2020-11-30 12:24:27 -0500 | [diff] [blame] | 445 | return this->inlineExpression(offset, varMap, symbolTableForStatement, *e); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 446 | } |
| 447 | return nullptr; |
| 448 | }; |
John Stiles | 031a767 | 2020-11-13 16:13:18 -0500 | [diff] [blame] | 449 | |
| 450 | ++fInlinedStatementCounter; |
| 451 | |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 452 | switch (statement.kind()) { |
| 453 | case Statement::Kind::kBlock: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 454 | const Block& b = statement.as<Block>(); |
John Stiles | bf16b6c | 2021-03-12 19:24:31 -0500 | [diff] [blame] | 455 | return Block::Make(offset, blockStmts(b), |
| 456 | SymbolTable::WrapIfBuiltin(b.symbolTable()), |
| 457 | b.isScope()); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 458 | } |
| 459 | |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 460 | case Statement::Kind::kBreak: |
| 461 | case Statement::Kind::kContinue: |
| 462 | case Statement::Kind::kDiscard: |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 463 | return statement.clone(); |
| 464 | |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 465 | case Statement::Kind::kDo: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 466 | const DoStatement& d = statement.as<DoStatement>(); |
John Stiles | ea5822e | 2021-02-26 11:18:20 -0500 | [diff] [blame] | 467 | return DoStatement::Make(*fContext, stmt(d.statement()), expr(d.test())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 468 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 469 | case Statement::Kind::kExpression: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 470 | const ExpressionStatement& e = statement.as<ExpressionStatement>(); |
John Stiles | 3e5871c | 2021-02-25 20:52:03 -0500 | [diff] [blame] | 471 | return ExpressionStatement::Make(*fContext, expr(e.expression())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 472 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 473 | case Statement::Kind::kFor: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 474 | const ForStatement& f = statement.as<ForStatement>(); |
| 475 | // need to ensure initializer is evaluated first so that we've already remapped its |
| 476 | // declarations by the time we evaluate test & next |
Ethan Nicholas | 0d31ed5 | 2020-10-05 14:47:09 -0400 | [diff] [blame] | 477 | std::unique_ptr<Statement> initializer = stmt(f.initializer()); |
John Stiles | b321a07 | 2021-02-25 16:24:19 -0500 | [diff] [blame] | 478 | return ForStatement::Make(*fContext, offset, std::move(initializer), expr(f.test()), |
| 479 | expr(f.next()), stmt(f.statement()), |
| 480 | SymbolTable::WrapIfBuiltin(f.symbols())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 481 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 482 | case Statement::Kind::kIf: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 483 | const IfStatement& i = statement.as<IfStatement>(); |
John Stiles | cf3059e | 2021-02-25 14:27:02 -0500 | [diff] [blame] | 484 | return IfStatement::Make(*fContext, offset, i.isStatic(), expr(i.test()), |
| 485 | stmt(i.ifTrue()), stmt(i.ifFalse())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 486 | } |
John Stiles | 98c1f82 | 2020-09-09 14:18:53 -0400 | [diff] [blame] | 487 | case Statement::Kind::kInlineMarker: |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 488 | case Statement::Kind::kNop: |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 489 | return statement.clone(); |
John Stiles | ea5822e | 2021-02-26 11:18:20 -0500 | [diff] [blame] | 490 | |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 491 | case Statement::Kind::kReturn: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 492 | const ReturnStatement& r = statement.as<ReturnStatement>(); |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 493 | if (!r.expression()) { |
John Stiles | dc20847 | 2021-03-17 10:58:16 -0400 | [diff] [blame] | 494 | // This function doesn't return a value. We won't inline functions with early |
| 495 | // returns, so a return statement is a no-op and can be treated as such. |
| 496 | return Nop::Make(); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 497 | } |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 498 | |
John Stiles | c5ff486 | 2020-12-22 13:47:05 -0500 | [diff] [blame] | 499 | // If a function only contains a single return, and it doesn't reference variables from |
| 500 | // inside an Block's scope, we don't need to store the result in a variable at all. Just |
| 501 | // replace the function-call expression with the function's return expression. |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 502 | SkASSERT(resultExpr); |
John Stiles | c5ff486 | 2020-12-22 13:47:05 -0500 | [diff] [blame] | 503 | if (returnComplexity <= ReturnComplexity::kSingleSafeReturn) { |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 504 | *resultExpr = expr(r.expression()); |
John Stiles | a0c04d6 | 2021-03-11 23:07:24 -0500 | [diff] [blame] | 505 | return Nop::Make(); |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 506 | } |
| 507 | |
| 508 | // For more complex functions, assign their result into a variable. |
John Stiles | 511c500 | 2021-02-25 11:17:02 -0500 | [diff] [blame] | 509 | SkASSERT(*resultExpr); |
John Stiles | 3e5871c | 2021-02-25 20:52:03 -0500 | [diff] [blame] | 510 | auto assignment = ExpressionStatement::Make( |
| 511 | *fContext, |
John Stiles | e2aec43 | 2021-03-01 09:27:48 -0500 | [diff] [blame] | 512 | BinaryExpression::Make( |
| 513 | *fContext, |
| 514 | clone_with_ref_kind(**resultExpr, VariableRefKind::kWrite), |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 515 | Token::Kind::TK_EQ, |
John Stiles | e2aec43 | 2021-03-01 09:27:48 -0500 | [diff] [blame] | 516 | expr(r.expression()))); |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 517 | |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 518 | // Functions without early returns aren't wrapped in a for loop and don't need to worry |
| 519 | // about breaking out of the control flow. |
John Stiles | 3e5871c | 2021-02-25 20:52:03 -0500 | [diff] [blame] | 520 | return assignment; |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 521 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 522 | case Statement::Kind::kSwitch: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 523 | const SwitchStatement& ss = statement.as<SwitchStatement>(); |
John Stiles | b23a64b | 2021-03-11 08:27:59 -0500 | [diff] [blame] | 524 | StatementArray cases; |
| 525 | cases.reserve_back(ss.cases().size()); |
| 526 | for (const std::unique_ptr<Statement>& statement : ss.cases()) { |
| 527 | const SwitchCase& sc = statement->as<SwitchCase>(); |
| 528 | cases.push_back(std::make_unique<SwitchCase>(offset, expr(sc.value()), |
| 529 | stmt(sc.statement()))); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 530 | } |
John Stiles | e1d1b08 | 2021-02-23 13:44:36 -0500 | [diff] [blame] | 531 | return SwitchStatement::Make(*fContext, offset, ss.isStatic(), expr(ss.value()), |
| 532 | std::move(cases), SymbolTable::WrapIfBuiltin(ss.symbols())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 533 | } |
Ethan Nicholas | e659214 | 2020-09-08 10:22:09 -0400 | [diff] [blame] | 534 | case Statement::Kind::kVarDeclaration: { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 535 | const VarDeclaration& decl = statement.as<VarDeclaration>(); |
John Stiles | 35fee4c | 2020-12-16 18:25:14 +0000 | [diff] [blame] | 536 | std::unique_ptr<Expression> initialValue = expr(decl.value()); |
John Stiles | ddcc843 | 2021-01-15 15:32:32 -0500 | [diff] [blame] | 537 | const Variable& variable = decl.var(); |
| 538 | |
John Stiles | 35fee4c | 2020-12-16 18:25:14 +0000 | [diff] [blame] | 539 | // We assign unique names to inlined variables--scopes hide most of the problems in this |
| 540 | // regard, but see `InlinerAvoidsVariableNameOverlap` for a counterexample where unique |
| 541 | // names are important. |
John Stiles | d51c979 | 2021-03-18 11:40:14 -0400 | [diff] [blame] | 542 | const String* name = symbolTableForStatement->takeOwnershipOfString( |
Ethan Nicholas | d2e0960 | 2021-06-10 11:21:59 -0400 | [diff] [blame] | 543 | fMangler.uniqueName(String(variable.name()), symbolTableForStatement)); |
Ethan Nicholas | 5b9b0db | 2021-01-21 13:12:01 -0500 | [diff] [blame] | 544 | auto clonedVar = std::make_unique<Variable>( |
| 545 | offset, |
| 546 | &variable.modifiers(), |
John Stiles | d51c979 | 2021-03-18 11:40:14 -0400 | [diff] [blame] | 547 | name->c_str(), |
Ethan Nicholas | 5b9b0db | 2021-01-21 13:12:01 -0500 | [diff] [blame] | 548 | variable.type().clone(symbolTableForStatement), |
| 549 | isBuiltinCode, |
| 550 | variable.storage()); |
John Stiles | a94e026 | 2021-04-27 17:29:59 -0400 | [diff] [blame] | 551 | (*varMap)[&variable] = VariableReference::Make(offset, clonedVar.get()); |
John Stiles | e67bd13 | 2021-03-19 18:39:25 -0400 | [diff] [blame] | 552 | auto result = VarDeclaration::Make(*fContext, |
| 553 | clonedVar.get(), |
| 554 | decl.baseType().clone(symbolTableForStatement), |
| 555 | decl.arraySize(), |
| 556 | std::move(initialValue)); |
Ethan Nicholas | 5b9b0db | 2021-01-21 13:12:01 -0500 | [diff] [blame] | 557 | symbolTableForStatement->takeOwnershipOfSymbol(std::move(clonedVar)); |
John Stiles | e67bd13 | 2021-03-19 18:39:25 -0400 | [diff] [blame] | 558 | return result; |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 559 | } |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 560 | default: |
| 561 | SkASSERT(false); |
| 562 | return nullptr; |
| 563 | } |
| 564 | } |
| 565 | |
John Stiles | 7b92044 | 2020-12-17 10:43:41 -0500 | [diff] [blame] | 566 | Inliner::InlineVariable Inliner::makeInlineVariable(const String& baseName, |
| 567 | const Type* type, |
| 568 | SymbolTable* symbolTable, |
| 569 | Modifiers modifiers, |
| 570 | bool isBuiltinCode, |
| 571 | std::unique_ptr<Expression>* initialValue) { |
| 572 | // $floatLiteral or $intLiteral aren't real types that we can use for scratch variables, so |
| 573 | // replace them if they ever appear here. If this happens, we likely forgot to coerce a type |
| 574 | // somewhere during compilation. |
John Stiles | 1497527 | 2021-01-12 11:41:14 -0500 | [diff] [blame] | 575 | if (type->isLiteral()) { |
| 576 | SkDEBUGFAIL("found a $literal type while inlining"); |
| 577 | type = &type->scalarTypeForLiteral(); |
John Stiles | 7b92044 | 2020-12-17 10:43:41 -0500 | [diff] [blame] | 578 | } |
| 579 | |
John Stiles | bff24ab | 2021-03-17 13:20:10 -0400 | [diff] [blame] | 580 | // Out parameters aren't supported. |
| 581 | SkASSERT(!(modifiers.fFlags & Modifiers::kOut_Flag)); |
| 582 | |
John Stiles | 7b92044 | 2020-12-17 10:43:41 -0500 | [diff] [blame] | 583 | // Provide our new variable with a unique name, and add it to our symbol table. |
John Stiles | d51c979 | 2021-03-18 11:40:14 -0400 | [diff] [blame] | 584 | const String* name = |
| 585 | symbolTable->takeOwnershipOfString(fMangler.uniqueName(baseName, symbolTable)); |
John Stiles | 7b92044 | 2020-12-17 10:43:41 -0500 | [diff] [blame] | 586 | |
| 587 | // Create our new variable and add it to the symbol table. |
| 588 | InlineVariable result; |
Ethan Nicholas | 5b9b0db | 2021-01-21 13:12:01 -0500 | [diff] [blame] | 589 | auto var = std::make_unique<Variable>(/*offset=*/-1, |
John Stiles | f2872e6 | 2021-05-04 11:38:43 -0400 | [diff] [blame] | 590 | this->modifiersPool().add(Modifiers{}), |
John Stiles | d51c979 | 2021-03-18 11:40:14 -0400 | [diff] [blame] | 591 | name->c_str(), |
Ethan Nicholas | 5b9b0db | 2021-01-21 13:12:01 -0500 | [diff] [blame] | 592 | type, |
| 593 | isBuiltinCode, |
| 594 | Variable::Storage::kLocal); |
John Stiles | 7b92044 | 2020-12-17 10:43:41 -0500 | [diff] [blame] | 595 | |
John Stiles | bff24ab | 2021-03-17 13:20:10 -0400 | [diff] [blame] | 596 | // Create our variable declaration. |
John Stiles | e67bd13 | 2021-03-19 18:39:25 -0400 | [diff] [blame] | 597 | result.fVarDecl = VarDeclaration::Make(*fContext, var.get(), type, /*arraySize=*/0, |
| 598 | std::move(*initialValue)); |
Ethan Nicholas | 5b9b0db | 2021-01-21 13:12:01 -0500 | [diff] [blame] | 599 | result.fVarSymbol = symbolTable->add(std::move(var)); |
John Stiles | 7b92044 | 2020-12-17 10:43:41 -0500 | [diff] [blame] | 600 | return result; |
| 601 | } |
| 602 | |
John Stiles | 6eadf13 | 2020-09-08 10:16:10 -0400 | [diff] [blame] | 603 | Inliner::InlinedCall Inliner::inlineCall(FunctionCall* call, |
John Stiles | 7804758 | 2020-12-16 16:17:41 -0500 | [diff] [blame] | 604 | std::shared_ptr<SymbolTable> symbolTable, |
John Stiles | 30fce9c | 2021-03-18 09:24:06 -0400 | [diff] [blame] | 605 | const ProgramUsage& usage, |
Brian Osman | 3887a01 | 2020-09-30 13:22:27 -0400 | [diff] [blame] | 606 | const FunctionDeclaration* caller) { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 607 | // Inlining is more complicated here than in a typical compiler, because we have to have a |
| 608 | // high-level IR and can't just drop statements into the middle of an expression or even use |
| 609 | // gotos. |
| 610 | // |
| 611 | // Since we can't insert statements into an expression, we run the inline function as extra |
| 612 | // statements before the statement we're currently processing, relying on a lack of execution |
| 613 | // order guarantees. Since we can't use gotos (which are normally used to replace return |
| 614 | // statements), we wrap the whole function in a loop and use break statements to jump to the |
| 615 | // end. |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 616 | SkASSERT(fContext); |
| 617 | SkASSERT(call); |
Ethan Nicholas | ed84b73 | 2020-10-08 11:45:44 -0400 | [diff] [blame] | 618 | SkASSERT(this->isSafeToInline(call->function().definition())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 619 | |
John Stiles | 8e3b6be | 2020-10-13 11:14:08 -0400 | [diff] [blame] | 620 | ExpressionArray& arguments = call->arguments(); |
John Stiles | 6eadf13 | 2020-09-08 10:16:10 -0400 | [diff] [blame] | 621 | const int offset = call->fOffset; |
Ethan Nicholas | ed84b73 | 2020-10-08 11:45:44 -0400 | [diff] [blame] | 622 | const FunctionDefinition& function = *call->function().definition(); |
John Stiles | 28257db | 2021-03-17 15:18:09 -0400 | [diff] [blame] | 623 | const Block& body = function.body()->as<Block>(); |
John Stiles | 77702f1 | 2020-12-17 14:38:56 -0500 | [diff] [blame] | 624 | const ReturnComplexity returnComplexity = GetReturnComplexity(function); |
John Stiles | 6eadf13 | 2020-09-08 10:16:10 -0400 | [diff] [blame] | 625 | |
John Stiles | 28257db | 2021-03-17 15:18:09 -0400 | [diff] [blame] | 626 | StatementArray inlineStatements; |
| 627 | int expectedStmtCount = 1 + // Inline marker |
| 628 | 1 + // Result variable |
| 629 | arguments.size() + // Function argument temp-vars |
| 630 | body.children().size(); // Inlined code |
John Stiles | 98c1f82 | 2020-09-09 14:18:53 -0400 | [diff] [blame] | 631 | |
John Stiles | 28257db | 2021-03-17 15:18:09 -0400 | [diff] [blame] | 632 | inlineStatements.reserve_back(expectedStmtCount); |
| 633 | inlineStatements.push_back(InlineMarker::Make(&call->function())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 634 | |
John Stiles | e41b4ee | 2020-09-28 12:28:16 -0400 | [diff] [blame] | 635 | std::unique_ptr<Expression> resultExpr; |
John Stiles | 511c500 | 2021-02-25 11:17:02 -0500 | [diff] [blame] | 636 | if (returnComplexity > ReturnComplexity::kSingleSafeReturn && |
John Stiles | 2558c46 | 2021-03-16 17:49:20 -0400 | [diff] [blame] | 637 | !function.declaration().returnType().isVoid()) { |
John Stiles | 511c500 | 2021-02-25 11:17:02 -0500 | [diff] [blame] | 638 | // Create a variable to hold the result in the extra statements. We don't need to do this |
| 639 | // for void-return functions, or in cases that are simple enough that we can just replace |
| 640 | // the function-call node with the result expression. |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 641 | std::unique_ptr<Expression> noInitialValue; |
Ethan Nicholas | d2e0960 | 2021-06-10 11:21:59 -0400 | [diff] [blame] | 642 | InlineVariable var = this->makeInlineVariable(String(function.declaration().name()), |
John Stiles | 7b92044 | 2020-12-17 10:43:41 -0500 | [diff] [blame] | 643 | &function.declaration().returnType(), |
| 644 | symbolTable.get(), Modifiers{}, |
| 645 | caller->isBuiltin(), &noInitialValue); |
John Stiles | 28257db | 2021-03-17 15:18:09 -0400 | [diff] [blame] | 646 | inlineStatements.push_back(std::move(var.fVarDecl)); |
John Stiles | a94e026 | 2021-04-27 17:29:59 -0400 | [diff] [blame] | 647 | resultExpr = VariableReference::Make(/*offset=*/-1, var.fVarSymbol); |
John Stiles | 511c500 | 2021-02-25 11:17:02 -0500 | [diff] [blame] | 648 | } |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 649 | |
| 650 | // Create variables in the extra statements to hold the arguments, and assign the arguments to |
| 651 | // them. |
| 652 | VariableRewriteMap varMap; |
John Stiles | bff24ab | 2021-03-17 13:20:10 -0400 | [diff] [blame] | 653 | for (int i = 0; i < arguments.count(); ++i) { |
John Stiles | 049f0df | 2021-03-19 09:39:44 -0400 | [diff] [blame] | 654 | // If the parameter isn't written to within the inline function ... |
John Stiles | bff24ab | 2021-03-17 13:20:10 -0400 | [diff] [blame] | 655 | const Variable* param = function.declaration().parameters()[i]; |
John Stiles | 049f0df | 2021-03-19 09:39:44 -0400 | [diff] [blame] | 656 | const ProgramUsage::VariableCounts& paramUsage = usage.get(*param); |
| 657 | if (!paramUsage.fWrite) { |
| 658 | // ... and can be inlined trivially (e.g. a swizzle, or a constant array index), |
| 659 | // or any expression without side effects that is only accessed at most once... |
| 660 | if ((paramUsage.fRead > 1) ? Analysis::IsTrivialExpression(*arguments[i]) |
| 661 | : !arguments[i]->hasSideEffects()) { |
John Stiles | f201af8 | 2020-09-29 16:57:55 -0400 | [diff] [blame] | 662 | // ... we don't need to copy it at all! We can just use the existing expression. |
| 663 | varMap[param] = arguments[i]->clone(); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 664 | continue; |
| 665 | } |
| 666 | } |
Ethan Nicholas | d2e0960 | 2021-06-10 11:21:59 -0400 | [diff] [blame] | 667 | InlineVariable var = this->makeInlineVariable(String(param->name()), &arguments[i]->type(), |
John Stiles | 7b92044 | 2020-12-17 10:43:41 -0500 | [diff] [blame] | 668 | symbolTable.get(), param->modifiers(), |
| 669 | caller->isBuiltin(), &arguments[i]); |
John Stiles | 28257db | 2021-03-17 15:18:09 -0400 | [diff] [blame] | 670 | inlineStatements.push_back(std::move(var.fVarDecl)); |
John Stiles | a94e026 | 2021-04-27 17:29:59 -0400 | [diff] [blame] | 671 | varMap[param] = VariableReference::Make(/*offset=*/-1, var.fVarSymbol); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 672 | } |
| 673 | |
John Stiles | 7b92044 | 2020-12-17 10:43:41 -0500 | [diff] [blame] | 674 | for (const std::unique_ptr<Statement>& stmt : body.children()) { |
John Stiles | 28257db | 2021-03-17 15:18:09 -0400 | [diff] [blame] | 675 | inlineStatements.push_back(this->inlineStatement(offset, &varMap, symbolTable.get(), |
| 676 | &resultExpr, returnComplexity, *stmt, |
| 677 | caller->isBuiltin())); |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 678 | } |
| 679 | |
John Stiles | 28257db | 2021-03-17 15:18:09 -0400 | [diff] [blame] | 680 | SkASSERT(inlineStatements.count() <= expectedStmtCount); |
| 681 | |
John Stiles | bf16b6c | 2021-03-12 19:24:31 -0500 | [diff] [blame] | 682 | // Wrap all of the generated statements in a block. We need a real Block here, so we can't use |
| 683 | // MakeUnscoped. This is because we need to add another child statement to the Block later. |
John Stiles | 28257db | 2021-03-17 15:18:09 -0400 | [diff] [blame] | 684 | InlinedCall inlinedCall; |
| 685 | inlinedCall.fInlinedBody = Block::Make(offset, std::move(inlineStatements), |
John Stiles | bf16b6c | 2021-03-12 19:24:31 -0500 | [diff] [blame] | 686 | /*symbols=*/nullptr, /*isScope=*/false); |
| 687 | |
John Stiles | 0c2d14a | 2021-03-01 10:08:08 -0500 | [diff] [blame] | 688 | if (resultExpr) { |
| 689 | // Return our result expression as-is. |
John Stiles | e41b4ee | 2020-09-28 12:28:16 -0400 | [diff] [blame] | 690 | inlinedCall.fReplacementExpr = std::move(resultExpr); |
John Stiles | 2558c46 | 2021-03-16 17:49:20 -0400 | [diff] [blame] | 691 | } else if (function.declaration().returnType().isVoid()) { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 692 | // It's a void function, so it doesn't actually result in anything, but we have to return |
| 693 | // something non-null as a standin. |
John Stiles | 9ce80f7 | 2021-03-11 22:35:19 -0500 | [diff] [blame] | 694 | inlinedCall.fReplacementExpr = BoolLiteral::Make(*fContext, offset, /*value=*/false); |
John Stiles | 0c2d14a | 2021-03-01 10:08:08 -0500 | [diff] [blame] | 695 | } else { |
| 696 | // It's a non-void function, but it never created a result expression--that is, it never |
John Stiles | 2dda50d | 2021-03-03 10:46:44 -0500 | [diff] [blame] | 697 | // returned anything on any path! This should have been detected in the function finalizer. |
| 698 | // Still, discard our output and generate an error. |
| 699 | SkDEBUGFAIL("inliner found non-void function that fails to return a value on any path"); |
| 700 | fContext->fErrors.error(function.fOffset, "inliner found non-void function '" + |
John Stiles | 0c2d14a | 2021-03-01 10:08:08 -0500 | [diff] [blame] | 701 | function.declaration().name() + |
John Stiles | 2dda50d | 2021-03-03 10:46:44 -0500 | [diff] [blame] | 702 | "' that fails to return a value on any path"); |
John Stiles | 0c2d14a | 2021-03-01 10:08:08 -0500 | [diff] [blame] | 703 | inlinedCall = {}; |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 704 | } |
| 705 | |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 706 | return inlinedCall; |
| 707 | } |
| 708 | |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 709 | bool Inliner::isSafeToInline(const FunctionDefinition* functionDef) { |
John Stiles | 1c03d33 | 2020-10-13 10:30:23 -0400 | [diff] [blame] | 710 | // A threshold of zero indicates that the inliner is completely disabled, so we can just return. |
John Stiles | d120464 | 2021-02-17 16:30:02 -0500 | [diff] [blame] | 711 | if (this->settings().fInlineThreshold <= 0) { |
John Stiles | 1c03d33 | 2020-10-13 10:30:23 -0400 | [diff] [blame] | 712 | return false; |
| 713 | } |
| 714 | |
John Stiles | 031a767 | 2020-11-13 16:13:18 -0500 | [diff] [blame] | 715 | // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl) |
| 716 | if (fInlinedStatementCounter >= kInlinedStatementLimit) { |
| 717 | return false; |
| 718 | } |
| 719 | |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 720 | if (functionDef == nullptr) { |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 721 | // Can't inline something if we don't actually have its definition. |
| 722 | return false; |
| 723 | } |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 724 | |
John Stiles | 0dd1a77 | 2021-03-09 22:14:27 -0500 | [diff] [blame] | 725 | if (functionDef->declaration().modifiers().fFlags & Modifiers::kNoInline_Flag) { |
| 726 | // Refuse to inline functions decorated with `noinline`. |
| 727 | return false; |
| 728 | } |
| 729 | |
John Stiles | bff24ab | 2021-03-17 13:20:10 -0400 | [diff] [blame] | 730 | // We don't allow inlining a function with out parameters. (See skia:11326 for rationale.) |
| 731 | for (const Variable* param : functionDef->declaration().parameters()) { |
| 732 | if (param->modifiers().fFlags & Modifiers::Flag::kOut_Flag) { |
| 733 | return false; |
| 734 | } |
| 735 | } |
| 736 | |
John Stiles | dc20847 | 2021-03-17 10:58:16 -0400 | [diff] [blame] | 737 | // We don't have a mechanism to simulate early returns, so we can't inline if there is one. |
| 738 | return GetReturnComplexity(*functionDef) < ReturnComplexity::kEarlyReturns; |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 739 | } |
| 740 | |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 741 | // A candidate function for inlining, containing everything that `inlineCall` needs. |
| 742 | struct InlineCandidate { |
John Stiles | 7804758 | 2020-12-16 16:17:41 -0500 | [diff] [blame] | 743 | std::shared_ptr<SymbolTable> fSymbols; // the SymbolTable of the candidate |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 744 | std::unique_ptr<Statement>* fParentStmt; // the parent Statement of the enclosing stmt |
| 745 | std::unique_ptr<Statement>* fEnclosingStmt; // the Statement containing the candidate |
| 746 | std::unique_ptr<Expression>* fCandidateExpr; // the candidate FunctionCall to be inlined |
| 747 | FunctionDefinition* fEnclosingFunction; // the Function containing the candidate |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 748 | }; |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 749 | |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 750 | struct InlineCandidateList { |
| 751 | std::vector<InlineCandidate> fCandidates; |
| 752 | }; |
| 753 | |
| 754 | class InlineCandidateAnalyzer { |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 755 | public: |
| 756 | // A list of all the inlining candidates we found during analysis. |
| 757 | InlineCandidateList* fCandidateList; |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 758 | |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 759 | // A stack of the symbol tables; since most nodes don't have one, expected to be shallower than |
| 760 | // the enclosing-statement stack. |
John Stiles | 7804758 | 2020-12-16 16:17:41 -0500 | [diff] [blame] | 761 | std::vector<std::shared_ptr<SymbolTable>> fSymbolTableStack; |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 762 | // A stack of "enclosing" statements--these would be suitable for the inliner to use for adding |
| 763 | // new instructions. Not all statements are suitable (e.g. a for-loop's initializer). The |
| 764 | // inliner might replace a statement with a block containing the statement. |
| 765 | std::vector<std::unique_ptr<Statement>*> fEnclosingStmtStack; |
| 766 | // The function that we're currently processing (i.e. inlining into). |
| 767 | FunctionDefinition* fEnclosingFunction = nullptr; |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 768 | |
Brian Osman | 0006ad0 | 2020-11-18 15:38:39 -0500 | [diff] [blame] | 769 | void visit(const std::vector<std::unique_ptr<ProgramElement>>& elements, |
John Stiles | 7804758 | 2020-12-16 16:17:41 -0500 | [diff] [blame] | 770 | std::shared_ptr<SymbolTable> symbols, |
Brian Osman | 0006ad0 | 2020-11-18 15:38:39 -0500 | [diff] [blame] | 771 | InlineCandidateList* candidateList) { |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 772 | fCandidateList = candidateList; |
Brian Osman | 0006ad0 | 2020-11-18 15:38:39 -0500 | [diff] [blame] | 773 | fSymbolTableStack.push_back(symbols); |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 774 | |
Brian Osman | 0006ad0 | 2020-11-18 15:38:39 -0500 | [diff] [blame] | 775 | for (const std::unique_ptr<ProgramElement>& pe : elements) { |
Brian Osman | 1179fcf | 2020-10-08 16:04:40 -0400 | [diff] [blame] | 776 | this->visitProgramElement(pe.get()); |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 777 | } |
| 778 | |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 779 | fSymbolTableStack.pop_back(); |
| 780 | fCandidateList = nullptr; |
| 781 | } |
| 782 | |
| 783 | void visitProgramElement(ProgramElement* pe) { |
| 784 | switch (pe->kind()) { |
| 785 | case ProgramElement::Kind::kFunction: { |
| 786 | FunctionDefinition& funcDef = pe->as<FunctionDefinition>(); |
Brian Osman | 0006ad0 | 2020-11-18 15:38:39 -0500 | [diff] [blame] | 787 | fEnclosingFunction = &funcDef; |
| 788 | this->visitStatement(&funcDef.body()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 789 | break; |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 790 | } |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 791 | default: |
| 792 | // The inliner can't operate outside of a function's scope. |
| 793 | break; |
| 794 | } |
| 795 | } |
| 796 | |
| 797 | void visitStatement(std::unique_ptr<Statement>* stmt, |
| 798 | bool isViableAsEnclosingStatement = true) { |
| 799 | if (!*stmt) { |
| 800 | return; |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 801 | } |
| 802 | |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 803 | size_t oldEnclosingStmtStackSize = fEnclosingStmtStack.size(); |
| 804 | size_t oldSymbolStackSize = fSymbolTableStack.size(); |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 805 | |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 806 | if (isViableAsEnclosingStatement) { |
| 807 | fEnclosingStmtStack.push_back(stmt); |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 808 | } |
| 809 | |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 810 | switch ((*stmt)->kind()) { |
| 811 | case Statement::Kind::kBreak: |
| 812 | case Statement::Kind::kContinue: |
| 813 | case Statement::Kind::kDiscard: |
| 814 | case Statement::Kind::kInlineMarker: |
| 815 | case Statement::Kind::kNop: |
| 816 | break; |
| 817 | |
| 818 | case Statement::Kind::kBlock: { |
| 819 | Block& block = (*stmt)->as<Block>(); |
| 820 | if (block.symbolTable()) { |
John Stiles | 7804758 | 2020-12-16 16:17:41 -0500 | [diff] [blame] | 821 | fSymbolTableStack.push_back(block.symbolTable()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 822 | } |
| 823 | |
| 824 | for (std::unique_ptr<Statement>& stmt : block.children()) { |
| 825 | this->visitStatement(&stmt); |
| 826 | } |
| 827 | break; |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 828 | } |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 829 | case Statement::Kind::kDo: { |
| 830 | DoStatement& doStmt = (*stmt)->as<DoStatement>(); |
| 831 | // The loop body is a candidate for inlining. |
| 832 | this->visitStatement(&doStmt.statement()); |
| 833 | // The inliner isn't smart enough to inline the test-expression for a do-while |
| 834 | // loop at this time. There are two limitations: |
| 835 | // - We would need to insert the inlined-body block at the very end of the do- |
| 836 | // statement's inner fStatement. We don't support that today, but it's doable. |
| 837 | // - We cannot inline the test expression if the loop uses `continue` anywhere; that |
| 838 | // would skip over the inlined block that evaluates the test expression. There |
| 839 | // isn't a good fix for this--any workaround would be more complex than the cost |
| 840 | // of a function call. However, loops that don't use `continue` would still be |
| 841 | // viable candidates for inlining. |
| 842 | break; |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 843 | } |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 844 | case Statement::Kind::kExpression: { |
| 845 | ExpressionStatement& expr = (*stmt)->as<ExpressionStatement>(); |
| 846 | this->visitExpression(&expr.expression()); |
| 847 | break; |
| 848 | } |
| 849 | case Statement::Kind::kFor: { |
| 850 | ForStatement& forStmt = (*stmt)->as<ForStatement>(); |
Ethan Nicholas | 0d31ed5 | 2020-10-05 14:47:09 -0400 | [diff] [blame] | 851 | if (forStmt.symbols()) { |
John Stiles | 7804758 | 2020-12-16 16:17:41 -0500 | [diff] [blame] | 852 | fSymbolTableStack.push_back(forStmt.symbols()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 853 | } |
| 854 | |
| 855 | // The initializer and loop body are candidates for inlining. |
Ethan Nicholas | 0d31ed5 | 2020-10-05 14:47:09 -0400 | [diff] [blame] | 856 | this->visitStatement(&forStmt.initializer(), |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 857 | /*isViableAsEnclosingStatement=*/false); |
Ethan Nicholas | 0d31ed5 | 2020-10-05 14:47:09 -0400 | [diff] [blame] | 858 | this->visitStatement(&forStmt.statement()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 859 | |
| 860 | // The inliner isn't smart enough to inline the test- or increment-expressions |
| 861 | // of a for loop loop at this time. There are a handful of limitations: |
| 862 | // - We would need to insert the test-expression block at the very beginning of the |
| 863 | // for-loop's inner fStatement, and the increment-expression block at the very |
| 864 | // end. We don't support that today, but it's doable. |
| 865 | // - The for-loop's built-in test-expression would need to be dropped entirely, |
| 866 | // and the loop would be halted via a break statement at the end of the inlined |
| 867 | // test-expression. This is again something we don't support today, but it could |
| 868 | // be implemented. |
| 869 | // - We cannot inline the increment-expression if the loop uses `continue` anywhere; |
| 870 | // that would skip over the inlined block that evaluates the increment expression. |
| 871 | // There isn't a good fix for this--any workaround would be more complex than the |
| 872 | // cost of a function call. However, loops that don't use `continue` would still |
| 873 | // be viable candidates for increment-expression inlining. |
| 874 | break; |
| 875 | } |
| 876 | case Statement::Kind::kIf: { |
| 877 | IfStatement& ifStmt = (*stmt)->as<IfStatement>(); |
Ethan Nicholas | 8c44eca | 2020-10-07 16:47:09 -0400 | [diff] [blame] | 878 | this->visitExpression(&ifStmt.test()); |
| 879 | this->visitStatement(&ifStmt.ifTrue()); |
| 880 | this->visitStatement(&ifStmt.ifFalse()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 881 | break; |
| 882 | } |
| 883 | case Statement::Kind::kReturn: { |
| 884 | ReturnStatement& returnStmt = (*stmt)->as<ReturnStatement>(); |
Ethan Nicholas | 2a4952d | 2020-10-08 15:35:56 -0400 | [diff] [blame] | 885 | this->visitExpression(&returnStmt.expression()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 886 | break; |
| 887 | } |
| 888 | case Statement::Kind::kSwitch: { |
| 889 | SwitchStatement& switchStmt = (*stmt)->as<SwitchStatement>(); |
Ethan Nicholas | 01b05e5 | 2020-10-22 15:53:41 -0400 | [diff] [blame] | 890 | if (switchStmt.symbols()) { |
John Stiles | 7804758 | 2020-12-16 16:17:41 -0500 | [diff] [blame] | 891 | fSymbolTableStack.push_back(switchStmt.symbols()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 892 | } |
| 893 | |
Ethan Nicholas | 01b05e5 | 2020-10-22 15:53:41 -0400 | [diff] [blame] | 894 | this->visitExpression(&switchStmt.value()); |
John Stiles | b23a64b | 2021-03-11 08:27:59 -0500 | [diff] [blame] | 895 | for (const std::unique_ptr<Statement>& switchCase : switchStmt.cases()) { |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 896 | // The switch-case's fValue cannot be a FunctionCall; skip it. |
John Stiles | b23a64b | 2021-03-11 08:27:59 -0500 | [diff] [blame] | 897 | this->visitStatement(&switchCase->as<SwitchCase>().statement()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 898 | } |
| 899 | break; |
| 900 | } |
| 901 | case Statement::Kind::kVarDeclaration: { |
| 902 | VarDeclaration& varDeclStmt = (*stmt)->as<VarDeclaration>(); |
| 903 | // Don't need to scan the declaration's sizes; those are always IntLiterals. |
Ethan Nicholas | c51f33e | 2020-10-13 13:49:44 -0400 | [diff] [blame] | 904 | this->visitExpression(&varDeclStmt.value()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 905 | break; |
| 906 | } |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 907 | default: |
| 908 | SkUNREACHABLE; |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 909 | } |
| 910 | |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 911 | // Pop our symbol and enclosing-statement stacks. |
| 912 | fSymbolTableStack.resize(oldSymbolStackSize); |
| 913 | fEnclosingStmtStack.resize(oldEnclosingStmtStackSize); |
| 914 | } |
| 915 | |
| 916 | void visitExpression(std::unique_ptr<Expression>* expr) { |
| 917 | if (!*expr) { |
| 918 | return; |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 919 | } |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 920 | |
| 921 | switch ((*expr)->kind()) { |
| 922 | case Expression::Kind::kBoolLiteral: |
Brian Osman | be0b3b7 | 2021-01-06 14:27:35 -0500 | [diff] [blame] | 923 | case Expression::Kind::kExternalFunctionReference: |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 924 | case Expression::Kind::kFieldAccess: |
| 925 | case Expression::Kind::kFloatLiteral: |
| 926 | case Expression::Kind::kFunctionReference: |
| 927 | case Expression::Kind::kIntLiteral: |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 928 | case Expression::Kind::kSetting: |
| 929 | case Expression::Kind::kTypeReference: |
| 930 | case Expression::Kind::kVariableReference: |
| 931 | // Nothing to scan here. |
| 932 | break; |
| 933 | |
| 934 | case Expression::Kind::kBinary: { |
| 935 | BinaryExpression& binaryExpr = (*expr)->as<BinaryExpression>(); |
John Stiles | 2d4f959 | 2020-10-30 10:29:12 -0400 | [diff] [blame] | 936 | this->visitExpression(&binaryExpr.left()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 937 | |
| 938 | // Logical-and and logical-or binary expressions do not inline the right side, |
| 939 | // because that would invalidate short-circuiting. That is, when evaluating |
| 940 | // expressions like these: |
| 941 | // (false && x()) // always false |
| 942 | // (true || y()) // always true |
| 943 | // It is illegal for side-effects from x() or y() to occur. The simplest way to |
| 944 | // enforce that rule is to avoid inlining the right side entirely. However, it is |
| 945 | // safe for other types of binary expression to inline both sides. |
John Stiles | 4599050 | 2021-02-16 10:55:27 -0500 | [diff] [blame] | 946 | Operator op = binaryExpr.getOperator(); |
| 947 | bool shortCircuitable = (op.kind() == Token::Kind::TK_LOGICALAND || |
| 948 | op.kind() == Token::Kind::TK_LOGICALOR); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 949 | if (!shortCircuitable) { |
John Stiles | 2d4f959 | 2020-10-30 10:29:12 -0400 | [diff] [blame] | 950 | this->visitExpression(&binaryExpr.right()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 951 | } |
| 952 | break; |
| 953 | } |
John Stiles | 7384b37 | 2021-04-01 13:48:15 -0400 | [diff] [blame] | 954 | case Expression::Kind::kConstructorArray: |
John Stiles | 8cad637 | 2021-04-07 12:31:13 -0400 | [diff] [blame] | 955 | case Expression::Kind::kConstructorCompound: |
| 956 | case Expression::Kind::kConstructorCompoundCast: |
John Stiles | 2938eea | 2021-04-01 18:58:25 -0400 | [diff] [blame] | 957 | case Expression::Kind::kConstructorDiagonalMatrix: |
John Stiles | 5abb9e1 | 2021-04-06 13:47:19 -0400 | [diff] [blame] | 958 | case Expression::Kind::kConstructorMatrixResize: |
John Stiles | fd7252f | 2021-04-04 22:24:40 -0400 | [diff] [blame] | 959 | case Expression::Kind::kConstructorScalarCast: |
John Stiles | d47330f | 2021-04-08 23:25:52 -0400 | [diff] [blame] | 960 | case Expression::Kind::kConstructorSplat: |
| 961 | case Expression::Kind::kConstructorStruct: { |
John Stiles | 7384b37 | 2021-04-01 13:48:15 -0400 | [diff] [blame] | 962 | AnyConstructor& constructorExpr = (*expr)->asAnyConstructor(); |
| 963 | for (std::unique_ptr<Expression>& arg : constructorExpr.argumentSpan()) { |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 964 | this->visitExpression(&arg); |
| 965 | } |
| 966 | break; |
| 967 | } |
| 968 | case Expression::Kind::kExternalFunctionCall: { |
| 969 | ExternalFunctionCall& funcCallExpr = (*expr)->as<ExternalFunctionCall>(); |
| 970 | for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) { |
| 971 | this->visitExpression(&arg); |
| 972 | } |
| 973 | break; |
| 974 | } |
| 975 | case Expression::Kind::kFunctionCall: { |
| 976 | FunctionCall& funcCallExpr = (*expr)->as<FunctionCall>(); |
Ethan Nicholas | 0dec992 | 2020-10-05 15:51:52 -0400 | [diff] [blame] | 977 | for (std::unique_ptr<Expression>& arg : funcCallExpr.arguments()) { |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 978 | this->visitExpression(&arg); |
| 979 | } |
| 980 | this->addInlineCandidate(expr); |
| 981 | break; |
| 982 | } |
John Stiles | 708faba | 2021-03-19 09:43:23 -0400 | [diff] [blame] | 983 | case Expression::Kind::kIndex: { |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 984 | IndexExpression& indexExpr = (*expr)->as<IndexExpression>(); |
Ethan Nicholas | 2a4952d | 2020-10-08 15:35:56 -0400 | [diff] [blame] | 985 | this->visitExpression(&indexExpr.base()); |
| 986 | this->visitExpression(&indexExpr.index()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 987 | break; |
| 988 | } |
| 989 | case Expression::Kind::kPostfix: { |
| 990 | PostfixExpression& postfixExpr = (*expr)->as<PostfixExpression>(); |
Ethan Nicholas | 444ccc6 | 2020-10-09 10:16:22 -0400 | [diff] [blame] | 991 | this->visitExpression(&postfixExpr.operand()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 992 | break; |
| 993 | } |
| 994 | case Expression::Kind::kPrefix: { |
| 995 | PrefixExpression& prefixExpr = (*expr)->as<PrefixExpression>(); |
Ethan Nicholas | 444ccc6 | 2020-10-09 10:16:22 -0400 | [diff] [blame] | 996 | this->visitExpression(&prefixExpr.operand()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 997 | break; |
| 998 | } |
| 999 | case Expression::Kind::kSwizzle: { |
| 1000 | Swizzle& swizzleExpr = (*expr)->as<Swizzle>(); |
Ethan Nicholas | 6b4d581 | 2020-10-12 16:11:51 -0400 | [diff] [blame] | 1001 | this->visitExpression(&swizzleExpr.base()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 1002 | break; |
| 1003 | } |
| 1004 | case Expression::Kind::kTernary: { |
| 1005 | TernaryExpression& ternaryExpr = (*expr)->as<TernaryExpression>(); |
| 1006 | // The test expression is a candidate for inlining. |
Ethan Nicholas | dd21816 | 2020-10-08 05:48:01 -0400 | [diff] [blame] | 1007 | this->visitExpression(&ternaryExpr.test()); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 1008 | // The true- and false-expressions cannot be inlined, because we are only allowed to |
| 1009 | // evaluate one side. |
| 1010 | break; |
| 1011 | } |
| 1012 | default: |
| 1013 | SkUNREACHABLE; |
| 1014 | } |
| 1015 | } |
| 1016 | |
| 1017 | void addInlineCandidate(std::unique_ptr<Expression>* candidate) { |
| 1018 | fCandidateList->fCandidates.push_back( |
| 1019 | InlineCandidate{fSymbolTableStack.back(), |
| 1020 | find_parent_statement(fEnclosingStmtStack), |
| 1021 | fEnclosingStmtStack.back(), |
| 1022 | candidate, |
John Stiles | 9b9415e | 2020-11-23 14:48:06 -0500 | [diff] [blame] | 1023 | fEnclosingFunction}); |
John Stiles | 70957c8 | 2020-10-02 16:42:10 -0400 | [diff] [blame] | 1024 | } |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1025 | }; |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 1026 | |
John Stiles | 9b9415e | 2020-11-23 14:48:06 -0500 | [diff] [blame] | 1027 | static const FunctionDeclaration& candidate_func(const InlineCandidate& candidate) { |
| 1028 | return (*candidate.fCandidateExpr)->as<FunctionCall>().function(); |
| 1029 | } |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1030 | |
John Stiles | 9b9415e | 2020-11-23 14:48:06 -0500 | [diff] [blame] | 1031 | bool Inliner::candidateCanBeInlined(const InlineCandidate& candidate, InlinabilityCache* cache) { |
| 1032 | const FunctionDeclaration& funcDecl = candidate_func(candidate); |
John Stiles | 1c03d33 | 2020-10-13 10:30:23 -0400 | [diff] [blame] | 1033 | auto [iter, wasInserted] = cache->insert({&funcDecl, false}); |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1034 | if (wasInserted) { |
| 1035 | // Recursion is forbidden here to avoid an infinite death spiral of inlining. |
John Stiles | 132cfdd | 2021-03-15 22:08:38 +0000 | [diff] [blame] | 1036 | iter->second = this->isSafeToInline(funcDecl.definition()) && |
| 1037 | !contains_recursive_call(funcDecl); |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 1038 | } |
| 1039 | |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1040 | return iter->second; |
| 1041 | } |
| 1042 | |
John Stiles | 9b9415e | 2020-11-23 14:48:06 -0500 | [diff] [blame] | 1043 | int Inliner::getFunctionSize(const FunctionDeclaration& funcDecl, FunctionSizeCache* cache) { |
| 1044 | auto [iter, wasInserted] = cache->insert({&funcDecl, 0}); |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1045 | if (wasInserted) { |
John Stiles | 9b9415e | 2020-11-23 14:48:06 -0500 | [diff] [blame] | 1046 | iter->second = Analysis::NodeCountUpToLimit(*funcDecl.definition(), |
John Stiles | d120464 | 2021-02-17 16:30:02 -0500 | [diff] [blame] | 1047 | this->settings().fInlineThreshold); |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1048 | } |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1049 | return iter->second; |
| 1050 | } |
| 1051 | |
Brian Osman | 0006ad0 | 2020-11-18 15:38:39 -0500 | [diff] [blame] | 1052 | void Inliner::buildCandidateList(const std::vector<std::unique_ptr<ProgramElement>>& elements, |
John Stiles | 7804758 | 2020-12-16 16:17:41 -0500 | [diff] [blame] | 1053 | std::shared_ptr<SymbolTable> symbols, ProgramUsage* usage, |
Brian Osman | 0006ad0 | 2020-11-18 15:38:39 -0500 | [diff] [blame] | 1054 | InlineCandidateList* candidateList) { |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1055 | // This is structured much like a ProgramVisitor, but does not actually use ProgramVisitor. |
| 1056 | // The analyzer needs to keep track of the `unique_ptr<T>*` of statements and expressions so |
| 1057 | // that they can later be replaced, and ProgramVisitor does not provide this; it only provides a |
| 1058 | // `const T&`. |
| 1059 | InlineCandidateAnalyzer analyzer; |
Brian Osman | 0006ad0 | 2020-11-18 15:38:39 -0500 | [diff] [blame] | 1060 | analyzer.visit(elements, symbols, candidateList); |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1061 | |
John Stiles | 0ad233f | 2020-11-25 11:02:05 -0500 | [diff] [blame] | 1062 | // Early out if there are no inlining candidates. |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1063 | std::vector<InlineCandidate>& candidates = candidateList->fCandidates; |
John Stiles | 0ad233f | 2020-11-25 11:02:05 -0500 | [diff] [blame] | 1064 | if (candidates.empty()) { |
| 1065 | return; |
| 1066 | } |
| 1067 | |
| 1068 | // Remove candidates that are not safe to inline. |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1069 | InlinabilityCache cache; |
| 1070 | candidates.erase(std::remove_if(candidates.begin(), |
| 1071 | candidates.end(), |
| 1072 | [&](const InlineCandidate& candidate) { |
| 1073 | return !this->candidateCanBeInlined(candidate, &cache); |
| 1074 | }), |
| 1075 | candidates.end()); |
| 1076 | |
John Stiles | 0ad233f | 2020-11-25 11:02:05 -0500 | [diff] [blame] | 1077 | // If the inline threshold is unlimited, or if we have no candidates left, our candidate list is |
| 1078 | // complete. |
John Stiles | d120464 | 2021-02-17 16:30:02 -0500 | [diff] [blame] | 1079 | if (this->settings().fInlineThreshold == INT_MAX || candidates.empty()) { |
John Stiles | 0ad233f | 2020-11-25 11:02:05 -0500 | [diff] [blame] | 1080 | return; |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1081 | } |
John Stiles | 0ad233f | 2020-11-25 11:02:05 -0500 | [diff] [blame] | 1082 | |
| 1083 | // Remove candidates on a per-function basis if the effect of inlining would be to make more |
| 1084 | // than `inlineThreshold` nodes. (i.e. if Func() would be inlined six times and its size is |
| 1085 | // 10 nodes, it should be inlined if the inlineThreshold is 60 or higher.) |
| 1086 | FunctionSizeCache functionSizeCache; |
| 1087 | FunctionSizeCache candidateTotalCost; |
| 1088 | for (InlineCandidate& candidate : candidates) { |
| 1089 | const FunctionDeclaration& fnDecl = candidate_func(candidate); |
| 1090 | candidateTotalCost[&fnDecl] += this->getFunctionSize(fnDecl, &functionSizeCache); |
| 1091 | } |
| 1092 | |
John Stiles | d120464 | 2021-02-17 16:30:02 -0500 | [diff] [blame] | 1093 | candidates.erase(std::remove_if(candidates.begin(), candidates.end(), |
| 1094 | [&](const InlineCandidate& candidate) { |
| 1095 | const FunctionDeclaration& fnDecl = candidate_func(candidate); |
| 1096 | if (fnDecl.modifiers().fFlags & Modifiers::kInline_Flag) { |
| 1097 | // Functions marked `inline` ignore size limitations. |
| 1098 | return false; |
| 1099 | } |
| 1100 | if (usage->get(fnDecl) == 1) { |
| 1101 | // If a function is only used once, it's cost-free to inline. |
| 1102 | return false; |
| 1103 | } |
| 1104 | if (candidateTotalCost[&fnDecl] <= this->settings().fInlineThreshold) { |
| 1105 | // We won't exceed the inline threshold by inlining this. |
| 1106 | return false; |
| 1107 | } |
| 1108 | // Inlining this function will add too many IRNodes. |
| 1109 | return true; |
| 1110 | }), |
| 1111 | candidates.end()); |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1112 | } |
| 1113 | |
Brian Osman | 0006ad0 | 2020-11-18 15:38:39 -0500 | [diff] [blame] | 1114 | bool Inliner::analyze(const std::vector<std::unique_ptr<ProgramElement>>& elements, |
John Stiles | 7804758 | 2020-12-16 16:17:41 -0500 | [diff] [blame] | 1115 | std::shared_ptr<SymbolTable> symbols, |
Brian Osman | 0006ad0 | 2020-11-18 15:38:39 -0500 | [diff] [blame] | 1116 | ProgramUsage* usage) { |
John Stiles | d34d56e | 2020-10-12 12:04:47 -0400 | [diff] [blame] | 1117 | // A threshold of zero indicates that the inliner is completely disabled, so we can just return. |
John Stiles | d120464 | 2021-02-17 16:30:02 -0500 | [diff] [blame] | 1118 | if (this->settings().fInlineThreshold <= 0) { |
John Stiles | d34d56e | 2020-10-12 12:04:47 -0400 | [diff] [blame] | 1119 | return false; |
| 1120 | } |
| 1121 | |
John Stiles | 031a767 | 2020-11-13 16:13:18 -0500 | [diff] [blame] | 1122 | // Enforce a limit on inlining to avoid pathological cases. (inliner/ExponentialGrowth.sksl) |
| 1123 | if (fInlinedStatementCounter >= kInlinedStatementLimit) { |
| 1124 | return false; |
| 1125 | } |
| 1126 | |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1127 | InlineCandidateList candidateList; |
John Stiles | 9b9415e | 2020-11-23 14:48:06 -0500 | [diff] [blame] | 1128 | this->buildCandidateList(elements, symbols, usage, &candidateList); |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1129 | |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1130 | // Inline the candidates where we've determined that it's safe to do so. |
John Stiles | 708faba | 2021-03-19 09:43:23 -0400 | [diff] [blame] | 1131 | using StatementRemappingTable = std::unordered_map<std::unique_ptr<Statement>*, |
| 1132 | std::unique_ptr<Statement>*>; |
| 1133 | StatementRemappingTable statementRemappingTable; |
| 1134 | |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1135 | bool madeChanges = false; |
John Stiles | 2d7973a | 2020-10-02 15:01:03 -0400 | [diff] [blame] | 1136 | for (const InlineCandidate& candidate : candidateList.fCandidates) { |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1137 | FunctionCall& funcCall = (*candidate.fCandidateExpr)->as<FunctionCall>(); |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1138 | |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1139 | // Convert the function call to its inlined equivalent. |
John Stiles | 30fce9c | 2021-03-18 09:24:06 -0400 | [diff] [blame] | 1140 | InlinedCall inlinedCall = this->inlineCall(&funcCall, candidate.fSymbols, *usage, |
Ethan Nicholas | 0a5d096 | 2020-10-14 13:33:18 -0400 | [diff] [blame] | 1141 | &candidate.fEnclosingFunction->declaration()); |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1142 | |
John Stiles | 0c2d14a | 2021-03-01 10:08:08 -0500 | [diff] [blame] | 1143 | // Stop if an error was detected during the inlining process. |
| 1144 | if (!inlinedCall.fInlinedBody && !inlinedCall.fReplacementExpr) { |
| 1145 | break; |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1146 | } |
| 1147 | |
John Stiles | 0c2d14a | 2021-03-01 10:08:08 -0500 | [diff] [blame] | 1148 | // Ensure that the inlined body has a scope if it needs one. |
| 1149 | this->ensureScopedBlocks(inlinedCall.fInlinedBody.get(), candidate.fParentStmt->get()); |
| 1150 | |
| 1151 | // Add references within the inlined body |
| 1152 | usage->add(inlinedCall.fInlinedBody.get()); |
| 1153 | |
John Stiles | 708faba | 2021-03-19 09:43:23 -0400 | [diff] [blame] | 1154 | // Look up the enclosing statement; remap it if necessary. |
| 1155 | std::unique_ptr<Statement>* enclosingStmt = candidate.fEnclosingStmt; |
| 1156 | for (;;) { |
| 1157 | auto iter = statementRemappingTable.find(enclosingStmt); |
| 1158 | if (iter == statementRemappingTable.end()) { |
| 1159 | break; |
| 1160 | } |
| 1161 | enclosingStmt = iter->second; |
| 1162 | } |
| 1163 | |
John Stiles | 0c2d14a | 2021-03-01 10:08:08 -0500 | [diff] [blame] | 1164 | // Move the enclosing statement to the end of the unscoped Block containing the inlined |
| 1165 | // function, then replace the enclosing statement with that Block. |
| 1166 | // Before: |
| 1167 | // fInlinedBody = Block{ stmt1, stmt2, stmt3 } |
| 1168 | // fEnclosingStmt = stmt4 |
| 1169 | // After: |
| 1170 | // fInlinedBody = null |
| 1171 | // fEnclosingStmt = Block{ stmt1, stmt2, stmt3, stmt4 } |
John Stiles | 708faba | 2021-03-19 09:43:23 -0400 | [diff] [blame] | 1172 | inlinedCall.fInlinedBody->children().push_back(std::move(*enclosingStmt)); |
| 1173 | *enclosingStmt = std::move(inlinedCall.fInlinedBody); |
John Stiles | 0c2d14a | 2021-03-01 10:08:08 -0500 | [diff] [blame] | 1174 | |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1175 | // Replace the candidate function call with our replacement expression. |
John Stiles | 60dbf07 | 2021-08-02 14:22:34 -0400 | [diff] [blame^] | 1176 | usage->remove(candidate.fCandidateExpr->get()); |
| 1177 | usage->add(inlinedCall.fReplacementExpr.get()); |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1178 | *candidate.fCandidateExpr = std::move(inlinedCall.fReplacementExpr); |
| 1179 | madeChanges = true; |
| 1180 | |
John Stiles | 708faba | 2021-03-19 09:43:23 -0400 | [diff] [blame] | 1181 | // If anything else pointed at our enclosing statement, it's now pointing at a Block |
| 1182 | // containing many other statements as well. Maintain a fix-up table to account for this. |
| 1183 | statementRemappingTable[enclosingStmt] = &(*enclosingStmt)->as<Block>().children().back(); |
| 1184 | |
John Stiles | 031a767 | 2020-11-13 16:13:18 -0500 | [diff] [blame] | 1185 | // Stop inlining if we've reached our hard cap on new statements. |
| 1186 | if (fInlinedStatementCounter >= kInlinedStatementLimit) { |
| 1187 | break; |
| 1188 | } |
| 1189 | |
John Stiles | 915a38c | 2020-09-14 09:38:13 -0400 | [diff] [blame] | 1190 | // Note that nothing was destroyed except for the FunctionCall. All other nodes should |
| 1191 | // remain valid. |
| 1192 | } |
| 1193 | |
| 1194 | return madeChanges; |
John Stiles | 9344262 | 2020-09-11 12:11:27 -0400 | [diff] [blame] | 1195 | } |
| 1196 | |
John Stiles | 44e96be | 2020-08-31 13:16:04 -0400 | [diff] [blame] | 1197 | } // namespace SkSL |