blob: 5ad8fd975c703107a9fd6eec1576dabfda4f1c64 [file] [log] [blame]
mtklein7fbfbbe2016-07-21 12:25:45 -07001# Copyright 2016 Google Inc.
2#
3# Use of this source code is governed by a BSD-style license that can be
4# found in the LICENSE file.
5
John Rosasco24cbdab2019-09-25 14:14:35 -07006if (is_fuchsia) {
Robert Phillipsc919f972019-11-18 11:01:05 -05007 import("//build/fuchsia/sdk.gni")
John Rosasco24cbdab2019-09-25 14:14:35 -07008}
9
mtklein7fbfbbe2016-07-21 12:25:45 -070010declare_args() {
Kevin Lubick2677a9a2017-03-28 15:45:41 -040011 extra_asmflags = []
Mike Klein121563e2016-10-04 17:09:13 -040012 extra_cflags = []
13 extra_cflags_c = []
14 extra_cflags_cc = []
15 extra_ldflags = []
mtkleincab0bb72016-08-26 13:43:19 -070016
Herb Derby76073c12016-12-08 19:00:40 -050017 malloc = ""
Mike Klein29cb9f92020-06-19 16:25:12 -050018 werror = false
Herb Derbyc65eb342019-10-18 14:29:09 -040019 xcode_sysroot = ""
mtklein7fbfbbe2016-07-21 12:25:45 -070020}
Mike Klein82364ba2016-10-24 16:49:15 -040021
Herb Derbyc65eb342019-10-18 14:29:09 -040022if (is_ios && xcode_sysroot == "") {
Matthew Leibowitz3150ec62017-03-14 16:22:32 -040023 if (is_tvos) {
24 sdk = "appletvos"
25 if (target_cpu == "x86" || target_cpu == "x64") {
26 sdk = "appletvsimulator"
27 }
28 } else {
29 sdk = "iphoneos"
30 if (target_cpu == "x86" || target_cpu == "x64") {
31 sdk = "iphonesimulator"
32 }
Mike Klein7a5e0f32017-03-13 09:25:33 -070033 }
Herb Derbyc65eb342019-10-18 14:29:09 -040034 xcode_sysroot = exec_script("find_xcode_sysroot.py", [ sdk ], "trim string")
35}
36
37# If building for mac on a mac then lookup all the system includes so that goma and the clang
38# shipped with chrome can find them. When the gn_to_bp.py tool is run, then the host_os != mac.
39# In this case leave the xcode_sysroot empty, and the cc/c++ that come with XCode will be able to
40# find needed include paths.
41if (is_mac && host_os == "mac" && xcode_sysroot == "") {
42 xcode_sysroot =
43 exec_script("find_xcode_sysroot.py", [ "macosx" ], "trim string")
Mike Klein7d302882016-11-03 14:06:31 -040044}
45
mtkleinb9be9792016-09-16 14:44:18 -070046config("default") {
47 asmflags = []
48 cflags = []
49 cflags_c = []
50 cflags_cc = []
51 defines = []
52 ldflags = []
Herb Derby76073c12016-12-08 19:00:40 -050053 libs = []
mtkleinb9be9792016-09-16 14:44:18 -070054
Mike Kleinba201ae2019-04-23 07:38:07 -050055 if (werror) {
56 if (is_win) {
57 cflags += [ "/WX" ]
58 } else {
59 cflags += [ "-Werror" ]
60 }
61 }
62
Mike Klein28abea52020-02-19 09:17:51 -060063 # Disable warnings about unknown attributes.
64 # (These unknown attribute warnings are on by default, so we don't make
65 # disabling them part of :warnings, as some targets remove :warnings.)
66 if (is_win && !is_clang) {
67 cflags += [ "/wd5030" ]
68 } else {
69 cflags += [ "-Wno-attributes" ]
70 }
71
John Rosasco24cbdab2019-09-25 14:14:35 -070072 if (is_fuchsia && using_fuchsia_sdk) {
Robert Phillipsc919f972019-11-18 11:01:05 -050073 ldflags += [
74 "-v",
75 "--sysroot=" + rebase_path("$fuchsia_sdk_path/arch/$target_cpu/sysroot"),
76 ]
77 cflags += [ "--sysroot=" +
78 rebase_path("$fuchsia_sdk_path/arch/$target_cpu/sysroot") ]
John Rosasco24cbdab2019-09-25 14:14:35 -070079 if (target_cpu == "x64") {
80 target_triple = "--target=x86_64-${target_os}"
81 } else if (target_cpu == "arm64") {
82 target_triple = "--target=aarch64-unknown-${target_os}"
83 } else {
84 print("Unknown target CPU for Fuchsia target build.")
85 assert(false)
86 }
87 ldflags += [ target_triple ]
88 cflags += [ target_triple ]
89 asmflags += [ target_triple ]
90 }
91
mtkleinb9be9792016-09-16 14:44:18 -070092 if (is_win) {
Mike Kleinda8a6e12019-04-17 08:18:10 -050093 if (is_clang && target_cpu == "arm64") {
94 cflags += [ "--target=arm64-windows" ]
95 }
mtkleinb9be9792016-09-16 14:44:18 -070096 cflags += [
herbb6318bf2016-09-16 13:29:57 -070097 "/bigobj", # Some of our files are bigger than the regular limits.
Ben Wagnere6b274e2017-01-03 17:09:59 -050098 "/utf-8", # Set Source and Executable character sets to UTF-8.
herbb6318bf2016-09-16 13:29:57 -070099 ]
Brian Salomon8283fa42019-11-07 10:42:41 -0500100 cflags_cc += [ "/std:c++17" ]
mtkleinb9be9792016-09-16 14:44:18 -0700101 defines += [
Mike Kleinc7165c22016-10-12 23:58:06 -0400102 "_CRT_SECURE_NO_WARNINGS", # Disables warnings about sscanf().
103 "_HAS_EXCEPTIONS=0", # Disables exceptions in MSVC STL.
mtkleinb9be9792016-09-16 14:44:18 -0700104 "WIN32_LEAN_AND_MEAN",
105 "NOMINMAX",
herbb6318bf2016-09-16 13:29:57 -0700106 ]
Mike Klein98adfa82017-07-31 15:46:47 -0400107
Hal Canaryf72728e2019-07-10 11:24:52 -0400108 _include_dirs = [
109 "$win_vc/Tools/MSVC/$win_toolchain_version/include",
Brian Osman5f872622017-12-06 15:21:44 -0500110 "$win_sdk/Include/$win_sdk_version/shared",
111 "$win_sdk/Include/$win_sdk_version/ucrt",
112 "$win_sdk/Include/$win_sdk_version/um",
113 "$win_sdk/Include/$win_sdk_version/winrt",
114 ]
115
Mike Klein98adfa82017-07-31 15:46:47 -0400116 if (is_clang) {
117 foreach(dir, _include_dirs) {
118 cflags += [
119 "-imsvc",
120 dir,
121 ]
122 }
123 } else {
124 include_dirs = _include_dirs
125 }
126
Brian Osman5f872622017-12-06 15:21:44 -0500127 lib_dirs = [
128 "$win_sdk/Lib/$win_sdk_version/ucrt/$target_cpu",
129 "$win_sdk/Lib/$win_sdk_version/um/$target_cpu",
Hal Canaryf72728e2019-07-10 11:24:52 -0400130 "$win_vc/Tools/MSVC/$win_toolchain_version/lib/$target_cpu",
Brian Osman5f872622017-12-06 15:21:44 -0500131 ]
mtkleinb9be9792016-09-16 14:44:18 -0700132 } else {
Shachar Langbeheim07c4e1d2019-12-16 10:46:52 +0200133 cflags += [
134 "-fstrict-aliasing",
135 "-fPIC",
Mike Kleined800352020-08-04 12:06:23 -0500136 "-fvisibility=hidden",
Shachar Langbeheim07c4e1d2019-12-16 10:46:52 +0200137 ]
Mike Kleined800352020-08-04 12:06:23 -0500138 cflags_cc += [
139 "-std=c++17",
140 "-fvisibility-inlines-hidden",
141 ]
mtkleinb9be9792016-09-16 14:44:18 -0700142 }
herbb6318bf2016-09-16 13:29:57 -0700143
mtkleinb9be9792016-09-16 14:44:18 -0700144 if (current_cpu == "arm") {
145 cflags += [
146 "-march=armv7-a",
147 "-mfpu=neon",
148 "-mthumb",
149 ]
Mike Klein4d4b3aa2018-03-21 13:07:35 -0400150 } else if (current_cpu == "x86" && !is_win) {
mtkleinb9be9792016-09-16 14:44:18 -0700151 asmflags += [ "-m32" ]
152 cflags += [
153 "-m32",
154 "-msse2",
155 "-mfpmath=sse",
156 ]
157 ldflags += [ "-m32" ]
158 }
herbb6318bf2016-09-16 13:29:57 -0700159
Herb Derby76073c12016-12-08 19:00:40 -0500160 if (malloc != "" && !is_win) {
161 cflags += [
162 "-fno-builtin-malloc",
163 "-fno-builtin-calloc",
164 "-fno-builtin-realloc",
165 "-fno-builtin-free",
166 ]
167 libs += [ malloc ]
168 }
169
Hal Canarya0834042018-06-01 20:22:25 +0000170 if (is_android) {
Mike Klein5b52c522019-07-03 10:44:21 -0500171 cflags += [ "--sysroot=$ndk/sysroot" ]
Mike Klein2e096932020-10-06 10:12:11 -0500172 cflags_cc += [
173 "-isystem$ndk/sources/cxx-stl/llvm-libc++/include",
174 "-isystem$ndk/sources/cxx-stl/llvm-libc++abi/include",
175 ]
Mike Klein5b52c522019-07-03 10:44:21 -0500176 ldflags += [ "-static-libstdc++" ]
mtklein2b3c2a32016-09-08 08:39:34 -0700177 }
mtklein7fbfbbe2016-07-21 12:25:45 -0700178
Mike Klein7d302882016-11-03 14:06:31 -0400179 if (is_ios) {
Mike Kleinb48fd3c2017-01-23 11:58:53 -0500180 if (target_cpu == "arm") {
Mike Kleina1397882020-08-25 10:03:03 -0500181 _arch_flags = [
182 "-arch",
183 "armv7",
184 ]
185 } else if (target_cpu == "arm64") {
186 _arch_flags = [
187 "-arch",
188 "arm64",
189 "-arch",
190 "arm64e",
191 ]
Mike Klein7a5e0f32017-03-13 09:25:33 -0700192 } else if (target_cpu == "x86") {
Mike Kleina1397882020-08-25 10:03:03 -0500193 _arch_flags = [
194 "-arch",
195 "i386",
196 ]
Mike Klein7a5e0f32017-03-13 09:25:33 -0700197 } else if (target_cpu == "x64") {
Mike Kleina1397882020-08-25 10:03:03 -0500198 _arch_flags = [
199 "-arch",
200 "x86_64",
201 ]
202 } else {
203 _arch_flags = [
204 "-arch",
205 target_cpu,
206 ]
Mike Kleinb48fd3c2017-01-23 11:58:53 -0500207 }
Mike Kleina1397882020-08-25 10:03:03 -0500208
Mike Klein4fe2b152017-02-17 15:36:01 -0500209 asmflags += [
Mike Kleina1397882020-08-25 10:03:03 -0500210 "-isysroot",
211 xcode_sysroot,
212 ] + _arch_flags
Mike Klein7d302882016-11-03 14:06:31 -0400213 cflags += [
Mike Kleina1397882020-08-25 10:03:03 -0500214 "-isysroot",
215 xcode_sysroot,
216 ] + _arch_flags
Brian Salomon8283fa42019-11-07 10:42:41 -0500217 cflags_cc += [
218 "-stdlib=libc++",
219 "-fno-aligned-allocation",
220 ]
Mike Klein7d302882016-11-03 14:06:31 -0400221 ldflags += [
Mike Kleina1397882020-08-25 10:03:03 -0500222 "-isysroot",
223 xcode_sysroot,
224 "-stdlib=libc++",
225 ] + _arch_flags
Herb Derby76073c12016-12-08 19:00:40 -0500226 libs += [ "objc" ]
Mike Klein7d302882016-11-03 14:06:31 -0400227 }
228
mtkleinb9be9792016-09-16 14:44:18 -0700229 if (is_linux) {
Herb Derby76073c12016-12-08 19:00:40 -0500230 libs += [ "pthread" ]
mtkleinb9be9792016-09-16 14:44:18 -0700231 }
Herb Derbyc65eb342019-10-18 14:29:09 -0400232
Mike Klein15f46c32017-12-07 12:48:57 -0500233 if (is_mac) {
Herb Derbyc65eb342019-10-18 14:29:09 -0400234 # If there was a xcode_sysroot set in args or calculated then use it, else don't set anything
235 # because the XCode cc/c++ already know all this stuff.
236 if (xcode_sysroot != "") {
237 asmflags += [
238 "-isysroot",
239 xcode_sysroot,
240 ]
241 cflags += [
242 "-isysroot",
243 xcode_sysroot,
244 ]
245 ldflags += [
246 "-isysroot",
247 xcode_sysroot,
248 ]
249 }
250
Mike Klein15f46c32017-12-07 12:48:57 -0500251 # Disable linker warnings. They're usually just annoyances like,
252 # ld: warning: text-based stub file
253 # /System/Library/Frameworks/foo.framework/foo.tbd and library file
254 # /System/Library/Frameworks/foo.framework/foo are out of sync.
255 # Falling back to library file for linking.
256 ldflags += [ "-Wl,-w" ]
257 }
mtkleinb9be9792016-09-16 14:44:18 -0700258
Brian Osman50ea3c02019-02-04 10:01:53 -0500259 if (sanitize != "" && sanitize != "MSVC") {
mtkleinb9be9792016-09-16 14:44:18 -0700260 # You can either pass the sanitizers directly, e.g. "address,undefined",
261 # or pass one of the couple common aliases used by the bots.
262 sanitizers = sanitize
Kevin Lubickd0950402018-03-20 10:10:58 -0400263
Ben Wagnerb6f98ea2019-12-21 00:53:11 -0500264 if (sanitize == "ASAN") {
Ben Wagner314d7c22018-01-03 11:04:30 -0500265 # ASAN implicitly runs all UBSAN checks also.
Ben Wagnerb6f98ea2019-12-21 00:53:11 -0500266 sanitizers = "undefined,address"
Kevin Lubick4f0f9332018-01-12 14:31:48 -0500267
Mike Klein02046a72018-08-10 12:25:12 -0400268 if (is_android) {
269 # TODO(mtklein): work out UBSAN link errors
270 sanitizers = "address"
Kevin Lubick4f0f9332018-01-12 14:31:48 -0500271 }
mtkleinb9be9792016-09-16 14:44:18 -0700272 } else if (sanitize == "TSAN") {
273 sanitizers = "thread"
274 } else if (sanitize == "MSAN") {
275 sanitizers = "memory"
276 }
277
Mike Kleind26b3e22020-07-24 12:16:50 -0500278 _suppressions = rebase_path("../tools/xsan.supp")
Mike Klein475c5e92018-08-08 10:23:17 -0400279
mtkleinb9be9792016-09-16 14:44:18 -0700280 cflags += [
Mike Klein02046a72018-08-10 12:25:12 -0400281 "-fsanitize=$sanitizers",
mtkleinb9be9792016-09-16 14:44:18 -0700282 "-fno-sanitize-recover=$sanitizers",
Mike Kleind26b3e22020-07-24 12:16:50 -0500283 "-fsanitize-blacklist=$_suppressions",
mtkleinb9be9792016-09-16 14:44:18 -0700284 ]
Mike Kleincdb0e8f2019-12-18 14:25:50 -0600285
Mike Klein94c4f412018-08-09 17:24:45 -0400286 if (is_win) {
Ben Wagnerb6f98ea2019-12-21 00:53:11 -0500287 cflags += [
Mike Kleind26b3e22020-07-24 12:16:50 -0500288 "/FI$_suppressions",
Ben Wagnerb6f98ea2019-12-21 00:53:11 -0500289
290 # On Release builds, we get strange warnings about string literals.
291 "/GF-",
292 ]
293
294 assert(clang_win != "")
295 libs += [ "$clang_win/lib/clang/$clang_win_version/lib/windows/clang_rt.asan-x86_64.lib" ]
Mike Klein94c4f412018-08-09 17:24:45 -0400296 } else {
297 cflags += [
Mike Kleind26b3e22020-07-24 12:16:50 -0500298 "-include$_suppressions",
Mike Klein94c4f412018-08-09 17:24:45 -0400299 "-fno-omit-frame-pointer",
300 ]
Ben Wagnerb6f98ea2019-12-21 00:53:11 -0500301
302 ldflags += [ "-fsanitize=$sanitizers" ]
Kevin Lubick5798c9f2018-02-15 09:45:58 -0500303 }
Mike Klein94c4f412018-08-09 17:24:45 -0400304
Kevin Lubick5798c9f2018-02-15 09:45:58 -0500305 if (is_linux) {
Kevin Lubick43bd2592018-02-15 09:03:44 -0500306 cflags_cc += [ "-stdlib=libc++" ]
307 ldflags += [ "-stdlib=libc++" ]
Kevin Lubick3cda39f2018-02-01 12:09:55 -0500308 }
Mike Klein02046a72018-08-10 12:25:12 -0400309
mtkleinb9be9792016-09-16 14:44:18 -0700310 if (sanitizers == "memory") {
311 cflags += [ "-fsanitize-memory-track-origins" ]
mtkleinb9be9792016-09-16 14:44:18 -0700312 }
Brian Salomon8283fa42019-11-07 10:42:41 -0500313 if (sanitizers == "safe-stack") {
314 cflags_cc += [ "-fno-aligned-allocation" ]
315 }
mtkleinb9be9792016-09-16 14:44:18 -0700316 }
317}
318
Mike Kleinc0c05222020-01-31 11:07:51 -0600319# See skia:9731.
320config("recover_pointer_overflow") {
321 cflags = [ "-fsanitize-recover=pointer-overflow" ]
322}
323
Mike Klein6e55fef2016-10-26 11:41:47 -0400324config("no_exceptions") {
Mike Klein228276d2017-08-16 13:20:20 +0000325 # Exceptions are disabled by default on Windows. (Use /EHsc to enable them.)
Mike Klein6e55fef2016-10-26 11:41:47 -0400326 if (!is_win) {
327 cflags_cc = [ "-fno-exceptions" ]
328 }
329}
330
Mike Kleinc7165c22016-10-12 23:58:06 -0400331config("warnings") {
332 cflags = []
333 cflags_cc = []
Mike Klein43c25262016-10-20 10:17:47 -0400334 cflags_objc = []
Greg Daniel6b7e0e22017-07-12 16:21:09 -0400335 cflags_objcc = []
Mike Kleinc7165c22016-10-12 23:58:06 -0400336 if (is_win) {
337 cflags += [
338 "/W3", # Turn on lots of warnings.
339
340 # Disable a bunch of warnings:
341 "/wd4244", # conversion from 'float' to 'int', possible loss of data
342 "/wd4267", # conversion from 'size_t' to 'int', possible loss of data
Mike Kleina01c6b02020-04-01 13:47:34 -0500343 "/wd4800", # forcing value to bool 'true' or 'false' (performance
344 # warning)
Mike Kleinc7165c22016-10-12 23:58:06 -0400345
346 # Probably only triggers when /EHsc is enabled.
347 "/wd4291", # no matching operator delete found;
Mike Kleina01c6b02020-04-01 13:47:34 -0500348 # memory will not be freed if initialization throws an
349 # exception
Brian Osmaneec1e9e2019-04-10 16:22:15 -0400350
351 # These only show up in shared builds:
Mike Kleina01c6b02020-04-01 13:47:34 -0500352 "/wd4251", # class 'type' needs to have dll-interface to be used by
353 # clients of class 'type2'
354 "/wd4275", # non dll-interface class 'base' used as base for
355 # dll-interface class 'derived'
Brian Salomon8283fa42019-11-07 10:42:41 -0500356
357 # It'd be nice to fix these and turn this on:
Mike Kleina01c6b02020-04-01 13:47:34 -0500358 "/wd5041", # out-of-line definition for constexpr static data member is
359 # not needed and is deprecated in C++17
Mike Kleindc976a92020-04-30 06:45:25 -0500360
361 # warning C4996: 'std::result_of_t': warning STL4014: std::result_of and std::result_of_t are
362 # deprecated in C++17. They are superseded by std::invoke_result and std::invoke_result_t.
363 "/wd4996",
Mike Kleinc7165c22016-10-12 23:58:06 -0400364 ]
365 } else {
366 cflags += [
367 "-Wall",
368 "-Wextra",
369 "-Winit-self",
370 "-Wpointer-arith",
371 "-Wsign-compare",
372 "-Wvla",
373
374 "-Wno-deprecated-declarations",
Mike Kleindb402ca2016-12-13 12:46:05 -0500375 "-Wno-maybe-uninitialized",
Mike Klein90b027a2020-09-02 09:09:11 -0500376 "-Wno-psabi",
Mike Kleinc7165c22016-10-12 23:58:06 -0400377 ]
Ben Wagnerf8a131d2018-03-13 16:56:43 -0400378 cflags_cc += [
379 "-Wnon-virtual-dtor",
380 "-Wno-noexcept-type",
Ben Wagner7363af82020-03-27 14:29:38 -0400381 "-Wno-redundant-move", #TODO: gcc conflict with return-std-move-in-c++11
Ben Wagnerf8a131d2018-03-13 16:56:43 -0400382 ]
Chris Dalton1ef80942017-12-04 12:01:30 -0700383 }
Mike Kleinc7165c22016-10-12 23:58:06 -0400384
Chris Dalton1ef80942017-12-04 12:01:30 -0700385 if (is_clang) {
386 cflags += [
Mike Kleinb7b2da82019-02-28 08:47:44 -0600387 "-fcolor-diagnostics",
Chris Dalton1ef80942017-12-04 12:01:30 -0700388 "-Weverything",
Mike Kleina01c6b02020-04-01 13:47:34 -0500389 "-Wno-unknown-warning-option", # Let older Clangs ignore newer Clangs'
390 # warnings.
Chris Dalton1ef80942017-12-04 12:01:30 -0700391 ]
Mike Kleinc7165c22016-10-12 23:58:06 -0400392
Chris Dalton1ef80942017-12-04 12:01:30 -0700393 if (target_cpu == "arm" && is_ios) {
394 # Clang seems to think new/malloc will only be 4-byte aligned on 32-bit iOS.
395 # We're pretty sure it's actually 8-byte alignment.
396 cflags += [ "-Wno-over-aligned" ]
Mike Kleinc7165c22016-10-12 23:58:06 -0400397 }
Mike Klein04282792018-01-08 18:23:32 -0500398 if (target_cpu == "x86" && is_android) {
399 # Clang seems to think new/malloc will only be 4-byte aligned on 32-bit x86 Android builds.
400 # We're pretty sure it's actually 8-byte alignment. See OverAlignedTest.cpp for more info.
401 cflags += [ "-Wno-over-aligned" ]
402 }
Chris Dalton1ef80942017-12-04 12:01:30 -0700403
404 # Shouldn't be necessary for local builds. With distributed Windows builds, files may lose
405 # their case during copy, causing case-sensitivity mismatch on remote machines.
406 cflags += [
407 "-Wno-nonportable-include-path",
408 "-Wno-nonportable-system-include-path",
409 ]
410
411 # TODO: These would all be really great warnings to turn on.
412 cflags += [
413 "-Wno-cast-align",
414 "-Wno-cast-qual",
Chris Dalton1ef80942017-12-04 12:01:30 -0700415 "-Wno-conversion",
416 "-Wno-disabled-macro-expansion",
417 "-Wno-documentation",
418 "-Wno-documentation-unknown-command",
419 "-Wno-double-promotion",
420 "-Wno-exit-time-destructors", # TODO: OK outside libskia
Chris Dalton1ef80942017-12-04 12:01:30 -0700421 "-Wno-float-equal",
422 "-Wno-format-nonliteral",
423 "-Wno-global-constructors", # TODO: OK outside libskia
Chris Dalton1ef80942017-12-04 12:01:30 -0700424 "-Wno-missing-prototypes",
425 "-Wno-missing-variable-declarations",
426 "-Wno-pedantic",
427 "-Wno-reserved-id-macro",
428 "-Wno-shadow",
429 "-Wno-shift-sign-overflow",
Chris Dalton1ef80942017-12-04 12:01:30 -0700430 "-Wno-signed-enum-bitfield",
431 "-Wno-switch-enum",
432 "-Wno-undef",
433 "-Wno-unreachable-code",
434 "-Wno-unreachable-code-break",
435 "-Wno-unreachable-code-return",
436 "-Wno-unused-macros",
437 "-Wno-unused-member-function",
438 "-Wno-unused-template",
439 "-Wno-zero-as-null-pointer-constant",
Herb Derbya1b7be62019-05-09 16:59:18 -0400440 "-Wno-thread-safety-negative",
Mike Kleinfdd542f2020-06-02 11:41:55 -0500441 "-Wno-non-c-typedef-for-linkage", # Dawn, not Skia per se.
Chris Dalton1ef80942017-12-04 12:01:30 -0700442 ]
443 cflags_cc += [
444 "-Wno-abstract-vbase-init",
445 "-Wno-weak-vtables",
446 ]
447
Mike Klein89c909e2020-06-01 15:50:19 -0500448 # Turn back on after -Wno-conversion.
449 # This only affects public headers... see :warnings_except_public_headers.
450 cflags += [ "-Wsign-conversion" ]
451
Chris Dalton1ef80942017-12-04 12:01:30 -0700452 # We are unlikely to want to fix these.
453 cflags += [
454 "-Wno-covered-switch-default",
455 "-Wno-deprecated",
Chris Dalton1ef80942017-12-04 12:01:30 -0700456 "-Wno-missing-noreturn",
457 "-Wno-old-style-cast",
458 "-Wno-padded",
Chris Daltond1ec4102017-12-04 13:31:21 -0700459 "-Wno-newline-eof",
Chris Dalton1ef80942017-12-04 12:01:30 -0700460 ]
461 cflags_cc += [
462 "-Wno-c++98-compat",
463 "-Wno-c++98-compat-pedantic",
464 "-Wno-undefined-func-template",
465 ]
466 cflags_objc += [
467 "-Wno-direct-ivar-access",
468 "-Wno-objc-interface-ivars",
469 ]
470 cflags_objcc += [
471 "-Wno-direct-ivar-access",
472 "-Wno-objcc-interface-ivars",
473 ]
Ben Wagner833313b2020-03-23 17:22:24 -0400474
475 # Wno-deprecated turns off the whole group, but also has its own warnings like
476 # out-of-line definition of constexpr static data member is redundant in C++17 and is deprecated [-Werror,-Wdeprecated]
477 # but we would like others. Created from clang/include/clang/Basic/DiagnosticGroups.td
478 cflags += [
479 "-Wdeprecated-anon-enum-enum-conversion",
480 "-Wdeprecated-array-compare",
481 "-Wdeprecated-attributes",
482 "-Wdeprecated-comma-subscript",
483 "-Wdeprecated-copy",
Ben Wagner7345d882020-03-27 11:28:03 -0400484
Ben Wagner507e4862020-03-31 22:31:46 +0000485 #"-Wdeprecated-copy-dtor",
Ben Wagner833313b2020-03-23 17:22:24 -0400486 #"-Wdeprecated-declarations",
487 "-Wdeprecated-dynamic-exception-spec",
488 "-Wdeprecated-enum-compare",
489 "-Wdeprecated-enum-compare-conditional",
490 "-Wdeprecated-enum-enum-conversion",
491 "-Wdeprecated-enum-float-conversion",
492 "-Wdeprecated-increment-bool",
493 "-Wdeprecated-register",
494 "-Wdeprecated-this-capture",
495 "-Wdeprecated-volatile",
496 "-Wdeprecated-writable-str",
497 ]
Mike Kleinc7165c22016-10-12 23:58:06 -0400498 }
499}
Mike Klein50500ad2016-11-16 12:13:44 -0500500config("warnings_except_public_headers") {
Chris Dalton1ef80942017-12-04 12:01:30 -0700501 if (!is_win || is_clang) {
Mike Klein89c909e2020-06-01 15:50:19 -0500502 cflags = [
503 "-Wno-sign-conversion",
504 "-Wno-unused-parameter",
505 ]
Mike Klein50500ad2016-11-16 12:13:44 -0500506 }
507}
Mike Kleinc7165c22016-10-12 23:58:06 -0400508
Mike Klein121563e2016-10-04 17:09:13 -0400509config("extra_flags") {
Kevin Lubick2677a9a2017-03-28 15:45:41 -0400510 asmflags = extra_asmflags
Mike Klein121563e2016-10-04 17:09:13 -0400511 cflags = extra_cflags
512 cflags_c = extra_cflags_c
513 cflags_cc = extra_cflags_cc
514 ldflags = extra_ldflags
515}
516
mtkleinb9be9792016-09-16 14:44:18 -0700517config("debug_symbols") {
518 # It's annoying to wait for full debug symbols to push over
519 # to Android devices. -gline-tables-only is a lot slimmer.
520 if (is_android) {
Mike Klein1b4602b2017-08-30 10:23:01 -0400521 cflags = [
522 "-gline-tables-only",
523 "-funwind-tables", # Helps make in-process backtraces fuller.
524 ]
Mike Kleincc300a12016-10-12 16:25:27 -0400525 } else if (is_win) {
Mike Klein67a86d52017-12-15 07:34:27 -0500526 cflags = [ "/Z7" ]
Brian Osman7142ae52018-12-12 16:32:35 -0500527 if (is_clang) {
Eric Boren56bf8ce2019-02-07 13:05:06 -0500528 cflags += [ "-gcodeview-ghash" ]
Mike Kleincae020a2018-12-23 10:25:44 -0500529 ldflags = [ "/DEBUG:GHASH" ]
Brian Osman7142ae52018-12-12 16:32:35 -0500530 } else {
Mike Kleina6e0c2b2018-12-10 08:48:03 -0500531 ldflags = [ "/DEBUG:FASTLINK" ]
Brian Osman0ab56842018-09-13 15:46:02 -0400532 }
Mike Kleincc300a12016-10-12 16:25:27 -0400533 } else {
mtkleinb9be9792016-09-16 14:44:18 -0700534 cflags = [ "-g" ]
535 }
536}
537
538config("no_rtti") {
539 if (sanitize != "ASAN") { # -fsanitize=vptr requires RTTI
Mike Kleincc300a12016-10-12 16:25:27 -0400540 if (is_win) {
541 cflags_cc = [ "/GR-" ]
542 } else {
mtkleinb9be9792016-09-16 14:44:18 -0700543 cflags_cc = [ "-fno-rtti" ]
544 }
545 }
546}
547
Mike Klein7ea977b2018-09-19 13:44:43 -0400548config("optimize") {
Mike Kleincc300a12016-10-12 16:25:27 -0400549 if (is_win) {
Mike Klein916ca1d2016-10-20 13:34:18 -0400550 cflags = [
551 "/O2",
552 "/Zc:inline",
553 ]
Mike Klein90a381f2016-10-20 13:52:38 -0400554 ldflags = [
555 "/OPT:ICF",
556 "/OPT:REF",
557 ]
Mike Kleincc300a12016-10-12 16:25:27 -0400558 } else {
Mike Klein13daa4f2019-06-20 10:08:55 -0500559 cflags = [ "-O3" ]
Mike Kleinbd9be4d2017-02-10 07:59:39 -0500560 if (is_mac || is_ios) {
561 ldflags = [ "-dead_strip" ]
562 } else {
Mike Klein13daa4f2019-06-20 10:08:55 -0500563 cflags += [
564 "-fdata-sections",
565 "-ffunction-sections",
566 ]
Mike Kleinbd9be4d2017-02-10 07:59:39 -0500567 ldflags = [ "-Wl,--gc-sections" ]
568 }
Kevin Lubickebf648e2017-09-21 13:45:16 -0400569 if (target_cpu == "wasm") {
570 # The compiler asks us to add an optimization flag to both cflags
571 # and ldflags to cut down on the local variables,
572 # for performance reasons.
573 # The "linking" step is the conversion to javascript.
574 ldflags += [ "-O3" ]
575 }
herbb6318bf2016-09-16 13:29:57 -0700576 }
Mike Klein7ea977b2018-09-19 13:44:43 -0400577}
578
579config("NDEBUG") {
mtkleinb9be9792016-09-16 14:44:18 -0700580 defines = [ "NDEBUG" ]
mtklein7fbfbbe2016-07-21 12:25:45 -0700581}
582
583config("executable") {
Mike Kleinc5875fb2016-12-06 10:46:02 -0500584 if (is_android) {
Mike Klein1b4602b2017-08-30 10:23:01 -0400585 ldflags = [
586 "-pie",
587 "-rdynamic",
588 ]
Mike Kleinc5875fb2016-12-06 10:46:02 -0500589 } else if (is_mac) {
mtklein7fbfbbe2016-07-21 12:25:45 -0700590 ldflags = [ "-Wl,-rpath,@loader_path/." ]
591 } else if (is_linux) {
mtkleina846c722016-09-15 10:44:15 -0700592 ldflags = [
593 "-rdynamic",
594 "-Wl,-rpath,\$ORIGIN",
595 ]
Mike Klein4b6b5032016-11-06 11:54:19 -0500596 } else if (is_win) {
597 ldflags = [
598 "/SUBSYSTEM:CONSOLE", # Quiet "no subsystem specified; CONSOLE assumed".
Mike Kleina01c6b02020-04-01 13:47:34 -0500599 "/INCREMENTAL:NO", # Quiet warnings about failing to incrementally link
600 # by never trying to.
Mike Klein4b6b5032016-11-06 11:54:19 -0500601 ]
mtklein7fbfbbe2016-07-21 12:25:45 -0700602 }
603}