ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 1 | /* |
| 2 | * Copyright 2016 Google Inc. |
| 3 | * |
| 4 | * Use of this source code is governed by a BSD-style license that can be |
| 5 | * found in the LICENSE file. |
| 6 | */ |
| 7 | |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 8 | #include "src/sksl/SkSLCompiler.h" |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 9 | |
Mike Klein | c0bd9f9 | 2019-04-23 12:05:21 -0500 | [diff] [blame] | 10 | #include "tests/Test.h" |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 11 | |
| 12 | static void test_failure(skiatest::Reporter* r, const char* src, const char* error) { |
| 13 | SkSL::Compiler compiler; |
Ethan Nicholas | 941e7e2 | 2016-12-12 15:33:30 -0500 | [diff] [blame] | 14 | SkSL::Program::Settings settings; |
| 15 | sk_sp<GrShaderCaps> caps = SkSL::ShaderCapsFactory::Default(); |
| 16 | settings.fCaps = caps.get(); |
Ethan Nicholas | 0054311 | 2018-07-31 09:44:36 -0400 | [diff] [blame] | 17 | std::unique_ptr<SkSL::Program> program = compiler.convertProgram(SkSL::Program::kFragment_Kind, |
| 18 | SkSL::String(src), settings); |
| 19 | if (!compiler.errorCount()) { |
| 20 | compiler.optimize(*program); |
| 21 | } |
Ethan Nicholas | 0df1b04 | 2017-03-31 13:56:23 -0400 | [diff] [blame] | 22 | SkSL::String skError(error); |
Ethan Nicholas | 9e1138d | 2016-11-21 10:39:35 -0500 | [diff] [blame] | 23 | if (compiler.errorText() != skError) { |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 24 | SkDebugf("SKSL ERROR:\n source: %s\n expected: %s received: %s", src, error, |
| 25 | compiler.errorText().c_str()); |
| 26 | } |
Ethan Nicholas | 9e1138d | 2016-11-21 10:39:35 -0500 | [diff] [blame] | 27 | REPORTER_ASSERT(r, compiler.errorText() == skError); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 28 | } |
| 29 | |
| 30 | static void test_success(skiatest::Reporter* r, const char* src) { |
| 31 | SkSL::Compiler compiler; |
Ethan Nicholas | 941e7e2 | 2016-12-12 15:33:30 -0500 | [diff] [blame] | 32 | SkSL::Program::Settings settings; |
| 33 | sk_sp<GrShaderCaps> caps = SkSL::ShaderCapsFactory::Default(); |
| 34 | settings.fCaps = caps.get(); |
| 35 | std::unique_ptr<SkSL::Program> program = compiler.convertProgram(SkSL::Program::kFragment_Kind, |
Brian Osman | 93ba0a4 | 2017-08-14 14:48:10 -0400 | [diff] [blame] | 36 | SkSL::String(src), settings); |
Ethan Nicholas | 941e7e2 | 2016-12-12 15:33:30 -0500 | [diff] [blame] | 37 | REPORTER_ASSERT(r, program); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 38 | } |
| 39 | |
Ethan Nicholas | 0c8582e | 2019-07-19 09:26:46 -0400 | [diff] [blame] | 40 | DEF_TEST(SkSLOpenArray, r) { |
| 41 | test_failure(r, |
| 42 | "void main(inout float4 color) { color.r[ = ( color.g ); }", |
| 43 | "error: 1: expected expression, but found '='\n1 error\n"); |
| 44 | } |
| 45 | |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 46 | DEF_TEST(SkSLUndefinedSymbol, r) { |
| 47 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 48 | "void main() { x = float2(1); }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 49 | "error: 1: unknown identifier 'x'\n1 error\n"); |
| 50 | } |
| 51 | |
| 52 | DEF_TEST(SkSLUndefinedFunction, r) { |
| 53 | test_failure(r, |
Ethan Nicholas | f7b8820 | 2017-09-18 14:10:39 -0400 | [diff] [blame] | 54 | "void main() { int x = foo(1); }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 55 | "error: 1: unknown identifier 'foo'\n1 error\n"); |
| 56 | } |
| 57 | |
| 58 | DEF_TEST(SkSLGenericArgumentMismatch, r) { |
| 59 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 60 | "void main() { float x = sin(1, 2); }", |
Ethan Nicholas | e1f5502 | 2019-02-05 17:17:40 -0500 | [diff] [blame] | 61 | "error: 1: no match for sin(int, int)\n1 error\n"); |
ethannicholas | 471e894 | 2016-10-28 09:02:46 -0700 | [diff] [blame] | 62 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 63 | "void main() { float x = sin(true); }", |
ethannicholas | 471e894 | 2016-10-28 09:02:46 -0700 | [diff] [blame] | 64 | "error: 1: no match for sin(bool)\n1 error\n"); |
| 65 | test_success(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 66 | "void main() { float x = sin(1); }"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 67 | } |
| 68 | |
| 69 | DEF_TEST(SkSLArgumentCountMismatch, r) { |
| 70 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 71 | "float foo(float x) { return x * x; }" |
| 72 | "void main() { float x = foo(1, 2); }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 73 | "error: 1: call to 'foo' expected 1 argument, but found 2\n1 error\n"); |
| 74 | } |
| 75 | |
| 76 | DEF_TEST(SkSLArgumentMismatch, r) { |
Ethan Nicholas | f7b8820 | 2017-09-18 14:10:39 -0400 | [diff] [blame] | 77 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 78 | "float foo(float x) { return x * x; }" |
| 79 | "void main() { float x = foo(true); }", |
| 80 | "error: 1: expected 'float', but found 'bool'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 81 | } |
| 82 | |
| 83 | DEF_TEST(SkSLIfTypeMismatch, r) { |
| 84 | test_failure(r, |
| 85 | "void main() { if (3) { } }", |
| 86 | "error: 1: expected 'bool', but found 'int'\n1 error\n"); |
| 87 | } |
| 88 | |
| 89 | DEF_TEST(SkSLDoTypeMismatch, r) { |
| 90 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 91 | "void main() { do { } while (float2(1)); }", |
| 92 | "error: 1: expected 'bool', but found 'float2'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 93 | } |
| 94 | |
| 95 | DEF_TEST(SkSLWhileTypeMismatch, r) { |
| 96 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 97 | "void main() { while (float3(1)) { } }", |
| 98 | "error: 1: expected 'bool', but found 'float3'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 99 | } |
| 100 | |
| 101 | DEF_TEST(SkSLForTypeMismatch, r) { |
| 102 | test_failure(r, |
Ethan Nicholas | f7b8820 | 2017-09-18 14:10:39 -0400 | [diff] [blame] | 103 | "void main() { for (int x = 0; x; x++) { } }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 104 | "error: 1: expected 'bool', but found 'int'\n1 error\n"); |
| 105 | } |
| 106 | |
| 107 | DEF_TEST(SkSLConstructorTypeMismatch, r) { |
| 108 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 109 | "void main() { float2 x = float2(1.0, false); }", |
| 110 | "error: 1: expected 'float', but found 'bool'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 111 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 112 | "void main() { float2 x = float2(bool2(false)); }", |
| 113 | "error: 1: 'bool2' is not a valid parameter to 'float2' constructor\n1 error\n"); |
Ethan Nicholas | 4578a8e | 2016-11-01 11:57:42 -0400 | [diff] [blame] | 114 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 115 | "void main() { bool2 x = bool2(float2(1)); }", |
| 116 | "error: 1: 'float2' is not a valid parameter to 'bool2' constructor\n1 error\n"); |
Ethan Nicholas | 4578a8e | 2016-11-01 11:57:42 -0400 | [diff] [blame] | 117 | test_failure(r, |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 118 | "void main() { bool x = bool(1.0); }", |
| 119 | "error: 1: cannot construct 'bool'\n1 error\n"); |
| 120 | test_failure(r, |
| 121 | "struct foo { int x; }; void main() { foo x = foo(5); }", |
| 122 | "error: 1: cannot construct 'foo'\n1 error\n"); |
| 123 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 124 | "struct foo { int x; } foo; void main() { float x = float(foo); }", |
| 125 | "error: 1: invalid argument to 'float' constructor (expected a number or bool, but found 'foo')\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 126 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 127 | "struct foo { int x; } foo; void main() { float2 x = float2(foo); }", |
| 128 | "error: 1: 'foo' is not a valid parameter to 'float2' constructor\n1 error\n"); |
Ethan Nicholas | 3deaeb2 | 2017-04-25 14:42:11 -0400 | [diff] [blame] | 129 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 130 | "void main() { float2x2 x = float2x2(true); }", |
| 131 | "error: 1: expected 'float', but found 'bool'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 132 | } |
| 133 | |
| 134 | DEF_TEST(SkSLConstructorArgumentCount, r) { |
| 135 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 136 | "void main() { float3 x = float3(1.0, 2.0); }", |
| 137 | "error: 1: invalid arguments to 'float3' constructor (expected 3 scalars, but " |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 138 | "found 2)\n1 error\n"); |
Ethan Nicholas | 84645e3 | 2017-02-09 13:57:14 -0500 | [diff] [blame] | 139 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 140 | "void main() { float3 x = float3(1.0, 2.0, 3.0, 4.0); }", |
| 141 | "error: 1: invalid arguments to 'float3' constructor (expected 3 scalars, but found " |
Ethan Nicholas | 84645e3 | 2017-02-09 13:57:14 -0500 | [diff] [blame] | 142 | "4)\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 143 | } |
| 144 | |
| 145 | DEF_TEST(SkSLSwizzleScalar, r) { |
| 146 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 147 | "void main() { float x = 1; float y = x.y; }", |
| 148 | "error: 1: cannot swizzle value of type 'float'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 149 | } |
| 150 | |
| 151 | DEF_TEST(SkSLSwizzleMatrix, r) { |
| 152 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 153 | "void main() { float2x2 x = float2x2(1); float y = x.y; }", |
| 154 | "error: 1: cannot swizzle value of type 'float2x2'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 155 | } |
| 156 | |
| 157 | DEF_TEST(SkSLSwizzleOutOfBounds, r) { |
| 158 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 159 | "void main() { float3 test = float2(1).xyz; }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 160 | "error: 1: invalid swizzle component 'z'\n1 error\n"); |
| 161 | } |
| 162 | |
| 163 | DEF_TEST(SkSLSwizzleTooManyComponents, r) { |
| 164 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 165 | "void main() { float4 test = float2(1).xxxxx; }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 166 | "error: 1: too many components in swizzle mask 'xxxxx'\n1 error\n"); |
| 167 | } |
| 168 | |
| 169 | DEF_TEST(SkSLSwizzleDuplicateOutput, r) { |
| 170 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 171 | "void main() { float4 test = float4(1); test.xyyz = float4(1); }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 172 | "error: 1: cannot write to the same swizzle field more than once\n1 error\n"); |
| 173 | } |
ethannicholas | ea4567c | 2016-10-17 11:24:37 -0700 | [diff] [blame] | 174 | |
Ethan Nicholas | cb0f409 | 2019-04-19 11:26:50 -0400 | [diff] [blame] | 175 | DEF_TEST(SkSLSwizzleConstantOutput, r) { |
| 176 | test_failure(r, |
| 177 | "void main() { float4 test = float4(1); test.xyz0 = float4(1); }", |
| 178 | "error: 1: cannot write to a swizzle mask containing a constant\n1 error\n"); |
| 179 | } |
| 180 | |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 181 | DEF_TEST(SkSLAssignmentTypeMismatch, r) { |
| 182 | test_failure(r, |
| 183 | "void main() { int x = 1.0; }", |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 184 | "error: 1: expected 'int', but found 'float'\n1 error\n"); |
ethannicholas | ea4567c | 2016-10-17 11:24:37 -0700 | [diff] [blame] | 185 | test_failure(r, |
| 186 | "void main() { int x; x = 1.0; }", |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 187 | "error: 1: type mismatch: '=' cannot operate on 'int', 'float'\n1 error\n"); |
ethannicholas | ea4567c | 2016-10-17 11:24:37 -0700 | [diff] [blame] | 188 | test_success(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 189 | "void main() { float3 x = float3(0); x *= 1.0; }"); |
ethannicholas | ea4567c | 2016-10-17 11:24:37 -0700 | [diff] [blame] | 190 | test_failure(r, |
Ethan Nicholas | 5af9ea3 | 2017-07-28 15:19:46 -0400 | [diff] [blame] | 191 | "void main() { int3 x = int3(0); x *= 1.0; }", |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 192 | "error: 1: type mismatch: '*=' cannot operate on 'int3', 'float'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 193 | } |
| 194 | |
| 195 | DEF_TEST(SkSLReturnFromVoid, r) { |
| 196 | test_failure(r, |
| 197 | "void main() { return true; }", |
| 198 | "error: 1: may not return a value from a void function\n1 error\n"); |
| 199 | } |
| 200 | |
| 201 | DEF_TEST(SkSLReturnMissingValue, r) { |
| 202 | test_failure(r, |
| 203 | "int foo() { return; } void main() { }", |
| 204 | "error: 1: expected function to return 'int'\n1 error\n"); |
| 205 | } |
| 206 | |
| 207 | DEF_TEST(SkSLReturnTypeMismatch, r) { |
| 208 | test_failure(r, |
Ethan Nicholas | f7b8820 | 2017-09-18 14:10:39 -0400 | [diff] [blame] | 209 | "int foo() { return 1.0; } void main() { }", |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 210 | "error: 1: expected 'int', but found 'float'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 211 | } |
| 212 | |
| 213 | DEF_TEST(SkSLDuplicateFunction, r) { |
| 214 | test_failure(r, |
Ethan Nicholas | f7b8820 | 2017-09-18 14:10:39 -0400 | [diff] [blame] | 215 | "void main() { } void main() { }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 216 | "error: 1: duplicate definition of void main()\n1 error\n"); |
| 217 | test_success(r, |
| 218 | "void main(); void main() { }"); |
| 219 | } |
| 220 | |
| 221 | DEF_TEST(SkSLUsingInvalidValue, r) { |
| 222 | test_failure(r, |
Ethan Nicholas | f7b8820 | 2017-09-18 14:10:39 -0400 | [diff] [blame] | 223 | "void main() { int x = int; }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 224 | "error: 1: expected '(' to begin constructor invocation\n1 error\n"); |
| 225 | test_failure(r, |
Ethan Nicholas | f7b8820 | 2017-09-18 14:10:39 -0400 | [diff] [blame] | 226 | "int test() { return 1; } void main() { int x = test; }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 227 | "error: 1: expected '(' to begin function call\n1 error\n"); |
| 228 | } |
| 229 | DEF_TEST(SkSLDifferentReturnType, r) { |
| 230 | test_failure(r, |
Ethan Nicholas | f7b8820 | 2017-09-18 14:10:39 -0400 | [diff] [blame] | 231 | "int main() { return 1; } void main() { }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 232 | "error: 1: functions 'void main()' and 'int main()' differ only in return type\n1 " |
| 233 | "error\n"); |
| 234 | } |
| 235 | |
| 236 | DEF_TEST(SkSLDifferentModifiers, r) { |
| 237 | test_failure(r, |
Ethan Nicholas | f7b8820 | 2017-09-18 14:10:39 -0400 | [diff] [blame] | 238 | "void test(int x); void test(out int x) { }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 239 | "error: 1: modifiers on parameter 1 differ between declaration and definition\n1 " |
| 240 | "error\n"); |
| 241 | } |
| 242 | |
| 243 | DEF_TEST(SkSLDuplicateSymbol, r) { |
| 244 | test_failure(r, |
Ethan Nicholas | f7b8820 | 2017-09-18 14:10:39 -0400 | [diff] [blame] | 245 | "int main; void main() { }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 246 | "error: 1: symbol 'main' was already defined\n1 error\n"); |
| 247 | |
| 248 | test_failure(r, |
| 249 | "int x; int x; void main() { }", |
| 250 | "error: 1: symbol 'x' was already defined\n1 error\n"); |
| 251 | |
| 252 | test_success(r, "int x; void main() { int x; }"); |
| 253 | } |
| 254 | |
| 255 | DEF_TEST(SkSLBinaryTypeMismatch, r) { |
| 256 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 257 | "void main() { float x = 3 * true; }", |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 258 | "error: 1: type mismatch: '*' cannot operate on 'int', 'bool'\n1 error\n"); |
| 259 | test_failure(r, |
| 260 | "void main() { bool x = 1 || 2.0; }", |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 261 | "error: 1: type mismatch: '||' cannot operate on 'int', 'float'\n1 error\n"); |
Ethan Nicholas | 2346300 | 2018-03-28 15:16:15 -0400 | [diff] [blame] | 262 | test_failure(r, |
| 263 | "void main() { bool x = float2(0) == 0; }", |
| 264 | "error: 1: type mismatch: '==' cannot operate on 'float2', 'int'\n1 error\n"); |
| 265 | test_failure(r, |
| 266 | "void main() { bool x = float2(0) != 0; }", |
| 267 | "error: 1: type mismatch: '!=' cannot operate on 'float2', 'int'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 268 | } |
| 269 | |
| 270 | DEF_TEST(SkSLCallNonFunction, r) { |
| 271 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 272 | "void main() { float x = 3; x(); }", |
Ethan Nicholas | 2a099da | 2020-01-02 14:40:54 -0500 | [diff] [blame] | 273 | "error: 1: not a function\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 274 | } |
| 275 | |
| 276 | DEF_TEST(SkSLInvalidUnary, r) { |
| 277 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 278 | "void main() { float4x4 x = float4x4(1); ++x; }", |
| 279 | "error: 1: '++' cannot operate on 'float4x4'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 280 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 281 | "void main() { float3 x = float3(1); --x; }", |
| 282 | "error: 1: '--' cannot operate on 'float3'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 283 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 284 | "void main() { float4x4 x = float4x4(1); x++; }", |
| 285 | "error: 1: '++' cannot operate on 'float4x4'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 286 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 287 | "void main() { float3 x = float3(1); x--; }", |
| 288 | "error: 1: '--' cannot operate on 'float3'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 289 | test_failure(r, |
| 290 | "void main() { int x = !12; }", |
| 291 | "error: 1: '!' cannot operate on 'int'\n1 error\n"); |
| 292 | test_failure(r, |
| 293 | "struct foo { } bar; void main() { foo x = +bar; }", |
| 294 | "error: 1: '+' cannot operate on 'foo'\n1 error\n"); |
| 295 | test_failure(r, |
| 296 | "struct foo { } bar; void main() { foo x = -bar; }", |
| 297 | "error: 1: '-' cannot operate on 'foo'\n1 error\n"); |
| 298 | test_success(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 299 | "void main() { float2 x = float2(1, 1); x = +x; x = -x; }"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 300 | } |
| 301 | |
| 302 | DEF_TEST(SkSLInvalidAssignment, r) { |
| 303 | test_failure(r, |
| 304 | "void main() { 1 = 2; }", |
Ethan Nicholas | 2a099da | 2020-01-02 14:40:54 -0500 | [diff] [blame] | 305 | "error: 1: cannot assign to this expression\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 306 | test_failure(r, |
| 307 | "uniform int x; void main() { x = 0; }", |
| 308 | "error: 1: cannot modify immutable variable 'x'\n1 error\n"); |
| 309 | test_failure(r, |
| 310 | "const int x; void main() { x = 0; }", |
| 311 | "error: 1: cannot modify immutable variable 'x'\n1 error\n"); |
| 312 | } |
| 313 | |
| 314 | DEF_TEST(SkSLBadIndex, r) { |
| 315 | test_failure(r, |
| 316 | "void main() { int x = 2[0]; }", |
| 317 | "error: 1: expected array, but found 'int'\n1 error\n"); |
| 318 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 319 | "void main() { float2 x = float2(0); int y = x[0][0]; }", |
| 320 | "error: 1: expected array, but found 'float'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 321 | } |
| 322 | |
| 323 | DEF_TEST(SkSLTernaryMismatch, r) { |
| 324 | test_failure(r, |
| 325 | "void main() { int x = 5 > 2 ? true : 1.0; }", |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 326 | "error: 1: ternary operator result mismatch: 'bool', 'float'\n1 error\n"); |
Ethan Nicholas | 2be687a | 2017-01-03 16:44:39 -0500 | [diff] [blame] | 327 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 328 | "void main() { int x = 5 > 2 ? float3(1) : 1.0; }", |
| 329 | "error: 1: ternary operator result mismatch: 'float3', 'float'\n1 error\n"); |
ethannicholas | b3058bd | 2016-07-01 08:22:01 -0700 | [diff] [blame] | 330 | } |
| 331 | |
| 332 | DEF_TEST(SkSLInterfaceBlockStorageModifiers, r) { |
| 333 | test_failure(r, |
| 334 | "uniform foo { out int x; };", |
| 335 | "error: 1: interface block fields may not have storage qualifiers\n1 error\n"); |
| 336 | } |
ethannicholas | 22f939e | 2016-10-13 13:25:34 -0700 | [diff] [blame] | 337 | |
| 338 | DEF_TEST(SkSLUseWithoutInitialize, r) { |
| 339 | test_failure(r, |
| 340 | "void main() { int x; if (5 == 2) x = 3; x++; }", |
| 341 | "error: 1: 'x' has not been assigned\n1 error\n"); |
| 342 | test_failure(r, |
| 343 | "void main() { int x[2][2]; int i; x[i][1] = 4; }", |
| 344 | "error: 1: 'i' has not been assigned\n1 error\n"); |
| 345 | test_failure(r, |
| 346 | "int main() { int r; return r; }", |
| 347 | "error: 1: 'r' has not been assigned\n1 error\n"); |
| 348 | test_failure(r, |
Ethan Nicholas | 82a62d2 | 2017-11-07 14:42:10 +0000 | [diff] [blame] | 349 | "void main() { int x; int y = x; }", |
ethannicholas | 22f939e | 2016-10-13 13:25:34 -0700 | [diff] [blame] | 350 | "error: 1: 'x' has not been assigned\n1 error\n"); |
| 351 | test_failure(r, |
| 352 | "void main() { bool x; if (true && (false || x)) return; }", |
| 353 | "error: 1: 'x' has not been assigned\n1 error\n"); |
Ethan Nicholas | af19769 | 2017-02-27 13:26:45 -0500 | [diff] [blame] | 354 | test_failure(r, |
| 355 | "void main() { int x; switch (3) { case 0: x = 0; case 1: x = 1; }" |
Ethan Nicholas | e1f5502 | 2019-02-05 17:17:40 -0500 | [diff] [blame] | 356 | "sk_FragColor = half4(x); }", |
Ethan Nicholas | af19769 | 2017-02-27 13:26:45 -0500 | [diff] [blame] | 357 | "error: 1: 'x' has not been assigned\n1 error\n"); |
ethannicholas | 22f939e | 2016-10-13 13:25:34 -0700 | [diff] [blame] | 358 | } |
| 359 | |
| 360 | DEF_TEST(SkSLUnreachable, r) { |
| 361 | test_failure(r, |
| 362 | "void main() { return; return; }", |
| 363 | "error: 1: unreachable\n1 error\n"); |
| 364 | test_failure(r, |
| 365 | "void main() { for (;;) { continue; int x = 1; } }", |
| 366 | "error: 1: unreachable\n1 error\n"); |
Ethan Nicholas | d9fe700 | 2017-05-30 10:15:34 -0400 | [diff] [blame] | 367 | /* test_failure(r, |
ethannicholas | 22f939e | 2016-10-13 13:25:34 -0700 | [diff] [blame] | 368 | "void main() { for (;;) { } return; }", |
Ethan Nicholas | d9fe700 | 2017-05-30 10:15:34 -0400 | [diff] [blame] | 369 | "error: 1: unreachable\n1 error\n");*/ |
ethannicholas | 22f939e | 2016-10-13 13:25:34 -0700 | [diff] [blame] | 370 | test_failure(r, |
| 371 | "void main() { if (true) return; else discard; return; }", |
| 372 | "error: 1: unreachable\n1 error\n"); |
| 373 | test_failure(r, |
| 374 | "void main() { return; while (true); }", |
| 375 | "error: 1: unreachable\n1 error\n"); |
| 376 | } |
| 377 | |
| 378 | DEF_TEST(SkSLNoReturn, r) { |
| 379 | test_failure(r, |
| 380 | "int foo() { if (2 > 5) return 3; }", |
Ethan Nicholas | db80f69 | 2019-11-22 14:06:12 -0500 | [diff] [blame] | 381 | "error: 1: function 'foo' can exit without returning a value\n1 error\n"); |
ethannicholas | 22f939e | 2016-10-13 13:25:34 -0700 | [diff] [blame] | 382 | } |
| 383 | |
| 384 | DEF_TEST(SkSLBreakOutsideLoop, r) { |
| 385 | test_failure(r, |
| 386 | "void foo() { while(true) {} if (true) break; }", |
Ethan Nicholas | af19769 | 2017-02-27 13:26:45 -0500 | [diff] [blame] | 387 | "error: 1: break statement must be inside a loop or switch\n1 error\n"); |
ethannicholas | 22f939e | 2016-10-13 13:25:34 -0700 | [diff] [blame] | 388 | } |
| 389 | |
| 390 | DEF_TEST(SkSLContinueOutsideLoop, r) { |
| 391 | test_failure(r, |
| 392 | "void foo() { for(;;); continue; }", |
| 393 | "error: 1: continue statement must be inside a loop\n1 error\n"); |
Ethan Nicholas | af19769 | 2017-02-27 13:26:45 -0500 | [diff] [blame] | 394 | test_failure(r, |
| 395 | "void foo() { switch (1) { default: continue; } }", |
| 396 | "error: 1: continue statement must be inside a loop\n1 error\n"); |
ethannicholas | 22f939e | 2016-10-13 13:25:34 -0700 | [diff] [blame] | 397 | } |
ethannicholas | 08a9211 | 2016-11-09 13:26:45 -0800 | [diff] [blame] | 398 | |
| 399 | DEF_TEST(SkSLStaticIfError, r) { |
| 400 | // ensure eliminated branch of static if / ternary is still checked for errors |
| 401 | test_failure(r, |
| 402 | "void foo() { if (true); else x = 5; }", |
| 403 | "error: 1: unknown identifier 'x'\n1 error\n"); |
| 404 | test_failure(r, |
| 405 | "void foo() { if (false) x = 5; }", |
| 406 | "error: 1: unknown identifier 'x'\n1 error\n"); |
| 407 | test_failure(r, |
| 408 | "void foo() { true ? 5 : x; }", |
| 409 | "error: 1: unknown identifier 'x'\n1 error\n"); |
| 410 | test_failure(r, |
| 411 | "void foo() { false ? x : 5; }", |
| 412 | "error: 1: unknown identifier 'x'\n1 error\n"); |
| 413 | } |
Ethan Nicholas | 7ef4b74 | 2016-11-11 15:16:46 -0500 | [diff] [blame] | 414 | |
Ethan Nicholas | 3605ace | 2016-11-21 15:59:48 -0500 | [diff] [blame] | 415 | DEF_TEST(SkSLBadCap, r) { |
| 416 | test_failure(r, |
| 417 | "bool b = sk_Caps.bugFreeDriver;", |
| 418 | "error: 1: unknown capability flag 'bugFreeDriver'\n1 error\n"); |
| 419 | } |
| 420 | |
Ethan Nicholas | 9a5610e | 2017-01-03 15:16:29 -0500 | [diff] [blame] | 421 | DEF_TEST(SkSLDivByZero, r) { |
| 422 | test_failure(r, |
| 423 | "int x = 1 / 0;", |
| 424 | "error: 1: division by zero\n1 error\n"); |
| 425 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 426 | "float x = 1 / 0;", |
Ethan Nicholas | 9a5610e | 2017-01-03 15:16:29 -0500 | [diff] [blame] | 427 | "error: 1: division by zero\n1 error\n"); |
| 428 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 429 | "float x = 1.0 / 0.0;", |
Ethan Nicholas | 9a5610e | 2017-01-03 15:16:29 -0500 | [diff] [blame] | 430 | "error: 1: division by zero\n1 error\n"); |
| 431 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 432 | "float x = -67.0 / (3.0 - 3);", |
Ethan Nicholas | 9a5610e | 2017-01-03 15:16:29 -0500 | [diff] [blame] | 433 | "error: 1: division by zero\n1 error\n"); |
| 434 | } |
| 435 | |
Ethan Nicholas | 3865711 | 2017-02-09 17:01:22 -0500 | [diff] [blame] | 436 | DEF_TEST(SkSLUnsupportedGLSLIdentifiers, r) { |
| 437 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 438 | "void main() { float x = gl_FragCoord.x; };", |
Ethan Nicholas | 3865711 | 2017-02-09 17:01:22 -0500 | [diff] [blame] | 439 | "error: 1: unknown identifier 'gl_FragCoord'\n1 error\n"); |
| 440 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 441 | "void main() { float r = gl_FragColor.r; };", |
Ethan Nicholas | 3865711 | 2017-02-09 17:01:22 -0500 | [diff] [blame] | 442 | "error: 1: unknown identifier 'gl_FragColor'\n1 error\n"); |
| 443 | } |
| 444 | |
Ethan Nicholas | af19769 | 2017-02-27 13:26:45 -0500 | [diff] [blame] | 445 | DEF_TEST(SkSLWrongSwitchTypes, r) { |
| 446 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 447 | "void main() { switch (float2(1)) { case 1: break; } }", |
| 448 | "error: 1: expected 'int', but found 'float2'\n1 error\n"); |
Ethan Nicholas | af19769 | 2017-02-27 13:26:45 -0500 | [diff] [blame] | 449 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 450 | "void main() { switch (1) { case float2(1): break; } }", |
| 451 | "error: 1: expected 'int', but found 'float2'\n1 error\n"); |
Ethan Nicholas | af19769 | 2017-02-27 13:26:45 -0500 | [diff] [blame] | 452 | } |
| 453 | |
| 454 | DEF_TEST(SkSLNonConstantCase, r) { |
| 455 | test_failure(r, |
| 456 | "void main() { int x = 1; switch (1) { case x: break; } }", |
| 457 | "error: 1: case value must be a constant\n1 error\n"); |
| 458 | } |
| 459 | |
| 460 | DEF_TEST(SkSLDuplicateCase, r) { |
| 461 | test_failure(r, |
| 462 | "void main() { switch (1) { case 0: case 1: case 0: break; } }", |
| 463 | "error: 1: duplicate case value\n1 error\n"); |
| 464 | } |
| 465 | |
Ethan Nicholas | 0dd30d9 | 2017-05-01 16:57:07 -0400 | [diff] [blame] | 466 | DEF_TEST(SkSLFieldAfterRuntimeArray, r) { |
| 467 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 468 | "buffer broken { float x[]; float y; };", |
Ethan Nicholas | 0dd30d9 | 2017-05-01 16:57:07 -0400 | [diff] [blame] | 469 | "error: 1: only the last entry in an interface block may be a runtime-sized " |
| 470 | "array\n1 error\n"); |
| 471 | } |
| 472 | |
Ethan Nicholas | 5ac13c2 | 2017-05-10 15:06:17 -0400 | [diff] [blame] | 473 | DEF_TEST(SkSLStaticIf, r) { |
| 474 | test_success(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 475 | "void main() { float x = 5; float y = 10;" |
Ethan Nicholas | e1f5502 | 2019-02-05 17:17:40 -0500 | [diff] [blame] | 476 | "@if (x < y) { sk_FragColor = half4(1); } }"); |
Ethan Nicholas | 5ac13c2 | 2017-05-10 15:06:17 -0400 | [diff] [blame] | 477 | test_failure(r, |
Ethan Nicholas | 8aa4569 | 2017-09-20 11:24:15 -0400 | [diff] [blame] | 478 | "void main() { float x = sqrt(25); float y = 10;" |
Ethan Nicholas | e1f5502 | 2019-02-05 17:17:40 -0500 | [diff] [blame] | 479 | "@if (x < y) { sk_FragColor = half4(1); } }", |
Ethan Nicholas | 5ac13c2 | 2017-05-10 15:06:17 -0400 | [diff] [blame] | 480 | "error: 1: static if has non-static test\n1 error\n"); |
| 481 | } |
| 482 | |
| 483 | DEF_TEST(SkSLStaticSwitch, r) { |
| 484 | test_success(r, |
| 485 | "void main() {" |
| 486 | "int x = 1;" |
| 487 | "@switch (x) {" |
Ethan Nicholas | e1f5502 | 2019-02-05 17:17:40 -0500 | [diff] [blame] | 488 | "case 1: sk_FragColor = half4(1); break;" |
| 489 | "default: sk_FragColor = half4(0);" |
Ethan Nicholas | 5ac13c2 | 2017-05-10 15:06:17 -0400 | [diff] [blame] | 490 | "}" |
| 491 | "}"); |
| 492 | test_failure(r, |
| 493 | "void main() {" |
| 494 | "int x = int(sqrt(1));" |
| 495 | "@switch (x) {" |
Ethan Nicholas | e1f5502 | 2019-02-05 17:17:40 -0500 | [diff] [blame] | 496 | "case 1: sk_FragColor = half4(1); break;" |
| 497 | "default: sk_FragColor = half4(0);" |
Ethan Nicholas | 5ac13c2 | 2017-05-10 15:06:17 -0400 | [diff] [blame] | 498 | "}" |
| 499 | "}", |
| 500 | "error: 1: static switch has non-static test\n1 error\n"); |
| 501 | test_failure(r, |
| 502 | "void main() {" |
| 503 | "int x = 1;" |
| 504 | "@switch (x) {" |
Ethan Nicholas | e1f5502 | 2019-02-05 17:17:40 -0500 | [diff] [blame] | 505 | "case 1: sk_FragColor = half4(1); if (sqrt(0) < sqrt(1)) break;" |
| 506 | "default: sk_FragColor = half4(0);" |
Ethan Nicholas | 5ac13c2 | 2017-05-10 15:06:17 -0400 | [diff] [blame] | 507 | "}" |
| 508 | "}", |
| 509 | "error: 1: static switch contains non-static conditional break\n1 error\n"); |
| 510 | } |
| 511 | |
Ethan Nicholas | 68dd2c1 | 2018-03-01 15:05:17 -0500 | [diff] [blame] | 512 | DEF_TEST(SkSLInterfaceBlockScope, r) { |
| 513 | test_failure(r, |
| 514 | "uniform testBlock {" |
| 515 | "float x;" |
| 516 | "} test[x];", |
| 517 | "error: 1: unknown identifier 'x'\n1 error\n"); |
| 518 | } |
| 519 | |
Ethan Nicholas | 6c94271 | 2018-03-16 09:45:11 -0400 | [diff] [blame] | 520 | DEF_TEST(SkSLDuplicateOutput, r) { |
| 521 | test_failure(r, |
| 522 | "layout (location=0, index=0) out half4 duplicateOutput;", |
| 523 | "error: 1: out location=0, index=0 is reserved for sk_FragColor\n1 error\n"); |
| 524 | } |
Ethan Nicholas | 5a9a0b3 | 2019-09-17 16:18:22 -0400 | [diff] [blame] | 525 | |
| 526 | DEF_TEST(SkSLSpuriousFloat, r) { |
| 527 | test_failure(r, |
| 528 | "void main() { float x; x = 1.5 2.5; }", |
| 529 | "error: 1: expected ';', but found '2.5'\n1 error\n"); |
| 530 | } |