commit 0554d497f80997658b5d0417897af4b818aae958
author Mike Klein <mtklein@chromium.org> Wed Dec 06 12:27:44 2017 -0500
committer Skia Commit-Bot <skia-commit-bot@chromium.org> Wed Dec 06 19:37:27 2017 +0000
tree 3c183bffed5ab5e7df4775a40e961d2daabf0f0a
parent d34c4a37276c240733a6d17812653636dc3656b5

add SkVptr()

I was wondering how feasible using this to make downcasts safe would be.
These tests would need to build and pass on all our bots, at least.

Change-Id: I1753ba58841bf6c17d6ac3af7374518356e1bb05
Reviewed-on: https://skia-review.googlesource.com/81180
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Mike Klein <mtklein@chromium.org>

gn/tests.gni

diff --git a/gn/tests.gni b/gn/tests.gni
index 8c08d16..30f6190 100644
--- a/gn/tests.gni
+++ b/gn/tests.gni
@@ -274,6 +274,7 @@
   "$_tests/VkHeapTests.cpp",
   "$_tests/VkUploadPixelsTests.cpp",
   "$_tests/VkWrapTests.cpp",
+  "$_tests/VptrTest.cpp",
   "$_tests/WindowRectanglesTest.cpp",
   "$_tests/WritePixelsTest.cpp",
   "$_tests/Writer32Test.cpp",

src/core/SkVptr.h

diff --git a/src/core/SkVptr.h b/src/core/SkVptr.h
new file mode 100644
index 0000000..2a33ad0
--- /dev/null
+++ b/src/core/SkVptr.h
@@ -0,0 +1,24 @@
+/*
+ * Copyright 2017 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#ifndef SkVptr_DEFINED
+#define SkVptr_DEFINED
+
+#include <string.h>
+#include <type_traits>
+
+// Experimentally, see if we can get at the vptr of objects with one.
+
+template <typename T>
+static inline void* SkVptr(const T& object) {
+    static_assert(std::has_virtual_destructor<T>::value, "");
+    void* vptr;
+    memcpy(&vptr, (const void*)&object, sizeof(vptr));
+    return vptr;
+}
+
+#endif//SkVptr_DEFINED

tests/VptrTest.cpp

diff --git a/tests/VptrTest.cpp b/tests/VptrTest.cpp
new file mode 100644
index 0000000..b8a9e1a
--- /dev/null
+++ b/tests/VptrTest.cpp
@@ -0,0 +1,61 @@
+/*
+ * Copyright 2017 Google Inc.
+ *
+ * Use of this source code is governed by a BSD-style license that can be
+ * found in the LICENSE file.
+ */
+
+#include "SkMakeUnique.h"
+#include "SkVptr.h"
+#include "Test.h"
+
+namespace {
+
+    struct Base {
+        virtual ~Base() = default;
+        virtual size_t val() const = 0;
+    };
+
+    struct SubclassA : public Base {
+        SubclassA(size_t val) : fVal(val) {}
+
+        size_t val() const override { return fVal; }
+
+        size_t fVal;
+    };
+
+    struct SubclassB : public Base {
+        SubclassB() {}
+
+        size_t val() const override { return 42; }
+    };
+
+}
+
+DEF_TEST(Vptr, r) {
+    std::unique_ptr<Base> a = skstd::make_unique<SubclassA>(21),
+                          b = skstd::make_unique<SubclassB>(),
+                          c = skstd::make_unique<SubclassA>(22),
+                          d = skstd::make_unique<SubclassB>();
+
+    // These 4 objects all have unique identities.
+    REPORTER_ASSERT(r, a != b);
+    REPORTER_ASSERT(r, a != c);
+    REPORTER_ASSERT(r, a != d);
+    REPORTER_ASSERT(r, b != c);
+    REPORTER_ASSERT(r, b != d);
+    REPORTER_ASSERT(r, c != d);
+
+    // Only b and d have the same val().
+    REPORTER_ASSERT(r, a->val() != b->val());
+    REPORTER_ASSERT(r, a->val() != c->val());
+    REPORTER_ASSERT(r, a->val() != d->val());
+    REPORTER_ASSERT(r, b->val() != c->val());
+    REPORTER_ASSERT(r, b->val() == d->val());
+    REPORTER_ASSERT(r, c->val() != d->val());
+
+    // SkVptr() returns the same value for objects of the same concrete type.
+    REPORTER_ASSERT(r, SkVptr(*a) == SkVptr(*c));
+    REPORTER_ASSERT(r, SkVptr(*b) == SkVptr(*d));
+    REPORTER_ASSERT(r, SkVptr(*a) != SkVptr(*b));
+}